Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/133663/?format=api
{ "id": 133663, "url": "http://patches.dpdk.org/api/patches/133663/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20231031122359.3930935-6-haijie1@huawei.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20231031122359.3930935-6-haijie1@huawei.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20231031122359.3930935-6-haijie1@huawei.com", "date": "2023-10-31T12:23:58", "name": "[5/6] net/hns3: do not export API for setting and getting algo and key", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "ba5e9bba456301ad5c37088c50f7a38bb0a4c4da", "submitter": { "id": 2935, "url": "http://patches.dpdk.org/api/people/2935/?format=api", "name": "Jie Hai", "email": "haijie1@huawei.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20231031122359.3930935-6-haijie1@huawei.com/mbox/", "series": [ { "id": 30073, "url": "http://patches.dpdk.org/api/series/30073/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=30073", "date": "2023-10-31T12:23:55", "name": "net/hns3: add some bugfix for hns3", "version": 1, "mbox": "http://patches.dpdk.org/series/30073/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/133663/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/133663/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id F14B143252;\n\tTue, 31 Oct 2023 13:35:58 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 0C20240DDE;\n\tTue, 31 Oct 2023 13:35:45 +0100 (CET)", "from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188])\n by mails.dpdk.org (Postfix) with ESMTP id 180B240294\n for <dev@dpdk.org>; Tue, 31 Oct 2023 13:35:41 +0100 (CET)", "from kwepemi500020.china.huawei.com (unknown [172.30.72.55])\n by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4SKTyt2gBczPnnh\n for <dev@dpdk.org>; Tue, 31 Oct 2023 20:31:34 +0800 (CST)", "from localhost.localdomain (10.67.165.2) by\n kwepemi500020.china.huawei.com (7.221.188.8) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id\n 15.1.2507.31; Tue, 31 Oct 2023 20:35:39 +0800" ], "From": "Jie Hai <haijie1@huawei.com>", "To": "<dev@dpdk.org>, Yisen Zhuang <yisen.zhuang@huawei.com>, Dongdong Liu\n <liudongdong3@huawei.com>, Huisong Li <lihuisong@huawei.com>", "CC": "<fengchengwen@huawei.com>", "Subject": "[PATCH 5/6] net/hns3: do not export API for setting and getting algo\n and key", "Date": "Tue, 31 Oct 2023 20:23:58 +0800", "Message-ID": "<20231031122359.3930935-6-haijie1@huawei.com>", "X-Mailer": "git-send-email 2.30.0", "In-Reply-To": "<20231031122359.3930935-1-haijie1@huawei.com>", "References": "<20231031122359.3930935-1-haijie1@huawei.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Originating-IP": "[10.67.165.2]", "X-ClientProxiedBy": "dggems703-chm.china.huawei.com (10.3.19.180) To\n kwepemi500020.china.huawei.com (7.221.188.8)", "X-CFilter-Loop": "Reflected", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "The functions \"hns3_rss_set_algo_key()\" and \"hns3_rss_get_algo_key()\"\nare the inner interfaces to set hardware. Driver already had an API,\n\"hns3_update_rss_algo_key()\", to export and to update RSS algo or key.\nSo above two innter interface don't export.\n\nFixes: 7da415d27d88 (\"net/hns3: use hardware config to report hash key\")\nCc: stable@dpdk.org\n\nSigned-off-by: Jie Hai <haijie1@huawei.com>\n---\n drivers/net/hns3/hns3_rss.c | 4 ++--\n drivers/net/hns3/hns3_rss.h | 4 ----\n 2 files changed, 2 insertions(+), 6 deletions(-)", "diff": "diff --git a/drivers/net/hns3/hns3_rss.c b/drivers/net/hns3/hns3_rss.c\nindex 6126512bd780..9bb84262563c 100644\n--- a/drivers/net/hns3/hns3_rss.c\n+++ b/drivers/net/hns3/hns3_rss.c\n@@ -283,7 +283,7 @@ static const struct {\n * rss_generic_config command function, opcode:0x0D01.\n * Used to set algorithm and hash key of RSS.\n */\n-int\n+static int\n hns3_rss_set_algo_key(struct hns3_hw *hw, uint8_t hash_algo,\n \t\t const uint8_t *key, uint8_t key_len)\n {\n@@ -324,7 +324,7 @@ hns3_rss_set_algo_key(struct hns3_hw *hw, uint8_t hash_algo,\n \treturn 0;\n }\n \n-int\n+static int\n hns3_rss_get_algo_key(struct hns3_hw *hw, uint8_t *hash_algo,\n \t\t uint8_t *key, uint8_t key_len)\n {\ndiff --git a/drivers/net/hns3/hns3_rss.h b/drivers/net/hns3/hns3_rss.h\nindex 415430a39948..9d182a8025c5 100644\n--- a/drivers/net/hns3/hns3_rss.h\n+++ b/drivers/net/hns3/hns3_rss.h\n@@ -190,10 +190,6 @@ bool hns3_check_rss_types_valid(struct hns3_hw *hw, uint64_t types);\n int hns3_set_rss_tuple_by_rss_hf(struct hns3_hw *hw, uint64_t rss_hf);\n int hns3_set_rss_tuple_field(struct hns3_hw *hw, uint64_t tuple_fields);\n int hns3_get_rss_tuple_field(struct hns3_hw *hw, uint64_t *tuple_fields);\n-int hns3_rss_set_algo_key(struct hns3_hw *hw, uint8_t hash_algo,\n-\t\t\t const uint8_t *key, uint8_t key_len);\n-int hns3_rss_get_algo_key(struct hns3_hw *hw, uint8_t *hash_algo,\n-\t\t\t uint8_t *key, uint8_t key_len);\n uint64_t hns3_rss_calc_tuple_filed(uint64_t rss_hf);\n int hns3_update_rss_algo_key(struct hns3_hw *hw, uint8_t hash_algo,\n \t\t\t uint8_t *key, uint8_t key_len);\n", "prefixes": [ "5/6" ] }