Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/133631/?format=api
{ "id": 133631, "url": "http://patches.dpdk.org/api/patches/133631/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20231030211244.2516043-1-abdullah.sevincer@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20231030211244.2516043-1-abdullah.sevincer@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20231030211244.2516043-1-abdullah.sevincer@intel.com", "date": "2023-10-30T21:12:44", "name": "[v3] event/dlb2: fix disable PASID for kernel 6.2", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": true, "hash": "c1afeb5fbee7461b27edfd0cbd8bda47437f8b45", "submitter": { "id": 2843, "url": "http://patches.dpdk.org/api/people/2843/?format=api", "name": "Sevincer, Abdullah", "email": "abdullah.sevincer@intel.com" }, "delegate": { "id": 310, "url": "http://patches.dpdk.org/api/users/310/?format=api", "username": "jerin", "first_name": "Jerin", "last_name": "Jacob", "email": "jerinj@marvell.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20231030211244.2516043-1-abdullah.sevincer@intel.com/mbox/", "series": [ { "id": 30062, "url": "http://patches.dpdk.org/api/series/30062/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=30062", "date": "2023-10-30T21:12:44", "name": "[v3] event/dlb2: fix disable PASID for kernel 6.2", "version": 3, "mbox": "http://patches.dpdk.org/series/30062/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/133631/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/133631/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id BD66443247;\n\tMon, 30 Oct 2023 22:12:51 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 5CC7A40266;\n\tMon, 30 Oct 2023 22:12:51 +0100 (CET)", "from mgamail.intel.com (mgamail.intel.com [192.55.52.151])\n by mails.dpdk.org (Postfix) with ESMTP id 1C51540042;\n Mon, 30 Oct 2023 22:12:48 +0100 (CET)", "from orsmga004.jf.intel.com ([10.7.209.38])\n by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 30 Oct 2023 14:12:47 -0700", "from txanpdk02.an.intel.com ([10.123.117.76])\n by orsmga004.jf.intel.com with ESMTP; 30 Oct 2023 14:12:46 -0700" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1698700369; x=1730236369;\n h=from:to:cc:subject:date:message-id:in-reply-to:\n references:mime-version:content-transfer-encoding;\n bh=QUgpOF9kbEL7HJlJpZKFk5SDDcHJTaIfnK7ZIyIokCk=;\n b=Iq9fLUJtkss+EEI8tEcBVYr25Yn7qxj4QysrKK5amrl3deBY2xysqNtz\n Wo44vfE2/NQ6xPffKARyPdIHVLq8/vvrb2mcTTYIH9TisdtldHdTKq7UH\n IdgzADeg5RsGpyn7t/2L+0TzsfpXPKSTLyVWJ4WXU7QSq3QBkAqKa4oAa\n 43P52gb3A58kq9JTgndf1VBKEXa/YmXlUpo2a3zVKcZS/ccF4oBl3s2Et\n 7qqOX1fJPpwkfY5vswLKgMhwUyBNVvK9KVCv46AbT2Yo6A68i7P4jbacO\n aQKOOUmmYwXWdSg/f7Ff8oaJBq/XA6/0oNv909gjsZ9RpIu91xp6YpkJN g==;", "X-IronPort-AV": [ "E=McAfee;i=\"6600,9927,10879\"; a=\"368372333\"", "E=Sophos;i=\"6.03,264,1694761200\"; d=\"scan'208\";a=\"368372333\"", "E=McAfee;i=\"6600,9927,10879\"; a=\"884004404\"", "E=Sophos;i=\"6.03,264,1694761200\"; d=\"scan'208\";a=\"884004404\"" ], "X-ExtLoop1": "1", "From": "Abdullah Sevincer <abdullah.sevincer@intel.com>", "To": "dev@dpdk.org", "Cc": "jerinj@marvell.com, mike.ximing.chen@intel.com,\n bruce.richardson@intel.com,\n Abdullah Sevincer <abdullah.sevincer@intel.com>, stable@dpdk.org", "Subject": "[PATCH v3] event/dlb2: fix disable PASID for kernel 6.2", "Date": "Mon, 30 Oct 2023 16:12:44 -0500", "Message-Id": "<20231030211244.2516043-1-abdullah.sevincer@intel.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20230607210050.107944-1-abdullah.sevincer@intel.com>", "References": "<20230607210050.107944-1-abdullah.sevincer@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "vfio-pci driver in Linux kernel 6.2 enables PASID by default.\nIn DLB hardware, enabling PASID puts DLB in SIOV mode. This\nbreaks DLB PF-PMD mode. For DLB PF-PMD mode to function properly\nPASID needs to be disabled for kernel 6.2.\n\nIn this commit this issue is addressed and PASID is disabled\nby writing a zero to PASID control register.\n\nFixes: 5433956d5185 (\"event/dlb2: add eventdev probe\")\nCc: stable@dpdk.org\n\nSigned-off-by: Abdullah Sevincer <abdullah.sevincer@intel.com>\n---\n drivers/event/dlb2/pf/dlb2_main.c | 27 +++++++++++++++++++++++++++\n lib/pci/rte_pci.h | 5 +++++\n 2 files changed, 32 insertions(+)", "diff": "diff --git a/drivers/event/dlb2/pf/dlb2_main.c b/drivers/event/dlb2/pf/dlb2_main.c\nindex aa03e4c311..34e47a4e33 100644\n--- a/drivers/event/dlb2/pf/dlb2_main.c\n+++ b/drivers/event/dlb2/pf/dlb2_main.c\n@@ -190,6 +190,7 @@ dlb2_pf_reset(struct dlb2_dev *dlb2_dev)\n \tuint16_t rt_ctl_word;\n \tuint32_t pri_reqs_dword;\n \tuint16_t pri_ctrl_word;\n+\tuint16_t pasid_ctrl;\n \n \toff_t pcie_cap_offset;\n \tint pri_cap_offset;\n@@ -197,6 +198,7 @@ dlb2_pf_reset(struct dlb2_dev *dlb2_dev)\n \tint err_cap_offset;\n \tint acs_cap_offset;\n \tint wait_count;\n+\tint pasid_cap_offset;\n \n \tuint16_t devsta_busy_word;\n \tuint16_t devctl_word;\n@@ -514,6 +516,31 @@ dlb2_pf_reset(struct dlb2_dev *dlb2_dev)\n \t\t}\n \t}\n \n+\t/* TODO - The current Linux kernel 6.2 vfio driver does not expose PASID capability to\n+\t * users. It also enables PASID by default, which breaks DLB PF PMD. We have\n+\t * to use the hardcoded offset for now to disable PASID. It may be different for\n+\t * other device drivers since they may have different design. When PASID capability\n+\t * is exposed to users, please revise this part and add api to disable PASID through\n+\t * pci common code.\n+\t */\n+\tpasid_cap_offset = RTE_PCI_PASID_CAP_OFFSET;\n+\n+\toff = pasid_cap_offset + RTE_PCI_PASID_CTRL;\n+\tif (rte_pci_read_config(pdev, &pasid_ctrl, 2, off) != 2)\n+\t\tpasid_ctrl = 0;\n+\n+\tif (pasid_ctrl) {\n+\t\tDLB2_INFO(dlb2_dev, \"DLB2 disabling pasid...\\n\");\n+\n+\t\tpasid_ctrl = 0;\n+\t\tret = rte_pci_write_config(pdev, &pasid_ctrl, 2, off);\n+\t\tif (ret != 2) {\n+\t\t\tDLB2_LOG_ERR(\"[%s()] failed to write the pcie config space at offset %d\\n\",\n+\t\t\t\t__func__, (int)off);\n+\t\t\treturn ret;\n+\t\t}\n+\t}\n+\n \treturn 0;\n }\n \ndiff --git a/lib/pci/rte_pci.h b/lib/pci/rte_pci.h\nindex 69e932d910..772a8d5622 100644\n--- a/lib/pci/rte_pci.h\n+++ b/lib/pci/rte_pci.h\n@@ -101,6 +101,11 @@ extern \"C\" {\n #define RTE_PCI_EXT_CAP_ID_ACS\t\t0x0d\t/* Access Control Services */\n #define RTE_PCI_EXT_CAP_ID_SRIOV\t0x10\t/* SR-IOV */\n #define RTE_PCI_EXT_CAP_ID_PRI\t\t0x13\t/* Page Request Interface */\n+#define RTE_PCI_EXT_CAP_ID_PASID 0x1B /* Process Address Space ID */\n+\n+/* Process Address Space ID */\n+#define RTE_PCI_PASID_CTRL\t\t0x06 /* PASID control register */\n+#define RTE_PCI_PASID_CAP_OFFSET 0x148 /* PASID capability offset */\n \n /* Advanced Error Reporting (RTE_PCI_EXT_CAP_ID_ERR) */\n #define RTE_PCI_ERR_UNCOR_STATUS\t0x04\t/* Uncorrectable Error Status */\n", "prefixes": [ "v3" ] }