Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/133627/?format=api
{ "id": 133627, "url": "http://patches.dpdk.org/api/patches/133627/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/tencent_CF44B0629A79704E5F22C0749CBFED469809@qq.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<tencent_CF44B0629A79704E5F22C0749CBFED469809@qq.com>", "list_archive_url": "https://inbox.dpdk.org/dev/tencent_CF44B0629A79704E5F22C0749CBFED469809@qq.com", "date": "2023-10-30T11:45:29", "name": "devargs: fix derefrence before null test", "commit_ref": null, "pull_url": null, "state": "rejected", "archived": true, "hash": "bb87b68d3a4b75c805b046a0a1dfca68c3eea17e", "submitter": { "id": 2458, "url": "http://patches.dpdk.org/api/people/2458/?format=api", "name": "Weiguo Li", "email": "liwg06@foxmail.com" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/tencent_CF44B0629A79704E5F22C0749CBFED469809@qq.com/mbox/", "series": [ { "id": 30058, "url": "http://patches.dpdk.org/api/series/30058/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=30058", "date": "2023-10-30T11:45:29", "name": "devargs: fix derefrence before null test", "version": 1, "mbox": "http://patches.dpdk.org/series/30058/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/133627/comments/", "check": "warning", "checks": "http://patches.dpdk.org/api/patches/133627/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id D8EA84323F;\n\tMon, 30 Oct 2023 12:46:11 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 77FC240A71;\n\tMon, 30 Oct 2023 12:46:11 +0100 (CET)", "from out162-62-57-210.mail.qq.com (out162-62-57-210.mail.qq.com\n [162.62.57.210])\n by mails.dpdk.org (Postfix) with ESMTP id 8B7E240285;\n Mon, 30 Oct 2023 12:46:02 +0100 (CET)", "from liwg-V5320.. ([36.112.73.58])\n by newxmesmtplogicsvrszc5-0.qq.com (NewEsmtp) with SMTP\n id B5D2C4BE; Mon, 30 Oct 2023 19:45:29 +0800" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=foxmail.com;\n s=s201512; t=1698666354;\n bh=09TGe/UHDWQZz7WW0TU9oNUmcnw30Vl8Wfua4BEyyu4=;\n h=From:To:Cc:Subject:Date;\n b=h2OATsCoBOK8SjpllNxDHvjlqYi5/i+puiwcBN/D1Mby1z37bEqWK6DKJlI4onDrT\n pumRjAjKWUeL3Ylt34HSemC/0Zcp+zZKuTN80TKw61ajLaBEOREwxVRyoqq1pBUHlC\n ZjEy+8kiwlmt6IQu2PCUnP8qnqfQM8dA8OPjALOA=", "X-QQ-mid": "xmsmtpt1698666329tbhk482eh", "Message-ID": "<tencent_CF44B0629A79704E5F22C0749CBFED469809@qq.com>", "X-QQ-XMAILINFO": "NjwfzuPTvt15zPz4MCYPTYbeB0lKoMUoQIJzUxubn5I4rWwV5kKsAD39kUl6Jm\n +LkFSKuJlsJv4+XRvA8wjNvI3yAPVgSCCNjZEXXxA0RQuO3SeNlLuWnEQt7letdSqYqyaMzvfCwK\n 4VCweRMVKlRUqO9ujsm2hYJMF+yorK3BBtiD1sByKWKcIz9rOlMImYmiWKOLWaHSdF8zI92RSTuN\n FXBPnDh6X5oIJTjNGn8ZTMheM43Hm0anGsjzWco1sOpMujt1jCMqmQ8KHkJvoJzllfosNug2i99S\n mldr297QksCX6ka1tNLHeHTCqwnJh9KPHcoLudz6kS0R46cBnQAa4yaUJBFAeKzJUq2U5OLs0227\n lY0rsoEs2EBL5fEioAKBFJgTlR7Z0NChv66FBlHdVxixfl8Y7yj5cb0LnVKQnt8n0x6Oi3ctHBup\n gTndIUsTxFJQNEFOhiuYOgppmU8YP1vlwMD64+l7FJ8GxV06h2G9BhsdYoEf5Wx20FRo+FzL2vmH\n UZeEBwn0Xx4f71eFp9UtvfJqtfwFHwNniUUllG8ZF17CHGsyF0guRARXnqwgMxigEGR4zf4PrQ7p\n XU5aeHoc7gS8+ou03uB2c+IyD/zCLaEk4nREJUJX5pgjZ6Zr7rUU7+xyks8090fSXgKgTC8jI6aO\n TUy8nG98TNQKa+OjD1waAKZQ8P+BhOxU3zrNLB3hZu1EeG4XFcvTnvR69g6M2/ISztLORpmNvf6C\n DeTaBWro+HGpxz8QrTV8zLXAbdJUWRBe/qIxSMR8NyyXi+ddNgtk7jhNh2atslN5XvdRAyeSGasf\n pt5qlhRCLftwm9ElrXc8/va7ftBMvYpHJkviLUYq/hQMW4WATVIB9F7dPwxTFuqfx6/vU4dr2F8p\n cE2F4PKVvj5OM8TliCwxmTVZVsh0h7AV4Hc8g3Zna8m9pOUZNSxNZPhS1fu8ZyUySSHJJLrUt06h\n zQobGxVdbVHHQhldwz7SeO5kcahwuIi2x5fJ71TKXwEty3RdzLuwcxJvx39QyyqUTmjLVP3/7MFe\n AU5WpjAYs8ryx2PJwZCj1WhnquMSE=", "X-QQ-XMRINFO": "Nq+8W0+stu50PRdwbJxPCL0=", "From": "Weiguo Li <liwg06@foxmail.com>", "To": "dev@dpdk.org", "Cc": "stable@dpdk.org,\n\tWeiguo Li <liweiguo@xencore.cn>", "Subject": "[PATCH] devargs: fix derefrence before null test", "Date": "Mon, 30 Oct 2023 19:45:29 +0800", "X-OQ-MSGID": "<20231030114529.1669787-1-liwg06@foxmail.com>", "X-Mailer": "git-send-email 2.34.1", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Pointer 'da' was dereferenced and then compared to NULL,\nreorder the code to keep the logic consistent.\n\nFixes: 4969f5914c9e (\"devargs: introduce new parsing helper\")\nCc: stable@dpdk.org\n\nSigned-off-by: Weiguo Li <liweiguo@xencore.cn>\n---\n .mailmap | 2 +-\n lib/eal/common/eal_common_devargs.c | 4 +++-\n 2 files changed, 4 insertions(+), 2 deletions(-)", "diff": "diff --git a/.mailmap b/.mailmap\nindex 3f5bab26a8..b4f0ae26b8 100644\n--- a/.mailmap\n+++ b/.mailmap\n@@ -1500,7 +1500,7 @@ Waterman Cao <waterman.cao@intel.com>\n Weichun Chen <weichunx.chen@intel.com>\n Wei Dai <wei.dai@intel.com>\n Weifeng Li <liweifeng96@126.com>\n-Weiguo Li <liwg06@foxmail.com>\n+Weiguo Li <liwg06@foxmail.com> <liweiguo@xencore.cn>\n Wei Huang <wei.huang@intel.com>\n Wei Hu <weh@microsoft.com>\n Wei Hu (Xavier) <xavier.huwei@huawei.com>\ndiff --git a/lib/eal/common/eal_common_devargs.c b/lib/eal/common/eal_common_devargs.c\nindex fb5d0a293b..8d6c3938eb 100644\n--- a/lib/eal/common/eal_common_devargs.c\n+++ b/lib/eal/common/eal_common_devargs.c\n@@ -185,11 +185,13 @@ rte_devargs_parse(struct rte_devargs *da, const char *dev)\n {\n \tstruct rte_bus *bus = NULL;\n \tconst char *devname;\n-\tconst size_t maxlen = sizeof(da->name);\n \tsize_t i;\n \n \tif (da == NULL)\n \t\treturn -EINVAL;\n+\n+\tconst size_t maxlen = sizeof(da->name);\n+\n \tmemset(da, 0, sizeof(*da));\n \n \t/* First parse according global device syntax. */\n", "prefixes": [] }