Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/133586/?format=api
{ "id": 133586, "url": "http://patches.dpdk.org/api/patches/133586/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20231029163202.216450-13-getelson@nvidia.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20231029163202.216450-13-getelson@nvidia.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20231029163202.216450-13-getelson@nvidia.com", "date": "2023-10-29T16:31:45", "name": "[13/30] net/mlx5: add validation support for tags", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "5e647377f59593e5591760ade4b9a7806ce4502f", "submitter": { "id": 1882, "url": "http://patches.dpdk.org/api/people/1882/?format=api", "name": "Gregory Etelson", "email": "getelson@nvidia.com" }, "delegate": { "id": 3268, "url": "http://patches.dpdk.org/api/users/3268/?format=api", "username": "rasland", "first_name": "Raslan", "last_name": "Darawsheh", "email": "rasland@nvidia.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20231029163202.216450-13-getelson@nvidia.com/mbox/", "series": [ { "id": 30049, "url": "http://patches.dpdk.org/api/series/30049/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=30049", "date": "2023-10-29T16:31:33", "name": "[01/30] net/mlx5/hws: Definer, add mlx5dr context to definer_conv_data", "version": 1, "mbox": "http://patches.dpdk.org/series/30049/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/133586/comments/", "check": "warning", "checks": "http://patches.dpdk.org/api/patches/133586/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 4F8D343238;\n\tSun, 29 Oct 2023 17:34:19 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id B13B1410D0;\n\tSun, 29 Oct 2023 17:33:16 +0100 (CET)", "from NAM11-CO1-obe.outbound.protection.outlook.com\n (mail-co1nam11on2082.outbound.protection.outlook.com [40.107.220.82])\n by mails.dpdk.org (Postfix) with ESMTP id C3048411F3\n for <dev@dpdk.org>; Sun, 29 Oct 2023 17:33:14 +0100 (CET)", "from BL1PR13CA0082.namprd13.prod.outlook.com (2603:10b6:208:2b8::27)\n by SJ1PR12MB6025.namprd12.prod.outlook.com (2603:10b6:a03:48c::7)\n with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6933.26; Sun, 29 Oct\n 2023 16:33:11 +0000", "from BL02EPF0001A100.namprd03.prod.outlook.com\n (2603:10b6:208:2b8:cafe::17) by BL1PR13CA0082.outlook.office365.com\n (2603:10b6:208:2b8::27) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6954.14 via Frontend\n Transport; Sun, 29 Oct 2023 16:33:10 +0000", "from mail.nvidia.com (216.228.117.161) by\n BL02EPF0001A100.mail.protection.outlook.com (10.167.242.107) with Microsoft\n SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.20.6933.15 via Frontend Transport; Sun, 29 Oct 2023 16:33:10 +0000", "from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com\n (10.129.200.67) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.41; Sun, 29 Oct\n 2023 09:32:58 -0700", "from nvidia.com (10.126.231.35) by rnnvmail201.nvidia.com\n (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.41; Sun, 29 Oct\n 2023 09:32:55 -0700" ], "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;\n b=hqGfnx8NS4LQOFNOehfSnaaq9UwdueeXJID1/LCOBgIYHdXpMX2CtPIjIYBE+goqlf+ttT8oQyuwj+IzEWa3KlA2SOhOjeQ7SKLp0qqR2rzgdJGAvwgSJPtzTlZ/3FuuOXeuN5ueUVc6f2bz0AKl6KXjnohr6/AqBmXjGarnvId8qIiAvtdCJVoOeEkHQKAK9VIcMx5vvVkOIUNoq//yWs1YAP1fDKJO50pHGwpkCSM+0digM+QQfTGx0lCDotpTFyp0I/gWR1qKPYej1U0+8IqbERmo7dPtdVIUX8xftOfr+STUBdSq7u0mG8YpqqawzxbaKMANJa0JjWW2yuBK0w==", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector9901;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=0aVBD2mtzeAL8YMyqf6ag3r3vixxiNKYrTyVrlUAmHo=;\n b=Xr8fRyorIRV6709GAgIdWLjDtg/8uHXq4KzL7jZFLuh5YBAE2XJGZihhZ6F/40/J9R9tOj21CG2inYiVyxZeoR2fqP60Ra5mIQV+6u1NMeun96L56Y3+Aln6i93gbtQg9QLlucRrmjRRSYjq82SJ/P77/7e49p+5pIw8yhp9aBYqv+xTDNe2ZA/Y5mTKUtW4hHjrkciYnXeYE/vPSQYFN7dXJ60ZCq+jmD7pgzB2OWVPOj1+G0gIGuCXu6jnpia/tnObt0dBGlxoFro9yk69GyNd1+GDIB2suyjDMpWvIBVZTDIO8RX22jiT7GNhE7YRU79eVsvhTz13XrtlbtpYNQ==", "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass (sender ip is\n 216.228.117.161) smtp.rcpttodomain=dpdk.org smtp.mailfrom=nvidia.com;\n dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com;\n dkim=none (message not signed); arc=none (0)", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com;\n s=selector2;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=0aVBD2mtzeAL8YMyqf6ag3r3vixxiNKYrTyVrlUAmHo=;\n b=M/j1ppZ4U6agJtBz/msJOGzfyusFg5Kqy9y8M+VZOucd7xFZ0l4Kxt1GHPnDttBBnyfHDvAgXHBg9No6eygQ+S5ata95jfGURKtbTIFAAFY2fDbzfCwtRDpJmNRQ1+Flx2C7X1m+kbmeW1jC0gwMzAladniuZ5ioBCUBdJczGTXco1YDF2GWq5RrzwSZmubjmfm70D69Cu0xnMIwH/E/7I7L937ioaAT4PjpetYBb85UoMcg8fbayeUjw2zhmnKB9WnFxlgBxBWs45ySOsBVZ6ic7wFxHamvwhwwuf1+6A5DsQiFYd/66mNiaQTLrt1qvhjYVnPS6qYnn4FNFRyJIw==", "X-MS-Exchange-Authentication-Results": "spf=pass (sender IP is 216.228.117.161)\n smtp.mailfrom=nvidia.com;\n dkim=none (message not signed)\n header.d=none;dmarc=pass action=none header.from=nvidia.com;", "Received-SPF": "Pass (protection.outlook.com: domain of nvidia.com designates\n 216.228.117.161 as permitted sender) receiver=protection.outlook.com;\n client-ip=216.228.117.161; helo=mail.nvidia.com; pr=C", "From": "Gregory Etelson <getelson@nvidia.com>", "To": "<dev@dpdk.org>", "CC": "<getelson@nvidia.com>, <mkashani@nvidia.com>, <rasland@nvidia.com>, \"Ori\n Kam\" <orika@nvidia.com>, Matan Azrad <matan@nvidia.com>, Viacheslav Ovsiienko\n <viacheslavo@nvidia.com>, Suanming Mou <suanmingm@nvidia.com>", "Subject": "[PATCH 13/30] net/mlx5: add validation support for tags", "Date": "Sun, 29 Oct 2023 18:31:45 +0200", "Message-ID": "<20231029163202.216450-13-getelson@nvidia.com>", "X-Mailer": "git-send-email 2.39.2", "In-Reply-To": "<20231029163202.216450-1-getelson@nvidia.com>", "References": "<20231029163202.216450-1-getelson@nvidia.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Originating-IP": "[10.126.231.35]", "X-ClientProxiedBy": "rnnvmail203.nvidia.com (10.129.68.9) To\n rnnvmail201.nvidia.com (10.129.68.8)", "X-EOPAttributedMessage": "0", "X-MS-PublicTrafficType": "Email", "X-MS-TrafficTypeDiagnostic": "BL02EPF0001A100:EE_|SJ1PR12MB6025:EE_", "X-MS-Office365-Filtering-Correlation-Id": "437a1206-a456-4aae-0d39-08dbd89cbd77", "X-MS-Exchange-SenderADCheck": "1", "X-MS-Exchange-AntiSpam-Relay": "0", "X-Microsoft-Antispam": "BCL:0;", "X-Microsoft-Antispam-Message-Info": "\n hhxPniEptXL8AOQ11fHqk2Yl/brRniJKghlROMMEksGsFn7qhmakwugtNWoZXP3s643zt/Dd5ckvrJDJi+YUr138R6e9rVHLKiFVwSOhPPKUd6aQtiYI6z9CFkpI74L19F9y+RaAF3RIU0CdwWYVuCLZIJTMjhoxqZewAnFQTX2gWWbfF2LztaY/Cl2x/eIbqLBc8m9QW618ncbzbMnKD5Ko1HGXffT0IbY9ZtYKWO5a/uJXOG/tS7s8R/A6JTh+JATH77nT7YG/z6d1/UOSmD7ySEU858zZQCBzK+QTXDd7AA52iI2g3GiOZrLQgtUbFI8BdcIfkisrX6b5jpiVTnULkhuecTui5vPkzOGGaMa5ECNAD2soN/yb1+pgWpanuqiRhxx+saazXLRgQYhnXEWUYykZlJVauu+Sn7BQ92b6Uk1bRFToUeZuZxrYIEFs/+Xeko9z7Bo+m+iqZTdw0FS+WPEZuu+glQAeAPi3CrZHHxMxtH4GV5ggBSAYZaaB116q8YE3ynbT4nJSpfenc+COLWU0AZ2N9b5aOzOAXRRaXdwNtCyu7r7bjW7xtSIB9Zoojj+XtBhF+AyIQgoPTdmkm1hSaPJo+ZFaFOJza1Uo35mBZ7zorwTQrxUSX+m5YyhJU0yzmdK15xfyTdCwmeWnqgKqgu7fp69YF3q9x4EdIG/W0pUFIVTkNtFW1u9M8WlPl3dDPo262hL4ehPmaPZaAE8ZcIziXi/Abz/IkXxkfoddazC4meYhVnovmeL+", "X-Forefront-Antispam-Report": "CIP:216.228.117.161; CTRY:US; LANG:en; SCL:1;\n SRV:;\n IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge2.nvidia.com; CAT:NONE;\n SFS:(13230031)(4636009)(346002)(396003)(136003)(39860400002)(376002)(230922051799003)(82310400011)(451199024)(64100799003)(186009)(1800799009)(40470700004)(36840700001)(46966006)(40460700003)(36756003)(26005)(16526019)(6286002)(1076003)(83380400001)(7636003)(426003)(336012)(5660300002)(356005)(6666004)(7696005)(2616005)(107886003)(82740400003)(8936002)(8676002)(47076005)(54906003)(316002)(41300700001)(6916009)(36860700001)(55016003)(40480700001)(70586007)(86362001)(478600001)(70206006)(2906002)(4326008);\n DIR:OUT; SFP:1101;", "X-OriginatorOrg": "Nvidia.com", "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "29 Oct 2023 16:33:10.6375 (UTC)", "X-MS-Exchange-CrossTenant-Network-Message-Id": "\n 437a1206-a456-4aae-0d39-08dbd89cbd77", "X-MS-Exchange-CrossTenant-Id": "43083d15-7273-40c1-b7db-39efd9ccc17a", "X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp": "\n TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.161];\n Helo=[mail.nvidia.com]", "X-MS-Exchange-CrossTenant-AuthSource": "\n BL02EPF0001A100.namprd03.prod.outlook.com", "X-MS-Exchange-CrossTenant-AuthAs": "Anonymous", "X-MS-Exchange-CrossTenant-FromEntityHeader": "HybridOnPrem", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "SJ1PR12MB6025", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "From: Ori Kam <orika@nvidia.com>\n\nThis commit introduce validation for invalid tags\n\nSigned-off-by: Ori Kam <orika@nvidia.com>\n---\n drivers/net/mlx5/mlx5_flow_hw.c | 30 +++++++++++++++++++++++++++---\n 1 file changed, 27 insertions(+), 3 deletions(-)", "diff": "diff --git a/drivers/net/mlx5/mlx5_flow_hw.c b/drivers/net/mlx5/mlx5_flow_hw.c\nindex ceeb82a649..6fc649d736 100644\n--- a/drivers/net/mlx5/mlx5_flow_hw.c\n+++ b/drivers/net/mlx5/mlx5_flow_hw.c\n@@ -4049,7 +4049,8 @@ flow_hw_modify_field_is_used(const struct rte_flow_action_modify_field *action,\n }\n \n static int\n-flow_hw_validate_action_modify_field(const struct rte_flow_action *action,\n+flow_hw_validate_action_modify_field(struct rte_eth_dev *dev,\n+\t\t\t\t const struct rte_flow_action *action,\n \t\t\t\t const struct rte_flow_action *mask,\n \t\t\t\t struct rte_flow_error *error)\n {\n@@ -4118,6 +4119,22 @@ flow_hw_validate_action_modify_field(const struct rte_flow_action *action,\n \t\tif (ret)\n \t\t\treturn ret;\n \t}\n+\tif ((action_conf->dst.field == RTE_FLOW_FIELD_TAG &&\n+\t action_conf->dst.tag_index >= MLX5_FLOW_HW_TAGS_MAX &&\n+\t action_conf->dst.tag_index != MLX5_LINEAR_HASH_TAG_INDEX) ||\n+\t (action_conf->src.field == RTE_FLOW_FIELD_TAG &&\n+\t action_conf->src.tag_index >= MLX5_FLOW_HW_TAGS_MAX &&\n+\t action_conf->src.tag_index != MLX5_LINEAR_HASH_TAG_INDEX))\n+\t\treturn rte_flow_error_set(error, EINVAL,\n+\t\t\t\t\t RTE_FLOW_ERROR_TYPE_ACTION, action,\n+\t\t\t\t \"tag index is out of range\");\n+\tif ((action_conf->dst.field == RTE_FLOW_FIELD_TAG &&\n+\t flow_hw_get_reg_id(dev, RTE_FLOW_ITEM_TYPE_TAG, action_conf->dst.tag_index) == REG_NON) ||\n+\t (action_conf->src.field == RTE_FLOW_FIELD_TAG &&\n+\t flow_hw_get_reg_id(dev, RTE_FLOW_ITEM_TYPE_TAG, action_conf->src.tag_index) == REG_NON))\n+\t\treturn rte_flow_error_set(error, EINVAL,\n+\t\t\t\t\t RTE_FLOW_ERROR_TYPE_ACTION, action,\n+\t\t\t\t\t \"tag index is out of range\");\n \tif (mask_conf->width != UINT32_MAX)\n \t\treturn rte_flow_error_set(error, EINVAL,\n \t\t\t\tRTE_FLOW_ERROR_TYPE_ACTION, action,\n@@ -4728,7 +4745,7 @@ mlx5_flow_hw_actions_validate(struct rte_eth_dev *dev,\n \t\t\taction_flags |= MLX5_FLOW_ACTION_METER;\n \t\t\tbreak;\n \t\tcase RTE_FLOW_ACTION_TYPE_MODIFY_FIELD:\n-\t\t\tret = flow_hw_validate_action_modify_field(action, mask,\n+\t\t\tret = flow_hw_validate_action_modify_field(dev, action, mask,\n \t\t\t\t\t\t\t\t error);\n \t\t\tif (ret < 0)\n \t\t\t\treturn ret;\n@@ -5596,7 +5613,14 @@ flow_hw_pattern_validate(struct rte_eth_dev *dev,\n \t\t\tif (tag == NULL)\n \t\t\t\treturn rte_flow_error_set(error, EINVAL,\n \t\t\t\t\t\t\t RTE_FLOW_ERROR_TYPE_UNSPECIFIED,\n-\t\t\t\t\t\t\t NULL, \"Tag spec is NULL\");\n+\t\t\t\t\t\t\t NULL,\n+\t\t\t\t\t\t\t \"Tag spec is NULL\");\n+\t\t\tif (tag->index >= MLX5_FLOW_HW_TAGS_MAX &&\n+\t\t\t tag->index != MLX5_LINEAR_HASH_TAG_INDEX)\n+\t\t\t\treturn rte_flow_error_set(error, EINVAL,\n+\t\t\t\t\t\t\t RTE_FLOW_ERROR_TYPE_UNSPECIFIED,\n+\t\t\t\t\t\t\t NULL,\n+\t\t\t\t\t\t\t \"Invalid tag index\");\n \t\t\ttag_idx = flow_hw_get_reg_id(dev, RTE_FLOW_ITEM_TYPE_TAG, tag->index);\n \t\t\tif (tag_idx == REG_NON)\n \t\t\t\treturn rte_flow_error_set(error, EINVAL,\n", "prefixes": [ "13/30" ] }