Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 133553,
    "url": "http://patches.dpdk.org/api/patches/133553/?format=api",
    "web_url": "http://patches.dpdk.org/project/dpdk/patch/20231028062315.1843075-4-chaoyong.he@corigine.com/",
    "project": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<20231028062315.1843075-4-chaoyong.he@corigine.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/20231028062315.1843075-4-chaoyong.he@corigine.com",
    "date": "2023-10-28T06:23:15",
    "name": "[3/3] net/nfp: fix the reconfigure logic of set mac address",
    "commit_ref": null,
    "pull_url": null,
    "state": "accepted",
    "archived": true,
    "hash": "ae6b7a010d7994759b1ab60cf0de90e1b83ce639",
    "submitter": {
        "id": 2554,
        "url": "http://patches.dpdk.org/api/people/2554/?format=api",
        "name": "Chaoyong He",
        "email": "chaoyong.he@corigine.com"
    },
    "delegate": {
        "id": 319,
        "url": "http://patches.dpdk.org/api/users/319/?format=api",
        "username": "fyigit",
        "first_name": "Ferruh",
        "last_name": "Yigit",
        "email": "ferruh.yigit@amd.com"
    },
    "mbox": "http://patches.dpdk.org/project/dpdk/patch/20231028062315.1843075-4-chaoyong.he@corigine.com/mbox/",
    "series": [
        {
            "id": 30038,
            "url": "http://patches.dpdk.org/api/series/30038/?format=api",
            "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=30038",
            "date": "2023-10-28T06:23:12",
            "name": "Fix some reconfigure problem",
            "version": 1,
            "mbox": "http://patches.dpdk.org/series/30038/mbox/"
        }
    ],
    "comments": "http://patches.dpdk.org/api/patches/133553/comments/",
    "check": "warning",
    "checks": "http://patches.dpdk.org/api/patches/133553/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@inbox.dpdk.org",
        "Delivered-To": "patchwork@inbox.dpdk.org",
        "Received": [
            "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id EDE4743220;\n\tSat, 28 Oct 2023 08:23:57 +0200 (CEST)",
            "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 917F2406BA;\n\tSat, 28 Oct 2023 08:23:49 +0200 (CEST)",
            "from NAM11-DM6-obe.outbound.protection.outlook.com\n (mail-dm6nam11on2103.outbound.protection.outlook.com [40.107.223.103])\n by mails.dpdk.org (Postfix) with ESMTP id CEBEE402DE;\n Sat, 28 Oct 2023 08:23:46 +0200 (CEST)",
            "from SJ0PR13MB5545.namprd13.prod.outlook.com (2603:10b6:a03:424::5)\n by PH7PR13MB6268.namprd13.prod.outlook.com (2603:10b6:510:24f::16)\n with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6933.22; Sat, 28 Oct\n 2023 06:23:45 +0000",
            "from SJ0PR13MB5545.namprd13.prod.outlook.com\n ([fe80::45b3:d83c:cff2:4a1b]) by SJ0PR13MB5545.namprd13.prod.outlook.com\n ([fe80::45b3:d83c:cff2:4a1b%6]) with mapi id 15.20.6933.022; Sat, 28 Oct 2023\n 06:23:45 +0000"
        ],
        "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;\n b=L/cd0Ku47mxOCmQH7hojyy8+18zjyWYdUi19685CsJksC/aSQRPSqpDcxMB9VNRl5ORkYi5rs6mqoJ3/RTBSYsXUJ6gnUNMYNqKnPrBHIrh0gaAWSIttolDBcwhW5VtvFXar3Yzt5Pnub/F6emNKkinj/hBqXdj3+mFNZtys/Z8Q6vVrCCfrT93E91RiHjQaxM9MI5j13Rag+l9qE4MirxZZpmqtswHMjaE2kqgupkDbwQFislwWEXhOaTUNuOX7t3ZFaR91xNLqm2zckOS3TZd6LdaFpSRIvIZKD/V8aOpEseBd7e1amVfTcuFGbPYK3liQS3Hdd7LlWiyt8HZFZw==",
        "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector9901;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=VW76zRL5X3TNcOyOuFKEMqd3l0X/eGDbDnHphBDgID4=;\n b=jaWnuHhkM6dz5Fcdrg1XwNbU0Hc2CuREw/vyernmWZ75iXq8nF5Rou6RhgtZcO4omlAj6nhKoU9YmuElC1WbrAKCYwgZZOkZGs7jMcu1SMaaxso3i//pBytFKPL8PbyR9PR3uJAG3DRLE0VMo+OAJcaIXk8yAckninV7JV2AXpk/0MhAgAo4Cno+elmVuRkHQH9IvUjOYq6jfbVZy+fpjKMDhcV4WjoZmSKYbnD/rtfg6br0bVq1dtfZ04G79POBNKuIc3LBxTg6Szye2l2BbRXc9slcDLBsKO5xVMGX5ov0tT/DjlYjFFu85MXC2Popl2otEBxejgHW365VK1oaag==",
        "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass\n smtp.mailfrom=corigine.com; dmarc=pass action=none header.from=corigine.com;\n dkim=pass header.d=corigine.com; arc=none",
        "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=corigine.onmicrosoft.com; s=selector2-corigine-onmicrosoft-com;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=VW76zRL5X3TNcOyOuFKEMqd3l0X/eGDbDnHphBDgID4=;\n b=N6mwb1dhnV0emQpRJhSIAs/E4mYyfMK0wUt/P6knrX2pCPnvtM5nMkpRDRCp0X5cOfkragoYREAFaDaH7nniYe/XEwnq/tO5ZPGkEYtO5WCVAGwBleiMDsbuEmjdf3U/Nm7DHGoFlkzBCGAMxuE4YdNE9kNYwx4aQkm+h8wW3T4=",
        "Authentication-Results": "dkim=none (message not signed)\n header.d=none;dmarc=none action=none header.from=corigine.com;",
        "From": "Chaoyong He <chaoyong.he@corigine.com>",
        "To": "dev@dpdk.org",
        "Cc": "oss-drivers@corigine.com, Chaoyong He <chaoyong.he@corigine.com>,\n stable@dpdk.org, Long Wu <long.wu@corigine.com>,\n Peng Zhang <peng.zhang@corigine.com>",
        "Subject": "[PATCH 3/3] net/nfp: fix the reconfigure logic of set mac address",
        "Date": "Sat, 28 Oct 2023 14:23:15 +0800",
        "Message-Id": "<20231028062315.1843075-4-chaoyong.he@corigine.com>",
        "X-Mailer": "git-send-email 2.39.1",
        "In-Reply-To": "<20231028062315.1843075-1-chaoyong.he@corigine.com>",
        "References": "<20231028062315.1843075-1-chaoyong.he@corigine.com>",
        "Content-Transfer-Encoding": "8bit",
        "Content-Type": "text/plain",
        "X-ClientProxiedBy": "BY5PR04CA0003.namprd04.prod.outlook.com\n (2603:10b6:a03:1d0::13) To SJ0PR13MB5545.namprd13.prod.outlook.com\n (2603:10b6:a03:424::5)",
        "MIME-Version": "1.0",
        "X-MS-PublicTrafficType": "Email",
        "X-MS-TrafficTypeDiagnostic": "SJ0PR13MB5545:EE_|PH7PR13MB6268:EE_",
        "X-MS-Office365-Filtering-Correlation-Id": "6eb3b0b1-f444-4f8f-0634-08dbd77e7026",
        "X-MS-Exchange-SenderADCheck": "1",
        "X-MS-Exchange-AntiSpam-Relay": "0",
        "X-Microsoft-Antispam": "BCL:0;",
        "X-Microsoft-Antispam-Message-Info": "\n iVzMHBkKqnij+qjZ7Yy+124hu6cKl1929mllcEOumRXA95vt2Jm8eyvkxcGfEJOtTtWdw7Ob8IWW1wtld7koQhkbQh42aPKFi2bsA5U+9Tng5YURvIAnLGxIp9kqcvZn2QqZ9dYRoxr0n0AaDdCeMSpSbc9qon1JxcB9ntoSDJXibFF1NAly/BbGT9CDzZnDOJMWLn6D53HuyXamgpzk2B87DyyCzQR2pdEu0OBuZre2FlhGQns80npAYrssrTBjydKmtDKJbM9FCEo94rwS/pziDSBkgK0JrA2nmCsO/eSN7q4PBnekiLXyiYlObvTI9C5CcueqR0qCdR/De0rflXhurhVPDS+b7FC2HGvBUMNKT13JbpO2g81MjtmWYl4EWAx0gj3R4ik9WrcF2aCJxkdIgvh45/5Nafv0YaYKjnTEfXYJ7fdHwJMS3N6laJzS+FrwjZlDvIuUHWNkidDPxlJWqmLkjKuXSFt/mOR5U2EgwZr56ySt1behlmWca8dPkP+Ume8G3OHbRRh0xdpwuFoVpxj/2sthlVqrEkTWkH6sf7ybSvo4lyRiCoE5CaJwZk+nD9GVjSSk2gqY+lQZ4C/JCNYmTDdJtLxqjqKUulD1GBolG7pomXU5tZrerWavV5z6fCIv3VwfEKf7YWlRIvaI2YsjcD67xCh9cT9ZSjc=",
        "X-Forefront-Antispam-Report": "CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;\n IPV:NLI; SFV:NSPM; H:SJ0PR13MB5545.namprd13.prod.outlook.com; PTR:; CAT:NONE;\n SFS:(13230031)(396003)(39830400003)(366004)(346002)(376002)(136003)(230922051799003)(186009)(1800799009)(451199024)(64100799003)(2906002)(38100700002)(83380400001)(1076003)(107886003)(5660300002)(2616005)(86362001)(6512007)(41300700001)(44832011)(36756003)(38350700005)(66476007)(316002)(6916009)(66946007)(54906003)(66556008)(52116002)(6666004)(6506007)(6486002)(8676002)(26005)(478600001)(450100002)(4326008)(8936002);\n DIR:OUT; SFP:1102;",
        "X-MS-Exchange-AntiSpam-MessageData-ChunkCount": "1",
        "X-MS-Exchange-AntiSpam-MessageData-0": "\n 2lwBx+zZyf50c6EzA7QIlOQIzWoHR1nMgGgfKfqKGER0nlmPz+yFpcyBd5EoIW/nG7Gl4t/BvogkdNh5La69jee7D5+pnLnZcM515prCL5uH4uA5xKgBvb13EWXbfT0+9dXGs9sRoHJvRSdVJxo9JBtETRIGEhtNrmRe8fl4vamF204uYAq8Y6uJFgyVXGvB95bjyNqVoDhE8hxkCiM7P39e/BrNMTkgBvDlWT8x4jS5Og7F3pbNW4lWFDHUBnONSbHpsJNjSmjM926Gnw6wYgFK1CzHpULzQYCCgwKexh+XlmvJkbhEbvbCwkPu6qtdU6+bf8tW4LqNClnGn107W1jdxFSSLnqlCIz06JIPfaPzLp8EbFKSSu5uAVRZzfegSI6lsoXiHwONVgY91TGWrRgMgbbA7UJiEVqiuhtxS4o2/zF8zkorJAE2McsaKmujqd/WQ2wAnfzSMG4ogNNLzgsA9WrTLVn4k9/hTTgt9EuU71myeS2FOZGnW4aq1t4JZrakG6VuGybTXdPfCZQGCTErmmz7Q9qAYIVHzxGOk4jDa6XCumSTBXjEjQuVLPgca5V8T93YDkm9mdu+lA6cHn7ncPjHsVHso4O1fUzngfP/brVPOQTheglUxnas7G79CvVS6KHUzxau9urJ+gdsQnmQNtedxJFiWdF/Fc60yqKyV+uq0jLal8S6iFKdJEwKGVhGtaAUGCT6vjz9SWxmfJEICeH8Qkd7w7Z9HvO3b4RUDhN97LjT32DAi8kE9f4bOc1Wm5XPOlqxmBauQFLBj14Hp3bkPu6vPKu1RJlzVPLsbqg5QX+5Vfm9pzaDnVagWDseHU9O/65aREQ3jHq/joa+r0Uu0CcdKgD0TusCETxQhTPH6Q2VwqEl7kmvkKf58FJhsNhMh6PaZaNR2mpIE3WvLuLSHHqe8IxBs7/bWCtXE/PnJRFwhcMfFtpje2IEqDhXkM3IclkpY7bvC2yMfya/llv+OJn2MVDM7s6aCravYgsuo358ILaw2V02LSfw6bds1Z7dDHwwqJJ/3b8sCtJisGbF9CGyjJz+7e/vxr0ZFDFnWlcQSrf421Nll+X03p/Oz6RuUVA0cdWau+QjTxRSQ7K22ZpNWXyDG+sjZr6AVqoxnPVPMV/UqoZR1YXM4yMk7/s7GvqfSXjGPv9uWVp8y2vkawaCo37Sz20HUylp+gpeBMAPrI779VWc2QvnuAfS0sbFcv5pg+Ro3NWRvn8WjZjkgpI2mlXExRL6L+6rRWqYc4X/1AHLQ/FUOvT4dNsIRC8QfyGwWJyVpuiJDFhBLrL7NriEMdoa1dDJZr+kKvdlDFQlwMJs2ynGW33T7lpK5VyJ2y5xG57RzH7iIGUl2jSi3mSzmzRheoFw5hSmBWWWKndbvh5/FGOiDUZv8oEgnmw2QZExrpNhqFUVGTuci29x1BpZ/FHa9QgCxf6jOMikCMzRNVZSjmOEZLH2WBjHFsOTCqXys/1owBoFXcfgizebKRmhm42Ne55rT/3YRr6dUmGHqfA6Sb4Jzv6AyOPSiFHWWIcucZ3eCj/F7sr4HZ1A8WXIFKE8bzaUNOuIYuz2qNLx/GZej0AOCOAiSmK8glddgasZ5zfYg3a1SA==",
        "X-OriginatorOrg": "corigine.com",
        "X-MS-Exchange-CrossTenant-Network-Message-Id": "\n 6eb3b0b1-f444-4f8f-0634-08dbd77e7026",
        "X-MS-Exchange-CrossTenant-AuthSource": "SJ0PR13MB5545.namprd13.prod.outlook.com",
        "X-MS-Exchange-CrossTenant-AuthAs": "Internal",
        "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "28 Oct 2023 06:23:45.3250 (UTC)",
        "X-MS-Exchange-CrossTenant-FromEntityHeader": "Hosted",
        "X-MS-Exchange-CrossTenant-Id": "fe128f2c-073b-4c20-818e-7246a585940c",
        "X-MS-Exchange-CrossTenant-MailboxType": "HOSTED",
        "X-MS-Exchange-CrossTenant-UserPrincipalName": "\n SrkKrfN6RUi2BSh5lcXIYIjiICb7CpLgiq2tuAfoPYIrkP80r6TyZu8OYweWp7sjQc6YnFylnWwb0mJuJUhCsxZyib8JRUufU1Lx574FdGc=",
        "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "PH7PR13MB6268",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.29",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org"
    },
    "content": "If the reconfigure API exit abnormally, the value in the config bar\nwill not same with the value stored in the data structure.\n\nFix this by add a local variable to hold the temporary value and the\nlogic of store it when no error happen.\n\nFixes: 2fe669f4bcd2 (\"net/nfp: support MAC address change\")\nCc: stable@dpdk.org\n\nSigned-off-by: Chaoyong He <chaoyong.he@corigine.com>\nReviewed-by: Long Wu <long.wu@corigine.com>\nReviewed-by: Peng Zhang <peng.zhang@corigine.com>\n---\n drivers/net/nfp/nfp_net_common.c | 10 ++++++----\n 1 file changed, 6 insertions(+), 4 deletions(-)",
    "diff": "diff --git a/drivers/net/nfp/nfp_net_common.c b/drivers/net/nfp/nfp_net_common.c\nindex ac97e3bed5..a4ba16445d 100644\n--- a/drivers/net/nfp/nfp_net_common.c\n+++ b/drivers/net/nfp/nfp_net_common.c\n@@ -362,8 +362,8 @@ int\n nfp_net_set_mac_addr(struct rte_eth_dev *dev,\n \t\tstruct rte_ether_addr *mac_addr)\n {\n-\tuint32_t ctrl;\n \tuint32_t update;\n+\tuint32_t new_ctrl;\n \tstruct nfp_hw *hw;\n \tstruct nfp_net_hw *net_hw;\n \n@@ -379,17 +379,19 @@ nfp_net_set_mac_addr(struct rte_eth_dev *dev,\n \tnfp_write_mac(hw, (uint8_t *)mac_addr);\n \n \tupdate = NFP_NET_CFG_UPDATE_MACADDR;\n-\tctrl = hw->ctrl;\n+\tnew_ctrl = hw->ctrl;\n \tif ((hw->ctrl & NFP_NET_CFG_CTRL_ENABLE) != 0 &&\n \t\t\t(hw->cap & NFP_NET_CFG_CTRL_LIVE_ADDR) != 0)\n-\t\tctrl |= NFP_NET_CFG_CTRL_LIVE_ADDR;\n+\t\tnew_ctrl |= NFP_NET_CFG_CTRL_LIVE_ADDR;\n \n \t/* Signal the NIC about the change */\n-\tif (nfp_reconfig(hw, ctrl, update) != 0) {\n+\tif (nfp_reconfig(hw, new_ctrl, update) != 0) {\n \t\tPMD_DRV_LOG(ERR, \"MAC address update failed\");\n \t\treturn -EIO;\n \t}\n \n+\thw->ctrl = new_ctrl;\n+\n \treturn 0;\n }\n \n",
    "prefixes": [
        "3/3"
    ]
}