Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/133552/?format=api
{ "id": 133552, "url": "http://patches.dpdk.org/api/patches/133552/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20231028062315.1843075-3-chaoyong.he@corigine.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20231028062315.1843075-3-chaoyong.he@corigine.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20231028062315.1843075-3-chaoyong.he@corigine.com", "date": "2023-10-28T06:23:14", "name": "[2/3] net/nfp: fix the reconfigure logic in VF initialization", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "7ab123623a4cc42d2a505a162ef8fd74b7011922", "submitter": { "id": 2554, "url": "http://patches.dpdk.org/api/people/2554/?format=api", "name": "Chaoyong He", "email": "chaoyong.he@corigine.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20231028062315.1843075-3-chaoyong.he@corigine.com/mbox/", "series": [ { "id": 30038, "url": "http://patches.dpdk.org/api/series/30038/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=30038", "date": "2023-10-28T06:23:12", "name": "Fix some reconfigure problem", "version": 1, "mbox": "http://patches.dpdk.org/series/30038/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/133552/comments/", "check": "warning", "checks": "http://patches.dpdk.org/api/patches/133552/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 496D243220;\n\tSat, 28 Oct 2023 08:23:52 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 764194067B;\n\tSat, 28 Oct 2023 08:23:47 +0200 (CEST)", "from NAM11-DM6-obe.outbound.protection.outlook.com\n (mail-dm6nam11on2108.outbound.protection.outlook.com [40.107.223.108])\n by mails.dpdk.org (Postfix) with ESMTP id 7761840272;\n Sat, 28 Oct 2023 08:23:44 +0200 (CEST)", "from SJ0PR13MB5545.namprd13.prod.outlook.com (2603:10b6:a03:424::5)\n by PH7PR13MB6268.namprd13.prod.outlook.com (2603:10b6:510:24f::16)\n with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6933.22; Sat, 28 Oct\n 2023 06:23:43 +0000", "from SJ0PR13MB5545.namprd13.prod.outlook.com\n ([fe80::45b3:d83c:cff2:4a1b]) by SJ0PR13MB5545.namprd13.prod.outlook.com\n ([fe80::45b3:d83c:cff2:4a1b%6]) with mapi id 15.20.6933.022; Sat, 28 Oct 2023\n 06:23:43 +0000" ], "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;\n b=j02A8ruV8yfgfO76lb3sdWaEH+37S4bTJ2Ux2It1ClrGLQf+78yhjkZj89bTqxdl8SsS3T0o7KLQrjdr/RyatZNQMlmpKG9E3Aa/8psuubN0GHryHcZJxac48Pmg1f1bpd+G7h8EsZUl+VqvBubPzrESOc+NwbZggZ7yXpWYTO5vbclYWXoo+pAjmyipOLBNXda46Azde/D8As2aEyUUfC5w+8cQlHqDG2I0PHKv29H72kmiaLnS8v7g+otZDXYWDbdXKdYw9nYv/aWqFzt39rRE7RoQvuhFH4xj91D2uldYHrutUT1rkG06RP48/MD16rDRoV+loe1q4iLVUEnrrQ==", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector9901;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=nNhHr76sEyuNh0HytnS+WxdV+cw2IiqXmKh+lXcYEy4=;\n b=eOInL20mvpFw2EB0ICfLh25VVd6CuQpLChg58IdP5/3ZkUUrb4PtRo+5p5szvCU5nZoEJgv66zpvHR0yGkChP1lLng5Cp8dVuh21aRsqVlsF3cmPPOs+TbqJAv5OA1ju8pbE0J7HqfKFBYMoOZCmfRikB3a/7/bUqja8mQ4Xqsv1xJ5qXrYA6JKEoOSsN/JhoAotb2GlR/U+sGBvH3t+g0JOLOM/pkht1U+C2O6pSGaa+2IW/NG/JicHFfERhSqrPBV9jAZjT1QgHoZ5A6aGRcRw8X+fSHE6an1GOd19OwAfqew4AfOBCz0PQjrjHElDM8cpWulPrqkojqEAoPWJmw==", "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass\n smtp.mailfrom=corigine.com; dmarc=pass action=none header.from=corigine.com;\n dkim=pass header.d=corigine.com; arc=none", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=corigine.onmicrosoft.com; s=selector2-corigine-onmicrosoft-com;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=nNhHr76sEyuNh0HytnS+WxdV+cw2IiqXmKh+lXcYEy4=;\n b=k4UemvstDYx4PcpMiJBKyLv9vFlkQ1wnoyoEI1cCvXAF16VG/SVJzwEOVwQaX3/k25n010hHYEUN9EyGjcl9lqecvVzRdmVHjsvqDdfA/VhssH1XmFa3y2zkj0LrOzh6m21+HfBWwRjQUXHtfiymU4hugNNpr4bZca4IPqu3BIM=", "Authentication-Results": "dkim=none (message not signed)\n header.d=none;dmarc=none action=none header.from=corigine.com;", "From": "Chaoyong He <chaoyong.he@corigine.com>", "To": "dev@dpdk.org", "Cc": "oss-drivers@corigine.com, Chaoyong He <chaoyong.he@corigine.com>,\n stable@dpdk.org, Long Wu <long.wu@corigine.com>,\n Peng Zhang <peng.zhang@corigine.com>", "Subject": "[PATCH 2/3] net/nfp: fix the reconfigure logic in VF initialization", "Date": "Sat, 28 Oct 2023 14:23:14 +0800", "Message-Id": "<20231028062315.1843075-3-chaoyong.he@corigine.com>", "X-Mailer": "git-send-email 2.39.1", "In-Reply-To": "<20231028062315.1843075-1-chaoyong.he@corigine.com>", "References": "<20231028062315.1843075-1-chaoyong.he@corigine.com>", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-ClientProxiedBy": "BY5PR04CA0003.namprd04.prod.outlook.com\n (2603:10b6:a03:1d0::13) To SJ0PR13MB5545.namprd13.prod.outlook.com\n (2603:10b6:a03:424::5)", "MIME-Version": "1.0", "X-MS-PublicTrafficType": "Email", "X-MS-TrafficTypeDiagnostic": "SJ0PR13MB5545:EE_|PH7PR13MB6268:EE_", "X-MS-Office365-Filtering-Correlation-Id": "a01ef9e1-99c8-42a2-4044-08dbd77e6eb9", "X-MS-Exchange-SenderADCheck": "1", "X-MS-Exchange-AntiSpam-Relay": "0", "X-Microsoft-Antispam": "BCL:0;", "X-Microsoft-Antispam-Message-Info": "\n 3d4z2nVbbtJDy0Cg+ytJJoRlEj5q+2UwlALsJimIZ2tNLOq7TUoJ1LHY1Dcxas04fnp20V29bd+tidRr+VcyycpJ5UW1Y/MbBeagGZb6j2eFqJgp0tevlUyvvFxDqsj3D/LBPuHLkgUdzVd7BPkI2RRvFBzdqghj88wF+6FigZcEPH8F+y8VslugKn9n/7e5NliPu9qC1aY5PugWrQm73xTeflMzzHBuIlXigAXjWWzcjGro/rnyeG7eE/t6z/gDcjCe633VOPkDVShrhXgmcGXhJY10pjf+9CrjaINkJjfZHm6QGcppLclZ2P2xNkeKDelmPFFPSz3awDLJA8nOipmL4NzSutrmhqxQqfsIPvjl7juYJM8f9l4sbgZJjskSTv+xbximVPb88gDRW0//tXJT+QO9hL0R1UWBYknrXJPz0HLZ5jFYiASFFbwPo4pdQNtgk7w75T8qymdcJDuPPKAW7nv/B7fpc5VbbDf/VpvTx9qHd/Ukj6j8C1yHYxTcFd9z9SOO7n7qfAXW+TuCnjBD0nttpkIxZqDuWwoG2T7A0nNf8/OTkuaimfViFpYEECzNNGdBBxU4Mccjfpqx5527MNhtc6ZjyNj4xmANPwEgv8KmMJoM/2U4Pb2v4yt2GOFqJwm0ZrO57zBQn3uJwRcFsNzIj6gKuD2d+gnmWz0=", "X-Forefront-Antispam-Report": "CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;\n IPV:NLI; SFV:NSPM; H:SJ0PR13MB5545.namprd13.prod.outlook.com; PTR:; CAT:NONE;\n SFS:(13230031)(396003)(39830400003)(366004)(346002)(376002)(136003)(230922051799003)(186009)(1800799009)(451199024)(64100799003)(2906002)(38100700002)(83380400001)(1076003)(107886003)(5660300002)(2616005)(86362001)(6512007)(41300700001)(44832011)(36756003)(38350700005)(66476007)(316002)(6916009)(66946007)(54906003)(66556008)(52116002)(6666004)(6506007)(6486002)(8676002)(26005)(478600001)(450100002)(4326008)(8936002);\n DIR:OUT; SFP:1102;", "X-MS-Exchange-AntiSpam-MessageData-ChunkCount": "1", "X-MS-Exchange-AntiSpam-MessageData-0": "\n W/6yFvVTm0mo9Gb7G1kirSP5OKcmPwQT6PxWpJ/dLM0ts46BzIdPHDPMi0eL6xigBVj6QK3BxOgsRlCDfpn3ObzQStQpG2yoR4jBgEwkV3Ae1U8xpQNgFhBedgMSYa5IlsgI/5XZyLnuq75psPS4OfK8WcH9Kbg7f/ceC3Fj+cP9M7QMQdcYDBfXRJrJwnhfEnOsKjFjJbeS3NgkanXJESg7aIFB1N0TvzTKX0TtGpZMXB7yRR2G9tssLlHhIBk4TcA7bJ/2ljD9jSEvwZA1DmX2GKGIRH3e8usaHrKOL4pIPdqZXKSrlq2EbzQwQBghbuKfuWB1GJ4yadQVTUG0WZtLlcLrlHbpqbYuliHcP1ggFY3OHrS/l9cYjAqu67MAIzCqZSIkr9yVfTeSuAGwYl4VbgRhNEHB9VSh7EzwdFNHjfA76tTY9d6Kec/TUZy2wEqIId9LrdtAtB1uswWw0rFnahZoLN1rMd3yTdZlBVN9UEixryHuow0zD+iExVAETJU5+CZh90/oLuQ4Cl8/eH809o95r4mqgDABgiMiey0D0zkEYHLhAyUMFf2MrwbvVOxoYrbWG2HekZgks7lbaf+Aemlel6a/4VkIptgFnYEtJQCAN/7Zi2BuA2Twt96mBJAuzYmpzEtT0fuzRmPHkLSIkjNG3SYA4xT4aY4rkzeZuRLxdROksdZOOt4ilTFOmhsS4n/fK3LrSDVrhemSKmlxPoIuEDk4YRSuuA+hDzCivh3ZDWKNy7xaWNk62s/xKxn46GcUtAbA+ZNioPe8t09zKtg4x6jdk+bcEawRxJZ0bG2eOVVntn6YMk8GGzVWV0NvAxPLW1tHORyUBMRAZKCuvrThgNPAvS5w/h5MYHAirt9uEzt5Stu1SsjgZXxJC7fLiOrMq2RQSODBrA0+Ix2MEq1dDWkYaIKwjf5dcgWqUUd690iOo6V+XQ5pSbyL7WJIT7cmQNOc1xH28MzyhJZRyDSziEOUZjgjc5H7KC967uj+1pcsM9XuqrFJfASVQOYwf9akS0DXv49ujiIS8A3Bh+91052S8b1yxfkzZp45uD0MTirmHCGFHFA/qxPGCgMKeqtb23PShvh7L5WhKA+OJPPT24hsbvUXFlbjgky5WJ2uThzxVphgw6uB3V2ytysvhn+xZhmzt04fPLkP+E0JkFb2872AH8p2NhRZo4oHW+KHOxS8uOkyOfQEfV1O0zY8/4Hj8yMlbLqhr/djjFWMGGayTc0gsHIH/LCqgvoNBWx71NLIoO8jwetGg6Kwsj7nqSsFiDl/Qp+7sQX6STTNFNkBcZybGkZBmGJ34kN6RJ8M2E8Fqb4TdxQLRZVwNGJxucQK8CYNK/cJAhzEJUT4SlxGtpQabuLaAsZtfRJo7EiFQ9pUkNrzUneqs7dT7/01DyiHsWYGN/sm/RnHtIRSRSYntyT+Gzjm/7+ETXpn0RiNER5FXq7964kjhGtz2IuzA9kx9s4egDSUxY6HLW1GzxnTqX575Sjqg3t2y9sbE9oaRj0w5pUWnTzZWr+V/1sYCjo8dGOQNdA4oeyyGKZfaJg81s1rPUNMNVa4qLIuq3VuHH5Jaqzrxznw10KvIgBewA9Vm4VnDENwz67ZYA==", "X-OriginatorOrg": "corigine.com", "X-MS-Exchange-CrossTenant-Network-Message-Id": "\n a01ef9e1-99c8-42a2-4044-08dbd77e6eb9", "X-MS-Exchange-CrossTenant-AuthSource": "SJ0PR13MB5545.namprd13.prod.outlook.com", "X-MS-Exchange-CrossTenant-AuthAs": "Internal", "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "28 Oct 2023 06:23:42.9377 (UTC)", "X-MS-Exchange-CrossTenant-FromEntityHeader": "Hosted", "X-MS-Exchange-CrossTenant-Id": "fe128f2c-073b-4c20-818e-7246a585940c", "X-MS-Exchange-CrossTenant-MailboxType": "HOSTED", "X-MS-Exchange-CrossTenant-UserPrincipalName": "\n iHw0mpyRp29caZHMbgS5c3gn/gxjid5YyBB+EWGvml0452XczAIxg34DoK9TL6v3DLJhEyIxkzmpyBOHcls4v7vi8Z9CBxGVHguuGX5wD3c=", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "PH7PR13MB6268", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "There exists exit point between the reconfigure logic and the stroe\nlogic of the VF initialization, this may lead one situation that value\nin the config bar is not same with the value stored in the data\nstructure.\n\nFix this by move up the store statement.\n\nFixes: 7f8e73201dae (\"net/nfp: move VF functions into its own file\")\nCc: stable@dpdk.org\n\nSigned-off-by: Chaoyong He <chaoyong.he@corigine.com>\nReviewed-by: Long Wu <long.wu@corigine.com>\nReviewed-by: Peng Zhang <peng.zhang@corigine.com>\n---\n drivers/net/nfp/nfp_ethdev_vf.c | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)", "diff": "diff --git a/drivers/net/nfp/nfp_ethdev_vf.c b/drivers/net/nfp/nfp_ethdev_vf.c\nindex b9cfb48021..2d08a07913 100644\n--- a/drivers/net/nfp/nfp_ethdev_vf.c\n+++ b/drivers/net/nfp/nfp_ethdev_vf.c\n@@ -91,6 +91,8 @@ nfp_netvf_start(struct rte_eth_dev *dev)\n \tif (nfp_reconfig(hw, new_ctrl, update) != 0)\n \t\treturn -EIO;\n \n+\thw->ctrl = new_ctrl;\n+\n \t/*\n \t * Allocating rte mbufs for configured rx queues.\n \t * This requires queues being enabled before.\n@@ -100,8 +102,6 @@ nfp_netvf_start(struct rte_eth_dev *dev)\n \t\tgoto error;\n \t}\n \n-\thw->ctrl = new_ctrl;\n-\n \tfor (i = 0; i < dev->data->nb_rx_queues; i++)\n \t\tdev->data->rx_queue_state[i] = RTE_ETH_QUEUE_STATE_STARTED;\n \tfor (i = 0; i < dev->data->nb_tx_queues; i++)\n", "prefixes": [ "2/3" ] }