Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/133551/?format=api
{ "id": 133551, "url": "http://patches.dpdk.org/api/patches/133551/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20231028062315.1843075-2-chaoyong.he@corigine.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20231028062315.1843075-2-chaoyong.he@corigine.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20231028062315.1843075-2-chaoyong.he@corigine.com", "date": "2023-10-28T06:23:13", "name": "[1/3] net/nfp: fix the reconfigure logic in PF initialization", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "e926976494b24c09d873a3ebfeab0d5f8e8b8550", "submitter": { "id": 2554, "url": "http://patches.dpdk.org/api/people/2554/?format=api", "name": "Chaoyong He", "email": "chaoyong.he@corigine.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20231028062315.1843075-2-chaoyong.he@corigine.com/mbox/", "series": [ { "id": 30038, "url": "http://patches.dpdk.org/api/series/30038/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=30038", "date": "2023-10-28T06:23:12", "name": "Fix some reconfigure problem", "version": 1, "mbox": "http://patches.dpdk.org/series/30038/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/133551/comments/", "check": "warning", "checks": "http://patches.dpdk.org/api/patches/133551/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 0361943220;\n\tSat, 28 Oct 2023 08:23:46 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id DE397402D2;\n\tSat, 28 Oct 2023 08:23:43 +0200 (CEST)", "from NAM11-DM6-obe.outbound.protection.outlook.com\n (mail-dm6nam11on2129.outbound.protection.outlook.com [40.107.223.129])\n by mails.dpdk.org (Postfix) with ESMTP id 3E75D4029F;\n Sat, 28 Oct 2023 08:23:42 +0200 (CEST)", "from SJ0PR13MB5545.namprd13.prod.outlook.com (2603:10b6:a03:424::5)\n by PH7PR13MB6268.namprd13.prod.outlook.com (2603:10b6:510:24f::16)\n with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6933.22; Sat, 28 Oct\n 2023 06:23:40 +0000", "from SJ0PR13MB5545.namprd13.prod.outlook.com\n ([fe80::45b3:d83c:cff2:4a1b]) by SJ0PR13MB5545.namprd13.prod.outlook.com\n ([fe80::45b3:d83c:cff2:4a1b%6]) with mapi id 15.20.6933.022; Sat, 28 Oct 2023\n 06:23:40 +0000" ], "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;\n b=i9XhpWLzrGx1qDrbzdZxCu6SBeo5k9HS6NsqFHv+HH/oTUbxi6m5iTRLmYLRgPofX21rkY1IYfist3EuZMRGBpINoeIPjBY/F6RjqTH9dYcDNMVuwWpZDeEwYNX5yoN53j5Aw90oxouY20jJgQDViYph9i6cHMoyROfRfRZ9WcDT/WVrdtGWfuLuspVj8h9GWZFdCz94dUy/pWTjSloNdg/Gp01n2ntTK8nO9KXO3bMputYpYuGKtV+isD8EFhJVG/GFMYbMX0u7PTxxa607b4KgpKUC2aEOThZZX/W3+xCm7UYFuUAuj1rXHhNM9QxDOMcsuV4ev7TpEA6iILxz4Q==", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector9901;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=uhl5Eg0enzDYURVvE5BtOza+5swxNwAyx25FzC+oYSw=;\n b=iaCse512314x66OVpPI+7XOVNFHOFIjhYCYzqWod4uNpYdjui4OG6TdmZlzS8YcH5ax79f1qgSmPxxPgvTInXSCQmrZFTK+p2PseyDZvtybRK13aiQ/0I2oCLdSI3z2gFHE7iKZlluvOjGm7omgnUUaYQvAVLi6L31UdphCNKh/8jnInIG0SNVAaJs6p5qFfPgqPJVhOadIsA09mbfYmsOCrT37zjkMd/lr8RPDhJRCtCSy76JkHTQcIQgL+feRhPa2yGtnwdraqVlyyQiJzER5DXRNSHet4bmMvZ40VVTMEPLeB/GtEAijiHY65c/t0ZTzld3MYbFRibT8fAC39Bw==", "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass\n smtp.mailfrom=corigine.com; dmarc=pass action=none header.from=corigine.com;\n dkim=pass header.d=corigine.com; arc=none", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=corigine.onmicrosoft.com; s=selector2-corigine-onmicrosoft-com;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=uhl5Eg0enzDYURVvE5BtOza+5swxNwAyx25FzC+oYSw=;\n b=JhN+gr+zqWogBs/UzzkX1YV2TZb4kKhiMpEQBtTmkS7XvKjb3D795iL37E394BjXeuTgyE9DlU6UAt51MQv3BkrrqW5MWj96oVcTu5vzAPVFOPVvVtUGzCC+Oby51jnvTEynrRTxs+N012fqvSuNEatob7+BEFg8AMbCt7tcpoY=", "Authentication-Results": "dkim=none (message not signed)\n header.d=none;dmarc=none action=none header.from=corigine.com;", "From": "Chaoyong He <chaoyong.he@corigine.com>", "To": "dev@dpdk.org", "Cc": "oss-drivers@corigine.com, Chaoyong He <chaoyong.he@corigine.com>,\n stable@dpdk.org, Long Wu <long.wu@corigine.com>,\n Peng Zhang <peng.zhang@corigine.com>", "Subject": "[PATCH 1/3] net/nfp: fix the reconfigure logic in PF initialization", "Date": "Sat, 28 Oct 2023 14:23:13 +0800", "Message-Id": "<20231028062315.1843075-2-chaoyong.he@corigine.com>", "X-Mailer": "git-send-email 2.39.1", "In-Reply-To": "<20231028062315.1843075-1-chaoyong.he@corigine.com>", "References": "<20231028062315.1843075-1-chaoyong.he@corigine.com>", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-ClientProxiedBy": "BY5PR04CA0003.namprd04.prod.outlook.com\n (2603:10b6:a03:1d0::13) To SJ0PR13MB5545.namprd13.prod.outlook.com\n (2603:10b6:a03:424::5)", "MIME-Version": "1.0", "X-MS-PublicTrafficType": "Email", "X-MS-TrafficTypeDiagnostic": "SJ0PR13MB5545:EE_|PH7PR13MB6268:EE_", "X-MS-Office365-Filtering-Correlation-Id": "a4403f8f-dc0b-43fd-6080-08dbd77e6d77", "X-MS-Exchange-SenderADCheck": "1", "X-MS-Exchange-AntiSpam-Relay": "0", "X-Microsoft-Antispam": "BCL:0;", "X-Microsoft-Antispam-Message-Info": "\n UtMs9z/hbaQi58P/i85opEw2KKpE15qDfugtDUnWlg8CBuRxXeJgRYYJMxMBq185bpcCgogOxzVK3aoIKyp7m/xqxFk8MIcL9y/lTnkXlwGlTs3syNXjYzcCVEuosdKF6uSrsled0XfjQQDkZoHDKtwI+NttB8D9ZbnCewibwuz234LfCQit6Gw/QlBg8VfCSW9myOlG46+0x9QVFQ5MIBQbc9Vk066+C6FP739LXh+TJRwws21JB/ghJDf2Uork/HXpTb764NAzDLZiuNiqi70rSl2IDOAnNRv9AdqbjRwBuGhNwuNsQfpVoiWV21oe3ctjhGvt81opDhODaNR9Rc/fgl5HEgB803cup+iSphz5kTrxjjDKys7XdM/p1erc1/hgb2g0203N2obzGNabaeZfVEzCgtvhwH4CXyJH+67g4axrm0HtCIGGpfyIGJXvFnv0EkHZJPai/9KpKY4dRlcDwjBvO07BHOUkiFkDBPJBVXOfVaVIS01szp0ISS+frFxhDRrXPVKE7uA/FzNBXEPNfEPkg9SZ8ID6ti7XQtOhFXQ5QJLd+aZZUGa5k2uopCb3bzbd8E92PBL94htUq1luyVmJeisDK1VJcf6DJaWH4IrxJ6SdIlV2Y2iX+hCkKNygyE7ZgrE/z/Khc7bPQYZusdDyYVQoUGHCAvuC2jY=", "X-Forefront-Antispam-Report": "CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;\n IPV:NLI; SFV:NSPM; H:SJ0PR13MB5545.namprd13.prod.outlook.com; PTR:; CAT:NONE;\n SFS:(13230031)(396003)(39830400003)(366004)(346002)(376002)(136003)(230922051799003)(186009)(1800799009)(451199024)(64100799003)(2906002)(38100700002)(83380400001)(1076003)(107886003)(5660300002)(2616005)(86362001)(6512007)(41300700001)(44832011)(36756003)(38350700005)(66476007)(316002)(6916009)(66946007)(54906003)(66556008)(52116002)(6666004)(6506007)(6486002)(8676002)(26005)(478600001)(450100002)(4326008)(8936002);\n DIR:OUT; SFP:1102;", "X-MS-Exchange-AntiSpam-MessageData-ChunkCount": "1", "X-MS-Exchange-AntiSpam-MessageData-0": "\n /8KXS3xI1wJ/sWjImSKxPQoA3j9AO6+D+Kh5bJSpWsLsAIosnHjSHSmOa2NEesS8XAfI0+OsBrVlAPCg/Ucn9zQqWwEAwVQ8vrFvEPtuVmLGXJyunyy2jszlzl8m+S/VpwHzYK5fRicLYAL44clHfVKHCYn9iQXYACBe+xgzCm3mVIGK5tICOoX4x4X4oNNQo3OMpVlV0abgDV9CVYphXyDQuPmm1EJc9SzW/To4Fd3KMEIh6n+eEca58RLsKk5ah9Wiaq1DVYpoB1pDxdwoJ001UB/JA8+i9a+O7+qfng9deyt2CkBJK+QdAVTcbqh4475vyz4bF1xfizVdEGJB4nXt+P2gRHylORZShqChKAris3IPYE65IUPp+d8lpwXH0vWHAaHnfjPkgjwGRsGrUTBjP5Rtx2XsnAYyAd/PlMic5Ak8TXKkK1pokg3LU/AKOQyo3BYLaUZOyjy03LXTvSsv1/LkVYgfh4VAkyTq0ZbPu7XZv87hIj3E9WI+BFC3NdTM1s/zPJvZwlLGIA6K9hcEmd10m9pV5LPweFaNlQJV8fPXVsBEaEuVzweQUWki3K9d5nS3rJaoVS07w8+ZvX3+hMo8cnnM3O5P48MBxrLLWE6kVPGqiIyUXP4LeKHedNOIoGNxmve9jwbP9MZCzs0XX6tUOGaTC4i4c8FKEzgyVQhFPE5hCrXOUmyBqHfMinPulZvscqYnzL+4avJqxqaCRsDEjUg5pFsT49ObtteZhrZANC5KHztMjEQZ7Oo+o2ILiMvne98YVdQKsYCUCnvb/RtBFq6bM+/UQM8SApY22PD9ISIT/9uIfYAPfmR+XdmVfPoq0n2nROpPjohq+uBG7ZUHmcsCczw7Dz225KA7889P/sh41GBLFewoiWfjbv3A4SPKHkL107XzMrJLlBP0CUzO17KU2qY5TRT1q+KTnZUreezYgPZmpv4LTXdAQcAgTr+JGEt4FkILr4E4zjzqOwcr6JJ6gI1icPzJgfrgFzVbEVvbsYi1uTmXI2amdHZDi+wO7fGiX0AxALjHHiqgo1qOPmhmiExTNEBq0QjNvm7YBzoQVLt8Jz3tXago5hprTT5DlMoZFewmO2nHLU7/QdOjV6k03r0C7GbzJDGBcenG0N03TOo353WXdg9yLi7WIfvShGE9JqhgxxRReyBkVn++Uri4Sa0NpsYyidJ0YqToEf+4eYQvakFISA+LuUsXHDn997eJQFDamrhcVrRclqkvpw9t3rawc9W9xyhMa4YIDa7/3PJHtbH4L0AQdhDi6jko52rjvvdwQnTL23wX08x9PNn236ryHVOLBsCIVmDn6dXH3WksvbRrUZ9kWs/QM3yYrI5RyguLducFarNGoHf6/xMan5GrRVJhMCGOF5jaDhRrrfKZCeIIQaFtIFZfBhZj2YBRU5D/GI+A1iSdtmu6WbB1/vzMTboAwHTv/ftqm20dnmCfyUiD5I+hS24+VBDPuyorLYxBERKL/KIc+h83GfC9Eo8JJ/Kzwse3oz3I0w+tmZV2ADcbqmw1iTtWIJGoH/7L8b0u47xJRPjF8/mL4OMSJTZ16IM1AjAmXnZxgoG25vKv3XXm/4JI+qtWNyoDzQ+GhjeIqk6lQQ==", "X-OriginatorOrg": "corigine.com", "X-MS-Exchange-CrossTenant-Network-Message-Id": "\n a4403f8f-dc0b-43fd-6080-08dbd77e6d77", "X-MS-Exchange-CrossTenant-AuthSource": "SJ0PR13MB5545.namprd13.prod.outlook.com", "X-MS-Exchange-CrossTenant-AuthAs": "Internal", "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "28 Oct 2023 06:23:40.8207 (UTC)", "X-MS-Exchange-CrossTenant-FromEntityHeader": "Hosted", "X-MS-Exchange-CrossTenant-Id": "fe128f2c-073b-4c20-818e-7246a585940c", "X-MS-Exchange-CrossTenant-MailboxType": "HOSTED", "X-MS-Exchange-CrossTenant-UserPrincipalName": "\n DzDPjt6MpZWinWGgoyYTb7gOzUL4BRpUzMHmEaKnQBO5Fi7IPEdFpIyhtEfl1ylW5RuHuvu+NbdYmoNdd5tkRoZGTC1HDKW2et8rNA2POqE=", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "PH7PR13MB6268", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "There exists exit point between the reconfigure logic and the stroe\nlogic of the PF initialization, this may lead one situation that value\nin the config bar is not same with the value stored in the data\nstructure.\n\nFix this by move up the store statement.\n\nFixes: b812daadad0d (\"nfp: add Rx and Tx\")\nCc: stable@dpdk.org\n\nSigned-off-by: Chaoyong He <chaoyong.he@corigine.com>\nReviewed-by: Long Wu <long.wu@corigine.com>\nReviewed-by: Peng Zhang <peng.zhang@corigine.com>\n---\n drivers/net/nfp/nfp_ethdev.c | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)", "diff": "diff --git a/drivers/net/nfp/nfp_ethdev.c b/drivers/net/nfp/nfp_ethdev.c\nindex 76317925ec..0a0e3d6375 100644\n--- a/drivers/net/nfp/nfp_ethdev.c\n+++ b/drivers/net/nfp/nfp_ethdev.c\n@@ -141,6 +141,8 @@ nfp_net_start(struct rte_eth_dev *dev)\n \tif (nfp_reconfig(hw, new_ctrl, update) != 0)\n \t\treturn -EIO;\n \n+\thw->ctrl = new_ctrl;\n+\n \t/* Enable packet type offload by extend ctrl word1. */\n \tcap_extend = hw->cap_ext;\n \tif ((cap_extend & NFP_NET_CFG_CTRL_PKT_TYPE) != 0)\n@@ -171,8 +173,6 @@ nfp_net_start(struct rte_eth_dev *dev)\n \telse\n \t\tnfp_eth_set_configured(dev->process_private, net_hw->nfp_idx, 1);\n \n-\thw->ctrl = new_ctrl;\n-\n \tfor (i = 0; i < dev->data->nb_rx_queues; i++)\n \t\tdev->data->rx_queue_state[i] = RTE_ETH_QUEUE_STATE_STARTED;\n \tfor (i = 0; i < dev->data->nb_tx_queues; i++)\n", "prefixes": [ "1/3" ] }