Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/133523/?format=api
{ "id": 133523, "url": "http://patches.dpdk.org/api/patches/133523/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20231027225728.563914-6-nicolas.chautru@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20231027225728.563914-6-nicolas.chautru@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20231027225728.563914-6-nicolas.chautru@intel.com", "date": "2023-10-27T22:57:23", "name": "[v2,05/10] test/bbdev: improve test log messages", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "c107933bd11c2ef04649a7a11f55457a6ae0dc2d", "submitter": { "id": 1314, "url": "http://patches.dpdk.org/api/people/1314/?format=api", "name": "Chautru, Nicolas", "email": "nicolas.chautru@intel.com" }, "delegate": { "id": 2642, "url": "http://patches.dpdk.org/api/users/2642/?format=api", "username": "mcoquelin", "first_name": "Maxime", "last_name": "Coquelin", "email": "maxime.coquelin@redhat.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20231027225728.563914-6-nicolas.chautru@intel.com/mbox/", "series": [ { "id": 30034, "url": "http://patches.dpdk.org/api/series/30034/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=30034", "date": "2023-10-27T22:57:18", "name": "test-bbdev changes for 23.11", "version": 2, "mbox": "http://patches.dpdk.org/series/30034/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/133523/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/133523/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 07EB84321A;\n\tSat, 28 Oct 2023 01:04:55 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id ECB2842DFF;\n\tSat, 28 Oct 2023 01:04:20 +0200 (CEST)", "from mgamail.intel.com (mgamail.intel.com [198.175.65.9])\n by mails.dpdk.org (Postfix) with ESMTP id 0C25F4068A;\n Sat, 28 Oct 2023 01:04:12 +0200 (CEST)", "from fmsmga008.fm.intel.com ([10.253.24.58])\n by orvoesa101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 27 Oct 2023 16:04:12 -0700", "from spr-npg-bds1-eec2.sn.intel.com (HELO spr-npg-bds1-eec2..)\n ([10.233.181.123])\n by fmsmga008.fm.intel.com with ESMTP; 27 Oct 2023 16:04:10 -0700" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1698447854; x=1729983854;\n h=from:to:cc:subject:date:message-id:in-reply-to:\n references:mime-version:content-transfer-encoding;\n bh=Kjk2ILwomXfJ1u+GslcAAxCvQVOVpkBgyDJBrv2IdYI=;\n b=LyPb1sf79sZQ4M7SCbMlpCWEA3vEy7VkhGfdzP8mRbmyxaWDkrGJfEmq\n gmIuogVu1iMpcemom9Bf01U3B7yyav68K23QkvNoOcovIrXS1Nc0YIDWr\n p2t5l+rl/LieJRr38qkEQY/Kz1wKE/Leqk1TBdQ/L4bvuNLUfa1N2rYQD\n PHVp1++h33yrd/lOd3Dquhslkx63EaqfUebBM0OxjLcwQfNILVlSk+LOT\n JpZm+apXwFDhSJQ2ZpewCG+PBMg2hVCU1E5Jb2n+7XR0h7JbypoK8NmO7\n BLxpEVpfEz84s0hzGvBLHE//AKJ3UM/ba5ICarvkNJH055jLR3xWToNLt w==;", "X-IronPort-AV": [ "E=McAfee;i=\"6600,9927,10876\"; a=\"6494081\"", "E=Sophos;i=\"6.03,257,1694761200\";\n d=\"scan'208\";a=\"6494081\"", "E=McAfee;i=\"6600,9927,10876\"; a=\"825496969\"", "E=Sophos;i=\"6.03,257,1694761200\"; d=\"scan'208\";a=\"825496969\"" ], "X-ExtLoop1": "1", "From": "Nicolas Chautru <nicolas.chautru@intel.com>", "To": "dev@dpdk.org,\n\tmaxime.coquelin@redhat.com", "Cc": "hemant.agrawal@nxp.com, david.marchand@redhat.com,\n hernan.vargas@intel.com,\n stable@dpdk.org", "Subject": "[PATCH v2 05/10] test/bbdev: improve test log messages", "Date": "Fri, 27 Oct 2023 22:57:23 +0000", "Message-Id": "<20231027225728.563914-6-nicolas.chautru@intel.com>", "X-Mailer": "git-send-email 2.34.1", "In-Reply-To": "<20231027225728.563914-1-nicolas.chautru@intel.com>", "References": "<20231027225728.563914-1-nicolas.chautru@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "From: Hernan Vargas <hernan.vargas@intel.com>\n\nAdd a print message for failure to retrieve stats on bbdev.\nAdd vector name in logs.\nRemove unnecessary prints.\nUpdate code comments and cosmetic changes.\nNo functional impact.\n\nSigned-off-by: Hernan Vargas <hernan.vargas@intel.com>\nReviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>\n---\n app/test-bbdev/main.c | 3 ++-\n app/test-bbdev/test_bbdev_perf.c | 26 ++++++++++++++------------\n 2 files changed, 16 insertions(+), 13 deletions(-)", "diff": "diff --git a/app/test-bbdev/main.c b/app/test-bbdev/main.c\nindex ec830eb32b..8f6852e2ef 100644\n--- a/app/test-bbdev/main.c\n+++ b/app/test-bbdev/main.c\n@@ -107,7 +107,8 @@ unit_test_suite_runner(struct unit_test_suite *suite)\n \tend = rte_rdtsc_precise();\n \n \tprintf(\" + ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ +\\n\");\n-\tprintf(\" + Test Suite Summary : %s\\n\", suite->suite_name);\n+\tprintf(\" + Test Suite Summary : %s - %s\\n\",\n+\t\t\tsuite->suite_name, get_vector_filename());\n \tprintf(\" + Tests Total : %2d\\n\", total);\n \tprintf(\" + Tests Skipped : %2d\\n\", skipped);\n \tprintf(\" + Tests Passed : %2d\\n\", succeeded);\ndiff --git a/app/test-bbdev/test_bbdev_perf.c b/app/test-bbdev/test_bbdev_perf.c\nindex 54cb2090f9..4f8e226e58 100644\n--- a/app/test-bbdev/test_bbdev_perf.c\n+++ b/app/test-bbdev/test_bbdev_perf.c\n@@ -721,9 +721,9 @@ add_bbdev_dev(uint8_t dev_id, struct rte_bbdev_info *info,\n \t\t\tconf.vf_dl_queues_number[i] = VF_DL_5G_QUEUE_VALUE;\n \t\t}\n \n-\t\t/* UL bandwidth. Needed for schedule algorithm */\n+\t\t/* UL bandwidth. Needed only for Vista Creek 5GNR schedule algorithm */\n \t\tconf.ul_bandwidth = UL_5G_BANDWIDTH;\n-\t\t/* DL bandwidth */\n+\t\t/* DL bandwidth. Needed only for Vista Creek 5GNR schedule algorithm */\n \t\tconf.dl_bandwidth = DL_5G_BANDWIDTH;\n \n \t\t/* UL & DL load Balance Factor to 64 */\n@@ -743,7 +743,7 @@ add_bbdev_dev(uint8_t dev_id, struct rte_bbdev_info *info,\n \t\tstruct rte_acc_conf conf;\n \t\tunsigned int i;\n \n-\t\tprintf(\"Configure ACC100/ACC101 FEC Driver %s with default values\\n\",\n+\t\tprintf(\"Configure ACC100 FEC device %s with default values\\n\",\n \t\t\t\tinfo->drv.driver_name);\n \n \t\t/* clear default configuration before initialization */\n@@ -1047,13 +1047,15 @@ ut_setup(void)\n static void\n ut_teardown(void)\n {\n-\tuint8_t i, dev_id;\n+\tuint8_t i, dev_id, ret;\n \tstruct rte_bbdev_stats stats;\n \n \tfor (i = 0; i < nb_active_devs; i++) {\n \t\tdev_id = active_devs[i].dev_id;\n \t\t/* read stats and print */\n-\t\trte_bbdev_stats_get(dev_id, &stats);\n+\t\tret = rte_bbdev_stats_get(dev_id, &stats);\n+\t\tif (ret != 0)\n+\t\t\tprintf(\"Failed to get stats on bbdev %u\\n\", dev_id);\n \t\t/* Stop the device */\n \t\trte_bbdev_stop(dev_id);\n \t}\n@@ -2227,9 +2229,11 @@ validate_op_harq_chain(struct rte_bbdev_op_data *op,\n \t\t\t\tif ((error > 8 && (abs_harq_origin <\n \t\t\t\t\t\t(llr_max - 16))) ||\n \t\t\t\t\t\t(error > 16)) {\n+\t\t\t\t\t/*\n \t\t\t\t\tprintf(\"HARQ mismatch %d: exp %d act %d => %d\\n\",\n \t\t\t\t\t\t\tj, harq_orig[j],\n \t\t\t\t\t\t\tharq_out[jj], error);\n+\t\t\t\t\t*/\n \t\t\t\t\tbyte_error++;\n \t\t\t\t\tcum_error += error;\n \t\t\t\t}\n@@ -5270,7 +5274,7 @@ offload_latency_test_fft(struct rte_mempool *mempool, struct test_buffers *bufs,\n \t\t\tburst_sz = num_to_process - dequeued;\n \n \t\tret = rte_bbdev_fft_op_alloc_bulk(mempool, ops_enq, burst_sz);\n-\t\tTEST_ASSERT_SUCCESS(ret, \"Allocation failed for %d ops\", burst_sz);\n+\t\tTEST_ASSERT_SUCCESS(ret, \"rte_bbdev_fft_op_alloc_bulk() failed\");\n \t\tif (test_vector.op_type != RTE_BBDEV_OP_NONE)\n \t\t\tcopy_reference_fft_op(ops_enq, burst_sz, dequeued,\n \t\t\t\t\tbufs->inputs,\n@@ -5352,7 +5356,7 @@ offload_latency_test_dec(struct rte_mempool *mempool, struct test_buffers *bufs,\n \t\t\tburst_sz = num_to_process - dequeued;\n \n \t\tret = rte_bbdev_dec_op_alloc_bulk(mempool, ops_enq, burst_sz);\n-\t\tTEST_ASSERT_SUCCESS(ret, \"Allocation failed for %d ops\", burst_sz);\n+\t\tTEST_ASSERT_SUCCESS(ret, \"rte_bbdev_dec_op_alloc_bulk() failed\");\n \t\tref_op->turbo_dec.iter_max = get_iter_max();\n \t\tif (test_vector.op_type != RTE_BBDEV_OP_NONE)\n \t\t\tcopy_reference_dec_op(ops_enq, burst_sz, dequeued,\n@@ -5439,7 +5443,7 @@ offload_latency_test_ldpc_dec(struct rte_mempool *mempool,\n \t\t\tburst_sz = num_to_process - dequeued;\n \n \t\tret = rte_bbdev_dec_op_alloc_bulk(mempool, ops_enq, burst_sz);\n-\t\tTEST_ASSERT_SUCCESS(ret, \"Allocation failed for %d ops\", burst_sz);\n+\t\tTEST_ASSERT_SUCCESS(ret, \"rte_bbdev_dec_op_alloc_bulk() failed\");\n \t\tref_op->ldpc_dec.iter_max = get_iter_max();\n \t\tif (test_vector.op_type != RTE_BBDEV_OP_NONE)\n \t\t\tcopy_reference_ldpc_dec_op(ops_enq, burst_sz, dequeued,\n@@ -5534,8 +5538,7 @@ offload_latency_test_enc(struct rte_mempool *mempool, struct test_buffers *bufs,\n \t\t\tburst_sz = num_to_process - dequeued;\n \n \t\tret = rte_bbdev_enc_op_alloc_bulk(mempool, ops_enq, burst_sz);\n-\t\tTEST_ASSERT_SUCCESS(ret,\n-\t\t\t\t\"rte_bbdev_enc_op_alloc_bulk() failed\");\n+\t\tTEST_ASSERT_SUCCESS(ret, \"rte_bbdev_enc_op_alloc_bulk() failed\");\n \t\tif (test_vector.op_type != RTE_BBDEV_OP_NONE)\n \t\t\tcopy_reference_enc_op(ops_enq, burst_sz, dequeued,\n \t\t\t\t\tbufs->inputs,\n@@ -5617,8 +5620,7 @@ offload_latency_test_ldpc_enc(struct rte_mempool *mempool,\n \t\t\tburst_sz = num_to_process - dequeued;\n \n \t\tret = rte_bbdev_enc_op_alloc_bulk(mempool, ops_enq, burst_sz);\n-\t\tTEST_ASSERT_SUCCESS(ret,\n-\t\t\t\t\"rte_bbdev_enc_op_alloc_bulk() failed\");\n+\t\tTEST_ASSERT_SUCCESS(ret, \"rte_bbdev_enc_op_alloc_bulk() failed\");\n \t\tif (test_vector.op_type != RTE_BBDEV_OP_NONE)\n \t\t\tcopy_reference_ldpc_enc_op(ops_enq, burst_sz, dequeued,\n \t\t\t\t\tbufs->inputs,\n", "prefixes": [ "v2", "05/10" ] }