Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/133518/?format=api
{ "id": 133518, "url": "http://patches.dpdk.org/api/patches/133518/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20231027225728.563914-2-nicolas.chautru@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20231027225728.563914-2-nicolas.chautru@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20231027225728.563914-2-nicolas.chautru@intel.com", "date": "2023-10-27T22:57:19", "name": "[v2,01/10] test/bbdev: fix python script subprocess", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "6c03f70b9f9b1af1fbced8190620b45614ab7c7b", "submitter": { "id": 1314, "url": "http://patches.dpdk.org/api/people/1314/?format=api", "name": "Chautru, Nicolas", "email": "nicolas.chautru@intel.com" }, "delegate": { "id": 2642, "url": "http://patches.dpdk.org/api/users/2642/?format=api", "username": "mcoquelin", "first_name": "Maxime", "last_name": "Coquelin", "email": "maxime.coquelin@redhat.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20231027225728.563914-2-nicolas.chautru@intel.com/mbox/", "series": [ { "id": 30034, "url": "http://patches.dpdk.org/api/series/30034/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=30034", "date": "2023-10-27T22:57:18", "name": "test-bbdev changes for 23.11", "version": 2, "mbox": "http://patches.dpdk.org/series/30034/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/133518/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/133518/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 7784A4321A;\n\tSat, 28 Oct 2023 01:04:19 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id B8ECF40F16;\n\tSat, 28 Oct 2023 01:04:13 +0200 (CEST)", "from mgamail.intel.com (mgamail.intel.com [198.175.65.9])\n by mails.dpdk.org (Postfix) with ESMTP id 4BBC6402C8;\n Sat, 28 Oct 2023 01:04:11 +0200 (CEST)", "from fmsmga008.fm.intel.com ([10.253.24.58])\n by orvoesa101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 27 Oct 2023 16:04:10 -0700", "from spr-npg-bds1-eec2.sn.intel.com (HELO spr-npg-bds1-eec2..)\n ([10.233.181.123])\n by fmsmga008.fm.intel.com with ESMTP; 27 Oct 2023 16:04:09 -0700" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1698447852; x=1729983852;\n h=from:to:cc:subject:date:message-id:in-reply-to:\n references:mime-version:content-transfer-encoding;\n bh=6jGiaPdwIjXHS6xPN6bnJYVw/SM5GND4ora6R1Ctafo=;\n b=QHrSnMacf5S61kZz9tsqx1kUrlYPnZihmFMxQGVVzsc2x75sXpj2FsJA\n LFvDlz8pQ5QuPxL8GWz+MVCS2g8XfrmdRJLfO9NtMNzYcEhBI/aTIdt1J\n wJIJyrFxRndhhQMhDWpqTZ89O5mqBjwBrkTaTijuau2LtSfC13oQpOaJG\n AK1EvyDKN5DoiK5iRUvqirlRWI+ZRWdmohXJKCn+//+CjR6qpW5fNBZgR\n pGsgazuQa3JPmRnDC3mxC9dzkKXIpBtuV2RX8zIvWyNBTOiqpIK0myILS\n M+YrkOCWxD/m9kvKbM4uajpZTH0C2PTJTej+vsiIwWcN5+KKY6O7k3ZRH A==;", "X-IronPort-AV": [ "E=McAfee;i=\"6600,9927,10876\"; a=\"6494066\"", "E=Sophos;i=\"6.03,257,1694761200\";\n d=\"scan'208\";a=\"6494066\"", "E=McAfee;i=\"6600,9927,10876\"; a=\"825496957\"", "E=Sophos;i=\"6.03,257,1694761200\"; d=\"scan'208\";a=\"825496957\"" ], "X-ExtLoop1": "1", "From": "Nicolas Chautru <nicolas.chautru@intel.com>", "To": "dev@dpdk.org,\n\tmaxime.coquelin@redhat.com", "Cc": "hemant.agrawal@nxp.com, david.marchand@redhat.com,\n hernan.vargas@intel.com,\n stable@dpdk.org", "Subject": "[PATCH v2 01/10] test/bbdev: fix python script subprocess", "Date": "Fri, 27 Oct 2023 22:57:19 +0000", "Message-Id": "<20231027225728.563914-2-nicolas.chautru@intel.com>", "X-Mailer": "git-send-email 2.34.1", "In-Reply-To": "<20231027225728.563914-1-nicolas.chautru@intel.com>", "References": "<20231027225728.563914-1-nicolas.chautru@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "From: Hernan Vargas <hernan.vargas@intel.com>\n\ntest-bbdev.py relying on non-recommended subprocess Popen.\nThis can lead to instabilities where the process cannot be stopped with a\nsig TERM.\nUse subprocess run with proper timeout argument.\n\nFixes: f714a18885a6 (\"app/testbbdev: add test application for bbdev\")\nCc: stable@dpdk.org\n\nSigned-off-by: Hernan Vargas <hernan.vargas@intel.com>\n---\n app/test-bbdev/test-bbdev.py | 29 +++++++++++++----------------\n 1 file changed, 13 insertions(+), 16 deletions(-)", "diff": "diff --git a/app/test-bbdev/test-bbdev.py b/app/test-bbdev/test-bbdev.py\nindex 291c80b0f5..02c678a360 100755\n--- a/app/test-bbdev/test-bbdev.py\n+++ b/app/test-bbdev/test-bbdev.py\n@@ -91,21 +91,18 @@ def kill(process):\n params_string = \" \".join(call_params)\n \n print(\"Executing: {}\".format(params_string))\n- app_proc = subprocess.Popen(call_params)\n- if args.timeout > 0:\n- timer = Timer(args.timeout, kill, [app_proc])\n- timer.start()\n-\n try:\n- app_proc.communicate()\n- except:\n- print(\"Error: failed to execute: {}\".format(params_string))\n- finally:\n- timer.cancel()\n-\n- if app_proc.returncode != 0:\n- exit_status = 1\n- print(\"ERROR TestCase failed. Failed test for vector {}. Return code: {}\".format(\n- vector, app_proc.returncode))\n-\n+ output = subprocess.run(call_params, timeout=args.timeout, universal_newlines=True)\n+ except subprocess.TimeoutExpired as e:\n+ print(\"Starting Test Suite : BBdev TimeOut Tests\")\n+ print(\"== test: timeout\")\n+ print(\"TestCase [ 0] : timeout passed\")\n+ print(\" + Tests Failed : 1\")\n+ print(\"Unexpected Error\")\n+ if output.returncode < 0:\n+ print(\"Starting Test Suite : BBdev Exception Tests\")\n+ print(\"== test: exception\")\n+ print(\"TestCase [ 0] : exception passed\")\n+ print(\" + Tests Failed : 1\")\n+ print(\"Unexpected Error\")\n sys.exit(exit_status)\n", "prefixes": [ "v2", "01/10" ] }