Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/133485/?format=api
{ "id": 133485, "url": "http://patches.dpdk.org/api/patches/133485/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20231027092836.445224-2-haijie1@huawei.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20231027092836.445224-2-haijie1@huawei.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20231027092836.445224-2-haijie1@huawei.com", "date": "2023-10-27T09:28:28", "name": "[1/9] ethdev: overwrite some comment related to RSS", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "60f3c0d54fd7755a74237cc12a661107845dfde6", "submitter": { "id": 2935, "url": "http://patches.dpdk.org/api/people/2935/?format=api", "name": "Jie Hai", "email": "haijie1@huawei.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20231027092836.445224-2-haijie1@huawei.com/mbox/", "series": [ { "id": 30023, "url": "http://patches.dpdk.org/api/series/30023/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=30023", "date": "2023-10-27T09:28:29", "name": "support setting and querying RSS algorithms", "version": 1, "mbox": "http://patches.dpdk.org/series/30023/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/133485/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/133485/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 1EA4843214;\n\tFri, 27 Oct 2023 11:32:50 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 93FC842D66;\n\tFri, 27 Oct 2023 11:32:41 +0200 (CEST)", "from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187])\n by mails.dpdk.org (Postfix) with ESMTP id EE00A402DF\n for <dev@dpdk.org>; Fri, 27 Oct 2023 11:32:32 +0200 (CEST)", "from kwepemi500020.china.huawei.com (unknown [172.30.72.53])\n by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4SGy4S0wLBzpWWK;\n Fri, 27 Oct 2023 17:27:36 +0800 (CST)", "from localhost.localdomain (10.67.165.2) by\n kwepemi500020.china.huawei.com (7.221.188.8) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id\n 15.1.2507.31; Fri, 27 Oct 2023 17:32:30 +0800" ], "From": "Jie Hai <haijie1@huawei.com>", "To": "<dev@dpdk.org>, Thomas Monjalon <thomas@monjalon.net>, Ferruh Yigit\n <ferruh.yigit@amd.com>, Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>, Ori\n Kam <orika@nvidia.com>", "CC": "<lihuisong@huawei.com>, <fengchengwen@huawei.com>,\n <liudongdong3@huawei.com>", "Subject": "[PATCH 1/9] ethdev: overwrite some comment related to RSS", "Date": "Fri, 27 Oct 2023 17:28:28 +0800", "Message-ID": "<20231027092836.445224-2-haijie1@huawei.com>", "X-Mailer": "git-send-email 2.30.0", "In-Reply-To": "<20231027092836.445224-1-haijie1@huawei.com>", "References": "<20231011092805.693171-1-haijie1@huawei.com>\n <20231027092836.445224-1-haijie1@huawei.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Originating-IP": "[10.67.165.2]", "X-ClientProxiedBy": "dggems705-chm.china.huawei.com (10.3.19.182) To\n kwepemi500020.china.huawei.com (7.221.188.8)", "X-CFilter-Loop": "Reflected", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "1. overwrite the comments of fields of 'rte_eth_rss_conf'.\n2. Add comments for RTE_ETH_HASH_FUNCTION_DEFAULT.\n\nSigned-off-by: Jie Hai <haijie1@huawei.com>\n---\n lib/ethdev/rte_ethdev.h | 33 ++++++++++++++++++---------------\n lib/ethdev/rte_flow.h | 1 +\n 2 files changed, 19 insertions(+), 15 deletions(-)", "diff": "diff --git a/lib/ethdev/rte_ethdev.h b/lib/ethdev/rte_ethdev.h\nindex 2fd3cd808dbf..37fd5afef48a 100644\n--- a/lib/ethdev/rte_ethdev.h\n+++ b/lib/ethdev/rte_ethdev.h\n@@ -448,24 +448,27 @@ struct rte_vlan_filter_conf {\n /**\n * A structure used to configure the Receive Side Scaling (RSS) feature\n * of an Ethernet port.\n- * If not NULL, the *rss_key* pointer of the *rss_conf* structure points\n- * to an array holding the RSS key to use for hashing specific header\n- * fields of received packets. The length of this array should be indicated\n- * by *rss_key_len* below. Otherwise, a default random hash key is used by\n- * the device driver.\n- *\n- * The *rss_key_len* field of the *rss_conf* structure indicates the length\n- * in bytes of the array pointed by *rss_key*. To be compatible, this length\n- * will be checked in i40e only. Others assume 40 bytes to be used as before.\n- *\n- * The *rss_hf* field of the *rss_conf* structure indicates the different\n- * types of IPv4/IPv6 packets to which the RSS hashing must be applied.\n- * Supplying an *rss_hf* equal to zero disables the RSS feature.\n */\n struct rte_eth_rss_conf {\n-\tuint8_t *rss_key; /**< If not NULL, 40-byte hash key. */\n+\t/**\n+\t * In rte_eth_dev_rss_hash_conf_get(), the *rss_key_len* should be\n+\t * greater than or equal to the hash_key_size which get from\n+\t * rte_eth_dev_info_get() API. And the *rss_key* should contain at least\n+\t * *rss_key_len* bytes. If not meet these requirements, the query result\n+\t * is unreliable even the operation returns success.\n+\t *\n+\t * In rte_eth_dev_rss_hash_update() or rte_eth_dev_configure(), the\n+\t * *rss_key_len* indicates the length of the *rss_key* in bytes of\n+\t * the array pointed by *rss_key*. Drivers are free to ignore the\n+\t * *rss_key_len* and assume key length is 40 bytes.\n+\t */\n+\tuint8_t *rss_key;\n \tuint8_t rss_key_len; /**< hash key length in bytes. */\n-\tuint64_t rss_hf; /**< Hash functions to apply - see below. */\n+\t/**\n+\t * Indicates the type of packets or the specific part of packets to\n+\t * which RSS hashing is to be applied.\n+\t */\n+\tuint64_t rss_hf;\n };\n \n /*\ndiff --git a/lib/ethdev/rte_flow.h b/lib/ethdev/rte_flow.h\nindex edefa34c10da..25f1dffd1f30 100644\n--- a/lib/ethdev/rte_flow.h\n+++ b/lib/ethdev/rte_flow.h\n@@ -3226,6 +3226,7 @@ struct rte_flow_query_count {\n * Hash function types.\n */\n enum rte_eth_hash_function {\n+\t/** DEFAULT means driver decides which hash algorithm to pick. */\n \tRTE_ETH_HASH_FUNCTION_DEFAULT = 0,\n \tRTE_ETH_HASH_FUNCTION_TOEPLITZ, /**< Toeplitz */\n \tRTE_ETH_HASH_FUNCTION_SIMPLE_XOR, /**< Simple XOR */\n", "prefixes": [ "1/9" ] }