Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/133475/?format=api
{ "id": 133475, "url": "http://patches.dpdk.org/api/patches/133475/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20231027060947.3183983-6-haijie1@huawei.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20231027060947.3183983-6-haijie1@huawei.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20231027060947.3183983-6-haijie1@huawei.com", "date": "2023-10-27T06:09:43", "name": "[5/8] net/hns3: remove reset log in secondary", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "a9adfb3a64f6223dc623e01cb8c1fcc624f4080b", "submitter": { "id": 2935, "url": "http://patches.dpdk.org/api/people/2935/?format=api", "name": "Jie Hai", "email": "haijie1@huawei.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20231027060947.3183983-6-haijie1@huawei.com/mbox/", "series": [ { "id": 30018, "url": "http://patches.dpdk.org/api/series/30018/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=30018", "date": "2023-10-27T06:09:41", "name": "net/hns3: add some bugfix for hns3", "version": 1, "mbox": "http://patches.dpdk.org/series/30018/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/133475/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/133475/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id E7A5E43212;\n\tFri, 27 Oct 2023 08:14:27 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 5F41B42670;\n\tFri, 27 Oct 2023 08:13:59 +0200 (CEST)", "from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188])\n by mails.dpdk.org (Postfix) with ESMTP id BB0664029A\n for <dev@dpdk.org>; Fri, 27 Oct 2023 08:13:52 +0200 (CEST)", "from kwepemi500020.china.huawei.com (unknown [172.30.72.55])\n by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4SGshC47LJzPngv\n for <dev@dpdk.org>; Fri, 27 Oct 2023 14:09:47 +0800 (CST)", "from localhost.localdomain (10.67.165.2) by\n kwepemi500020.china.huawei.com (7.221.188.8) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id\n 15.1.2507.31; Fri, 27 Oct 2023 14:13:50 +0800" ], "From": "Jie Hai <haijie1@huawei.com>", "To": "<dev@dpdk.org>, Yisen Zhuang <yisen.zhuang@huawei.com>, Anatoly Burakov\n <anatoly.burakov@intel.com>, Chengwen Feng <fengchengwen@huawei.com>,\n Dongdong Liu <liudongdong3@huawei.com>", "CC": "<lihuisong@huawei.com>, <huangdengdui@huawei.com>", "Subject": "[PATCH 5/8] net/hns3: remove reset log in secondary", "Date": "Fri, 27 Oct 2023 14:09:43 +0800", "Message-ID": "<20231027060947.3183983-6-haijie1@huawei.com>", "X-Mailer": "git-send-email 2.30.0", "In-Reply-To": "<20231027060947.3183983-1-haijie1@huawei.com>", "References": "<20231027060947.3183983-1-haijie1@huawei.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Originating-IP": "[10.67.165.2]", "X-ClientProxiedBy": "dggems703-chm.china.huawei.com (10.3.19.180) To\n kwepemi500020.china.huawei.com (7.221.188.8)", "X-CFilter-Loop": "Reflected", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "From: Dengdui Huang <huangdengdui@huawei.com>\n\nThe reset event is checked and done in primary. And the secondary\ndoesn't check and display reset log. There is a patch to remove the\ncheck code for secondary. please see commit a8f1f7cf1b42 (\"net/hns3:\nfix crash when secondary process access FW\")\n\nThis patch removes the redundant log print of reset.\n\nFixes: a8f1f7cf1b42 (\"net/hns3: fix crash when secondary process access FW\")\nCc: stable@dpdk.org\n\nSigned-off-by: Dengdui Huang <huangdengdui@huawei.com>\n---\n drivers/net/hns3/hns3_ethdev.c | 11 +++++------\n drivers/net/hns3/hns3_ethdev_vf.c | 11 +++++------\n 2 files changed, 10 insertions(+), 12 deletions(-)", "diff": "diff --git a/drivers/net/hns3/hns3_ethdev.c b/drivers/net/hns3/hns3_ethdev.c\nindex 964f47f1641e..3bdce1fa4b48 100644\n--- a/drivers/net/hns3/hns3_ethdev.c\n+++ b/drivers/net/hns3/hns3_ethdev.c\n@@ -5512,14 +5512,13 @@ hns3_is_reset_pending(struct hns3_adapter *hns)\n \tenum hns3_reset_level reset;\n \n \t/*\n-\t * Check the registers to confirm whether there is reset pending.\n-\t * Note: This check may lead to schedule reset task, but only primary\n-\t * process can process the reset event. Therefore, limit the\n-\t * checking under only primary process.\n+\t * Only primary can process can process the reset event,\n+\t * so don't check reset event in secondary.\n \t */\n-\tif (rte_eal_process_type() == RTE_PROC_PRIMARY)\n-\t\thns3_check_event_cause(hns, NULL);\n+\tif (rte_eal_process_type() != RTE_PROC_PRIMARY)\n+\t\treturn false;\n \n+\thns3_check_event_cause(hns, NULL);\n \treset = hns3_get_reset_level(hns, &hw->reset.pending);\n \tif (reset != HNS3_NONE_RESET && hw->reset.level != HNS3_NONE_RESET &&\n \t hw->reset.level < reset) {\ndiff --git a/drivers/net/hns3/hns3_ethdev_vf.c b/drivers/net/hns3/hns3_ethdev_vf.c\nindex 007f5d619fbf..5f3422d14e8a 100644\n--- a/drivers/net/hns3/hns3_ethdev_vf.c\n+++ b/drivers/net/hns3/hns3_ethdev_vf.c\n@@ -1715,14 +1715,13 @@ hns3vf_is_reset_pending(struct hns3_adapter *hns)\n \t\treturn false;\n \n \t/*\n-\t * Check the registers to confirm whether there is reset pending.\n-\t * Note: This check may lead to schedule reset task, but only primary\n-\t * process can process the reset event. Therefore, limit the\n-\t * checking under only primary process.\n+\t * Only primary can process can process the reset event,\n+\t * so don't check reset event in secondary.\n \t */\n-\tif (rte_eal_process_type() == RTE_PROC_PRIMARY)\n-\t\thns3vf_check_event_cause(hns, NULL);\n+\tif (rte_eal_process_type() != RTE_PROC_PRIMARY)\n+\t\treturn false;\n \n+\thns3vf_check_event_cause(hns, NULL);\n \treset = hns3vf_get_reset_level(hw, &hw->reset.pending);\n \tif (hw->reset.level != HNS3_NONE_RESET && reset != HNS3_NONE_RESET &&\n \t hw->reset.level < reset) {\n", "prefixes": [ "5/8" ] }