Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/133433/?format=api
{ "id": 133433, "url": "http://patches.dpdk.org/api/patches/133433/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20231026151959.1458112-1-sivaprasad.tummala@amd.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20231026151959.1458112-1-sivaprasad.tummala@amd.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20231026151959.1458112-1-sivaprasad.tummala@amd.com", "date": "2023-10-26T15:19:59", "name": "examples/l3fwd-power: fix to configure the uncore env", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "763cd78e917fd1afc4a65ed706040839036e6e73", "submitter": { "id": 2510, "url": "http://patches.dpdk.org/api/people/2510/?format=api", "name": "Sivaprasad Tummala", "email": "Sivaprasad.Tummala@amd.com" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20231026151959.1458112-1-sivaprasad.tummala@amd.com/mbox/", "series": [ { "id": 30008, "url": "http://patches.dpdk.org/api/series/30008/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=30008", "date": "2023-10-26T15:19:59", "name": "examples/l3fwd-power: fix to configure the uncore env", "version": 1, "mbox": "http://patches.dpdk.org/series/30008/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/133433/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/133433/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 4665743209;\n\tThu, 26 Oct 2023 17:20:23 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 12472406B8;\n\tThu, 26 Oct 2023 17:20:23 +0200 (CEST)", "from NAM10-BN7-obe.outbound.protection.outlook.com\n (mail-bn7nam10on2054.outbound.protection.outlook.com [40.107.92.54])\n by mails.dpdk.org (Postfix) with ESMTP id D1DD6402D4\n for <dev@dpdk.org>; Thu, 26 Oct 2023 17:20:21 +0200 (CEST)", "from MN2PR18CA0026.namprd18.prod.outlook.com (2603:10b6:208:23c::31)\n by BY5PR12MB4273.namprd12.prod.outlook.com (2603:10b6:a03:212::16)\n with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6907.26; Thu, 26 Oct\n 2023 15:20:19 +0000", "from BL6PEPF0001AB74.namprd02.prod.outlook.com\n (2603:10b6:208:23c:cafe::31) by MN2PR18CA0026.outlook.office365.com\n (2603:10b6:208:23c::31) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6933.22 via Frontend\n Transport; Thu, 26 Oct 2023 15:20:19 +0000", "from SATLEXMB04.amd.com (165.204.84.17) by\n BL6PEPF0001AB74.mail.protection.outlook.com (10.167.242.167) with Microsoft\n SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id\n 15.20.6933.15 via Frontend Transport; Thu, 26 Oct 2023 15:20:18 +0000", "from telco-siena.amd.com (10.180.168.240) by SATLEXMB04.amd.com\n (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.32; Thu, 26 Oct\n 2023 10:20:17 -0500" ], "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;\n b=kI3r6cJoWVFuZY9EoWZp1aj8JPq3XUwzM9/loZuWlFS9CxurQsGybN6Zy7KM+bJ/EJx0/VgLGy9KRIs0hepj4QFjvjMWJI4ML/RX6zwtCAUDK4Ljc77+C4FeOA0xM+/e1sWAtaSf7wEe/ooYVBrB1b787pfBk0iCxwz21OuWfRJX1q/vL+151Q0Wtuitndz1TzrnDKMSVD+AMoD1dcn+d5edZth9R/N+++HHo6u0WRai4SFXNkbly7q8bawn9DKI8wfTuSr1hz6aWbgP9C0rHPSualXZfLIAAuQc+ow1NHD9Bj4kCsXBKQKezV2pUeaab9p6gjCBTj+wPMa4I3Hg/g==", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector9901;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=w6HoETu7IfgyYW3t86I6mzz8VW6hr0YgsevCQYVzbO8=;\n b=QV7Kmhhrfh8bWU6CgO4RlQJE3V4PHmyl18SjZWo0p3xCJVtyy6lwQ3KXMbEZ5pMEPfKqC/zBhVySPvku/54G44fKbW3Lga8yrIgtO6KEDfNv21HWO6mMdKKkdMjEljI5BugqEOVWnvaIjWvk4SBqQILN0YWa0SAAnQhWIe7phz2B0c/7DC0KAROrtAnF4MCuOvr/XicpOvbLMePKX1R06bCS+8US0shR8HeK1YBbT1oQC/gG16R/XUliWQfMOMs9VeVW2+46cjLJgP9fsS++pjRMdTNKawo8HmHcRlsYDtL4JfE+mEpZ9xWhtrQQlN4D+iKwuRE2H98OpoHdIOmMoA==", "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass (sender ip is\n 165.204.84.17) smtp.rcpttodomain=intel.com smtp.mailfrom=amd.com; dmarc=pass\n (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com;\n dkim=none (message not signed); arc=none (0)", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=w6HoETu7IfgyYW3t86I6mzz8VW6hr0YgsevCQYVzbO8=;\n b=scho7kN3TxfUb21K6cDMIateHeOcL0b9LSwuZCdu8oQM4bB+u4eFIy55CDw8lUzvkBHTpehTkR6ynFu8mPBTf1gxPLDNSijzV9hd5R861WQ6T7wH3FEa9hVrhjBNMKKvph5oJjcHr4Dv6aJ6Zm5VfdgNOEuH7DJDRdEqIHbQ6yA=", "X-MS-Exchange-Authentication-Results": "spf=pass (sender IP is 165.204.84.17)\n smtp.mailfrom=amd.com; dkim=none (message not signed)\n header.d=none;dmarc=pass action=none header.from=amd.com;", "Received-SPF": "Pass (protection.outlook.com: domain of amd.com designates\n 165.204.84.17 as permitted sender) receiver=protection.outlook.com;\n client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C", "From": "Sivaprasad Tummala <sivaprasad.tummala@amd.com>", "To": "<david.hunt@intel.com>, <anatoly.burakov@intel.com>,\n <david.marchand@redhat.com>", "CC": "<dev@dpdk.org>, <john.mcnamara@intel.com>, <thomas@monjalon.net>,\n <ferruh.yigit@amd.com>, <karen.kelly@intel.com>", "Subject": "[PATCH] examples/l3fwd-power: fix to configure the uncore env", "Date": "Thu, 26 Oct 2023 08:19:59 -0700", "Message-ID": "<20231026151959.1458112-1-sivaprasad.tummala@amd.com>", "X-Mailer": "git-send-email 2.34.1", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Originating-IP": "[10.180.168.240]", "X-ClientProxiedBy": "SATLEXMB03.amd.com (10.181.40.144) To SATLEXMB04.amd.com\n (10.181.40.145)", "X-EOPAttributedMessage": "0", "X-MS-PublicTrafficType": "Email", "X-MS-TrafficTypeDiagnostic": "BL6PEPF0001AB74:EE_|BY5PR12MB4273:EE_", "X-MS-Office365-Filtering-Correlation-Id": "5778971a-d2f3-422f-9b6c-08dbd6371043", "X-MS-Exchange-SenderADCheck": "1", "X-MS-Exchange-AntiSpam-Relay": "0", "X-Microsoft-Antispam": "BCL:0;", "X-Microsoft-Antispam-Message-Info": "\n DFBvHICcJNngpoqSlKVSjMe6Jaw99VEsa875KB9br/Cbkdz3jaBphbf5G1ptdSfjT8aCY1leMVJDxHgEcuEJ1qEvepiXkmztb+9dYyAagVkuWF2Y0DLPd+sTagymI7DGXb4p5ImPIyAws8ikUB5OuMgNuvKyeu/Ey5E8x8CXEhJZcmUn+26Oxv2vYa3+UNlEXDxGZlysGOFQqKN6KmyPVpw64sl+YP9qmgokR3eI0AnjGhib8F4ToPcJ46wh5J/+mBsZhawxuqeukkNyD/ND/VPY80LRxG5rNTkjg3hOqnEjo7n1M0/WpHyAYmoZ3Nfd6jJZfCy3WgZfgPVFSZHNsZT7iP5xS70jrC76mjnWRamtexfoHFAiwPPWxD7TSVF3kh+Rdtr+RN54ep6HEs985T98dET8JwaqfIEbHFq2B48vPs8NK9rnP+ZnQ6KIiZzI4Bz9Km7uW38ooHV/jySFpoiADANBQ6qirWotPeALF8r5Q9DbfmiXcW08DzxgfrtnQqRAMhsKK9q+NKwC8GjMrTh/LwEp44d42wDfqzH8Iid+LuTLulwOPVYn39nip3SphXd2g4cF/iPa0T7F3EOQosAXQdn+t53UnkQoEQysefsG7yrq5BwZQ7CSXDijtw0XOhflnTywhjXJUK/6/gIcvoctbDk83Ykjp4PkGbTif/1IOP6RXkVjEyRXt8rH+fKNNwZH3PaX6F127P/3HqhVaIIlUOndBKYXHIsmZSWIQQ2NRMDwYLPCMiY6W1P2XPVJI9WOZSf/Pe6pjDj6tzB4xg==", "X-Forefront-Antispam-Report": "CIP:165.204.84.17; CTRY:US; LANG:en; SCL:1; SRV:;\n IPV:CAL; SFV:NSPM; H:SATLEXMB04.amd.com; PTR:InfoDomainNonexistent; CAT:NONE;\n SFS:(13230031)(4636009)(396003)(39860400002)(136003)(346002)(376002)(230922051799003)(82310400011)(186009)(64100799003)(1800799009)(451199024)(46966006)(36840700001)(40470700004)(40460700003)(83380400001)(2906002)(36860700001)(8936002)(44832011)(8676002)(82740400003)(36756003)(47076005)(81166007)(336012)(426003)(1076003)(2616005)(356005)(26005)(16526019)(7696005)(40480700001)(110136005)(4326008)(478600001)(6666004)(316002)(5660300002)(41300700001)(86362001)(54906003)(70586007)(70206006)(36900700001);\n DIR:OUT; SFP:1101;", "X-OriginatorOrg": "amd.com", "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "26 Oct 2023 15:20:18.7156 (UTC)", "X-MS-Exchange-CrossTenant-Network-Message-Id": "\n 5778971a-d2f3-422f-9b6c-08dbd6371043", "X-MS-Exchange-CrossTenant-Id": "3dd8961f-e488-4e60-8e11-a82d994e183d", "X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp": "\n TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d; Ip=[165.204.84.17];\n Helo=[SATLEXMB04.amd.com]", "X-MS-Exchange-CrossTenant-AuthSource": "\n BL6PEPF0001AB74.namprd02.prod.outlook.com", "X-MS-Exchange-CrossTenant-AuthAs": "Anonymous", "X-MS-Exchange-CrossTenant-FromEntityHeader": "HybridOnPrem", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "BY5PR12MB4273", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Updated the l3fwd-power app to configure the uncore env before invoking\nany uncore APIs. With auto-detection in 'rte_power_uncore_init()' it is\ntoo late because other APIs already called.\n\nBugzilla ID: 1304\nFixes: ac1edcb6621a (\"power: refactor uncore power management API\")\nCc: karen.kelly@intel.com\n\nSigned-off-by: Sivaprasad Tummala <sivaprasad.tummala@amd.com>\n---\n examples/l3fwd-power/main.c | 6 ++++++\n lib/power/rte_power_uncore.c | 7 +++++++\n lib/power/rte_power_uncore.h | 9 +++++----\n 3 files changed, 18 insertions(+), 4 deletions(-)", "diff": "diff --git a/examples/l3fwd-power/main.c b/examples/l3fwd-power/main.c\nindex 5fbc16bb2a..9c0dcd343b 100644\n--- a/examples/l3fwd-power/main.c\n+++ b/examples/l3fwd-power/main.c\n@@ -1561,6 +1561,12 @@ parse_uncore_options(enum uncore_choice choice, const char *argument)\n {\n \tunsigned int die, pkg, max_pkg, max_die;\n \tint ret = 0;\n+\tret = rte_power_set_uncore_env(RTE_UNCORE_PM_ENV_AUTO_DETECT);\n+\tif (ret < 0) {\n+\t\tRTE_LOG(INFO, L3FWD_POWER, \"Failed to set uncore env\\n\");\n+\t\treturn ret;\n+\t}\n+\n \tmax_pkg = rte_power_uncore_get_num_pkgs();\n \tif (max_pkg == 0)\n \t\treturn -1;\ndiff --git a/lib/power/rte_power_uncore.c b/lib/power/rte_power_uncore.c\nindex 78a823d34c..d87328bedf 100644\n--- a/lib/power/rte_power_uncore.c\n+++ b/lib/power/rte_power_uncore.c\n@@ -105,6 +105,13 @@ rte_power_set_uncore_env(enum rte_uncore_power_mgmt_env env)\n \t\treturn -1;\n \t}\n \n+\tif (env == RTE_UNCORE_PM_ENV_AUTO_DETECT)\n+\t\t/* Currently only intel_uncore is supported. This will be\n+\t\t * extended with auto-detection support for multiple uncore\n+\t\t * implementations.\n+\t\t */\n+\t\tenv = RTE_UNCORE_PM_ENV_INTEL_UNCORE;\n+\n \tret = 0;\n \tif (env == RTE_UNCORE_PM_ENV_INTEL_UNCORE) {\n \t\trte_power_get_uncore_freq = power_get_intel_uncore_freq;\ndiff --git a/lib/power/rte_power_uncore.h b/lib/power/rte_power_uncore.h\nindex 295017b7f4..ede50a5f87 100644\n--- a/lib/power/rte_power_uncore.h\n+++ b/lib/power/rte_power_uncore.h\n@@ -21,15 +21,16 @@ extern \"C\" {\n /* Uncore Power Management Environment */\n enum rte_uncore_power_mgmt_env {\n \tRTE_UNCORE_PM_ENV_NOT_SET,\n+\tRTE_UNCORE_PM_ENV_AUTO_DETECT,\n \tRTE_UNCORE_PM_ENV_INTEL_UNCORE,\n \tRTE_UNCORE_PM_ENV_AMD_HSMP\n };\n \n /**\n- * Set the default uncore power management implementation. If this is not called prior\n- * to rte_power_uncore_init(), then auto-detect of the environment will take place.\n- * It is thread safe. New env can be set only in uninitialized state\n- * (thus rte_power_unset_uncore_env must be called if different env was already set).\n+ * Set the default uncore power management implementation. This has to be called\n+ * prior to calling any other rte_power_uncore_*() API.\n+ * It is thread safe. New env can be set only in uninitialized state.\n+ * rte_power_unset_uncore_env must be called if different env was already set).\n *\n * @param env\n * env. The environment in which to initialise Uncore Power Management for.\n", "prefixes": [] }