Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/13341/?format=api
{ "id": 13341, "url": "http://patches.dpdk.org/api/patches/13341/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1465379291-25310-5-git-send-email-nelio.laranjeiro@6wind.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1465379291-25310-5-git-send-email-nelio.laranjeiro@6wind.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1465379291-25310-5-git-send-email-nelio.laranjeiro@6wind.com", "date": "2016-06-08T09:47:51", "name": "[dpdk-dev,04/24] mlx5: remove configuration variable for maximum number of segments", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "e02d40b6429f9ecd9b57c77020e4540133515c4f", "submitter": { "id": 243, "url": "http://patches.dpdk.org/api/people/243/?format=api", "name": "Nélio Laranjeiro", "email": "nelio.laranjeiro@6wind.com" }, "delegate": { "id": 10, "url": "http://patches.dpdk.org/api/users/10/?format=api", "username": "bruce", "first_name": "Bruce", "last_name": "Richardson", "email": "bruce.richardson@intel.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1465379291-25310-5-git-send-email-nelio.laranjeiro@6wind.com/mbox/", "series": [], "comments": "http://patches.dpdk.org/api/patches/13341/comments/", "check": "pending", "checks": "http://patches.dpdk.org/api/patches/13341/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 70BB69AEA;\n\tWed, 8 Jun 2016 11:48:25 +0200 (CEST)", "from mail-wm0-f48.google.com (mail-wm0-f48.google.com\n\t[74.125.82.48]) by dpdk.org (Postfix) with ESMTP id E0D979AD0\n\tfor <dev@dpdk.org>; Wed, 8 Jun 2016 11:48:21 +0200 (CEST)", "by mail-wm0-f48.google.com with SMTP id n184so173189365wmn.1\n\tfor <dev@dpdk.org>; Wed, 08 Jun 2016 02:48:21 -0700 (PDT)", "from ping.vm.6wind.com (guy78-3-82-239-227-177.fbx.proxad.net.\n\t[82.239.227.177]) by smtp.gmail.com with ESMTPSA id\n\tc185sm23899214wme.9.2016.06.08.02.48.20\n\t(version=TLSv1/SSLv3 cipher=OTHER);\n\tWed, 08 Jun 2016 02:48:21 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=6wind-com.20150623.gappssmtp.com; s=20150623;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references;\n\tbh=ZFS0wIq6f4GYu3WOJy3ZwC44oqjvFXXGThee9GrTd40=;\n\tb=VjrtZPS3I65D1srV8zsyg02rEXeADUfwoy2052jbtEzqqBZtS5EqoBF+ttM5W82oQr\n\tLsLIZubG0E29/GGBegPyyFB0yWXk/7hVCEevywnGD4J5OW3uXd9pN6OB9x1lpiPzUgNc\n\t0qJU5+dTfU/9gF2nwd1jIk+eF34PTZLrylOfo8yIfmuO6QLRy/NyIHVE1XVBGKajDmVc\n\thdI50msXRGpZ7s98v+2zmpuphLH6Hi0BoFZlbAjszw6js6zCmaJ4PMJIz7EyxdUQOof7\n\tUSKiUNYmNGVIljdgIe6dGGJ8+omMjQIxIFva/KIbQCA/CoNrQ2pEbI/wksAEOIXwTIeX\n\t4Q4A==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20130820;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references;\n\tbh=ZFS0wIq6f4GYu3WOJy3ZwC44oqjvFXXGThee9GrTd40=;\n\tb=GFknEJhZhmLVxiVjps3PbTtbD9mpHH4JBiIIyh0j7h3tOEayoatWpt8VE0BcR/9KRj\n\tozinQMff8OgvJtU9c/6oB/Lp4Y1FOmcjei6WgtZ4BqH3isMroryKUwnw2M+cReTqJftv\n\tFfHrFWt8z45CdYHmijx30H80jANKUdaFICm/+qUyEYaft3QOP9/6oXxJ5BTF9H+/IBWE\n\tyZnDytCSGuPZLJAWix73t1MD1j+jigMR7DkaSa1EEpwAll0lEUYc18DnQyg/qd2D4kNz\n\tLXAK0xmkLUaBfJvTkJA4ez3Jhnn1qajmXLXTLF+BbSnCOptSPX8INTNUUThM8HoHGZA7\n\toR+Q==", "X-Gm-Message-State": "ALyK8tLVLWz2OmxQ5Brr0SGGWKp6xtmTOU4DWvxeAajGKKrF80FHP73Fav6lzjGPJrSL7DgW", "X-Received": "by 10.194.83.103 with SMTP id p7mr3575612wjy.110.1465379301556; \n\tWed, 08 Jun 2016 02:48:21 -0700 (PDT)", "From": "Nelio Laranjeiro <nelio.laranjeiro@6wind.com>", "To": "dev@dpdk.org", "Cc": "Adrien Mazarguil <adrien.mazarguil@6wind.com>", "Date": "Wed, 8 Jun 2016 11:47:51 +0200", "Message-Id": "<1465379291-25310-5-git-send-email-nelio.laranjeiro@6wind.com>", "X-Mailer": "git-send-email 2.1.4", "In-Reply-To": "<1465379291-25310-1-git-send-email-nelio.laranjeiro@6wind.com>", "References": "<1465379291-25310-1-git-send-email-nelio.laranjeiro@6wind.com>", "Subject": "[dpdk-dev] [PATCH 04/24] mlx5: remove configuration variable for\n\tmaximum number of segments", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "There is no scatter/gather support anymore, CONFIG_RTE_LIBRTE_MLX5_SGE_WR_N\nhas no purpose and can be removed.\n\nSigned-off-by: Nelio Laranjeiro <nelio.laranjeiro@6wind.com>\nSigned-off-by: Adrien Mazarguil <adrien.mazarguil@6wind.com>\n---\n config/common_base | 1 -\n doc/guides/nics/mlx5.rst | 7 -------\n drivers/net/mlx5/Makefile | 4 ----\n drivers/net/mlx5/mlx5_defs.h | 5 -----\n drivers/net/mlx5/mlx5_rxq.c | 4 ----\n drivers/net/mlx5/mlx5_txq.c | 4 ----\n 6 files changed, 25 deletions(-)", "diff": "diff --git a/config/common_base b/config/common_base\nindex 47c26f6..a4a3a3a 100644\n--- a/config/common_base\n+++ b/config/common_base\n@@ -207,7 +207,6 @@ CONFIG_RTE_LIBRTE_MLX4_SOFT_COUNTERS=1\n #\n CONFIG_RTE_LIBRTE_MLX5_PMD=n\n CONFIG_RTE_LIBRTE_MLX5_DEBUG=n\n-CONFIG_RTE_LIBRTE_MLX5_SGE_WR_N=4\n CONFIG_RTE_LIBRTE_MLX5_MAX_INLINE=0\n CONFIG_RTE_LIBRTE_MLX5_TX_MP_CACHE=8\n \ndiff --git a/doc/guides/nics/mlx5.rst b/doc/guides/nics/mlx5.rst\nindex d9196d1..84c35a0 100644\n--- a/doc/guides/nics/mlx5.rst\n+++ b/doc/guides/nics/mlx5.rst\n@@ -114,13 +114,6 @@ These options can be modified in the ``.config`` file.\n adds additional run-time checks and debugging messages at the cost of\n lower performance.\n \n-- ``CONFIG_RTE_LIBRTE_MLX5_SGE_WR_N`` (default **4**)\n-\n- Number of scatter/gather elements (SGEs) per work request (WR). Lowering\n- this number improves performance but also limits the ability to receive\n- scattered packets (packets that do not fit a single mbuf). The default\n- value is a safe tradeoff.\n-\n - ``CONFIG_RTE_LIBRTE_MLX5_MAX_INLINE`` (default **0**)\n \n Amount of data to be inlined during TX operations. Improves latency.\ndiff --git a/drivers/net/mlx5/Makefile b/drivers/net/mlx5/Makefile\nindex 1dba3de..9a26269 100644\n--- a/drivers/net/mlx5/Makefile\n+++ b/drivers/net/mlx5/Makefile\n@@ -84,10 +84,6 @@ else\n CFLAGS += -DNDEBUG -UPEDANTIC\n endif\n \n-ifdef CONFIG_RTE_LIBRTE_MLX5_SGE_WR_N\n-CFLAGS += -DMLX5_PMD_SGE_WR_N=$(CONFIG_RTE_LIBRTE_MLX5_SGE_WR_N)\n-endif\n-\n ifdef CONFIG_RTE_LIBRTE_MLX5_MAX_INLINE\n CFLAGS += -DMLX5_PMD_MAX_INLINE=$(CONFIG_RTE_LIBRTE_MLX5_MAX_INLINE)\n endif\ndiff --git a/drivers/net/mlx5/mlx5_defs.h b/drivers/net/mlx5/mlx5_defs.h\nindex 09207d9..da1c90e 100644\n--- a/drivers/net/mlx5/mlx5_defs.h\n+++ b/drivers/net/mlx5/mlx5_defs.h\n@@ -54,11 +54,6 @@\n /* RSS Indirection table size. */\n #define RSS_INDIRECTION_TABLE_SIZE 256\n \n-/* Maximum number of Scatter/Gather Elements per Work Request. */\n-#ifndef MLX5_PMD_SGE_WR_N\n-#define MLX5_PMD_SGE_WR_N 4\n-#endif\n-\n /* Maximum size for inline data. */\n #ifndef MLX5_PMD_MAX_INLINE\n #define MLX5_PMD_MAX_INLINE 0\ndiff --git a/drivers/net/mlx5/mlx5_rxq.c b/drivers/net/mlx5/mlx5_rxq.c\nindex 38ff9fd..4000624 100644\n--- a/drivers/net/mlx5/mlx5_rxq.c\n+++ b/drivers/net/mlx5/mlx5_rxq.c\n@@ -976,10 +976,6 @@ rxq_setup(struct rte_eth_dev *dev, struct rxq *rxq, uint16_t desc,\n \t\tERROR(\"%p: invalid number of RX descriptors\", (void *)dev);\n \t\treturn EINVAL;\n \t}\n-\tif (MLX5_PMD_SGE_WR_N > 1) {\n-\t\tERROR(\"%p: RX scatter is not supported\", (void *)dev);\n-\t\treturn ENOTSUP;\n-\t}\n \t/* Toggle RX checksum offload if hardware supports it. */\n \tif (priv->hw_csum)\n \t\ttmpl.csum = !!dev->data->dev_conf.rxmode.hw_ip_checksum;\ndiff --git a/drivers/net/mlx5/mlx5_txq.c b/drivers/net/mlx5/mlx5_txq.c\nindex 5a248c9..59974c5 100644\n--- a/drivers/net/mlx5/mlx5_txq.c\n+++ b/drivers/net/mlx5/mlx5_txq.c\n@@ -264,10 +264,6 @@ txq_setup(struct rte_eth_dev *dev, struct txq *txq, uint16_t desc,\n \t\tERROR(\"%p: invalid number of TX descriptors\", (void *)dev);\n \t\treturn EINVAL;\n \t}\n-\tif (MLX5_PMD_SGE_WR_N > 1) {\n-\t\tERROR(\"%p: TX gather is not supported\", (void *)dev);\n-\t\treturn EINVAL;\n-\t}\n \t/* MRs will be registered in mp2mr[] later. */\n \tattr.rd = (struct ibv_exp_res_domain_init_attr){\n \t\t.comp_mask = (IBV_EXP_RES_DOMAIN_THREAD_MODEL |\n", "prefixes": [ "dpdk-dev", "04/24" ] }