Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/133363/?format=api
{ "id": 133363, "url": "http://patches.dpdk.org/api/patches/133363/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20231026064324.177531-24-chaoyong.he@corigine.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20231026064324.177531-24-chaoyong.he@corigine.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20231026064324.177531-24-chaoyong.he@corigine.com", "date": "2023-10-26T06:43:22", "name": "[v3,23/25] vdpa/nfp: add the notify related logic", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": true, "hash": "22f9059dc82707d20f8bd38e8bb2776d1fff80c6", "submitter": { "id": 2554, "url": "http://patches.dpdk.org/api/people/2554/?format=api", "name": "Chaoyong He", "email": "chaoyong.he@corigine.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20231026064324.177531-24-chaoyong.he@corigine.com/mbox/", "series": [ { "id": 29991, "url": "http://patches.dpdk.org/api/series/29991/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=29991", "date": "2023-10-26T06:42:59", "name": "add the NFP vDPA PMD", "version": 3, "mbox": "http://patches.dpdk.org/series/29991/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/133363/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/133363/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id ECDF543204;\n\tThu, 26 Oct 2023 08:47:52 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 9D90E42E5F;\n\tThu, 26 Oct 2023 08:44:39 +0200 (CEST)", "from NAM10-DM6-obe.outbound.protection.outlook.com\n (mail-dm6nam10on2139.outbound.protection.outlook.com [40.107.93.139])\n by mails.dpdk.org (Postfix) with ESMTP id DD17E42830\n for <dev@dpdk.org>; Thu, 26 Oct 2023 08:44:30 +0200 (CEST)", "from SJ0PR13MB5545.namprd13.prod.outlook.com (2603:10b6:a03:424::5)\n by DM4PR13MB5908.namprd13.prod.outlook.com (2603:10b6:8:50::21) with\n Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6933.19; Thu, 26 Oct\n 2023 06:44:29 +0000", "from SJ0PR13MB5545.namprd13.prod.outlook.com\n ([fe80::45b3:d83c:cff2:4a1b]) by SJ0PR13MB5545.namprd13.prod.outlook.com\n ([fe80::45b3:d83c:cff2:4a1b%6]) with mapi id 15.20.6933.022; Thu, 26 Oct 2023\n 06:44:29 +0000" ], "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;\n b=QGBVyIeBMMBGoummtT590jHM+DID838lo4vFyrlJWgQwxmMsRzUMAJQqF8UfhV/u2l0M10tb110Cz2Uow3FXBKBouAui8IiBExkPZZyUnThQ2Ay8gRxR9j3Mlg4b8dsnwe52CSfrINBDZKEIMLnjAM/sjNifTqXnmh72bbvuM1DZgqIzkeufjrKKzcye3GJvLZKxPB7vEyrAaervr18ejw4j8croJOwk5V8xuyASY+/2+I4zKrnFMwHWjwA1byDwpGd+TIGNqzCMGcMsyyit0pau+Yg9qgEqg0KFKSn3Q18AIFuydueD45rGcPBFpG6d0X1RmTZVxAmyyxdZYqwGdg==", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector9901;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=EkIhE+6SUYsV+j9Cgqztz8HgRPhMNijBbqLxanMivEM=;\n b=Az4rvCCFT5q/SHZ+oZMKBiTtyVkfBaeGWapOgwuMwoYzPrUeix+To6NXjQsU8DIVA0hfg2kqi+kJM8CMl/GPsK18FJB2RdaVw9MItCTm1ax+pjRUqEjFQ/DoXFiHxL/AqURuDXK1mVHIzIxubKept27+z8BHWi6ug1jrStswjfhCy0cq1l7HoC4dVG/t/+6RYKtDY29gFrXrc2EKq8GyCRT4tXKxVTlOTxaPFRNCPduBq2eJ5GKZnL1iSHweYmX73fLXvzqwIHUlDcDulm9fUi3h2zXbOuPLKRQzefIst5bq+Z1TrmxtwHIKcnIyuPmY2YUCDs6vrqtXuLgL9jDFYQ==", "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass\n smtp.mailfrom=corigine.com; dmarc=pass action=none header.from=corigine.com;\n dkim=pass header.d=corigine.com; arc=none", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=corigine.onmicrosoft.com; s=selector2-corigine-onmicrosoft-com;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=EkIhE+6SUYsV+j9Cgqztz8HgRPhMNijBbqLxanMivEM=;\n b=diknU+2LEn7zOpTnBc2kzcIzD2dds7zWu+9rB0RdmpIk+Dh3BgkU9+I6+L/bj7DZF+KuLxBm7yIEU00cg3NY8DmWaMxqOnHsev1K5YoOi1Miiv9kyPFIxibKlIGQtZabzV1w+2y6mD/5Z7e11lpBrbvH4vpon8BWHmPs33hXLL8=", "Authentication-Results": "dkim=none (message not signed)\n header.d=none;dmarc=none action=none header.from=corigine.com;", "From": "Chaoyong He <chaoyong.he@corigine.com>", "To": "dev@dpdk.org", "Cc": "oss-drivers@corigine.com, Chaoyong He <chaoyong.he@corigine.com>,\n Shujing Dong <shujing.dong@corigine.com>, Long Wu <long.wu@corigine.com>,\n Peng Zhang <peng.zhang@corigine.com>", "Subject": "[PATCH v3 23/25] vdpa/nfp: add the notify related logic", "Date": "Thu, 26 Oct 2023 14:43:22 +0800", "Message-Id": "<20231026064324.177531-24-chaoyong.he@corigine.com>", "X-Mailer": "git-send-email 2.39.1", "In-Reply-To": "<20231026064324.177531-1-chaoyong.he@corigine.com>", "References": "<20231024022849.3092506-1-chaoyong.he@corigine.com>\n <20231026064324.177531-1-chaoyong.he@corigine.com>", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-ClientProxiedBy": "BYAPR07CA0034.namprd07.prod.outlook.com\n (2603:10b6:a02:bc::47) To SJ0PR13MB5545.namprd13.prod.outlook.com\n (2603:10b6:a03:424::5)", "MIME-Version": "1.0", "X-MS-PublicTrafficType": "Email", "X-MS-TrafficTypeDiagnostic": "SJ0PR13MB5545:EE_|DM4PR13MB5908:EE_", "X-MS-Office365-Filtering-Correlation-Id": "cbc7d79b-65a1-456c-c9bc-08dbd5ef00a4", "X-MS-Exchange-SenderADCheck": "1", "X-MS-Exchange-AntiSpam-Relay": "0", "X-Microsoft-Antispam": "BCL:0;", "X-Microsoft-Antispam-Message-Info": "\n gZfo4oaSwWdSCLCseWKO1SMPp39GO8JexZdhB4WvuY9c5PpnaYWdIgOCoTwftvAPMXz0B9AOpuHF0W3l3tRm4vUukSPnTs7wVeAkL5P+MqUMdJ3B1GvF55Jf5z98dKG1n99mDyUpyhhTEI3scMEyN6NdwMWnWAJTAOko1FNNcCYa96j1jhMdy4DxjSLON28rHTXZBI2Ey9X4q8GKynAL/JVCsvoFCXawWWesan7FVAU/U54Umu+f+xaK2e/PLGJ5wBUXTh/77xh8ybeODEKhWbnlzM5d6iaVuRLiV9S2lQ/viq7a2bPGswrMbRJVbPt68yiUMPcu8Ot36Yr7IblP2yL1qhL3FURbp881F7XqIWTJEJeyx5hH4FObhBibDdWLfcXm+TkW374Cd8GCAhfNhxxNHMYmTxNXtZpsIdtMcSWA2yef/C06rbZXcistCpBpW93NUT4WP0Uop5v41RovsySoTP/HKmis6DmpTqek2ocKQbNh26PUWMs8dmMPFD1I3rhVWu3i/xtJpqDAYzQDGakvakQSbigJH0Z5E8qhBfkZ6GKpNIDVBKV7Ik2pulUzH7ZKjV/0AH8mFeyDH9Q7SlQ8AzG686okbklcii25xlRTqOl3BfQpfgGwbPqiykHQcMk0Idv7C9I69KNs7UxWQyOnUsL8yMrlCHDoK57/D6k=", "X-Forefront-Antispam-Report": "CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;\n IPV:NLI; SFV:NSPM; H:SJ0PR13MB5545.namprd13.prod.outlook.com; PTR:; CAT:NONE;\n SFS:(13230031)(136003)(376002)(366004)(396003)(346002)(39840400004)(230922051799003)(186009)(1800799009)(451199024)(64100799003)(26005)(478600001)(1076003)(316002)(6666004)(6512007)(86362001)(6506007)(6916009)(66946007)(66556008)(38100700002)(66476007)(54906003)(36756003)(38350700005)(2616005)(6486002)(107886003)(44832011)(2906002)(83380400001)(4326008)(8676002)(8936002)(5660300002)(41300700001)(52116002);\n DIR:OUT; SFP:1102;", "X-MS-Exchange-AntiSpam-MessageData-ChunkCount": "1", "X-MS-Exchange-AntiSpam-MessageData-0": "\n HFnk2JxAvSZNIDyLc9L17CVxztSFpgR5Fk5x3YesBbWRoTS5+27ge96wui/hdrgMRZe44d4vzWc2/IEBJB1WNkUtULBTtM2xXJwjcPRvOi1NmGCZlF9cNdzzr4Wj3M/O5q1g4DOquc11jcj6joxERwFwM9ykghNNu1XZLqO8Bj7EUfkfevwZUo4JaRCCuKU0qDj70OLhN1SDUpreavd2s4OcjxoNWBshCCN1jG3Z8t0odEGRqreIWhwe141q1ekL8c5j6aVKmZE9BaWQXt6Fv6jQraI2sik1gTWilKMSuWHsOefxP2BS+3jFMEkrj7tkc6k284tJhJaktrwczH4igNtxIR+XLCJVisUoiUI6RxMxm/Tv2fiZFFYHzGdQr8Lb3UfKmV0a9y6R2c2tfrM0IaHOKBtlLhQVO7Fw56J+aeu5+BxD1Y9QbnNCx+XRVZpUxasI/7/p+UaAyGQd+5yXbcRTLHOE7SJ1MK+KjFpUeAAn3GWWSn43VmrWbcia3GdiXVfq11/1yuKGoT6csLpAE/j1Omt5cP9Mueg7oyq+0HjNqMICGbpfSXI3QTy2ygrxi2XYT8EYurW3LjNxBBEDFtpypyEV0bvwPBFkfbIoIKPaRrvCpf+7rnBO8FojQZdtiF3e2I/xY8FFFTR2O9J+u+tOEJEUASS14eZitVB+XuddP6gB5dwrdybQwzmJRCPC+o5e6LrD2iS60lQXimdh/dFpReGVL5Lms8CRb7P1wrJmw70IT3YAIOmP0W3m+mtxdI4kJfV1hc4C41STFAXRziaO8NUHXRY93Ve/LMRYpbqIQglHsppTq1Od8NV9YhuEEDmwbSNKKEiGlq3pcpOCh3G1RDASVulJ2NoAwstsfpAYFln3CCbzE/7Lz9L4Fb+E3d3qEHRictxAUCaS4tPZvXzgBBYLnObDBK++VBdmxb93JacxpjEcw5JHOFfdE0w+ztH3VDIdNwlb9LbvI7nJAPs94LEZiJvMJ6iH8z+AXbVeWonAkChgZjOK/+Rz156OAYgCTImZlBtk9n1ZvKnfukyTXQzxfE5dY51Xj/lA/gjhM/Est7mGB4QLeFaNWv4UBPBTh4Lv+BRQ3dMlWYIQP48a7e5tZzkGESAjy6jAhCMW0/dlw/T3EGGrvSv8uf5GNOSDFBUPvqbV54Bd1liQdjX9Aeqro1mJZ9ObwaC6J3JoMFlu2CXQdgqF+NbjxDaJU2KiOyHb/ZFnI0ae/ApM95uF4wyaDYSmZb6h8WWT+8ULJdcQPngROEPHxsmW35B+1038/E0p+TirqikaCdoDhjKle26J38IgmQxuU+fceCD0KEkz9i7GtQbY5NNe8CoeIliTpiL+hFKBaQ/GPRfjKIACUauARTybPvzAfNMRw0DSeM+KA6jMUhtZJcsoRjeePm/UpsCHEYScDXwVKnQMlCw8OiuSnrrJLEkcLKWfySyud0TE74+mICf4+bx4P+vQe00T8E3sB4YOe0PDArJZ2sDPFY0FnFM7ZVgELxEhCl4NNWqp+GSDgLgQje4+3skvn1ANpeeJPIxn0LVQgx2q4Jx5DNAu/DpSTTnx3lU8umEV+gPfXhGN2lc5y6xlbxCyoBBMuDbrZpE6I1yseyuTHg==", "X-OriginatorOrg": "corigine.com", "X-MS-Exchange-CrossTenant-Network-Message-Id": "\n cbc7d79b-65a1-456c-c9bc-08dbd5ef00a4", "X-MS-Exchange-CrossTenant-AuthSource": "SJ0PR13MB5545.namprd13.prod.outlook.com", "X-MS-Exchange-CrossTenant-AuthAs": "Internal", "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "26 Oct 2023 06:44:29.0583 (UTC)", "X-MS-Exchange-CrossTenant-FromEntityHeader": "Hosted", "X-MS-Exchange-CrossTenant-Id": "fe128f2c-073b-4c20-818e-7246a585940c", "X-MS-Exchange-CrossTenant-MailboxType": "HOSTED", "X-MS-Exchange-CrossTenant-UserPrincipalName": "\n W++l/uTSmV9TJCNe7+MiQr91B8e1e5OEuh80Omu8gQj7SZgGMCodFO5jtiuJqN/VRKcKXDjRXHo2//4u65iyneHTntL5mOcJ7G/Hv2vVB94=", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "DM4PR13MB5908", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Add the logic to process vDPA notify relay.\n\nSigned-off-by: Chaoyong He <chaoyong.he@corigine.com>\nSigned-off-by: Shujing Dong <shujing.dong@corigine.com>\nReviewed-by: Long Wu <long.wu@corigine.com>\nReviewed-by: Peng Zhang <peng.zhang@corigine.com>\n---\n drivers/vdpa/nfp/nfp_vdpa.c | 155 +++++++++++++++++++++++++++++++\n drivers/vdpa/nfp/nfp_vdpa_core.c | 61 ++++++++++++\n drivers/vdpa/nfp/nfp_vdpa_core.h | 4 +\n 3 files changed, 220 insertions(+)", "diff": "diff --git a/drivers/vdpa/nfp/nfp_vdpa.c b/drivers/vdpa/nfp/nfp_vdpa.c\nindex d0d8050887..f4d63b8ba9 100644\n--- a/drivers/vdpa/nfp/nfp_vdpa.c\n+++ b/drivers/vdpa/nfp/nfp_vdpa.c\n@@ -4,7 +4,9 @@\n */\n \n #include <pthread.h>\n+#include <sys/epoll.h>\n #include <sys/ioctl.h>\n+#include <unistd.h>\n \n #include <nfp_common_pci.h>\n #include <nfp_dev.h>\n@@ -29,6 +31,9 @@ struct nfp_vdpa_dev {\n \tint vfio_dev_fd;\n \tint iommu_group;\n \n+\trte_thread_t tid; /**< Thread for notify relay */\n+\tint epoll_fd;\n+\n \tint vid;\n \tuint16_t max_queues;\n \tuint32_t started;\n@@ -368,6 +373,148 @@ nfp_vdpa_disable_vfio_intr(struct nfp_vdpa_dev *device)\n \treturn 0;\n }\n \n+static void\n+nfp_vdpa_read_kickfd(int kickfd)\n+{\n+\tint bytes;\n+\tuint64_t buf;\n+\n+\tfor (;;) {\n+\t\tbytes = read(kickfd, &buf, 8);\n+\t\tif (bytes >= 0)\n+\t\t\tbreak;\n+\n+\t\tif (errno != EINTR && errno != EWOULDBLOCK &&\n+\t\t\t\terrno != EAGAIN) {\n+\t\t\tDRV_VDPA_LOG(ERR, \"Error reading kickfd\");\n+\t\t\tbreak;\n+\t\t}\n+\t}\n+}\n+\n+static int\n+nfp_vdpa_notify_epoll_ctl(uint32_t queue_num,\n+\t\tstruct nfp_vdpa_dev *device)\n+{\n+\tint ret;\n+\tuint32_t qid;\n+\n+\tfor (qid = 0; qid < queue_num; qid++) {\n+\t\tstruct epoll_event ev;\n+\t\tstruct rte_vhost_vring vring;\n+\n+\t\tev.events = EPOLLIN | EPOLLPRI;\n+\t\trte_vhost_get_vhost_vring(device->vid, qid, &vring);\n+\t\tev.data.u64 = qid | (uint64_t)vring.kickfd << 32;\n+\t\tret = epoll_ctl(device->epoll_fd, EPOLL_CTL_ADD, vring.kickfd, &ev);\n+\t\tif (ret < 0) {\n+\t\t\tDRV_VDPA_LOG(ERR, \"Epoll add error for queue %d\", qid);\n+\t\t\treturn ret;\n+\t\t}\n+\t}\n+\n+\treturn 0;\n+}\n+\n+static int\n+nfp_vdpa_notify_epoll_wait(uint32_t queue_num,\n+\t\tstruct nfp_vdpa_dev *device)\n+{\n+\tint i;\n+\tint fds;\n+\tint kickfd;\n+\tuint32_t qid;\n+\tstruct epoll_event events[NFP_VDPA_MAX_QUEUES * 2];\n+\n+\tfor (;;) {\n+\t\tfds = epoll_wait(device->epoll_fd, events, queue_num, -1);\n+\t\tif (fds < 0) {\n+\t\t\tif (errno == EINTR)\n+\t\t\t\tcontinue;\n+\n+\t\t\tDRV_VDPA_LOG(ERR, \"Epoll wait fail\");\n+\t\t\treturn -EACCES;\n+\t\t}\n+\n+\t\tfor (i = 0; i < fds; i++) {\n+\t\t\tqid = events[i].data.u32;\n+\t\t\tkickfd = (uint32_t)(events[i].data.u64 >> 32);\n+\n+\t\t\tnfp_vdpa_read_kickfd(kickfd);\n+\t\t\tnfp_vdpa_notify_queue(&device->hw, qid);\n+\t\t}\n+\t}\n+\n+\treturn 0;\n+}\n+\n+static uint32_t\n+nfp_vdpa_notify_relay(void *arg)\n+{\n+\tint ret;\n+\tint epoll_fd;\n+\tuint32_t queue_num;\n+\tstruct nfp_vdpa_dev *device = arg;\n+\n+\tepoll_fd = epoll_create(NFP_VDPA_MAX_QUEUES * 2);\n+\tif (epoll_fd < 0) {\n+\t\tDRV_VDPA_LOG(ERR, \"failed to create epoll instance.\");\n+\t\treturn 1;\n+\t}\n+\n+\tdevice->epoll_fd = epoll_fd;\n+\n+\tqueue_num = rte_vhost_get_vring_num(device->vid);\n+\n+\tret = nfp_vdpa_notify_epoll_ctl(queue_num, device);\n+\tif (ret != 0)\n+\t\tgoto notify_exit;\n+\n+\tret = nfp_vdpa_notify_epoll_wait(queue_num, device);\n+\tif (ret != 0)\n+\t\tgoto notify_exit;\n+\n+\treturn 0;\n+\n+notify_exit:\n+\tclose(device->epoll_fd);\n+\tdevice->epoll_fd = -1;\n+\n+\treturn 1;\n+}\n+\n+static int\n+nfp_vdpa_setup_notify_relay(struct nfp_vdpa_dev *device)\n+{\n+\tint ret;\n+\tchar name[RTE_THREAD_INTERNAL_NAME_SIZE];\n+\n+\tsnprintf(name, sizeof(name), \"nfp-noti%d\", device->vid);\n+\tret = rte_thread_create_internal_control(&device->tid, name,\n+\t\t\tnfp_vdpa_notify_relay, (void *)device);\n+\tif (ret != 0) {\n+\t\tDRV_VDPA_LOG(ERR, \"Failed to create notify relay pthread.\");\n+\t\treturn -1;\n+\t}\n+\n+\treturn 0;\n+}\n+\n+static void\n+nfp_vdpa_unset_notify_relay(struct nfp_vdpa_dev *device)\n+{\n+\tif (device->tid.opaque_id != 0) {\n+\t\tpthread_cancel((pthread_t)device->tid.opaque_id);\n+\t\trte_thread_join(device->tid, NULL);\n+\t\tdevice->tid.opaque_id = 0;\n+\t}\n+\n+\tif (device->epoll_fd >= 0) {\n+\t\tclose(device->epoll_fd);\n+\t\tdevice->epoll_fd = -1;\n+\t}\n+}\n+\n static int\n update_datapath(struct nfp_vdpa_dev *device)\n {\n@@ -392,12 +539,18 @@ update_datapath(struct nfp_vdpa_dev *device)\n \t\tif (ret != 0)\n \t\t\tgoto disable_vfio_intr;\n \n+\t\tret = nfp_vdpa_setup_notify_relay(device);\n+\t\tif (ret != 0)\n+\t\t\tgoto vdpa_stop;\n+\n \t\trte_atomic_store_explicit(&device->running, 1, rte_memory_order_relaxed);\n \t} else if ((rte_atomic_load_explicit(&device->running, rte_memory_order_relaxed) != 0) &&\n \t\t\t((rte_atomic_load_explicit(&device->started,\n \t\t\t\t\trte_memory_order_relaxed) != 0) ||\n \t\t\t(rte_atomic_load_explicit(&device->dev_attached,\n \t\t\t\t\trte_memory_order_relaxed) != 0))) {\n+\t\tnfp_vdpa_unset_notify_relay(device);\n+\n \t\tnfp_vdpa_stop(device);\n \n \t\tret = nfp_vdpa_disable_vfio_intr(device);\n@@ -414,6 +567,8 @@ update_datapath(struct nfp_vdpa_dev *device)\n \trte_spinlock_unlock(&device->lock);\n \treturn 0;\n \n+vdpa_stop:\n+\tnfp_vdpa_stop(device);\n disable_vfio_intr:\n \tnfp_vdpa_disable_vfio_intr(device);\n dma_map_rollback:\ndiff --git a/drivers/vdpa/nfp/nfp_vdpa_core.c b/drivers/vdpa/nfp/nfp_vdpa_core.c\nindex db9b8462b4..e2a6253ae5 100644\n--- a/drivers/vdpa/nfp/nfp_vdpa_core.c\n+++ b/drivers/vdpa/nfp/nfp_vdpa_core.c\n@@ -15,6 +15,41 @@\n #define VIRTIO_F_IN_ORDER 35\n #endif\n \n+#define NFP_QCP_NOTIFY_MAX_ADD 0x7f\n+\n+enum nfp_qcp_notify_ptr {\n+\tNFP_QCP_NOTIFY_WRITE_PTR = 0,\n+\tNFP_QCP_NOTIFY_READ_PTR\n+};\n+\n+/**\n+ * Add the value to the selected pointer of a queue\n+ *\n+ * @param queue\n+ * Base address for queue structure\n+ * @param ptr\n+ * Add to the Read or Write pointer\n+ * @param val\n+ * Value to add to the queue pointer\n+ */\n+static inline void\n+nfp_qcp_notify_ptr_add(uint8_t *q,\n+\t\tenum nfp_qcp_notify_ptr ptr,\n+\t\tuint32_t val)\n+{\n+\tuint32_t off;\n+\n+\tif (ptr == NFP_QCP_NOTIFY_WRITE_PTR)\n+\t\toff = NFP_QCP_QUEUE_ADD_RPTR;\n+\telse\n+\t\toff = NFP_QCP_QUEUE_ADD_WPTR;\n+\n+\tfor (; val > NFP_QCP_NOTIFY_MAX_ADD; val -= NFP_QCP_NOTIFY_MAX_ADD)\n+\t\tnn_writel(rte_cpu_to_le_32(NFP_QCP_NOTIFY_MAX_ADD), q + off);\n+\n+\tnn_writel(rte_cpu_to_le_32(val), q + off);\n+}\n+\n int\n nfp_vdpa_hw_init(struct nfp_vdpa_hw *vdpa_hw,\n \t\tstruct rte_pci_device *pci_dev)\n@@ -130,3 +165,29 @@ nfp_vdpa_hw_stop(struct nfp_vdpa_hw *vdpa_hw)\n {\n \tnfp_disable_queues(&vdpa_hw->super);\n }\n+\n+/*\n+ * This offset is used for mmaping the notify area. It implies it needs\n+ * to be a multiple of PAGE_SIZE.\n+ * For debugging, using notify region 0 with an offset of 4K. This should\n+ * point to the conf bar.\n+ */\n+uint64_t\n+nfp_vdpa_get_queue_notify_offset(struct nfp_vdpa_hw *vdpa_hw __rte_unused,\n+\t\tint qid)\n+{\n+\treturn NFP_VDPA_NOTIFY_ADDR_BASE + (qid * NFP_VDPA_NOTIFY_ADDR_INTERVAL);\n+}\n+\n+/*\n+ * With just one queue the increment is 0, which does not\n+ * incremente the counter but will raise a queue event due\n+ * to queue configured for watermark events.\n+ */\n+void\n+nfp_vdpa_notify_queue(struct nfp_vdpa_hw *vdpa_hw,\n+\t\tuint16_t qid)\n+{\n+\tnfp_qcp_notify_ptr_add(vdpa_hw->notify_addr[qid],\n+\t\t\tNFP_QCP_NOTIFY_WRITE_PTR, qid);\n+}\ndiff --git a/drivers/vdpa/nfp/nfp_vdpa_core.h b/drivers/vdpa/nfp/nfp_vdpa_core.h\nindex a88de768dd..a8e0d6dd70 100644\n--- a/drivers/vdpa/nfp/nfp_vdpa_core.h\n+++ b/drivers/vdpa/nfp/nfp_vdpa_core.h\n@@ -44,4 +44,8 @@ int nfp_vdpa_hw_start(struct nfp_vdpa_hw *vdpa_hw, int vid);\n \n void nfp_vdpa_hw_stop(struct nfp_vdpa_hw *vdpa_hw);\n \n+void nfp_vdpa_notify_queue(struct nfp_vdpa_hw *vdpa_hw, uint16_t qid);\n+\n+uint64_t nfp_vdpa_get_queue_notify_offset(struct nfp_vdpa_hw *vdpa_hw, int qid);\n+\n #endif /* __NFP_VDPA_CORE_H__ */\n", "prefixes": [ "v3", "23/25" ] }