Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/133348/?format=api
{ "id": 133348, "url": "http://patches.dpdk.org/api/patches/133348/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20231026064324.177531-9-chaoyong.he@corigine.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20231026064324.177531-9-chaoyong.he@corigine.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20231026064324.177531-9-chaoyong.he@corigine.com", "date": "2023-10-26T06:43:07", "name": "[v3,08/25] net/nfp: extract the ctrl data field", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": true, "hash": "84099b7d8326c3b153f5cf228a9aece33ddcf8a9", "submitter": { "id": 2554, "url": "http://patches.dpdk.org/api/people/2554/?format=api", "name": "Chaoyong He", "email": "chaoyong.he@corigine.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20231026064324.177531-9-chaoyong.he@corigine.com/mbox/", "series": [ { "id": 29991, "url": "http://patches.dpdk.org/api/series/29991/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=29991", "date": "2023-10-26T06:42:59", "name": "add the NFP vDPA PMD", "version": 3, "mbox": "http://patches.dpdk.org/series/29991/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/133348/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/133348/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id DCB2C43204;\n\tThu, 26 Oct 2023 08:45:04 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 25D6640EE7;\n\tThu, 26 Oct 2023 08:44:07 +0200 (CEST)", "from NAM11-DM6-obe.outbound.protection.outlook.com\n (mail-dm6nam11on2131.outbound.protection.outlook.com [40.107.223.131])\n by mails.dpdk.org (Postfix) with ESMTP id DECA4410D5\n for <dev@dpdk.org>; Thu, 26 Oct 2023 08:44:00 +0200 (CEST)", "from SJ0PR13MB5545.namprd13.prod.outlook.com (2603:10b6:a03:424::5)\n by SJ0PR13MB5965.namprd13.prod.outlook.com (2603:10b6:a03:43d::10)\n with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6907.33; Thu, 26 Oct\n 2023 06:43:59 +0000", "from SJ0PR13MB5545.namprd13.prod.outlook.com\n ([fe80::45b3:d83c:cff2:4a1b]) by SJ0PR13MB5545.namprd13.prod.outlook.com\n ([fe80::45b3:d83c:cff2:4a1b%6]) with mapi id 15.20.6933.022; Thu, 26 Oct 2023\n 06:43:59 +0000" ], "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;\n b=gHxtISGMeMeWJKEWBafVQHEB3rXoXGSq5mz/dp4sBd3qoJdzIxXM0Z6IH+2yqHpR0yxoKWgGr1HC9cA6y5R7/ZtTnllwHsDPgm+ql9Awi7Jk/YDZn8KOjAnf46K1wANd8mVy//GYvnDfZn1BhDPnIFCi4BoXbv+oybXvQimFQ5zs3wdnv4n2eA0RytsraZFJLVw3PBDJ5aPSRA87XWvYIBtPOdz9tlyAmiOytCwaOTz4bZo1fHaUo0cbKgqvn370SIkJc6F9uueBtUkdMHwMD+R7NdjrdiZBu4qvIYaLZZP8OwNZ2eRzgVbTiSQrBEPQGXF68OwK+76m7tmPmbICJQ==", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector9901;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=RRhMHhn0YXvamlaXgWH2i+WpWihtdLcmMZwtXwxDeso=;\n b=QZR9T2FWNI8T2e1B1ArjI/ykaH9KN8ccBO7TTIjS8CxX4gAcEXZMdsAk0IYtxde6Gs2adAHaQRcNHtfiz88eSo0tEHazi8QPbAFkLgdFmGcEY4viE1GlvhZKb1K5yh80vG8cGNr54LAFcpKBSttvDr7vv6DiNhiFDjZCnse5CWgjVpUrr1FwrUvVAc3FtiFmM7uj38XY/3NVI8PGRnyxHbbd9VMB7vXwZeNKwU6LMmSGVIneoprr7tjggn1zzKXkMLFuUKdCgMj52PDKVeXp9jQejPto7jieWtOZwRfNMKen9MuGJq1JJ4D3rMGdvnK8YXkjKHOlFQA337+mPrWicA==", "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass\n smtp.mailfrom=corigine.com; dmarc=pass action=none header.from=corigine.com;\n dkim=pass header.d=corigine.com; arc=none", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=corigine.onmicrosoft.com; s=selector2-corigine-onmicrosoft-com;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=RRhMHhn0YXvamlaXgWH2i+WpWihtdLcmMZwtXwxDeso=;\n b=AbuMOyMVct6s4roXEkLKWU69tAl8kgM9ENujMlyswCvv/brvK3dTmpR0p0kUdQP42f37Hr2V4GqpMtJmurbmlWC0I62DQ+XhrQKuogk/ekhdXMroaSsOF/b02EBHa+k+FZSEFUujayVA5N318fagD8vfsWbzNqIrtsDJ6qz86Zs=", "Authentication-Results": "dkim=none (message not signed)\n header.d=none;dmarc=none action=none header.from=corigine.com;", "From": "Chaoyong He <chaoyong.he@corigine.com>", "To": "dev@dpdk.org", "Cc": "oss-drivers@corigine.com, Chaoyong He <chaoyong.he@corigine.com>,\n Long Wu <long.wu@corigine.com>, Peng Zhang <peng.zhang@corigine.com>", "Subject": "[PATCH v3 08/25] net/nfp: extract the ctrl data field", "Date": "Thu, 26 Oct 2023 14:43:07 +0800", "Message-Id": "<20231026064324.177531-9-chaoyong.he@corigine.com>", "X-Mailer": "git-send-email 2.39.1", "In-Reply-To": "<20231026064324.177531-1-chaoyong.he@corigine.com>", "References": "<20231024022849.3092506-1-chaoyong.he@corigine.com>\n <20231026064324.177531-1-chaoyong.he@corigine.com>", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-ClientProxiedBy": "BYAPR07CA0034.namprd07.prod.outlook.com\n (2603:10b6:a02:bc::47) To SJ0PR13MB5545.namprd13.prod.outlook.com\n (2603:10b6:a03:424::5)", "MIME-Version": "1.0", "X-MS-PublicTrafficType": "Email", "X-MS-TrafficTypeDiagnostic": "SJ0PR13MB5545:EE_|SJ0PR13MB5965:EE_", "X-MS-Office365-Filtering-Correlation-Id": "42b23607-79b6-4002-8342-08dbd5eeeee4", "X-MS-Exchange-SenderADCheck": "1", "X-MS-Exchange-AntiSpam-Relay": "0", "X-Microsoft-Antispam": "BCL:0;", "X-Microsoft-Antispam-Message-Info": "\n 1gPC9g9U1F5oSXmDZue/4MR6BaHb6aXNoe19wIW2eSK6gidaqsYUSPjLrj+SNOwty3n6uc5WINwgrJFK/aAg5V4j4vLwcLPXEaZ4v+PFNTxmzuBHGqTRLRIy582BLmbUsTa2QhK/fVq3sUuUmPJEH64i+i15URzsCcI0UnfCjMoAlRVAOu4BukwscrlS8Fe/+0SZ3/IeetPcXbHmIDs9J2JO194elUOyCqPLjull+g4gWEvfg9ibQVyw7B9/gQJ6yjdlBID438xpZ13ujAmkjEOJuK2YGGSXVHwZuNP7RnuASvH6TuCAo8PK/3VGIxV7ItZO5yrtj9GS1g7fTstVXzcxjh2M4eSPhyMJZ7J0eZteLvGoau/KPtq1ieC2sUwm09QRtreEH0eB4gOPgfU13lDEL+h8UmSnQnudqFO97EQ7m6NLYqVLUzeghOtC4XIqsNHQ6yC3VESHYO1xkFk89CxzQoHLCMFDsLCUkjqrtXKGqwFuQmJ4s9rjaE682rKhTEe0iCmozDlmDY+fkDKzaGuxDH56zNe6iuaHQnnWG0q7TWCEjleJsedDkWd5rIrP3ZltmfZmF8rOZdYRyvnJFe2pmoZVRToEWI4xmUeqoIwBY00HQEYNzqB/K3vNE06QK7p32E0v4HsvFCf/1ACwsJ6Lv6qLuFXFDt2e6Cpub9k=", "X-Forefront-Antispam-Report": "CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;\n IPV:NLI; SFV:NSPM; H:SJ0PR13MB5545.namprd13.prod.outlook.com; PTR:; CAT:NONE;\n SFS:(13230031)(346002)(39830400003)(136003)(366004)(376002)(396003)(230922051799003)(64100799003)(186009)(1800799009)(451199024)(6512007)(478600001)(6506007)(52116002)(2616005)(8676002)(83380400001)(107886003)(30864003)(41300700001)(26005)(1076003)(6486002)(5660300002)(6666004)(44832011)(6916009)(316002)(66556008)(54906003)(66476007)(66946007)(2906002)(4326008)(8936002)(38350700005)(38100700002)(86362001)(36756003);\n DIR:OUT; SFP:1102;", "X-MS-Exchange-AntiSpam-MessageData-ChunkCount": "1", "X-MS-Exchange-AntiSpam-MessageData-0": "\n 7c56R/onAaxDGlGh9Z2G94vq8UXLkYr0ZBewsKshQcSqbGiy5l8REje2lRIIcj3GoxaWaf5VNPPtj/WvW1Lv0JtIZNtP4GGIa8CVE4kfOm8lWnZK2suVqmshjy/omYlYy2spOPt8yMeR3u5cNY6flInLEd0/zzOmm3n4jmCRxRJ7sFdxDRm+lnrxRismJY9iEp9oDJAVehJ1XTII6rQZUAjA3cgKqahRpmx+kgsuhr1VEg6OWegaN9eTmR72hg6r+N58gdtoNy0JaFEREmLueh2dZncxwTdBAwGj5Zq16q9CMzhZofecpPuUdPl5ukEWFG/694LJJXOaZRQajoGa1/yUQEcV/BMfLvXK0LG3rmzZqE0AYVzEfsnNCQMEE0bDQqISvOB6OxkDqgZMRyn3rgEGb+bSs+1X3azrlWzBn2iszKguYHkHV0brw/h6THJCz2wHONJNGwmJ0i8mL1DwEPFA0Vgn89FYdOuEXp8CKmwINtpULbrtNqafBg227IaGS6PL4gWfZB8YqQ5RvXf8V34coH5z3HUPdYhWLYTd1OVb8MFJKM3+MENTSMQySNy7JNPRHO4R2rd26rkMBIJbpvVCWesUdfT1eS69oyV9uwTzw1TMPB7w+yOMAwwNoe+qf/QTOuVv0NMCRNa7Oxx0LBGiWQo7Z4XhEMRz7Rc/86DSxKqRW4ssDBykzqXCsEo7mQqE3+PadVnfgrSlg7rBfp4eS5WCUtz6ioh5kVuLB4QjPSEaMzcQuHRV3s/AzVZVC4ihd638Ig0QcpHOrrWh9aDsiqqtWF7WMlVRldnvxXsTTgfx7HIj8qV6BDgOYExWgZWyaR7Zuo9bbnPMQZP1fqJidQjHYaE98O3TNhiu5FVgoIU7e8toe7Uk7md4SmKJ0neSLoq9U7Fi1O7cgDJ0HUhnrHIV8DGTpQa+RLfO+S4/1i0q75ebUrE7hiAzBBoFnD7EXdMv8yrYSZ7S613Q5Ea6gxgLf5DkJX1v+SYyL+URB4YikHlIPFWqcTWpbITTV9p279yiaBu+T8cQ8b2Dix3rmaVPwGUAAzAfj89oLGYE+aDfN7mY/5ykGYNGU75G7wd60j865p23iwTbUBWPJdLtA5mG3dxZDJDXvlMItJYsNyZpPEwp4FUCcV9jSirojXbkqJ68hVxq+QhwlRcG6X48naM+MvhgptaRhHWCe/P4O3eYopRRzY2yJBL9+Atw0/SKN9/iTeTzHD/PVjllhqEsHqdD3OePIkKF1HmH4BYQe+/qY+aSSPWzeCUeRYLUfH7M/NCuhCBBHzB9t11GS/2OJv0Y69MJ23P0YeFDgrZzXM5Cn/C7Qi7CmiMhpCTe0xkC0bJ63aFP5aq1Gn5i4wslxe9C4ovQ4u1Ay6v6NX45Xt0librCqkLP916mANyanxJYXvPYvt5C60kZf5S72GR2+LQN4QGDeW8RTu+oafH2ghjsyP3xlabupvL/YZLdVaHZ8whXpN1BgmEikISVU80ddCIgwK9FE4f6VGkmjhPnSHYC5EoRRfr38eOgG4gJeZru7cJ359vHWQAL0kHlcZMa3OuIj1RPAEeKNtXWD0azbjONFpopUykAG9jifW/R224onbHCeOU0anYJSx2ZWA==", "X-OriginatorOrg": "corigine.com", "X-MS-Exchange-CrossTenant-Network-Message-Id": "\n 42b23607-79b6-4002-8342-08dbd5eeeee4", "X-MS-Exchange-CrossTenant-AuthSource": "SJ0PR13MB5545.namprd13.prod.outlook.com", "X-MS-Exchange-CrossTenant-AuthAs": "Internal", "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "26 Oct 2023 06:43:59.2819 (UTC)", "X-MS-Exchange-CrossTenant-FromEntityHeader": "Hosted", "X-MS-Exchange-CrossTenant-Id": "fe128f2c-073b-4c20-818e-7246a585940c", "X-MS-Exchange-CrossTenant-MailboxType": "HOSTED", "X-MS-Exchange-CrossTenant-UserPrincipalName": "\n /+CsF49BihnEztXHefDDM/kC30MJ/79laBrFGlglTbuhSfk9W0S6ITxrVVeIgHiVrhWGs5cH1ndRAL7yHrPquW67FpoKunOfXv7eZI0HdfA=", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "SJ0PR13MB5965", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Extract the 'ctrl' data filed into the super class, prepare for the\nupcoming common library.\n\nSigned-off-by: Chaoyong He <chaoyong.he@corigine.com>\nReviewed-by: Long Wu <long.wu@corigine.com>\nReviewed-by: Peng Zhang <peng.zhang@corigine.com>\n---\n drivers/net/nfp/flower/nfp_flower.c | 8 ++---\n drivers/net/nfp/nfd3/nfp_nfd3_dp.c | 2 +-\n drivers/net/nfp/nfdk/nfp_nfdk_dp.c | 2 +-\n drivers/net/nfp/nfp_ethdev.c | 4 ++-\n drivers/net/nfp/nfp_ethdev_vf.c | 2 +-\n drivers/net/nfp/nfp_net_common.c | 46 ++++++++++++++---------------\n drivers/net/nfp/nfp_net_common.h | 5 ++--\n drivers/net/nfp/nfp_rxtx.c | 12 ++++----\n 8 files changed, 41 insertions(+), 40 deletions(-)", "diff": "diff --git a/drivers/net/nfp/flower/nfp_flower.c b/drivers/net/nfp/flower/nfp_flower.c\nindex c8455e0241..8bb5914888 100644\n--- a/drivers/net/nfp/flower/nfp_flower.c\n+++ b/drivers/net/nfp/flower/nfp_flower.c\n@@ -61,7 +61,7 @@ nfp_pf_repr_disable_queues(struct rte_eth_dev *dev)\n \tnn_cfg_writeq(hw, NFP_NET_CFG_TXRS_ENABLE, 0);\n \tnn_cfg_writeq(hw, NFP_NET_CFG_RXRS_ENABLE, 0);\n \n-\tnew_ctrl = hw->ctrl & ~NFP_NET_CFG_CTRL_ENABLE;\n+\tnew_ctrl = hw->super.ctrl & ~NFP_NET_CFG_CTRL_ENABLE;\n \tupdate = NFP_NET_CFG_UPDATE_GEN | NFP_NET_CFG_UPDATE_RING |\n \t\t\tNFP_NET_CFG_UPDATE_MSIX;\n \n@@ -72,7 +72,7 @@ nfp_pf_repr_disable_queues(struct rte_eth_dev *dev)\n \tif (nfp_net_reconfig(hw, new_ctrl, update) != 0)\n \t\treturn;\n \n-\thw->ctrl = new_ctrl;\n+\thw->super.ctrl = new_ctrl;\n }\n \n int\n@@ -123,7 +123,7 @@ nfp_flower_pf_start(struct rte_eth_dev *dev)\n \t\treturn -EIO;\n \t}\n \n-\thw->ctrl = new_ctrl;\n+\thw->super.ctrl = new_ctrl;\n \n \t/* Setup the freelist ring */\n \tret = nfp_net_rx_freelist_setup(dev);\n@@ -721,7 +721,7 @@ nfp_flower_start_ctrl_vnic(struct nfp_net_hw *hw)\n \t\treturn -EIO;\n \t}\n \n-\thw->ctrl = new_ctrl;\n+\thw->super.ctrl = new_ctrl;\n \n \t/* Setup the freelist ring */\n \tret = nfp_net_rx_freelist_setup(dev);\ndiff --git a/drivers/net/nfp/nfd3/nfp_nfd3_dp.c b/drivers/net/nfp/nfd3/nfp_nfd3_dp.c\nindex bbf4530ae9..3045533857 100644\n--- a/drivers/net/nfp/nfd3/nfp_nfd3_dp.c\n+++ b/drivers/net/nfp/nfd3/nfp_nfd3_dp.c\n@@ -154,7 +154,7 @@ nfp_net_nfd3_set_meta_data(struct nfp_net_meta_raw *meta_data,\n \tcap_extend = hw->super.cap_ext;\n \n \tif ((pkt->ol_flags & RTE_MBUF_F_TX_VLAN) != 0 &&\n-\t\t\t(hw->ctrl & NFP_NET_CFG_CTRL_TXVLAN_V2) != 0) {\n+\t\t\t(hw->super.ctrl & NFP_NET_CFG_CTRL_TXVLAN_V2) != 0) {\n \t\tif (meta_data->length == 0)\n \t\t\tmeta_data->length = NFP_NET_META_HEADER_SIZE;\n \t\tmeta_data->length += NFP_NET_META_FIELD_SIZE;\ndiff --git a/drivers/net/nfp/nfdk/nfp_nfdk_dp.c b/drivers/net/nfp/nfdk/nfp_nfdk_dp.c\nindex 807666686f..63421ba796 100644\n--- a/drivers/net/nfp/nfdk/nfp_nfdk_dp.c\n+++ b/drivers/net/nfp/nfdk/nfp_nfdk_dp.c\n@@ -187,7 +187,7 @@ nfp_net_nfdk_set_meta_data(struct rte_mbuf *pkt,\n \tcap_extend = hw->super.cap_ext;\n \n \tif ((pkt->ol_flags & RTE_MBUF_F_TX_VLAN) != 0 &&\n-\t\t\t(hw->ctrl & NFP_NET_CFG_CTRL_TXVLAN_V2) != 0) {\n+\t\t\t(hw->super.ctrl & NFP_NET_CFG_CTRL_TXVLAN_V2) != 0) {\n \t\tif (meta_data.length == 0)\n \t\t\tmeta_data.length = NFP_NET_META_HEADER_SIZE;\n \t\tmeta_data.length += NFP_NET_META_FIELD_SIZE;\ndiff --git a/drivers/net/nfp/nfp_ethdev.c b/drivers/net/nfp/nfp_ethdev.c\nindex b7c60b642f..0f6f97be8e 100644\n--- a/drivers/net/nfp/nfp_ethdev.c\n+++ b/drivers/net/nfp/nfp_ethdev.c\n@@ -152,6 +152,8 @@ nfp_net_start(struct rte_eth_dev *dev)\n \tif (nfp_net_ext_reconfig(hw, ctrl_extend, update) != 0)\n \t\treturn -EIO;\n \n+\thw->super.ctrl_ext = ctrl_extend;\n+\n \t/*\n \t * Allocating rte mbufs for configured rx queues.\n \t * This requires queues being enabled before.\n@@ -167,7 +169,7 @@ nfp_net_start(struct rte_eth_dev *dev)\n \telse\n \t\tnfp_eth_set_configured(dev->process_private, hw->nfp_idx, 1);\n \n-\thw->ctrl = new_ctrl;\n+\thw->super.ctrl = new_ctrl;\n \n \tfor (i = 0; i < dev->data->nb_rx_queues; i++)\n \t\tdev->data->rx_queue_state[i] = RTE_ETH_QUEUE_STATE_STARTED;\ndiff --git a/drivers/net/nfp/nfp_ethdev_vf.c b/drivers/net/nfp/nfp_ethdev_vf.c\nindex 641fed6fcf..684968903c 100644\n--- a/drivers/net/nfp/nfp_ethdev_vf.c\n+++ b/drivers/net/nfp/nfp_ethdev_vf.c\n@@ -110,7 +110,7 @@ nfp_netvf_start(struct rte_eth_dev *dev)\n \t\tgoto error;\n \t}\n \n-\thw->ctrl = new_ctrl;\n+\thw->super.ctrl = new_ctrl;\n \n \tfor (i = 0; i < dev->data->nb_rx_queues; i++)\n \t\tdev->data->rx_queue_state[i] = RTE_ETH_QUEUE_STATE_STARTED;\ndiff --git a/drivers/net/nfp/nfp_net_common.c b/drivers/net/nfp/nfp_net_common.c\nindex 29f836c31e..058260bda3 100644\n--- a/drivers/net/nfp/nfp_net_common.c\n+++ b/drivers/net/nfp/nfp_net_common.c\n@@ -500,7 +500,7 @@ nfp_net_disable_queues(struct rte_eth_dev *dev)\n \tnn_cfg_writeq(hw, NFP_NET_CFG_TXRS_ENABLE, 0);\n \tnn_cfg_writeq(hw, NFP_NET_CFG_RXRS_ENABLE, 0);\n \n-\tnew_ctrl = hw->ctrl & ~NFP_NET_CFG_CTRL_ENABLE;\n+\tnew_ctrl = hw->super.ctrl & ~NFP_NET_CFG_CTRL_ENABLE;\n \tupdate = NFP_NET_CFG_UPDATE_GEN |\n \t\t\tNFP_NET_CFG_UPDATE_RING |\n \t\t\tNFP_NET_CFG_UPDATE_MSIX;\n@@ -512,7 +512,7 @@ nfp_net_disable_queues(struct rte_eth_dev *dev)\n \tif (nfp_net_reconfig(hw, new_ctrl, update) != 0)\n \t\treturn;\n \n-\thw->ctrl = new_ctrl;\n+\thw->super.ctrl = new_ctrl;\n }\n \n void\n@@ -553,7 +553,7 @@ nfp_net_set_mac_addr(struct rte_eth_dev *dev,\n \tstruct nfp_net_hw *hw;\n \n \thw = NFP_NET_DEV_PRIVATE_TO_HW(dev->data->dev_private);\n-\tif ((hw->ctrl & NFP_NET_CFG_CTRL_ENABLE) != 0 &&\n+\tif ((hw->super.ctrl & NFP_NET_CFG_CTRL_ENABLE) != 0 &&\n \t\t\t(hw->super.cap & NFP_NET_CFG_CTRL_LIVE_ADDR) == 0) {\n \t\tPMD_DRV_LOG(ERR, \"MAC address unable to change when port enabled\");\n \t\treturn -EBUSY;\n@@ -563,8 +563,8 @@ nfp_net_set_mac_addr(struct rte_eth_dev *dev,\n \tnfp_net_write_mac(hw, (uint8_t *)mac_addr);\n \n \tupdate = NFP_NET_CFG_UPDATE_MACADDR;\n-\tctrl = hw->ctrl;\n-\tif ((hw->ctrl & NFP_NET_CFG_CTRL_ENABLE) != 0 &&\n+\tctrl = hw->super.ctrl;\n+\tif ((hw->super.ctrl & NFP_NET_CFG_CTRL_ENABLE) != 0 &&\n \t\t\t(hw->super.cap & NFP_NET_CFG_CTRL_LIVE_ADDR) != 0)\n \t\tctrl |= NFP_NET_CFG_CTRL_LIVE_ADDR;\n \n@@ -613,7 +613,7 @@ nfp_configure_rx_interrupt(struct rte_eth_dev *dev,\n \t}\n \n \t/* Avoiding TX interrupts */\n-\thw->ctrl |= NFP_NET_CFG_CTRL_MSIX_TX_OFF;\n+\thw->super.ctrl |= NFP_NET_CFG_CTRL_MSIX_TX_OFF;\n \treturn 0;\n }\n \n@@ -705,19 +705,19 @@ nfp_net_promisc_enable(struct rte_eth_dev *dev)\n \t\treturn -ENOTSUP;\n \t}\n \n-\tif ((hw->ctrl & NFP_NET_CFG_CTRL_PROMISC) != 0) {\n+\tif ((hw->super.ctrl & NFP_NET_CFG_CTRL_PROMISC) != 0) {\n \t\tPMD_DRV_LOG(INFO, \"Promiscuous mode already enabled\");\n \t\treturn 0;\n \t}\n \n-\tnew_ctrl = hw->ctrl | NFP_NET_CFG_CTRL_PROMISC;\n+\tnew_ctrl = hw->super.ctrl | NFP_NET_CFG_CTRL_PROMISC;\n \tupdate = NFP_NET_CFG_UPDATE_GEN;\n \n \tret = nfp_net_reconfig(hw, new_ctrl, update);\n \tif (ret != 0)\n \t\treturn ret;\n \n-\thw->ctrl = new_ctrl;\n+\thw->super.ctrl = new_ctrl;\n \n \treturn 0;\n }\n@@ -732,19 +732,19 @@ nfp_net_promisc_disable(struct rte_eth_dev *dev)\n \n \thw = NFP_NET_DEV_PRIVATE_TO_HW(dev->data->dev_private);\n \n-\tif ((hw->ctrl & NFP_NET_CFG_CTRL_PROMISC) == 0) {\n+\tif ((hw->super.ctrl & NFP_NET_CFG_CTRL_PROMISC) == 0) {\n \t\tPMD_DRV_LOG(INFO, \"Promiscuous mode already disabled\");\n \t\treturn 0;\n \t}\n \n-\tnew_ctrl = hw->ctrl & ~NFP_NET_CFG_CTRL_PROMISC;\n+\tnew_ctrl = hw->super.ctrl & ~NFP_NET_CFG_CTRL_PROMISC;\n \tupdate = NFP_NET_CFG_UPDATE_GEN;\n \n \tret = nfp_net_reconfig(hw, new_ctrl, update);\n \tif (ret != 0)\n \t\treturn ret;\n \n-\thw->ctrl = new_ctrl;\n+\thw->super.ctrl = new_ctrl;\n \n \treturn 0;\n }\n@@ -1349,7 +1349,7 @@ nfp_net_common_init(struct rte_pci_device *pci_dev,\n \telse\n \t\thw->rx_offset = nn_cfg_readl(hw, NFP_NET_CFG_RX_OFFSET_ADDR);\n \n-\thw->ctrl = 0;\n+\thw->super.ctrl = 0;\n \thw->stride_rx = stride;\n \thw->stride_tx = stride;\n \n@@ -1453,7 +1453,7 @@ nfp_net_irq_unmask(struct rte_eth_dev *dev)\n \t/* Make sure all updates are written before un-masking */\n \trte_wmb();\n \n-\tif ((hw->ctrl & NFP_NET_CFG_CTRL_MSIXAUTO) != 0) {\n+\tif ((hw->super.ctrl & NFP_NET_CFG_CTRL_MSIXAUTO) != 0) {\n \t\t/* If MSI-X auto-masking is used, clear the entry */\n \t\trte_intr_ack(pci_dev->intr_handle);\n \t} else {\n@@ -1559,7 +1559,7 @@ nfp_net_vlan_offload_set(struct rte_eth_dev *dev,\n \n \thw = NFP_NET_DEV_PRIVATE_TO_HW(dev->data->dev_private);\n \trx_offload = dev->data->dev_conf.rxmode.offloads;\n-\tnew_ctrl = hw->ctrl;\n+\tnew_ctrl = hw->super.ctrl;\n \n \t/* VLAN stripping setting */\n \tif ((mask & RTE_ETH_VLAN_STRIP_MASK) != 0) {\n@@ -1578,7 +1578,7 @@ nfp_net_vlan_offload_set(struct rte_eth_dev *dev,\n \t\t\tnew_ctrl &= ~NFP_NET_CFG_CTRL_RXQINQ;\n \t}\n \n-\tif (new_ctrl == hw->ctrl)\n+\tif (new_ctrl == hw->super.ctrl)\n \t\treturn 0;\n \n \tupdate = NFP_NET_CFG_UPDATE_GEN;\n@@ -1587,7 +1587,7 @@ nfp_net_vlan_offload_set(struct rte_eth_dev *dev,\n \tif (ret != 0)\n \t\treturn ret;\n \n-\thw->ctrl = new_ctrl;\n+\thw->super.ctrl = new_ctrl;\n \n \treturn 0;\n }\n@@ -1660,7 +1660,7 @@ nfp_net_reta_update(struct rte_eth_dev *dev,\n \tstruct nfp_net_hw *hw;\n \n \thw = NFP_NET_DEV_PRIVATE_TO_HW(dev->data->dev_private);\n-\tif ((hw->ctrl & NFP_NET_CFG_CTRL_RSS_ANY) == 0)\n+\tif ((hw->super.ctrl & NFP_NET_CFG_CTRL_RSS_ANY) == 0)\n \t\treturn -EINVAL;\n \n \tret = nfp_net_rss_reta_write(dev, reta_conf, reta_size);\n@@ -1669,7 +1669,7 @@ nfp_net_reta_update(struct rte_eth_dev *dev,\n \n \tupdate = NFP_NET_CFG_UPDATE_RSS;\n \n-\tif (nfp_net_reconfig(hw, hw->ctrl, update) != 0)\n+\tif (nfp_net_reconfig(hw, hw->super.ctrl, update) != 0)\n \t\treturn -EIO;\n \n \treturn 0;\n@@ -1690,7 +1690,7 @@ nfp_net_reta_query(struct rte_eth_dev *dev,\n \tstruct nfp_net_hw *hw;\n \n \thw = NFP_NET_DEV_PRIVATE_TO_HW(dev->data->dev_private);\n-\tif ((hw->ctrl & NFP_NET_CFG_CTRL_RSS_ANY) == 0)\n+\tif ((hw->super.ctrl & NFP_NET_CFG_CTRL_RSS_ANY) == 0)\n \t\treturn -EINVAL;\n \n \tif (reta_size != NFP_NET_CFG_RSS_ITBL_SZ) {\n@@ -1795,7 +1795,7 @@ nfp_net_rss_hash_update(struct rte_eth_dev *dev,\n \trss_hf = rss_conf->rss_hf;\n \n \t/* Checking if RSS is enabled */\n-\tif ((hw->ctrl & NFP_NET_CFG_CTRL_RSS_ANY) == 0) {\n+\tif ((hw->super.ctrl & NFP_NET_CFG_CTRL_RSS_ANY) == 0) {\n \t\tif (rss_hf != 0) {\n \t\t\tPMD_DRV_LOG(ERR, \"RSS unsupported\");\n \t\t\treturn -EINVAL;\n@@ -1813,7 +1813,7 @@ nfp_net_rss_hash_update(struct rte_eth_dev *dev,\n \n \tupdate = NFP_NET_CFG_UPDATE_RSS;\n \n-\tif (nfp_net_reconfig(hw, hw->ctrl, update) != 0)\n+\tif (nfp_net_reconfig(hw, hw->super.ctrl, update) != 0)\n \t\treturn -EIO;\n \n \treturn 0;\n@@ -1831,7 +1831,7 @@ nfp_net_rss_hash_conf_get(struct rte_eth_dev *dev,\n \n \thw = NFP_NET_DEV_PRIVATE_TO_HW(dev->data->dev_private);\n \n-\tif ((hw->ctrl & NFP_NET_CFG_CTRL_RSS_ANY) == 0)\n+\tif ((hw->super.ctrl & NFP_NET_CFG_CTRL_RSS_ANY) == 0)\n \t\treturn -EINVAL;\n \n \trss_hf = rss_conf->rss_hf;\ndiff --git a/drivers/net/nfp/nfp_net_common.h b/drivers/net/nfp/nfp_net_common.h\nindex dd62ec6d83..3fb3b34613 100644\n--- a/drivers/net/nfp/nfp_net_common.h\n+++ b/drivers/net/nfp/nfp_net_common.h\n@@ -117,6 +117,8 @@ struct nfp_hw {\n \tuint8_t *qcp_cfg;\n \tuint32_t cap;\n \tuint32_t cap_ext;\n+\tuint32_t ctrl;\n+\tuint32_t ctrl_ext;\n };\n \n struct nfp_net_hw {\n@@ -139,9 +141,6 @@ struct nfp_net_hw {\n \t/** NFP ASIC params */\n \tconst struct nfp_dev_info *dev_info;\n \n-\t/** Current values for control */\n-\tuint32_t ctrl;\n-\n \tuint8_t *tx_bar;\n \tuint8_t *rx_bar;\n \ndiff --git a/drivers/net/nfp/nfp_rxtx.c b/drivers/net/nfp/nfp_rxtx.c\nindex a0c7e0e9b5..a9dd464a6a 100644\n--- a/drivers/net/nfp/nfp_rxtx.c\n+++ b/drivers/net/nfp/nfp_rxtx.c\n@@ -143,7 +143,7 @@ nfp_net_rx_cksum(struct nfp_net_rxq *rxq,\n {\n \tstruct nfp_net_hw *hw = rxq->hw;\n \n-\tif ((hw->ctrl & NFP_NET_CFG_CTRL_RXCSUM) == 0)\n+\tif ((hw->super.ctrl & NFP_NET_CFG_CTRL_RXCSUM) == 0)\n \t\treturn;\n \n \t/* If IPv4 and IP checksum error, fail */\n@@ -307,7 +307,7 @@ nfp_net_parse_meta_hash(const struct nfp_meta_parsed *meta,\n {\n \tstruct nfp_net_hw *hw = rxq->hw;\n \n-\tif ((hw->ctrl & NFP_NET_CFG_CTRL_RSS_ANY) == 0)\n+\tif ((hw->super.ctrl & NFP_NET_CFG_CTRL_RSS_ANY) == 0)\n \t\treturn;\n \n \tmbuf->hash.rss = meta->hash;\n@@ -339,7 +339,7 @@ nfp_net_parse_meta_vlan(const struct nfp_meta_parsed *meta,\n \tstruct nfp_net_hw *hw = rxq->hw;\n \n \t/* Skip if firmware don't support setting vlan. */\n-\tif ((hw->ctrl & (NFP_NET_CFG_CTRL_RXVLAN | NFP_NET_CFG_CTRL_RXVLAN_V2)) == 0)\n+\tif ((hw->super.ctrl & (NFP_NET_CFG_CTRL_RXVLAN | NFP_NET_CFG_CTRL_RXVLAN_V2)) == 0)\n \t\treturn;\n \n \t/*\n@@ -347,12 +347,12 @@ nfp_net_parse_meta_vlan(const struct nfp_meta_parsed *meta,\n \t * 1. Using the metadata when NFP_NET_CFG_CTRL_RXVLAN_V2 is set,\n \t * 2. Using the descriptor when NFP_NET_CFG_CTRL_RXVLAN is set.\n \t */\n-\tif ((hw->ctrl & NFP_NET_CFG_CTRL_RXVLAN_V2) != 0) {\n+\tif ((hw->super.ctrl & NFP_NET_CFG_CTRL_RXVLAN_V2) != 0) {\n \t\tif (meta->vlan_layer > 0 && meta->vlan[0].offload != 0) {\n \t\t\tmb->vlan_tci = rte_cpu_to_le_32(meta->vlan[0].tci);\n \t\t\tmb->ol_flags |= RTE_MBUF_F_RX_VLAN | RTE_MBUF_F_RX_VLAN_STRIPPED;\n \t\t}\n-\t} else if ((hw->ctrl & NFP_NET_CFG_CTRL_RXVLAN) != 0) {\n+\t} else if ((hw->super.ctrl & NFP_NET_CFG_CTRL_RXVLAN) != 0) {\n \t\tif ((rxd->rxd.flags & PCIE_DESC_RX_VLAN) != 0) {\n \t\t\tmb->vlan_tci = rte_cpu_to_le_32(rxd->rxd.offload_info);\n \t\t\tmb->ol_flags |= RTE_MBUF_F_RX_VLAN | RTE_MBUF_F_RX_VLAN_STRIPPED;\n@@ -385,7 +385,7 @@ nfp_net_parse_meta_qinq(const struct nfp_meta_parsed *meta,\n {\n \tstruct nfp_net_hw *hw = rxq->hw;\n \n-\tif ((hw->ctrl & NFP_NET_CFG_CTRL_RXQINQ) == 0 ||\n+\tif ((hw->super.ctrl & NFP_NET_CFG_CTRL_RXQINQ) == 0 ||\n \t\t\t(hw->super.cap & NFP_NET_CFG_CTRL_RXQINQ) == 0)\n \t\treturn;\n \n", "prefixes": [ "v3", "08/25" ] }