Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/133328/?format=api
{ "id": 133328, "url": "http://patches.dpdk.org/api/patches/133328/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1698280314-25861-8-git-send-email-roretzla@linux.microsoft.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1698280314-25861-8-git-send-email-roretzla@linux.microsoft.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1698280314-25861-8-git-send-email-roretzla@linux.microsoft.com", "date": "2023-10-26T00:31:42", "name": "[v3,07/19] mbuf: use rte optional stdatomic API", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "3533d4a4062d7282f8c35e23a85616b9b36e68f5", "submitter": { "id": 2077, "url": "http://patches.dpdk.org/api/people/2077/?format=api", "name": "Tyler Retzlaff", "email": "roretzla@linux.microsoft.com" }, "delegate": { "id": 24651, "url": "http://patches.dpdk.org/api/users/24651/?format=api", "username": "dmarchand", "first_name": "David", "last_name": "Marchand", "email": "david.marchand@redhat.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1698280314-25861-8-git-send-email-roretzla@linux.microsoft.com/mbox/", "series": [ { "id": 29989, "url": "http://patches.dpdk.org/api/series/29989/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=29989", "date": "2023-10-26T00:31:35", "name": "use rte optional stdatomic API", "version": 3, "mbox": "http://patches.dpdk.org/series/29989/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/133328/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/133328/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id B0A4443200;\n\tThu, 26 Oct 2023 02:32:56 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 1ACA542DE2;\n\tThu, 26 Oct 2023 02:32:12 +0200 (CEST)", "from linux.microsoft.com (linux.microsoft.com [13.77.154.182])\n by mails.dpdk.org (Postfix) with ESMTP id 11B21402BE\n for <dev@dpdk.org>; Thu, 26 Oct 2023 02:32:01 +0200 (CEST)", "by linux.microsoft.com (Postfix, from userid 1086)\n id AA11A20B74C7; Wed, 25 Oct 2023 17:31:59 -0700 (PDT)" ], "DKIM-Filter": "OpenDKIM Filter v2.11.0 linux.microsoft.com AA11A20B74C7", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com;\n s=default; t=1698280319;\n bh=WwKFAE+BTKqgPf6JrMJiSwJubseprZaUYU8IIoc4Zx0=;\n h=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n b=nPYqGz9BiLYzv48maNECuTZGpYEFITzPBElnMmLQAmfLrkWe7FPSb4iwnZgnJRcCb\n ollHbsJBcINo1AOuqx7OtQuYQI+4cOzI/BH9oqfWr+PSlruF2Bu+iyqQe+G6RVysd5\n Zc11XovUwsZzpiRDFFaxC14qv6J2BEe/Wmn1pzjE=", "From": "Tyler Retzlaff <roretzla@linux.microsoft.com>", "To": "dev@dpdk.org", "Cc": "Akhil Goyal <gakhil@marvell.com>,\n Anatoly Burakov <anatoly.burakov@intel.com>,\n Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>,\n Bruce Richardson <bruce.richardson@intel.com>,\n Chenbo Xia <chenbo.xia@intel.com>, Ciara Power <ciara.power@intel.com>,\n David Christensen <drc@linux.vnet.ibm.com>,\n David Hunt <david.hunt@intel.com>,\n Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>,\n Dmitry Malloy <dmitrym@microsoft.com>,\n Elena Agostini <eagostini@nvidia.com>,\n Erik Gabriel Carrillo <erik.g.carrillo@intel.com>,\n Fan Zhang <fanzhang.oss@gmail.com>, Ferruh Yigit <ferruh.yigit@amd.com>,\n Harman Kalra <hkalra@marvell.com>,\n Harry van Haaren <harry.van.haaren@intel.com>,\n Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>,\n Jerin Jacob <jerinj@marvell.com>,\n Konstantin Ananyev <konstantin.v.ananyev@yandex.ru>,\n Matan Azrad <matan@nvidia.com>,\n Maxime Coquelin <maxime.coquelin@redhat.com>,\n Narcisa Ana Maria Vasile <navasile@linux.microsoft.com>,\n Nicolas Chautru <nicolas.chautru@intel.com>,\n Olivier Matz <olivier.matz@6wind.com>, Ori Kam <orika@nvidia.com>,\n Pallavi Kadam <pallavi.kadam@intel.com>,\n Pavan Nikhilesh <pbhagavatula@marvell.com>,\n Reshma Pattan <reshma.pattan@intel.com>,\n Sameh Gobriel <sameh.gobriel@intel.com>,\n Shijith Thotton <sthotton@marvell.com>,\n Sivaprasad Tummala <sivaprasad.tummala@amd.com>,\n Stephen Hemminger <stephen@networkplumber.org>,\n Suanming Mou <suanmingm@nvidia.com>, Sunil Kumar Kori <skori@marvell.com>,\n Thomas Monjalon <thomas@monjalon.net>,\n Viacheslav Ovsiienko <viacheslavo@nvidia.com>,\n Vladimir Medvedkin <vladimir.medvedkin@intel.com>,\n Yipeng Wang <yipeng1.wang@intel.com>,\n Tyler Retzlaff <roretzla@linux.microsoft.com>", "Subject": "[PATCH v3 07/19] mbuf: use rte optional stdatomic API", "Date": "Wed, 25 Oct 2023 17:31:42 -0700", "Message-Id": "<1698280314-25861-8-git-send-email-roretzla@linux.microsoft.com>", "X-Mailer": "git-send-email 1.8.3.1", "In-Reply-To": "<1698280314-25861-1-git-send-email-roretzla@linux.microsoft.com>", "References": "<1697497745-20664-1-git-send-email-roretzla@linux.microsoft.com>\n <1698280314-25861-1-git-send-email-roretzla@linux.microsoft.com>", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Replace the use of gcc builtin __atomic_xxx intrinsics with\ncorresponding rte_atomic_xxx optional stdatomic API\n\nSigned-off-by: Tyler Retzlaff <roretzla@linux.microsoft.com>\n---\n lib/mbuf/rte_mbuf.h | 20 ++++++++++----------\n lib/mbuf/rte_mbuf_core.h | 5 +++--\n 2 files changed, 13 insertions(+), 12 deletions(-)", "diff": "diff --git a/lib/mbuf/rte_mbuf.h b/lib/mbuf/rte_mbuf.h\nindex 913c459..b8ab477 100644\n--- a/lib/mbuf/rte_mbuf.h\n+++ b/lib/mbuf/rte_mbuf.h\n@@ -361,7 +361,7 @@ struct rte_pktmbuf_pool_private {\n static inline uint16_t\n rte_mbuf_refcnt_read(const struct rte_mbuf *m)\n {\n-\treturn __atomic_load_n(&m->refcnt, __ATOMIC_RELAXED);\n+\treturn rte_atomic_load_explicit(&m->refcnt, rte_memory_order_relaxed);\n }\n \n /**\n@@ -374,15 +374,15 @@ struct rte_pktmbuf_pool_private {\n static inline void\n rte_mbuf_refcnt_set(struct rte_mbuf *m, uint16_t new_value)\n {\n-\t__atomic_store_n(&m->refcnt, new_value, __ATOMIC_RELAXED);\n+\trte_atomic_store_explicit(&m->refcnt, new_value, rte_memory_order_relaxed);\n }\n \n /* internal */\n static inline uint16_t\n __rte_mbuf_refcnt_update(struct rte_mbuf *m, int16_t value)\n {\n-\treturn __atomic_fetch_add(&m->refcnt, value,\n-\t\t\t\t __ATOMIC_ACQ_REL) + value;\n+\treturn rte_atomic_fetch_add_explicit(&m->refcnt, value,\n+\t\t\t\t rte_memory_order_acq_rel) + value;\n }\n \n /**\n@@ -463,7 +463,7 @@ struct rte_pktmbuf_pool_private {\n static inline uint16_t\n rte_mbuf_ext_refcnt_read(const struct rte_mbuf_ext_shared_info *shinfo)\n {\n-\treturn __atomic_load_n(&shinfo->refcnt, __ATOMIC_RELAXED);\n+\treturn rte_atomic_load_explicit(&shinfo->refcnt, rte_memory_order_relaxed);\n }\n \n /**\n@@ -478,7 +478,7 @@ struct rte_pktmbuf_pool_private {\n rte_mbuf_ext_refcnt_set(struct rte_mbuf_ext_shared_info *shinfo,\n \tuint16_t new_value)\n {\n-\t__atomic_store_n(&shinfo->refcnt, new_value, __ATOMIC_RELAXED);\n+\trte_atomic_store_explicit(&shinfo->refcnt, new_value, rte_memory_order_relaxed);\n }\n \n /**\n@@ -502,8 +502,8 @@ struct rte_pktmbuf_pool_private {\n \t\treturn (uint16_t)value;\n \t}\n \n-\treturn __atomic_fetch_add(&shinfo->refcnt, value,\n-\t\t\t\t __ATOMIC_ACQ_REL) + value;\n+\treturn rte_atomic_fetch_add_explicit(&shinfo->refcnt, value,\n+\t\t\t\t rte_memory_order_acq_rel) + value;\n }\n \n /** Mbuf prefetch */\n@@ -1315,8 +1315,8 @@ static inline int __rte_pktmbuf_pinned_extbuf_decref(struct rte_mbuf *m)\n \t * Direct usage of add primitive to avoid\n \t * duplication of comparing with one.\n \t */\n-\tif (likely(__atomic_fetch_add(&shinfo->refcnt, -1,\n-\t\t\t\t __ATOMIC_ACQ_REL) - 1))\n+\tif (likely(rte_atomic_fetch_add_explicit(&shinfo->refcnt, -1,\n+\t\t\t\t rte_memory_order_acq_rel) - 1))\n \t\treturn 1;\n \n \t/* Reinitialize counter before mbuf freeing. */\ndiff --git a/lib/mbuf/rte_mbuf_core.h b/lib/mbuf/rte_mbuf_core.h\nindex e9bc0d1..5688683 100644\n--- a/lib/mbuf/rte_mbuf_core.h\n+++ b/lib/mbuf/rte_mbuf_core.h\n@@ -19,6 +19,7 @@\n #include <stdint.h>\n \n #include <rte_byteorder.h>\n+#include <rte_stdatomic.h>\n \n #ifdef __cplusplus\n extern \"C\" {\n@@ -497,7 +498,7 @@ struct rte_mbuf {\n \t * rte_mbuf_refcnt_set(). The functionality of these functions (atomic,\n \t * or non-atomic) is controlled by the RTE_MBUF_REFCNT_ATOMIC flag.\n \t */\n-\tuint16_t refcnt;\n+\tRTE_ATOMIC(uint16_t) refcnt;\n \n \t/**\n \t * Number of segments. Only valid for the first segment of an mbuf\n@@ -674,7 +675,7 @@ struct rte_mbuf {\n struct rte_mbuf_ext_shared_info {\n \trte_mbuf_extbuf_free_callback_t free_cb; /**< Free callback function */\n \tvoid *fcb_opaque; /**< Free callback argument */\n-\tuint16_t refcnt;\n+\tRTE_ATOMIC(uint16_t) refcnt;\n };\n \n /** Maximum number of nb_segs allowed. */\n", "prefixes": [ "v3", "07/19" ] }