Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/133312/?format=api
{ "id": 133312, "url": "http://patches.dpdk.org/api/patches/133312/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20231025163352.1076755-2-thomas@monjalon.net/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20231025163352.1076755-2-thomas@monjalon.net>", "list_archive_url": "https://inbox.dpdk.org/dev/20231025163352.1076755-2-thomas@monjalon.net", "date": "2023-10-25T16:31:10", "name": "[v3,1/2] eal: add thread yield functions", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "704e8b5bcad22bccd99aa390311b946d3cfe7d18", "submitter": { "id": 685, "url": "http://patches.dpdk.org/api/people/685/?format=api", "name": "Thomas Monjalon", "email": "thomas@monjalon.net" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20231025163352.1076755-2-thomas@monjalon.net/mbox/", "series": [ { "id": 29984, "url": "http://patches.dpdk.org/api/series/29984/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=29984", "date": "2023-10-25T16:31:09", "name": "allow creating thread with real-time priority", "version": 3, "mbox": "http://patches.dpdk.org/series/29984/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/133312/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/133312/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 7ADD3431FC;\n\tWed, 25 Oct 2023 18:34:10 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id D214D42DB2;\n\tWed, 25 Oct 2023 18:34:05 +0200 (CEST)", "from wout5-smtp.messagingengine.com (wout5-smtp.messagingengine.com\n [64.147.123.21]) by mails.dpdk.org (Postfix) with ESMTP id D90DF40EAB\n for <dev@dpdk.org>; Wed, 25 Oct 2023 18:34:04 +0200 (CEST)", "from compute6.internal (compute6.nyi.internal [10.202.2.47])\n by mailout.west.internal (Postfix) with ESMTP id 8D1B83200989;\n Wed, 25 Oct 2023 12:34:03 -0400 (EDT)", "from mailfrontend2 ([10.202.2.163])\n by compute6.internal (MEProxy); Wed, 25 Oct 2023 12:34:04 -0400", "by mail.messagingengine.com (Postfix) with ESMTPA; Wed,\n 25 Oct 2023 12:34:01 -0400 (EDT)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=\n cc:cc:content-transfer-encoding:content-type:date:date:from:from\n :in-reply-to:in-reply-to:message-id:mime-version:references\n :reply-to:sender:subject:subject:to:to; s=fm3; t=1698251643; x=\n 1698338043; bh=tAu4SodJ0U2Qx5L5LNl0sjXglOylD5S7/k8hQAdwy1I=; b=b\n KgObMTKZhKvCnlxOPUptpgmoPTBjJBiskuSxPrBZWrscHgJEazgWU5yzo3uW8YNv\n uB/l/Y0lCLpZrV8S81T6qNBv/vToP5okAoLve62rqhW7cvISJYjotRlb8DS05dzm\n 9C9AgujbeF83SXV2kTLJmPGoD6wtkhTbUdIniMCquaQClQKp/Bg5EZUH7IiWDTuw\n 2whH8BDTPXB8Cwk4GoB9IWKnNQ1Q8xJSkILIPYhE0r2ZnApOOTxy7/YOclUZxcrY\n oUK4Px/yJIfuGqkIO1doe0JEm4qYwnymvF4+hDbgGBQ5ntl2RBl00x4KSNp8Whm9\n rMPZQd0pOp32ZinPLXkfA==", "v=1; a=rsa-sha256; c=relaxed/relaxed; d=\n messagingengine.com; h=cc:cc:content-transfer-encoding\n :content-type:date:date:feedback-id:feedback-id:from:from\n :in-reply-to:in-reply-to:message-id:mime-version:references\n :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy\n :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1698251643; x=\n 1698338043; bh=tAu4SodJ0U2Qx5L5LNl0sjXglOylD5S7/k8hQAdwy1I=; b=E\n K3QyGE/NxcYsHqHP65xDeznmPqJ/OU5bcjaFCXvNsHGLti6UOFT2/QsSi1KhCFgM\n 52xcfWD7HEhnzS+PznImyFlHt/do75Kp+8JsQtqDIDL0Xxet7nMKc86TWSlshfao\n B7ibch6fW/oif8HAsqBFVjaeXCCEEn8JYHABgxx70q9lVWif0w77mdSKO2l5UKG0\n +wQ8H6pG7tMZu1c7bl7sZNiMqS3HRlYgiZjaBan40asPiW/Sj5i72KOuhhw72LiC\n 1TC1Ks06XKitL9cBrvTDEtWyExZpr7ZWxm0toKmmLraHmV7zVFkyQVdGi+/4I8Ml\n aVHtodPl5JNJCZxdSTgfQ==" ], "X-ME-Sender": "<xms:ekM5Zb8rkIxO7geGq9-fEWMu27KR112Vg1_zLmIZi6eHTdLIAnkVXA>\n <xme:ekM5ZXtWup4cpb6VzSBrYgbTW-a8urtGURIH-k0pOQYZeDdXeGR5ZSDX15AyQPl-_\n tB4ifNwaKp30USKWQ>", "X-ME-Received": "\n <xmr:ekM5ZZCszVmqii75jP7n4Dn6K1NoVY-WBOqC5cwN98cxPerCcG4Nfuu-2nVY6oi78Xx9Qxav1B_5hXjwykmKuKwwg7oMn4s>", "X-ME-Proxy-Cause": "\n gggruggvucftvghtrhhoucdtuddrgedvkedrledtgddutdduucetufdoteggodetrfdotf\n fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen\n uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne\n cujfgurhephffvvefufffkofgjfhgggfestdekredtredttdenucfhrhhomhepvfhhohhm\n rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc\n ggtffrrghtthgvrhhnpedvjefhudeghedvtdeijeeigeetuedugfejueekieeltdfhteev\n keehhfeilefhtdenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfh\n hrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght", "X-ME-Proxy": "<xmx:ekM5ZXdFPz-vVzL01yhq5YMAZf64MW1ohMZlRCUqT29MdwEg4LrWTA>\n <xmx:ekM5ZQNCUT79WGZNzaGL1XX2ya3_qa0Wmn9ib29A_CGhJSFDyEtKcg>\n <xmx:ekM5ZZlpkn8Fyp-O9z6Ie5N9XTKV5KlbnVCZ6L4TwWbYBwCYcRY8GA>\n <xmx:e0M5Zdp2FWQjj86thNOrnfuBnQlseXCngDuFZq1G2UwY83sCgDFhmg>", "Feedback-ID": "i47234305:Fastmail", "From": "Thomas Monjalon <thomas@monjalon.net>", "To": "dev@dpdk.org", "Cc": "David Marchand <david.marchand@redhat.com>,\n Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>,\n Narcisa Ana Maria Vasile <navasile@linux.microsoft.com>,\n Dmitry Malloy <dmitrym@microsoft.com>,\n Pallavi Kadam <pallavi.kadam@intel.com>", "Subject": "[PATCH v3 1/2] eal: add thread yield functions", "Date": "Wed, 25 Oct 2023 18:31:10 +0200", "Message-ID": "<20231025163352.1076755-2-thomas@monjalon.net>", "X-Mailer": "git-send-email 2.42.0", "In-Reply-To": "<20231025163352.1076755-1-thomas@monjalon.net>", "References": "<20231024125416.798897-1-thomas@monjalon.net>\n <20231025163352.1076755-1-thomas@monjalon.net>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "When running real-time threads, we may need to force scheduling\nkernel threads or other real-time threads.\nNew functions are added to address these cases.\n\nThe yield functions should not have any interest for normal threads.\nNote: other purposes may be addressed with rte_pause() or rte_delay_*().\n\nSigned-off-by: Thomas Monjalon <thomas@monjalon.net>\n---\n lib/eal/include/rte_thread.h | 22 ++++++++++++++++++++++\n lib/eal/unix/rte_thread.c | 16 ++++++++++++++++\n lib/eal/version.map | 4 ++++\n lib/eal/windows/rte_thread.c | 15 +++++++++++++++\n 4 files changed, 57 insertions(+)", "diff": "diff --git a/lib/eal/include/rte_thread.h b/lib/eal/include/rte_thread.h\nindex 8da9d4d3fb..139cafac96 100644\n--- a/lib/eal/include/rte_thread.h\n+++ b/lib/eal/include/rte_thread.h\n@@ -183,6 +183,28 @@ int rte_thread_join(rte_thread_t thread_id, uint32_t *value_ptr);\n */\n int rte_thread_detach(rte_thread_t thread_id);\n \n+/**\n+ * Allow another thread to run on the same CPU core.\n+ *\n+ * Lower priority threads may not be scheduled.\n+ *\n+ * Especially useful in real-time thread priority\n+ * to schedule other real-time threads.\n+ * @see RTE_THREAD_PRIORITY_REALTIME_CRITICAL\n+ */\n+__rte_experimental\n+void rte_thread_yield(void);\n+\n+/**\n+ * Unblock a CPU core running busy in a real-time thread.\n+ *\n+ * Especially useful in real-time thread priority\n+ * to avoid a busy loop blocking vital threads on a core.\n+ * @see RTE_THREAD_PRIORITY_REALTIME_CRITICAL\n+ */\n+__rte_experimental\n+void rte_thread_yield_realtime(void);\n+\n /**\n * Get the id of the calling thread.\n *\ndiff --git a/lib/eal/unix/rte_thread.c b/lib/eal/unix/rte_thread.c\nindex 36a21ab2f9..92b4e53adb 100644\n--- a/lib/eal/unix/rte_thread.c\n+++ b/lib/eal/unix/rte_thread.c\n@@ -5,9 +5,11 @@\n \n #include <errno.h>\n #include <pthread.h>\n+#include <sched.h>\n #include <stdbool.h>\n #include <stdlib.h>\n #include <string.h>\n+#include <time.h>\n \n #include <rte_errno.h>\n #include <rte_log.h>\n@@ -227,6 +229,20 @@ rte_thread_detach(rte_thread_t thread_id)\n \treturn pthread_detach((pthread_t)thread_id.opaque_id);\n }\n \n+void\n+rte_thread_yield(void)\n+{\n+\tsched_yield();\n+}\n+\n+void\n+rte_thread_yield_realtime(void)\n+{\n+\t/* A simple yield may not be enough to schedule kernel threads. */\n+\tstruct timespec wait = {.tv_nsec = 1};\n+\tnanosleep(&wait, NULL);\n+}\n+\n int\n rte_thread_equal(rte_thread_t t1, rte_thread_t t2)\n {\ndiff --git a/lib/eal/version.map b/lib/eal/version.map\nindex e00a844805..b81ac3e3af 100644\n--- a/lib/eal/version.map\n+++ b/lib/eal/version.map\n@@ -413,6 +413,10 @@ EXPERIMENTAL {\n \t# added in 23.07\n \trte_memzone_max_get;\n \trte_memzone_max_set;\n+\n+\t# added in 23.11\n+\trte_thread_yield;\n+\trte_thread_yield_realtime;\n };\n \n INTERNAL {\ndiff --git a/lib/eal/windows/rte_thread.c b/lib/eal/windows/rte_thread.c\nindex acf648456c..1e031eca40 100644\n--- a/lib/eal/windows/rte_thread.c\n+++ b/lib/eal/windows/rte_thread.c\n@@ -304,6 +304,21 @@ rte_thread_detach(rte_thread_t thread_id)\n \treturn 0;\n }\n \n+void\n+rte_thread_yield(void)\n+{\n+\tSleep(0);\n+}\n+\n+void\n+rte_thread_yield_realtime(void)\n+{\n+\t/* Real-time threads are not causing problems on Windows.\n+\t * A normal yield should be fine.\n+\t */\n+\tSleep(0);\n+}\n+\n int\n rte_thread_equal(rte_thread_t t1, rte_thread_t t2)\n {\n", "prefixes": [ "v3", "1/2" ] }