Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/133078/?format=api
{ "id": 133078, "url": "http://patches.dpdk.org/api/patches/133078/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20231020170135.18319-1-syalavarthi@marvell.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20231020170135.18319-1-syalavarthi@marvell.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20231020170135.18319-1-syalavarthi@marvell.com", "date": "2023-10-20T17:01:35", "name": "[1/1] build: update link args and includes for libarchive", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "a608425f093b14ae7b8e4789742ec7d3f89e0889", "submitter": { "id": 2480, "url": "http://patches.dpdk.org/api/people/2480/?format=api", "name": "Srikanth Yalavarthi", "email": "syalavarthi@marvell.com" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20231020170135.18319-1-syalavarthi@marvell.com/mbox/", "series": [ { "id": 29934, "url": "http://patches.dpdk.org/api/series/29934/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=29934", "date": "2023-10-20T17:01:35", "name": "[1/1] build: update link args and includes for libarchive", "version": 1, "mbox": "http://patches.dpdk.org/series/29934/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/133078/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/133078/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id BBA43431BC;\n\tFri, 20 Oct 2023 19:01:57 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 3A6C1402A2;\n\tFri, 20 Oct 2023 19:01:57 +0200 (CEST)", "from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com\n [67.231.156.173])\n by mails.dpdk.org (Postfix) with ESMTP id 60D834027C;\n Fri, 20 Oct 2023 19:01:55 +0200 (CEST)", "from pps.filterd (m0045851.ppops.net [127.0.0.1])\n by mx0b-0016f401.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id\n 39KAoS2x014085; Fri, 20 Oct 2023 10:01:54 -0700", "from dc5-exch01.marvell.com ([199.233.59.181])\n by mx0b-0016f401.pphosted.com (PPS) with ESMTPS id 3tubwykhyc-2\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT);\n Fri, 20 Oct 2023 10:01:53 -0700", "from DC5-EXCH01.marvell.com (10.69.176.38) by DC5-EXCH01.marvell.com\n (10.69.176.38) with Microsoft SMTP Server (TLS) id 15.0.1497.48;\n Fri, 20 Oct 2023 10:01:46 -0700", "from maili.marvell.com (10.69.176.80) by DC5-EXCH01.marvell.com\n (10.69.176.38) with Microsoft SMTP Server id 15.0.1497.48 via Frontend\n Transport; Fri, 20 Oct 2023 10:01:46 -0700", "from ml-host-33.caveonetworks.com (unknown [10.110.143.233])\n by maili.marvell.com (Postfix) with ESMTP id 93E8C3F7040;\n Fri, 20 Oct 2023 10:01:46 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com;\n h=from : to : cc :\n subject : date : message-id : mime-version : content-transfer-encoding :\n content-type; s=pfpt0220; bh=1vZe6R0augbbJ4pPoT+DyB+veUPjlwYgRFDXLlNUbuo=;\n b=LQtQ1PdjYkc4gQmyMBd4dhPUu+DjBHT1yQNF1Yctyutumyk8kWXjiU0xjzUwX2wDHpCO\n 6K6Bt8zD6Y003GWuDvdaHDiG1yw6nsWv7VdSBjjdPWHAk0Q3naXhxA+cyPwTqXswqgCW\n /ODByxODz9K8eRkixeNXiu2VFe+RZZTqIpjk3kpBH+UJWpmZ54Qfan1qoQJ3Pv6iBG48\n Fv/zBmIOsMwM74+O/vXKf7IxEg2MlCDO2IzSQ5X/xzduc2nbPJ9ybS74I5uOt/sz7LyS\n T4m3EO9Sfwtgvf+dakxr/jEo/eps6qylLHgt7jZm4ZFPPc4vXIiTvVgntt5cOkznCcEG Xg==", "From": "Srikanth Yalavarthi <syalavarthi@marvell.com>", "To": "Bruce Richardson <bruce.richardson@intel.com>, Aaron Conole\n <aconole@redhat.com>, Igor Russkikh <irusskikh@marvell.com>, David Marchand\n <david.marchand@redhat.com>", "CC": "<dev@dpdk.org>, <syalavarthi@marvell.com>, <sshankarnara@marvell.com>,\n <jerinj@marvell.com>, <stable@dpdk.org>", "Subject": "[PATCH 1/1] build: update link args and includes for libarchive", "Date": "Fri, 20 Oct 2023 10:01:35 -0700", "Message-ID": "<20231020170135.18319-1-syalavarthi@marvell.com>", "X-Mailer": "git-send-email 2.42.0", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Proofpoint-ORIG-GUID": "PeSVdWg6RzhVJWHcV7NI5OccuUWV0u0H", "X-Proofpoint-GUID": "PeSVdWg6RzhVJWHcV7NI5OccuUWV0u0H", "X-Proofpoint-Virus-Version": "vendor=baseguard\n engine=ICAP:2.0.272,Aquarius:18.0.980,Hydra:6.0.619,FMLib:17.11.176.26\n definitions=2023-10-20_10,2023-10-19_01,2023-05-22_02", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "In order to avoid linking with all libraries listed as\nLibs.private in libarchive.pc, libarchive is not added\nto ext_deps during meson setup.\n\nSince libarchive is not added to ext_deps, cross-compilation\nor native compilation with libarchive installed in non-standard\nlocation fails with errors related to \"cannot find -larchive\"\nor \"archive.h: No such file or directory\". In order to fix the\nbuild failures, user is required to define the 'c_args' and\n'c_link_args' with '-I<includedir>' and '-L<libdir>'.\n\nThis patch updates meson build files to add libarchive's\nincludedir and libdir to compiler flags and would not require\nsetting c_args and c_link_args externally.\n\nFixes: 40edb9c0d36b (\"eal: handle compressed firmware\")\nCc: stable@dpdk.org\n\nSigned-off-by: Srikanth Yalavarthi <syalavarthi@marvell.com>\n---\n config/meson.build | 1 +\n lib/eal/meson.build | 3 +++\n 2 files changed, 4 insertions(+)", "diff": "diff --git a/config/meson.build b/config/meson.build\nindex d56b0f9bce..1bacea74ab 100644\n--- a/config/meson.build\n+++ b/config/meson.build\n@@ -239,6 +239,7 @@ if libarchive.found()\n # Push libarchive link dependency at the project level to support\n # statically linking dpdk apps. Details at:\n # https://inbox.dpdk.org/dev/20210605004024.660267a1@sovereign/\n+ add_project_link_arguments('-L' + libarchive.get_variable(pkgconfig: 'libdir'), language: 'c')\n add_project_link_arguments('-larchive', language: 'c')\n dpdk_extra_ldflags += '-larchive'\n endif\ndiff --git a/lib/eal/meson.build b/lib/eal/meson.build\nindex 9942104386..741a5cd088 100644\n--- a/lib/eal/meson.build\n+++ b/lib/eal/meson.build\n@@ -21,6 +21,9 @@ endif\n if dpdk_conf.has('RTE_USE_LIBBSD')\n ext_deps += libbsd\n endif\n+if dpdk_conf.has('RTE_HAS_LIBARCHIVE')\n+ includes += include_directories(libarchive.get_variable(pkgconfig: 'includedir'))\n+endif\n if cc.has_function('getentropy', prefix : '#include <unistd.h>')\n cflags += '-DRTE_LIBEAL_USE_GETENTROPY'\n endif\n", "prefixes": [ "1/1" ] }