Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/133040/?format=api
{ "id": 133040, "url": "http://patches.dpdk.org/api/patches/133040/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20231019191016.156430-12-stephen@networkplumber.org/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20231019191016.156430-12-stephen@networkplumber.org>", "list_archive_url": "https://inbox.dpdk.org/dev/20231019191016.156430-12-stephen@networkplumber.org", "date": "2023-10-19T19:09:59", "name": "[v4,11/28] hash: remove experimental from toeplitz hash", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "131fe586a30f10f6b64bd98c76f129d2f8c5519c", "submitter": { "id": 27, "url": "http://patches.dpdk.org/api/people/27/?format=api", "name": "Stephen Hemminger", "email": "stephen@networkplumber.org" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20231019191016.156430-12-stephen@networkplumber.org/mbox/", "series": [ { "id": 29925, "url": "http://patches.dpdk.org/api/series/29925/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=29925", "date": "2023-10-19T19:09:48", "name": "Promote many experimental API's to stable", "version": 4, "mbox": "http://patches.dpdk.org/series/29925/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/133040/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/133040/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id D9E4F431B1;\n\tThu, 19 Oct 2023 21:12:00 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 95E9442E1C;\n\tThu, 19 Oct 2023 21:10:43 +0200 (CEST)", "from mail-pf1-f172.google.com (mail-pf1-f172.google.com\n [209.85.210.172])\n by mails.dpdk.org (Postfix) with ESMTP id 34BD242E0C\n for <dev@dpdk.org>; Thu, 19 Oct 2023 21:10:37 +0200 (CEST)", "by mail-pf1-f172.google.com with SMTP id\n d2e1a72fcca58-6b9af7d41d2so87353b3a.0\n for <dev@dpdk.org>; Thu, 19 Oct 2023 12:10:37 -0700 (PDT)", "from hermes.local (204-195-126-68.wavecable.com. [204.195.126.68])\n by smtp.gmail.com with ESMTPSA id\n h12-20020a170902eecc00b001a9b29b6759sm52464plb.183.2023.10.19.12.10.35\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Thu, 19 Oct 2023 12:10:35 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1697742636;\n x=1698347436; darn=dpdk.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=MQi/QY4F89fHIaBBL8wYCbw0hSy34VeNPCJlIzw4yM8=;\n b=lkPF0x/dbEGp3Tixck85c1wgvsRnNX7+Z8MsAuyQzO1OsKXc+DK4YjsIECeoUGostA\n +qq7EYGNwrZljDtYeYhkU/Kxqrf30027dM4f6qhQOeBrMIViFSH4vOg+7x5vPpMSPBP0\n DMdRc6lWduVXdKozgAo9FPYad0QuVEx4hsPXaAKuRHDZz6Rsn05Suzy73+8mm+SrZG50\n uFMwTv4H9DLOzknyXvXRbONHf5GuklmNynN/2nWIBYm9jeSSeVk8q+I4in1VPbp01feF\n QXTTgkJ4huylK0y/HVYbGdXF6Saf99DeqOAigiKA14RXpUXCDOue/SNgjNr8H4nKG9V+\n t9TA==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20230601; t=1697742636; x=1698347436;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n :subject:date:message-id:reply-to;\n bh=MQi/QY4F89fHIaBBL8wYCbw0hSy34VeNPCJlIzw4yM8=;\n b=X7QanHV++eFI3glS9tCofTCOINvgCXK+2h3sYh84Od3T4ovAyZWUBSV4t6VAej3Z+d\n iGjYHBplkgy5pK4LQKgPkJdFWog41eGwRX+Z/dKD9P0guR6LqiCgGVEueen8JeUb7N/U\n GeUGBhSDfSeOHULK10bZXaBB60Ap5/XyVLHjgfiDARSBGaPfurxPC5xeLKcdbxe+ccOs\n KKlnSHAVFvngA4GTnfiDyTBT2+IocYO/ODHa7Xm/a2LIXjkXx9EtJNnQ1Rq45BKZrBcS\n xVqAkfClY0quSxRa7hjqNQs2kS6OEIXO7wMtves/Pg+oEdD445uh8FDdAl6gfmC8ndAm\n 2pqg==", "X-Gm-Message-State": "AOJu0YzcO1VJoQe7BWLR8z0Avh7GyoWQKyEU6kkS/fwtj4umY2U322P3\n kO7dLQdOeypjk/X315nFsipFUfBK+7IDkTru/bst+A==", "X-Google-Smtp-Source": "\n AGHT+IGxvre2KoS3pI+GdFQXlOwaQ/nza+ZjJLmeCWmaGH8Bk1g+4kNhQ9CkBVEAPmqEXhEYbvsr8g==", "X-Received": "by 2002:a05:6a21:7803:b0:17b:4b61:a8f7 with SMTP id\n be3-20020a056a21780300b0017b4b61a8f7mr3335473pzc.9.1697742636028;\n Thu, 19 Oct 2023 12:10:36 -0700 (PDT)", "From": "Stephen Hemminger <stephen@networkplumber.org>", "To": "dev@dpdk.org", "Cc": "Stephen Hemminger <stephen@networkplumber.org>,\n Yipeng Wang <yipeng1.wang@intel.com>,\n Sameh Gobriel <sameh.gobriel@intel.com>,\n Bruce Richardson <bruce.richardson@intel.com>,\n Vladimir Medvedkin <vladimir.medvedkin@intel.com>", "Subject": "[PATCH v4 11/28] hash: remove experimental from toeplitz hash", "Date": "Thu, 19 Oct 2023 12:09:59 -0700", "Message-Id": "<20231019191016.156430-12-stephen@networkplumber.org>", "X-Mailer": "git-send-email 2.39.2", "In-Reply-To": "<20231019191016.156430-1-stephen@networkplumber.org>", "References": "<20230808173527.186042-1-stephen@networkplumber.org>\n <20231019191016.156430-1-stephen@networkplumber.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "The rte_thash_ functions have been around since 2020.\nRemove experimental tag.\n\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\n---\n lib/hash/rte_thash.h | 44 -----------------------------------\n lib/hash/rte_thash_gfni.h | 8 -------\n lib/hash/rte_thash_x86_gfni.h | 8 -------\n lib/hash/version.map | 16 ++++---------\n 4 files changed, 4 insertions(+), 72 deletions(-)", "diff": "diff --git a/lib/hash/rte_thash.h b/lib/hash/rte_thash.h\nindex da06cd53c0e0..071730c7bab9 100644\n--- a/lib/hash/rte_thash.h\n+++ b/lib/hash/rte_thash.h\n@@ -221,14 +221,10 @@ rte_softrss_be(uint32_t *input_tuple, uint32_t input_len,\n /**\n * Indicates if GFNI implementations of the Toeplitz hash are supported.\n *\n- * @warning\n- * @b EXPERIMENTAL: this API may change without prior notice.\n- *\n * @return\n * 1 if GFNI is supported\n * 0 otherwise\n */\n-__rte_experimental\n int\n rte_thash_gfni_supported(void);\n \n@@ -236,9 +232,6 @@ rte_thash_gfni_supported(void);\n * Converts Toeplitz hash key (RSS key) into matrixes required\n * for GFNI implementation\n *\n- * @warning\n- * @b EXPERIMENTAL: this API may change without prior notice.\n- *\n * @param matrixes\n * pointer to the memory where matrices will be written.\n * Note: the size of this memory must be equal to size * 8\n@@ -247,7 +240,6 @@ rte_thash_gfni_supported(void);\n * @param size\n * Size of the rss_key in bytes.\n */\n-__rte_experimental\n void\n rte_thash_complete_matrix(uint64_t *matrixes, const uint8_t *rss_key,\n \tint size);\n@@ -276,9 +268,6 @@ struct rte_thash_subtuple_helper;\n /**\n * Create a new thash context.\n *\n- * @warning\n- * @b EXPERIMENTAL: this API may change without prior notice.\n- *\n * @param name\n * Context name\n * @param key_len\n@@ -298,7 +287,6 @@ struct rte_thash_subtuple_helper;\n * A pointer to the created context on success\n * NULL otherwise\n */\n-__rte_experimental\n struct rte_thash_ctx *\n rte_thash_init_ctx(const char *name, uint32_t key_len, uint32_t reta_sz,\n \tuint8_t *key, uint32_t flags);\n@@ -306,9 +294,6 @@ rte_thash_init_ctx(const char *name, uint32_t key_len, uint32_t reta_sz,\n /**\n * Find an existing thash context and return a pointer to it.\n *\n- * @warning\n- * @b EXPERIMENTAL: this API may change without prior notice.\n- *\n * @param name\n * Name of the thash context\n * @return\n@@ -316,20 +301,15 @@ rte_thash_init_ctx(const char *name, uint32_t key_len, uint32_t reta_sz,\n * set appropriately. Possible rte_errno values include:\n * - ENOENT - required entry not available to return.\n */\n-__rte_experimental\n struct rte_thash_ctx *\n rte_thash_find_existing(const char *name);\n \n /**\n * Free a thash context object\n *\n- * @warning\n- * @b EXPERIMENTAL: this API may change without prior notice.\n- *\n * @param ctx\n * Thash context\n */\n-__rte_experimental\n void\n rte_thash_free_ctx(struct rte_thash_ctx *ctx);\n \n@@ -339,9 +319,6 @@ rte_thash_free_ctx(struct rte_thash_ctx *ctx);\n * to calculate toeplitz hash collisions.\n * This function is not multi-thread safe.\n *\n- * @warning\n- * @b EXPERIMENTAL: this API may change without prior notice.\n- *\n * @param ctx\n * Thash context\n * @param name\n@@ -355,7 +332,6 @@ rte_thash_free_ctx(struct rte_thash_ctx *ctx);\n * 0 on success\n * negative on error\n */\n-__rte_experimental\n int\n rte_thash_add_helper(struct rte_thash_ctx *ctx, const char *name, uint32_t len,\n \tuint32_t offset);\n@@ -363,9 +339,6 @@ rte_thash_add_helper(struct rte_thash_ctx *ctx, const char *name, uint32_t len,\n /**\n * Find a helper in the context by the given name\n *\n- * @warning\n- * @b EXPERIMENTAL: this API may change without prior notice.\n- *\n * @param ctx\n * Thash context\n * @param name\n@@ -373,7 +346,6 @@ rte_thash_add_helper(struct rte_thash_ctx *ctx, const char *name, uint32_t len,\n * @return\n * Pointer to the thash helper or NULL if it was not found.\n */\n-__rte_experimental\n struct rte_thash_subtuple_helper *\n rte_thash_get_helper(struct rte_thash_ctx *ctx, const char *name);\n \n@@ -392,7 +364,6 @@ rte_thash_get_helper(struct rte_thash_ctx *ctx, const char *name);\n * @return\n * A complementary value which must be xored with the corresponding subtuple\n */\n-__rte_experimental\n uint32_t\n rte_thash_get_complement(struct rte_thash_subtuple_helper *h,\n \tuint32_t hash, uint32_t desired_hash);\n@@ -402,15 +373,11 @@ rte_thash_get_complement(struct rte_thash_subtuple_helper *h,\n * It changes after each addition of a helper. It should be installed to\n * the NIC.\n *\n- * @warning\n- * @b EXPERIMENTAL: this API may change without prior notice.\n- *\n * @param ctx\n * Thash context\n * @return\n * A pointer to the toeplitz hash key\n */\n-__rte_experimental\n const uint8_t *\n rte_thash_get_key(struct rte_thash_ctx *ctx);\n \n@@ -420,16 +387,12 @@ rte_thash_get_key(struct rte_thash_ctx *ctx);\n * CPU supports GFNI.\n * Matrices changes after each addition of a helper.\n *\n- * @warning\n- * @b EXPERIMENTAL: this API may change without prior notice.\n- *\n * @param ctx\n * Thash context\n * @return\n * A pointer to the toeplitz hash key matrices on success\n * NULL if GFNI is not supported.\n */\n-__rte_experimental\n const uint64_t *\n rte_thash_get_gfni_matrices(struct rte_thash_ctx *ctx);\n \n@@ -439,9 +402,6 @@ rte_thash_get_gfni_matrices(struct rte_thash_ctx *ctx);\n * Generally it is some kind of lookup function to check\n * if adjusted tuple is already in use.\n *\n- * @warning\n- * @b EXPERIMENTAL: this API may change without prior notice.\n- *\n * @param userdata\n * Pointer to the userdata. It could be a pointer to the\n * table with used tuples to search.\n@@ -459,9 +419,6 @@ typedef int (*rte_thash_check_tuple_t)(void *userdata, uint8_t *tuple);\n * desired least significant bits.\n * This function is multi-thread safe.\n *\n- * @warning\n- * @b EXPERIMENTAL: this API may change without prior notice.\n- *\n * @param ctx\n * Thash context\n * @param h\n@@ -483,7 +440,6 @@ typedef int (*rte_thash_check_tuple_t)(void *userdata, uint8_t *tuple);\n * 0 on success\n * negative otherwise\n */\n-__rte_experimental\n int\n rte_thash_adjust_tuple(struct rte_thash_ctx *ctx,\n \tstruct rte_thash_subtuple_helper *h,\ndiff --git a/lib/hash/rte_thash_gfni.h b/lib/hash/rte_thash_gfni.h\nindex ef90faa302d1..67d0fa4da988 100644\n--- a/lib/hash/rte_thash_gfni.h\n+++ b/lib/hash/rte_thash_gfni.h\n@@ -24,9 +24,6 @@ extern \"C\" {\n * Calculate Toeplitz hash.\n * Dummy implementation.\n *\n- * @warning\n- * @b EXPERIMENTAL: this API may change without prior notice.\n- *\n * @param m\n * Pointer to the matrices generated from the corresponding\n * RSS hash key using rte_thash_complete_matrix().\n@@ -37,7 +34,6 @@ extern \"C\" {\n * @return\n * Calculated Toeplitz hash value.\n */\n-__rte_experimental\n static inline uint32_t\n rte_thash_gfni(const uint64_t *mtrx __rte_unused,\n \tconst uint8_t *key __rte_unused, int len __rte_unused)\n@@ -50,9 +46,6 @@ rte_thash_gfni(const uint64_t *mtrx __rte_unused,\n * Bulk implementation for Toeplitz hash.\n * Dummy implementation.\n *\n- * @warning\n- * @b EXPERIMENTAL: this API may change without prior notice.\n- *\n * @param m\n * Pointer to the matrices generated from the corresponding\n * RSS hash key using rte_thash_complete_matrix().\n@@ -66,7 +59,6 @@ rte_thash_gfni(const uint64_t *mtrx __rte_unused,\n * @param num\n * Number of tuples to hash.\n */\n-__rte_experimental\n static inline void\n rte_thash_gfni_bulk(const uint64_t *mtrx __rte_unused,\n \tint len __rte_unused, uint8_t *tuple[] __rte_unused,\ndiff --git a/lib/hash/rte_thash_x86_gfni.h b/lib/hash/rte_thash_x86_gfni.h\nindex fbec16dde081..0ff7ad07eeaa 100644\n--- a/lib/hash/rte_thash_x86_gfni.h\n+++ b/lib/hash/rte_thash_x86_gfni.h\n@@ -161,9 +161,6 @@ __rte_thash_gfni(const uint64_t *mtrx, const uint8_t *tuple,\n /**\n * Calculate Toeplitz hash.\n *\n- * @warning\n- * @b EXPERIMENTAL: this API may change without prior notice.\n- *\n * @param m\n * Pointer to the matrices generated from the corresponding\n * RSS hash key using rte_thash_complete_matrix().\n@@ -175,7 +172,6 @@ __rte_thash_gfni(const uint64_t *mtrx, const uint8_t *tuple,\n * @return\n * Calculated Toeplitz hash value.\n */\n-__rte_experimental\n static inline uint32_t\n rte_thash_gfni(const uint64_t *m, const uint8_t *tuple, int len)\n {\n@@ -190,9 +186,6 @@ rte_thash_gfni(const uint64_t *m, const uint8_t *tuple, int len)\n /**\n * Bulk implementation for Toeplitz hash.\n *\n- * @warning\n- * @b EXPERIMENTAL: this API may change without prior notice.\n- *\n * @param m\n * Pointer to the matrices generated from the corresponding\n * RSS hash key using rte_thash_complete_matrix().\n@@ -207,7 +200,6 @@ rte_thash_gfni(const uint64_t *m, const uint8_t *tuple, int len)\n * @param num\n * Number of tuples to hash.\n */\n-__rte_experimental\n static inline void\n rte_thash_gfni_bulk(const uint64_t *mtrx, int len, uint8_t *tuple[],\n \tuint32_t val[], uint32_t num)\ndiff --git a/lib/hash/version.map b/lib/hash/version.map\nindex daaa9a8901db..b98b64a1638a 100644\n--- a/lib/hash/version.map\n+++ b/lib/hash/version.map\n@@ -30,25 +30,17 @@ DPDK_24 {\n \trte_hash_rcu_qsbr_add;\n \trte_hash_reset;\n \trte_hash_set_cmp_func;\n-\n-\tlocal: *;\n-};\n-\n-EXPERIMENTAL {\n-\tglobal:\n-\n-\t# added in 21.05\n \trte_thash_add_helper;\n \trte_thash_adjust_tuple;\n+\trte_thash_complete_matrix;\n \trte_thash_find_existing;\n \trte_thash_free_ctx;\n \trte_thash_get_complement;\n+\trte_thash_get_gfni_matrices;\n \trte_thash_get_helper;\n \trte_thash_get_key;\n+\trte_thash_gfni_supported;\n \trte_thash_init_ctx;\n \n-\t# added in 21.11\n-\trte_thash_complete_matrix;\n-\trte_thash_get_gfni_matrices;\n-\trte_thash_gfni_supported;\n+\tlocal: *;\n };\n", "prefixes": [ "v4", "11/28" ] }