Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/133017/?format=api
{ "id": 133017, "url": "http://patches.dpdk.org/api/patches/133017/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20231019172610.325081-1-timothy.miskell@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20231019172610.325081-1-timothy.miskell@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20231019172610.325081-1-timothy.miskell@intel.com", "date": "2023-10-19T17:26:10", "name": "[v2] net/ice: fix L1 check interval to account for longer link times", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "423ef48c68e6bc87ba85f905041ebd902f0d85b8", "submitter": { "id": 3210, "url": "http://patches.dpdk.org/api/people/3210/?format=api", "name": "Timothy Miskell", "email": "timothy.miskell@intel.com" }, "delegate": { "id": 1540, "url": "http://patches.dpdk.org/api/users/1540/?format=api", "username": "qzhan15", "first_name": "Qi", "last_name": "Zhang", "email": "qi.z.zhang@intel.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20231019172610.325081-1-timothy.miskell@intel.com/mbox/", "series": [ { "id": 29923, "url": "http://patches.dpdk.org/api/series/29923/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=29923", "date": "2023-10-19T17:26:10", "name": "[v2] net/ice: fix L1 check interval to account for longer link times", "version": 2, "mbox": "http://patches.dpdk.org/series/29923/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/133017/comments/", "check": "warning", "checks": "http://patches.dpdk.org/api/patches/133017/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id D2ED8431B0;\n\tThu, 19 Oct 2023 19:27:21 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id B592040276;\n\tThu, 19 Oct 2023 19:27:21 +0200 (CEST)", "from mgamail.intel.com (mgamail.intel.com [134.134.136.24])\n by mails.dpdk.org (Postfix) with ESMTP id B08444021F\n for <dev@dpdk.org>; Thu, 19 Oct 2023 19:27:19 +0200 (CEST)", "from fmsmga007.fm.intel.com ([10.253.24.52])\n by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 19 Oct 2023 10:26:51 -0700", "from wfp43-hdpae.hd.intel.com ([10.127.128.96])\n by fmsmga007.fm.intel.com with ESMTP; 19 Oct 2023 10:26:50 -0700" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1697736440; x=1729272440;\n h=from:to:cc:subject:date:message-id:mime-version:\n content-transfer-encoding;\n bh=MDEH7fTkmkgvKZ7Uy3/dJvAniVG1O+lsqD67xq79YjA=;\n b=KfGokJUsfZ/tuqQe73zGH3KKlqE+O90yMeWVJST4mRDNMtotRe/5dFfx\n nKpik+/KDRcTYkUIDHitqq3YvkytZfpO3TrrcgHBJ9tnt826IOFC4rG0a\n 1KsjvTKMIwHobGu9AneNemeqEGJP4KMeoGmAO4NuDkcan4cZCxEq8D1nz\n ljDMgEgINvH51maS3auQOds7OwGDIxO9tWE+K/mdi9ruGMFHLMcL5IvC/\n SwLK87piPxJ3MI5QLjmwOR4FEZs0Y3DuPLB9fB6OJHxb/Hq5jEBP5FRmo\n B5qSLfrprr6/RqeVV1EzP2G0XtycE5rlKnID+lTP85hLdn5cXo3/NzeWu g==;", "X-IronPort-AV": [ "E=McAfee;i=\"6600,9927,10868\"; a=\"389181929\"", "E=Sophos;i=\"6.03,237,1694761200\"; d=\"scan'208\";a=\"389181929\"", "E=McAfee;i=\"6600,9927,10868\"; a=\"760720826\"", "E=Sophos;i=\"6.03,237,1694761200\"; d=\"scan'208\";a=\"760720826\"" ], "X-ExtLoop1": "1", "From": "Timothy Miskell <timothy.miskell@intel.com>", "To": "qi.z.zhang@intel.com", "Cc": "dev@dpdk.org, Timothy Miskell <timothy.miskell@intel.com>,\n Jonathan Tsai <jonathan1.tsai@intel.com>", "Subject": "[PATCH v2] net/ice: fix L1 check interval to account for longer link\n times", "Date": "Thu, 19 Oct 2023 17:26:10 +0000", "Message-Id": "<20231019172610.325081-1-timothy.miskell@intel.com>", "X-Mailer": "git-send-email 2.25.1", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "For edge cases where the transceiver is physically inserted first and\nimmediately afterwards the DPDK PF is started the LSC event may occur\noutside the current setting for the maximum check interval window. This\nchange lengthens the check interval to account for this along with other\nreported cases where the link event may be longer than 1 second.\n\nSigned-off-by: Timothy Miskell <timothy.miskell@intel.com>\nTested-by: Jonathan Tsai <jonathan1.tsai@intel.com>\n---\n .mailmap | 2 ++\n drivers/net/ice/ice_ethdev.c | 4 ++--\n 2 files changed, 4 insertions(+), 2 deletions(-)", "diff": "diff --git a/.mailmap b/.mailmap\nindex 3f5bab26a8..93c09a23ee 100644\n--- a/.mailmap\n+++ b/.mailmap\n@@ -674,6 +674,7 @@ John Romein <romein@astron.nl>\n John W. Linville <linville@tuxdriver.com>\n Jonas Pfefferle <jpf@zurich.ibm.com> <pepperjo@japf.ch>\n Jonathan Erb <jonathan.erb@threatblockr.com> <jonathan.erb@banduracyber.com>\n+Jonathan Tsai <jonathan1.tsai@intel.com>\n Jon DeVree <nuxi@vault24.org>\n Jon Loeliger <jdl@netgate.com>\n Joongi Kim <joongi@an.kaist.ac.kr>\n@@ -1414,6 +1415,7 @@ Tianli Lai <laitianli@tom.com>\n Tianyu Li <tianyu.li@arm.com>\n Timmons C. Player <timmons.player@spirent.com>\n Timothy McDaniel <timothy.mcdaniel@intel.com>\n+Timothy Miskell <timothy.miskell@intel.com>\n Timothy Redaelli <tredaelli@redhat.com>\n Tim Shearer <tim.shearer@overturenetworks.com>\n Ting Xu <ting.xu@intel.com>\ndiff --git a/drivers/net/ice/ice_ethdev.c b/drivers/net/ice/ice_ethdev.c\nindex 305077e74e..6ef06b9926 100644\n--- a/drivers/net/ice/ice_ethdev.c\n+++ b/drivers/net/ice/ice_ethdev.c\n@@ -3992,8 +3992,8 @@ ice_atomic_write_link_status(struct rte_eth_dev *dev,\n static int\n ice_link_update(struct rte_eth_dev *dev, int wait_to_complete)\n {\n-#define CHECK_INTERVAL 100 /* 100ms */\n-#define MAX_REPEAT_TIME 10 /* 1s (10 * 100ms) in total */\n+#define CHECK_INTERVAL 50 /* 50ms */\n+#define MAX_REPEAT_TIME 40 /* 2s (40 * 50ms) in total */\n \tstruct ice_hw *hw = ICE_DEV_PRIVATE_TO_HW(dev->data->dev_private);\n \tstruct ice_link_status link_status;\n \tstruct rte_eth_link link, old;\n", "prefixes": [ "v2" ] }