Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/133008/?format=api
{ "id": 133008, "url": "http://patches.dpdk.org/api/patches/133008/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20231019165559.115742-22-stephen@networkplumber.org/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20231019165559.115742-22-stephen@networkplumber.org>", "list_archive_url": "https://inbox.dpdk.org/dev/20231019165559.115742-22-stephen@networkplumber.org", "date": "2023-10-19T16:55:50", "name": "[v3,21/29] security: remove experimental flag from macsec", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "ee7d2777b40834609f2e07af9c77ad01a70d9680", "submitter": { "id": 27, "url": "http://patches.dpdk.org/api/people/27/?format=api", "name": "Stephen Hemminger", "email": "stephen@networkplumber.org" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20231019165559.115742-22-stephen@networkplumber.org/mbox/", "series": [ { "id": 29922, "url": "http://patches.dpdk.org/api/series/29922/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=29922", "date": "2023-10-19T16:55:29", "name": "Promote experimental API's to stable.", "version": 3, "mbox": "http://patches.dpdk.org/series/29922/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/133008/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/133008/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id B2713431AE;\n\tThu, 19 Oct 2023 18:58:56 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 3D6BE42E52;\n\tThu, 19 Oct 2023 18:56:39 +0200 (CEST)", "from mail-ot1-f49.google.com (mail-ot1-f49.google.com\n [209.85.210.49]) by mails.dpdk.org (Postfix) with ESMTP id 1250142E03\n for <dev@dpdk.org>; Thu, 19 Oct 2023 18:56:28 +0200 (CEST)", "by mail-ot1-f49.google.com with SMTP id\n 46e09a7af769-6c0b8f42409so5546718a34.0\n for <dev@dpdk.org>; Thu, 19 Oct 2023 09:56:28 -0700 (PDT)", "from hermes.local (204-195-126-68.wavecable.com. [204.195.126.68])\n by smtp.gmail.com with ESMTPSA id\n y22-20020aa79436000000b00672ea40b8a9sm13988pfo.170.2023.10.19.09.56.26\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Thu, 19 Oct 2023 09:56:26 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1697734587;\n x=1698339387; darn=dpdk.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=RnGRESMpy1ysFXb/72yZioMZHnAOZlTf7cbicfT0L90=;\n b=Ues7XLs5m5UxanjFUMkM76qHLRE09vJob9Fp5sKciJWACii+o7HnWgP72dUnOUG+2c\n 8u3KzhDMUXjfSJmcgsTEXxyzewi6wbiNVFauVBbmodz6WUh0d4Y/1tckRnbsniF/3SBW\n 4ARqOo7Y8RYSJV9dyLcx+Fokl35AfC46jK4QywTfGcrXuE2nSjRi/EeoNyGpFZ1W7caS\n QhoPqxaAxNCkuOS8u3/56VQ4k6dCVNYLAKChDSsqILrmBD3NBgSR3NGyP6AaoYqAgOgc\n /8EuT5MFkCfnTj+y0bCDc3YeE6fk02OVYHHEWf5v0XQO00GH6rRnJKDlT1NClp2+xGIB\n onLQ==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20230601; t=1697734587; x=1698339387;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n :subject:date:message-id:reply-to;\n bh=RnGRESMpy1ysFXb/72yZioMZHnAOZlTf7cbicfT0L90=;\n b=EwUlAS60oSrQJTXoWvM5iShe4SKkBenxhO82EATy/OBl4JcdQA6LAISTnbEuhG9AN0\n 6R6urqJjtBo2ZyD5MbfaoSyOlepClvCY0AvQrgE7kgwlvXdzz4SoHS+POe7Tcq0A/mQD\n zvlRvgn6h2CsbilPkd48KwhMZoXK3aEkJRweV4sTFiUdgZMg+jxi+fWjTe/uAaydRrM+\n U/mh1ZVNUwE/SpSYZXg/QykYSx7FBUZ1KLb244vW3M1vpROfgdIDFMs5WWLbMhfRxQKP\n j6BeH6qc9GVQ6CUg/p9ksXkYj1eV8sBJLaWMFPEYzi77rV9R4UItQ1CgcN5kPSAMjmci\n rsYA==", "X-Gm-Message-State": "AOJu0YzL45WdaNuzdEgOTltbffe+HhbyIXdHcsThzhvmxJf82cHS+see\n cduWYEesEsRZo/Xy+HmXt9bx86s2jY/2+3X2h4LIqg==", "X-Google-Smtp-Source": "\n AGHT+IG0RLEKix4bvfaCEKcclbEGtcJ3XOQbyw9ixOPvCSrkcPdfuklUrt7ojn5k1YWJuTqxV7U4zQ==", "X-Received": "by 2002:a05:6830:1114:b0:6bd:b5f7:187a with SMTP id\n w20-20020a056830111400b006bdb5f7187amr3226277otq.20.1697734587133;\n Thu, 19 Oct 2023 09:56:27 -0700 (PDT)", "From": "Stephen Hemminger <stephen@networkplumber.org>", "To": "dev@dpdk.org", "Cc": "Stephen Hemminger <stephen@networkplumber.org>,\n Akhil Goyal <gakhil@marvell.com>", "Subject": "[PATCH v3 21/29] security: remove experimental flag from macsec", "Date": "Thu, 19 Oct 2023 09:55:50 -0700", "Message-Id": "<20231019165559.115742-22-stephen@networkplumber.org>", "X-Mailer": "git-send-email 2.39.2", "In-Reply-To": "<20231019165559.115742-1-stephen@networkplumber.org>", "References": "<20230808173527.186042-1-stephen@networkplumber.org>\n <20231019165559.115742-1-stephen@networkplumber.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "The rte_security API's for macsec were added in 22.11.\nTherefore remove the experimental tag.\n\nThere is also one helper function for setting packet\nmetadata that should have been marked internal.\n\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\n---\n lib/security/rte_security.h | 28 +---------------------------\n lib/security/version.map | 18 +++++++++---------\n 2 files changed, 10 insertions(+), 36 deletions(-)", "diff": "diff --git a/lib/security/rte_security.h b/lib/security/rte_security.h\nindex d2d2af23d5d2..ca78627ec7d2 100644\n--- a/lib/security/rte_security.h\n+++ b/lib/security/rte_security.h\n@@ -815,7 +815,6 @@ rte_security_session_create(void *instance,\n * - On success returns 0\n * - On failure returns a negative errno value.\n */\n-__rte_experimental\n int\n rte_security_session_update(void *instance,\n \t\t\t void *sess,\n@@ -851,9 +850,6 @@ int\n rte_security_session_destroy(void *instance, void *sess);\n \n /**\n- * @warning\n- * @b EXPERIMENTAL: this API may change without prior notice\n- *\n * Create MACsec security channel (SC).\n *\n * @param instance\tsecurity instance\n@@ -865,15 +861,11 @@ rte_security_session_destroy(void *instance, void *sess);\n * - -ENOMEM if PMD is not capable to create more SC.\n * - other negative value for other errors.\n */\n-__rte_experimental\n int\n rte_security_macsec_sc_create(void *instance,\n \t\t\t struct rte_security_macsec_sc *conf);\n \n /**\n- * @warning\n- * @b EXPERIMENTAL: this API may change without prior notice\n- *\n * Destroy MACsec security channel (SC).\n *\n * @param instance\tsecurity instance\n@@ -884,15 +876,11 @@ rte_security_macsec_sc_create(void *instance,\n * - -EINVAL if sc_id is invalid or instance is NULL.\n * - -EBUSY if sc is being used by some session.\n */\n-__rte_experimental\n int\n rte_security_macsec_sc_destroy(void *instance, uint16_t sc_id,\n \t\t\t enum rte_security_macsec_direction dir);\n \n /**\n- * @warning\n- * @b EXPERIMENTAL: this API may change without prior notice\n- *\n * Create MACsec security association (SA).\n *\n * @param instance\tsecurity instance\n@@ -904,15 +892,11 @@ rte_security_macsec_sc_destroy(void *instance, uint16_t sc_id,\n * - -ENOMEM if PMD is not capable to create more SAs.\n * - other negative value for other errors.\n */\n-__rte_experimental\n int\n rte_security_macsec_sa_create(void *instance,\n \t\t\t struct rte_security_macsec_sa *conf);\n \n /**\n- * @warning\n- * @b EXPERIMENTAL: this API may change without prior notice\n- *\n * Destroy MACsec security association (SA).\n *\n * @param instance\tsecurity instance\n@@ -923,7 +907,6 @@ rte_security_macsec_sa_create(void *instance,\n * - -EINVAL if sa_id is invalid or instance is NULL.\n * - -EBUSY if sa is being used by some session.\n */\n-__rte_experimental\n int\n rte_security_macsec_sa_destroy(void *instance, uint16_t sa_id,\n \t\t\t enum rte_security_macsec_direction dir);\n@@ -1059,7 +1042,7 @@ rte_security_session_fast_mdata_set(void *sess, uint64_t fdata)\n }\n \n /** Function to call PMD specific function pointer set_pkt_metadata() */\n-__rte_experimental\n+__rte_internal\n int __rte_security_set_pkt_metadata(void *instance,\n \t\t\t\t void *sess,\n \t\t\t\t struct rte_mbuf *m, void *params);\n@@ -1230,16 +1213,12 @@ struct rte_security_stats {\n * - On success, return 0\n * - On failure, a negative value\n */\n-__rte_experimental\n int\n rte_security_session_stats_get(void *instance,\n \t\t\t void *sess,\n \t\t\t struct rte_security_stats *stats);\n \n /**\n- * @warning\n- * @b EXPERIMENTAL: this API may change without prior notice\n- *\n * Get MACsec SA statistics.\n *\n * @param\tinstance\tsecurity instance\n@@ -1250,16 +1229,12 @@ rte_security_session_stats_get(void *instance,\n * - On success, return 0.\n * - On failure, a negative value.\n */\n-__rte_experimental\n int\n rte_security_macsec_sa_stats_get(void *instance,\n \t\t\t\t uint16_t sa_id, enum rte_security_macsec_direction dir,\n \t\t\t\t struct rte_security_macsec_sa_stats *stats);\n \n /**\n- * @warning\n- * @b EXPERIMENTAL: this API may change without prior notice\n- *\n * Get MACsec SC statistics.\n *\n * @param\tinstance\tsecurity instance\n@@ -1270,7 +1245,6 @@ rte_security_macsec_sa_stats_get(void *instance,\n * - On success, return 0.\n * - On failure, a negative value.\n */\n-__rte_experimental\n int\n rte_security_macsec_sc_stats_get(void *instance,\n \t\t\t\t uint16_t sc_id, enum rte_security_macsec_direction dir,\ndiff --git a/lib/security/version.map b/lib/security/version.map\nindex e07fca33a1e6..487822147fd3 100644\n--- a/lib/security/version.map\n+++ b/lib/security/version.map\n@@ -6,14 +6,6 @@ DPDK_24 {\n \trte_security_session_create;\n \trte_security_session_destroy;\n \trte_security_session_get_size;\n-\n-\tlocal: *;\n-};\n-\n-EXPERIMENTAL {\n-\tglobal:\n-\n-\t__rte_security_set_pkt_metadata;\n \trte_security_dynfield_offset;\n \trte_security_macsec_sa_create;\n \trte_security_macsec_sa_destroy;\n@@ -23,8 +15,15 @@ EXPERIMENTAL {\n \trte_security_macsec_sc_stats_get;\n \trte_security_session_stats_get;\n \trte_security_session_update;\n-\trte_security_oop_dynfield_offset;\n \n+\tlocal: *;\n+};\n+\n+EXPERIMENTAL {\n+\tglobal:\n+\n+\t# Added in 23.11\n+\trte_security_oop_dynfield_offset;\n \trte_security_rx_inject_configure;\n \trte_security_inb_pkt_rx_inject;\n };\n@@ -32,6 +31,7 @@ EXPERIMENTAL {\n INTERNAL {\n \tglobal:\n \n+\t__rte_security_set_pkt_metadata;\n \trte_security_dynfield_register;\n \trte_security_oop_dynfield_register;\n };\n", "prefixes": [ "v3", "21/29" ] }