Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/132987/?format=api
{ "id": 132987, "url": "http://patches.dpdk.org/api/patches/132987/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20231019163846.324098-1-timothy.miskell@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20231019163846.324098-1-timothy.miskell@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20231019163846.324098-1-timothy.miskell@intel.com", "date": "2023-10-19T16:38:46", "name": "ice: Increase L1 check interval to account for lengthier link time", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "423ef48c68e6bc87ba85f905041ebd902f0d85b8", "submitter": { "id": 3210, "url": "http://patches.dpdk.org/api/people/3210/?format=api", "name": "Timothy Miskell", "email": "timothy.miskell@intel.com" }, "delegate": { "id": 1540, "url": "http://patches.dpdk.org/api/users/1540/?format=api", "username": "qzhan15", "first_name": "Qi", "last_name": "Zhang", "email": "qi.z.zhang@intel.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20231019163846.324098-1-timothy.miskell@intel.com/mbox/", "series": [ { "id": 29921, "url": "http://patches.dpdk.org/api/series/29921/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=29921", "date": "2023-10-19T16:38:46", "name": "ice: Increase L1 check interval to account for lengthier link time", "version": 1, "mbox": "http://patches.dpdk.org/series/29921/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/132987/comments/", "check": "warning", "checks": "http://patches.dpdk.org/api/patches/132987/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id C2966431AE;\n\tThu, 19 Oct 2023 18:38:53 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 5C3A44021F;\n\tThu, 19 Oct 2023 18:38:53 +0200 (CEST)", "from mgamail.intel.com (mgamail.intel.com [192.55.52.43])\n by mails.dpdk.org (Postfix) with ESMTP id A560440150;\n Thu, 19 Oct 2023 18:38:51 +0200 (CEST)", "from orsmga005.jf.intel.com ([10.7.209.41])\n by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 19 Oct 2023 09:38:50 -0700", "from wfp43-hdpae.hd.intel.com ([10.127.128.96])\n by orsmga005.jf.intel.com with ESMTP; 19 Oct 2023 09:38:49 -0700" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1697733532; x=1729269532;\n h=from:to:cc:subject:date:message-id:mime-version:\n content-transfer-encoding;\n bh=hc9M5gtzIAWVlm02EJGGJtRGMQRI5hkCWeKPN5mewfo=;\n b=chox2ZKcjRPA+HAYB90pVv4rwEgLyd7SAQCubUvDn027ICNRIGzBkiU/\n SjUdLOSLH12Mzny0XveGdyag/DBCZDF8C9s/8X/1qKo+XjTvFb3XQuHQp\n +MWdbkud2Yj05Z3Q/agWTgSRkT9pne/bu2kO55+ioabDe5Dz1JZFlwLFC\n F261ab810ZEQ9aI2yC5Y7Jjr6Dk9oD0e4g1ZanYEniSnjEd8ZobDoOyxp\n UsuOwUeZdz1l4f71rmYdFqGxn1PyDsUDFODVD3fRAie/x1B7858l3Hdkl\n N0paHKWfN8JJiBhb2dgsbbI9+9rV2JnZibM4XqUiUbUYda6DZonP8+TVd Q==;", "X-IronPort-AV": [ "E=McAfee;i=\"6600,9927,10868\"; a=\"472534093\"", "E=Sophos;i=\"6.03,237,1694761200\"; d=\"scan'208\";a=\"472534093\"", "E=McAfee;i=\"6600,9927,10868\"; a=\"930680124\"", "E=Sophos;i=\"6.03,237,1694761200\"; d=\"scan'208\";a=\"930680124\"" ], "X-ExtLoop1": "1", "From": "Timothy Miskell <timothy.miskell@intel.com>", "To": "qi.z.zhang@intel.com", "Cc": "dev@dpdk.org, Timothy Miskell <timothy.miskell@intel.com>, stable@dpdk.org", "Subject": "[PATCH] ice: Increase L1 check interval to account for lengthier link\n time", "Date": "Thu, 19 Oct 2023 16:38:46 +0000", "Message-Id": "<20231019163846.324098-1-timothy.miskell@intel.com>", "X-Mailer": "git-send-email 2.25.1", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "For edge cases where the transceiver is physically inserted first and immediately afterwards the DPDK PF is started the LSC event may occur outside the current setting for the maximum check interval window. This change lengthens the check interval to account for this along with other reported cases where the link event be longer than 1 second.\n\nCc: stable@dpdk.org\n\nReported-by: Timothy Miskell\nSuggested-by: Timothy Miskell\nSigned-off-by: Timothy Miskell\nReviewed-by: Larry Wang\nTested-by: Jonathan Tsai\n---\n .mailmap | 2 ++\n drivers/net/ice/ice_ethdev.c | 4 ++--\n 2 files changed, 4 insertions(+), 2 deletions(-)", "diff": "diff --git a/.mailmap b/.mailmap\nindex 3f5bab26a8..93c09a23ee 100644\n--- a/.mailmap\n+++ b/.mailmap\n@@ -674,6 +674,7 @@ John Romein <romein@astron.nl>\n John W. Linville <linville@tuxdriver.com>\n Jonas Pfefferle <jpf@zurich.ibm.com> <pepperjo@japf.ch>\n Jonathan Erb <jonathan.erb@threatblockr.com> <jonathan.erb@banduracyber.com>\n+Jonathan Tsai <jonathan1.tsai@intel.com>\n Jon DeVree <nuxi@vault24.org>\n Jon Loeliger <jdl@netgate.com>\n Joongi Kim <joongi@an.kaist.ac.kr>\n@@ -1414,6 +1415,7 @@ Tianli Lai <laitianli@tom.com>\n Tianyu Li <tianyu.li@arm.com>\n Timmons C. Player <timmons.player@spirent.com>\n Timothy McDaniel <timothy.mcdaniel@intel.com>\n+Timothy Miskell <timothy.miskell@intel.com>\n Timothy Redaelli <tredaelli@redhat.com>\n Tim Shearer <tim.shearer@overturenetworks.com>\n Ting Xu <ting.xu@intel.com>\ndiff --git a/drivers/net/ice/ice_ethdev.c b/drivers/net/ice/ice_ethdev.c\nindex 305077e74e..6ef06b9926 100644\n--- a/drivers/net/ice/ice_ethdev.c\n+++ b/drivers/net/ice/ice_ethdev.c\n@@ -3992,8 +3992,8 @@ ice_atomic_write_link_status(struct rte_eth_dev *dev,\n static int\n ice_link_update(struct rte_eth_dev *dev, int wait_to_complete)\n {\n-#define CHECK_INTERVAL 100 /* 100ms */\n-#define MAX_REPEAT_TIME 10 /* 1s (10 * 100ms) in total */\n+#define CHECK_INTERVAL 50 /* 50ms */\n+#define MAX_REPEAT_TIME 40 /* 2s (40 * 50ms) in total */\n \tstruct ice_hw *hw = ICE_DEV_PRIVATE_TO_HW(dev->data->dev_private);\n \tstruct ice_link_status link_status;\n \tstruct rte_eth_link link, old;\n", "prefixes": [] }