Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 132815,
    "url": "http://patches.dpdk.org/api/patches/132815/?format=api",
    "web_url": "http://patches.dpdk.org/project/dpdk/patch/1697574677-16578-13-git-send-email-roretzla@linux.microsoft.com/",
    "project": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<1697574677-16578-13-git-send-email-roretzla@linux.microsoft.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/1697574677-16578-13-git-send-email-roretzla@linux.microsoft.com",
    "date": "2023-10-17T20:31:10",
    "name": "[v2,12/19] telemetry: use rte optional stdatomic API",
    "commit_ref": null,
    "pull_url": null,
    "state": "superseded",
    "archived": true,
    "hash": "25638a3ba0ae916de718384c73bcbf7ccfb9a2d6",
    "submitter": {
        "id": 2077,
        "url": "http://patches.dpdk.org/api/people/2077/?format=api",
        "name": "Tyler Retzlaff",
        "email": "roretzla@linux.microsoft.com"
    },
    "delegate": {
        "id": 24651,
        "url": "http://patches.dpdk.org/api/users/24651/?format=api",
        "username": "dmarchand",
        "first_name": "David",
        "last_name": "Marchand",
        "email": "david.marchand@redhat.com"
    },
    "mbox": "http://patches.dpdk.org/project/dpdk/patch/1697574677-16578-13-git-send-email-roretzla@linux.microsoft.com/mbox/",
    "series": [
        {
            "id": 29892,
            "url": "http://patches.dpdk.org/api/series/29892/?format=api",
            "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=29892",
            "date": "2023-10-17T20:30:58",
            "name": "use rte optional stdatomic API",
            "version": 2,
            "mbox": "http://patches.dpdk.org/series/29892/mbox/"
        }
    ],
    "comments": "http://patches.dpdk.org/api/patches/132815/comments/",
    "check": "warning",
    "checks": "http://patches.dpdk.org/api/patches/132815/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@inbox.dpdk.org",
        "Delivered-To": "patchwork@inbox.dpdk.org",
        "Received": [
            "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 7F75243190;\n\tTue, 17 Oct 2023 22:32:49 +0200 (CEST)",
            "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 7B5AE42E4F;\n\tTue, 17 Oct 2023 22:31:38 +0200 (CEST)",
            "from linux.microsoft.com (linux.microsoft.com [13.77.154.182])\n by mails.dpdk.org (Postfix) with ESMTP id 7B76F402EC\n for <dev@dpdk.org>; Tue, 17 Oct 2023 22:31:20 +0200 (CEST)",
            "by linux.microsoft.com (Postfix, from userid 1086)\n id 26DE920B74CC; Tue, 17 Oct 2023 13:31:18 -0700 (PDT)"
        ],
        "DKIM-Filter": "OpenDKIM Filter v2.11.0 linux.microsoft.com 26DE920B74CC",
        "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com;\n s=default; t=1697574679;\n bh=rY4lmR2gWxJMN7393MDpNdH7LXvEpEyXdr+d+xurNR4=;\n h=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n b=Jc+XYG1uv2W990pkWHqM+QBU5Qu6POI5lMSwB77kgYshfMgbd0NS9fsL4dn/mnQra\n n4o6CnMLwUKHuubnc/745ZAnbfLszjwtbUXfcg7me01zvWMps2JTrsfARI2z82loKL\n XSmTD81XRphrWOSF5yRnXB6TAc5iE46bWpf1hZAo=",
        "From": "Tyler Retzlaff <roretzla@linux.microsoft.com>",
        "To": "dev@dpdk.org",
        "Cc": "Akhil Goyal <gakhil@marvell.com>,\n Anatoly Burakov <anatoly.burakov@intel.com>,\n Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>,\n Bruce Richardson <bruce.richardson@intel.com>,\n Chenbo Xia <chenbo.xia@intel.com>, Ciara Power <ciara.power@intel.com>,\n David Christensen <drc@linux.vnet.ibm.com>,\n David Hunt <david.hunt@intel.com>,\n Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>,\n Dmitry Malloy <dmitrym@microsoft.com>,\n Elena Agostini <eagostini@nvidia.com>,\n Erik Gabriel Carrillo <erik.g.carrillo@intel.com>,\n Fan Zhang <fanzhang.oss@gmail.com>, Ferruh Yigit <ferruh.yigit@amd.com>,\n Harman Kalra <hkalra@marvell.com>,\n Harry van Haaren <harry.van.haaren@intel.com>,\n Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>,\n Jerin Jacob <jerinj@marvell.com>,\n Konstantin Ananyev <konstantin.v.ananyev@yandex.ru>,\n Matan Azrad <matan@nvidia.com>,\n Maxime Coquelin <maxime.coquelin@redhat.com>,\n Narcisa Ana Maria Vasile <navasile@linux.microsoft.com>,\n Nicolas Chautru <nicolas.chautru@intel.com>,\n Olivier Matz <olivier.matz@6wind.com>, Ori Kam <orika@nvidia.com>,\n Pallavi Kadam <pallavi.kadam@intel.com>,\n Pavan Nikhilesh <pbhagavatula@marvell.com>,\n Reshma Pattan <reshma.pattan@intel.com>,\n Sameh Gobriel <sameh.gobriel@intel.com>,\n Shijith Thotton <sthotton@marvell.com>,\n Sivaprasad Tummala <sivaprasad.tummala@amd.com>,\n Stephen Hemminger <stephen@networkplumber.org>,\n Suanming Mou <suanmingm@nvidia.com>, Sunil Kumar Kori <skori@marvell.com>,\n Thomas Monjalon <thomas@monjalon.net>,\n Viacheslav Ovsiienko <viacheslavo@nvidia.com>,\n Vladimir Medvedkin <vladimir.medvedkin@intel.com>,\n Yipeng Wang <yipeng1.wang@intel.com>,\n Tyler Retzlaff <roretzla@linux.microsoft.com>",
        "Subject": "[PATCH v2 12/19] telemetry: use rte optional stdatomic API",
        "Date": "Tue, 17 Oct 2023 13:31:10 -0700",
        "Message-Id": "<1697574677-16578-13-git-send-email-roretzla@linux.microsoft.com>",
        "X-Mailer": "git-send-email 1.8.3.1",
        "In-Reply-To": "<1697574677-16578-1-git-send-email-roretzla@linux.microsoft.com>",
        "References": "<1697497745-20664-1-git-send-email-roretzla@linux.microsoft.com>\n <1697574677-16578-1-git-send-email-roretzla@linux.microsoft.com>",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.29",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org"
    },
    "content": "Replace the use of gcc builtin __atomic_xxx intrinsics with\ncorresponding rte_atomic_xxx optional stdatomic API\n\nSigned-off-by: Tyler Retzlaff <roretzla@linux.microsoft.com>\n---\n lib/telemetry/telemetry.c | 18 +++++++++---------\n 1 file changed, 9 insertions(+), 9 deletions(-)",
    "diff": "diff --git a/lib/telemetry/telemetry.c b/lib/telemetry/telemetry.c\nindex aeb078c..9298284 100644\n--- a/lib/telemetry/telemetry.c\n+++ b/lib/telemetry/telemetry.c\n@@ -45,7 +45,7 @@ struct socket {\n \tint sock;\n \tchar path[sizeof(((struct sockaddr_un *)0)->sun_path)];\n \thandler fn;\n-\tuint16_t *num_clients;\n+\tRTE_ATOMIC(uint16_t) *num_clients;\n };\n static struct socket v2_socket; /* socket for v2 telemetry */\n static struct socket v1_socket; /* socket for v1 telemetry */\n@@ -64,7 +64,7 @@ struct socket {\n /* Used when accessing or modifying list of command callbacks */\n static rte_spinlock_t callback_sl = RTE_SPINLOCK_INITIALIZER;\n #ifndef RTE_EXEC_ENV_WINDOWS\n-static uint16_t v2_clients;\n+static RTE_ATOMIC(uint16_t) v2_clients;\n #endif /* !RTE_EXEC_ENV_WINDOWS */\n \n int\n@@ -404,7 +404,7 @@ struct socket {\n \t\tbytes = read(s, buffer, sizeof(buffer) - 1);\n \t}\n \tclose(s);\n-\t__atomic_fetch_sub(&v2_clients, 1, __ATOMIC_RELAXED);\n+\trte_atomic_fetch_sub_explicit(&v2_clients, 1, rte_memory_order_relaxed);\n \treturn NULL;\n }\n \n@@ -421,14 +421,14 @@ struct socket {\n \t\t\treturn NULL;\n \t\t}\n \t\tif (s->num_clients != NULL) {\n-\t\t\tuint16_t conns = __atomic_load_n(s->num_clients,\n-\t\t\t\t\t__ATOMIC_RELAXED);\n+\t\t\tuint16_t conns = rte_atomic_load_explicit(s->num_clients,\n+\t\t\t\t\trte_memory_order_relaxed);\n \t\t\tif (conns >= MAX_CONNECTIONS) {\n \t\t\t\tclose(s_accepted);\n \t\t\t\tcontinue;\n \t\t\t}\n-\t\t\t__atomic_fetch_add(s->num_clients, 1,\n-\t\t\t\t\t__ATOMIC_RELAXED);\n+\t\t\trte_atomic_fetch_add_explicit(s->num_clients, 1,\n+\t\t\t\t\trte_memory_order_relaxed);\n \t\t}\n \t\trc = pthread_create(&th, NULL, s->fn,\n \t\t\t\t    (void *)(uintptr_t)s_accepted);\n@@ -437,8 +437,8 @@ struct socket {\n \t\t\t\t strerror(rc));\n \t\t\tclose(s_accepted);\n \t\t\tif (s->num_clients != NULL)\n-\t\t\t\t__atomic_fetch_sub(s->num_clients, 1,\n-\t\t\t\t\t\t   __ATOMIC_RELAXED);\n+\t\t\t\trte_atomic_fetch_sub_explicit(s->num_clients, 1,\n+\t\t\t\t\t\t   rte_memory_order_relaxed);\n \t\t\tcontinue;\n \t\t}\n \t\tpthread_detach(th);\n",
    "prefixes": [
        "v2",
        "12/19"
    ]
}