Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/132729/?format=api
{ "id": 132729, "url": "http://patches.dpdk.org/api/patches/132729/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20231017080928.30454-10-getelson@nvidia.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20231017080928.30454-10-getelson@nvidia.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20231017080928.30454-10-getelson@nvidia.com", "date": "2023-10-17T08:09:21", "name": "[v3,09/16] net/mlx5: fix mirror action validation", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "31760c8f36cd1653b744d33a26dc8d32f3383880", "submitter": { "id": 1882, "url": "http://patches.dpdk.org/api/people/1882/?format=api", "name": "Gregory Etelson", "email": "getelson@nvidia.com" }, "delegate": { "id": 3268, "url": "http://patches.dpdk.org/api/users/3268/?format=api", "username": "rasland", "first_name": "Raslan", "last_name": "Darawsheh", "email": "rasland@nvidia.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20231017080928.30454-10-getelson@nvidia.com/mbox/", "series": [ { "id": 29872, "url": "http://patches.dpdk.org/api/series/29872/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=29872", "date": "2023-10-17T08:09:12", "name": "net/mlx5: support indirect actions list", "version": 3, "mbox": "http://patches.dpdk.org/series/29872/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/132729/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/132729/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id E5D9E4318A;\n\tTue, 17 Oct 2023 10:11:16 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id A75F542DC7;\n\tTue, 17 Oct 2023 10:10:34 +0200 (CEST)", "from NAM11-BN8-obe.outbound.protection.outlook.com\n (mail-bn8nam11on2040.outbound.protection.outlook.com [40.107.236.40])\n by mails.dpdk.org (Postfix) with ESMTP id 04AE442DB0\n for <dev@dpdk.org>; Tue, 17 Oct 2023 10:10:33 +0200 (CEST)", "from BL1PR13CA0018.namprd13.prod.outlook.com (2603:10b6:208:256::23)\n by DS7PR12MB6215.namprd12.prod.outlook.com (2603:10b6:8:95::7) with\n Microsoft\n SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.20.6886.36; Tue, 17 Oct 2023 08:10:31 +0000", "from MN1PEPF0000F0DE.namprd04.prod.outlook.com\n (2603:10b6:208:256:cafe::3e) by BL1PR13CA0018.outlook.office365.com\n (2603:10b6:208:256::23) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6907.16 via Frontend\n Transport; Tue, 17 Oct 2023 08:10:31 +0000", "from mail.nvidia.com (216.228.117.161) by\n MN1PEPF0000F0DE.mail.protection.outlook.com (10.167.242.36) with Microsoft\n SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.20.6838.22 via Frontend Transport; Tue, 17 Oct 2023 08:10:30 +0000", "from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com\n (10.129.200.67) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.41; Tue, 17 Oct\n 2023 01:10:16 -0700", "from nvidia.com (10.126.230.35) by rnnvmail201.nvidia.com\n (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.41; Tue, 17 Oct\n 2023 01:10:13 -0700" ], "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;\n b=WV5SUgjy7qgL2AmysJvJYcoHmfR5ZOGuM7661k8/eOEE6paMWttCdSn2tj2n8PhdCI7WbvHP1QobKmp3SzroNOgqTRv9ZYL5c6d0xg+Nrudp0FVRDJGLF2HkOZwEun+UyvA1iihWOT1UIBt6hsXF6EaWc5vUW95bI2hFbjp4YQ4S/ObKPKICue0e2CtO4e4wjA5fohQO7tnA0OBBzSKmkykfFQY+HF485JQfAL25Hq0kFKWQNSZ3TPMEzwOjklCNCBIPxs64ot2uILsQgk8cgOD7laPdB0LdIlRtj3e1kJ8cEHLbSJY4cGYnGYpiHieF9xo3nPyeg5ERx0h9isTuIA==", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector9901;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=q7fajYsP6CdPQ1ktqJcCbx36ZD49WdMhztW09vR85O0=;\n b=VE5RbYpD0HqodrhX9G99K79iaf/z1N0yQ0UZaMsOLRuOp5VeBNMZS1fpQ+ZkGyqGFaSs+TFPa88fIu0UUj3KQhtjXrVx9Z766/aklOHbRaIFFr+u6PNh2ghv8QKqtnDoWf/WqnxfyF4g7ff7btuJ5wue+TJWozqXgYqfM5yKfBCUEh8mf2eWCwPqZNhMuv2bPnb5WK+f2zS615zTF41CKmYf4GJ7qz+g4fgNIk6Ob+eUR5sP8QYXYg1/n5siSRTrFrw/pYTeG1BPE1NfyAgCFru/DPQk0Q1xA99Udo74gtZIzajKYixImK9KUoLZ7aM2Bm4XEfk7plmQJRDzHPbTqQ==", "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass (sender ip is\n 216.228.117.161) smtp.rcpttodomain=dpdk.org smtp.mailfrom=nvidia.com;\n dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com;\n dkim=none (message not signed); arc=none", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com;\n s=selector2;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=q7fajYsP6CdPQ1ktqJcCbx36ZD49WdMhztW09vR85O0=;\n b=UGIXyL5Rq+Cugb6hqLuDgxm7WUpHkJqvKJ7HD8p2YRi/1DFx/HuASbiZnDDM/wU+/XZXaVlBovxDpeAjbKeZ9kp3exBm6WccM54wqF0cz1UyCD8STOLexx56+Cb2YGGTVAnQMfvbDdd6U28uTQR0jVKpq6vPqnXWo1Wh6EMMK9aP5BMiuMcU6WVTDQpdDy3WZcYfLTKDJx8B1GJ53UOsyyKwKBMc4Ea5XKhB5s5/q1Yo5NSQMHl07XWVwaBNogCRMlh3zYf8NMSUnVls//HiaYKz4XKFq1JJ4EIxlFHuUJZODITQvLlBr5TYLywFQYcsovk0vwlje8h+2a6go4A8+Q==", "X-MS-Exchange-Authentication-Results": "spf=pass (sender IP is 216.228.117.161)\n smtp.mailfrom=nvidia.com;\n dkim=none (message not signed)\n header.d=none;dmarc=pass action=none header.from=nvidia.com;", "Received-SPF": "Pass (protection.outlook.com: domain of nvidia.com designates\n 216.228.117.161 as permitted sender) receiver=protection.outlook.com;\n client-ip=216.228.117.161; helo=mail.nvidia.com; pr=C", "From": "Gregory Etelson <getelson@nvidia.com>", "To": "<dev@dpdk.org>", "CC": "<getelson@nvidia.com>, =?utf-8?b?wqA=?= <mkashani@nvidia.com>,\n <rasland@nvidia.com>, Suanming Mou <suanmingm@nvidia.com>,\n Matan Azrad <matan@nvidia.com>,\n Viacheslav Ovsiienko <viacheslavo@nvidia.com>, Ori Kam <orika@nvidia.com>", "Subject": "[PATCH v3 09/16] net/mlx5: fix mirror action validation", "Date": "Tue, 17 Oct 2023 11:09:21 +0300", "Message-ID": "<20231017080928.30454-10-getelson@nvidia.com>", "X-Mailer": "git-send-email 2.39.2", "In-Reply-To": "<20231017080928.30454-1-getelson@nvidia.com>", "References": "<20230927191046.405282-1-getelson@nvidia.com>\n <20231017080928.30454-1-getelson@nvidia.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Originating-IP": "[10.126.230.35]", "X-ClientProxiedBy": "rnnvmail203.nvidia.com (10.129.68.9) To\n rnnvmail201.nvidia.com (10.129.68.8)", "X-EOPAttributedMessage": "0", "X-MS-PublicTrafficType": "Email", "X-MS-TrafficTypeDiagnostic": "MN1PEPF0000F0DE:EE_|DS7PR12MB6215:EE_", "X-MS-Office365-Filtering-Correlation-Id": "025018d4-0965-4398-48d9-08dbcee887f3", "X-MS-Exchange-SenderADCheck": "1", "X-MS-Exchange-AntiSpam-Relay": "0", "X-Microsoft-Antispam": "BCL:0;", "X-Microsoft-Antispam-Message-Info": "\n lKc4dRZ8NSygs0D1nhL7prlCqwkMWwaAZjLle5goXdsjfcEuCXDW9d9FT0YevOTZ/Dbx1AcxQIRThs7Rf2wO/7qNENbVs4VO70hEJyIbKa1+CNmAXY3QYj+qBAWTYIlPKiFkkP6SIVw+YaiYWrSpP3dPOrBt+NzKwu5GgxH7klU9ipkX69bsRU8ZWFd2VzJEAXd8wxjJWt+1Yyl0izMIlb5uZQVvqc4keancG8ws60RQr/oMj7DUPH2m7hIxj2+EXJfg3eVU6mzXxYBP7Nvzs6Ad5DkuOu8PyIq1V12cPu3JOWAEQ7fWPRPA8l36TihzRrGM591kQtuyfaARByaG8xxDb9iuTl1wr80Vv3Xu/TmXtEz5Yu6Vxc0siZMpY/EaJWMqR2n46iU7mYMxr0pv2sd8sgvOGg0+lZi7vzBlhTd+z+l4vhE0C8YkPsPueZZBF7VfbxCDIHfewLXcZd2LwVg6SivxllQ4wLizaWVQC3qB0TPQ1d2e+EZ+cR3dr9sSUSiDtwZSHXSleb4KsiO01NWD2NmWK69yPBfz3tSXaEFLUpM411gkyrdqSSoNwu1GdlXm2lPdMsWzHqMDKe2NiIY1zqUIDoqjBkd88sTYw/KSy63vTa16xvvUBcAYglBVXrTl6g9JrXcHZ6Tzqb9WluDiehHjsWEvrqN1Z8IIhq/OoZwmyvO/nHLxZfbxi5nISbj8UcGtPGWXE5Fr0wLzHzh5tGUw9D4Nc3ahpf/NdU0=", "X-Forefront-Antispam-Report": "CIP:216.228.117.161; CTRY:US; LANG:en; SCL:1;\n SRV:;\n IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge2.nvidia.com; CAT:NONE;\n SFS:(13230031)(4636009)(396003)(39860400002)(376002)(136003)(346002)(230922051799003)(186009)(1800799009)(451199024)(64100799003)(82310400011)(36840700001)(46966006)(40470700004)(86362001)(40480700001)(82740400003)(36756003)(55016003)(40460700003)(478600001)(6916009)(316002)(5660300002)(54906003)(70586007)(70206006)(7636003)(356005)(6666004)(7696005)(36860700001)(47076005)(26005)(336012)(1076003)(16526019)(2616005)(426003)(6286002)(4326008)(8936002)(8676002)(83380400001)(107886003)(2906002)(41300700001);\n DIR:OUT; SFP:1101;", "X-OriginatorOrg": "Nvidia.com", "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "17 Oct 2023 08:10:30.9628 (UTC)", "X-MS-Exchange-CrossTenant-Network-Message-Id": "\n 025018d4-0965-4398-48d9-08dbcee887f3", "X-MS-Exchange-CrossTenant-Id": "43083d15-7273-40c1-b7db-39efd9ccc17a", "X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp": "\n TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.161];\n Helo=[mail.nvidia.com]", "X-MS-Exchange-CrossTenant-AuthSource": "\n MN1PEPF0000F0DE.namprd04.prod.outlook.com", "X-MS-Exchange-CrossTenant-AuthAs": "Anonymous", "X-MS-Exchange-CrossTenant-FromEntityHeader": "HybridOnPrem", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "DS7PR12MB6215", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "HWS mirror flow action validation rejected flows in NIC domain,\nif PMD FDB mode was active.\n\nThe patch allows NIC mirror action in FDB mode.\n\nFixes: 0284c9b82ee8 (\"net/mlx5: support HWS mirror action\")\nSigned-off-by: Gregory Etelson <getelson@nvidia.com>\nAcked-by: Suanming Mou <suanmingm@nvidia.com>\n---\n drivers/net/mlx5/mlx5_flow_hw.c | 20 +++++++++++++-------\n 1 file changed, 13 insertions(+), 7 deletions(-)", "diff": "diff --git a/drivers/net/mlx5/mlx5_flow_hw.c b/drivers/net/mlx5/mlx5_flow_hw.c\nindex 44ed23b1fd..910d42a5f5 100644\n--- a/drivers/net/mlx5/mlx5_flow_hw.c\n+++ b/drivers/net/mlx5/mlx5_flow_hw.c\n@@ -9547,14 +9547,15 @@ mlx5_mirror_terminal_action(const struct rte_flow_action *action)\n \n static bool\n mlx5_mirror_validate_sample_action(struct rte_eth_dev *dev,\n-\tconst struct rte_flow_action *action)\n+\t\t\t\t const struct rte_flow_attr *flow_attr,\n+\t\t\t\t const struct rte_flow_action *action)\n {\n \tstruct mlx5_priv *priv = dev->data->dev_private;\n \n \tswitch(action->type) {\n \tcase RTE_FLOW_ACTION_TYPE_QUEUE:\n \tcase RTE_FLOW_ACTION_TYPE_RSS:\n-\t\tif (priv->sh->esw_mode)\n+\t\tif (flow_attr->transfer)\n \t\t\treturn false;\n \t\tbreak;\n \tcase RTE_FLOW_ACTION_TYPE_REPRESENTED_PORT:\n@@ -9562,7 +9563,7 @@ mlx5_mirror_validate_sample_action(struct rte_eth_dev *dev,\n \tcase RTE_FLOW_ACTION_TYPE_RAW_DECAP:\n \tcase RTE_FLOW_ACTION_TYPE_VXLAN_ENCAP:\n \tcase RTE_FLOW_ACTION_TYPE_NVGRE_ENCAP:\n-\t\tif (!priv->sh->esw_mode)\n+\t\tif (!priv->sh->esw_mode && !flow_attr->transfer)\n \t\t\treturn false;\n \t\tif (action[0].type == RTE_FLOW_ACTION_TYPE_RAW_DECAP &&\n \t\t action[1].type != RTE_FLOW_ACTION_TYPE_RAW_ENCAP)\n@@ -9584,19 +9585,22 @@ mlx5_mirror_validate_sample_action(struct rte_eth_dev *dev,\n */\n static int\n mlx5_hw_mirror_actions_list_validate(struct rte_eth_dev *dev,\n+\t\t\t\t const struct rte_flow_attr *flow_attr,\n \t\t\t\t const struct rte_flow_action *actions)\n {\n \tif (actions[0].type == RTE_FLOW_ACTION_TYPE_SAMPLE) {\n \t\tint i = 1;\n \t\tbool valid;\n \t\tconst struct rte_flow_action_sample *sample = actions[0].conf;\n-\t\tvalid = mlx5_mirror_validate_sample_action(dev, sample->actions);\n+\t\tvalid = mlx5_mirror_validate_sample_action(dev, flow_attr,\n+\t\t\t\t\t\t\t sample->actions);\n \t\tif (!valid)\n \t\t\treturn -EINVAL;\n \t\tif (actions[1].type == RTE_FLOW_ACTION_TYPE_SAMPLE) {\n \t\t\ti = 2;\n \t\t\tsample = actions[1].conf;\n-\t\t\tvalid = mlx5_mirror_validate_sample_action(dev, sample->actions);\n+\t\t\tvalid = mlx5_mirror_validate_sample_action(dev, flow_attr,\n+\t\t\t\t\t\t\t\t sample->actions);\n \t\t\tif (!valid)\n \t\t\t\treturn -EINVAL;\n \t\t}\n@@ -9780,15 +9784,17 @@ mlx5_hw_mirror_handle_create(struct rte_eth_dev *dev,\n \tstruct mlx5_mirror *mirror;\n \tenum mlx5dr_table_type table_type;\n \tstruct mlx5_priv *priv = dev->data->dev_private;\n+\tconst struct rte_flow_attr *flow_attr = &table_cfg->attr.flow_attr;\n \tstruct mlx5dr_action_dest_attr mirror_attr[MLX5_MIRROR_MAX_CLONES_NUM + 1];\n \tenum mlx5dr_action_type array_action_types[MLX5_MIRROR_MAX_CLONES_NUM + 1]\n \t\t\t\t\t\t [MLX5_MIRROR_MAX_SAMPLE_ACTIONS_LEN + 1];\n \n \tmemset(mirror_attr, 0, sizeof(mirror_attr));\n \tmemset(array_action_types, 0, sizeof(array_action_types));\n-\ttable_type = get_mlx5dr_table_type(&table_cfg->attr.flow_attr);\n+\ttable_type = get_mlx5dr_table_type(flow_attr);\n \thws_flags = mlx5_hw_act_flag[MLX5_HW_ACTION_FLAG_NONE_ROOT][table_type];\n-\tclones_num = mlx5_hw_mirror_actions_list_validate(dev, actions);\n+\tclones_num = mlx5_hw_mirror_actions_list_validate(dev, flow_attr,\n+\t\t\t\t\t\t\t actions);\n \tif (clones_num < 0) {\n \t\trte_flow_error_set(error, EINVAL, RTE_FLOW_ERROR_TYPE_ACTION,\n \t\t\t\t actions, \"Invalid mirror list format\");\n", "prefixes": [ "v3", "09/16" ] }