Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/132536/?format=api
{ "id": 132536, "url": "http://patches.dpdk.org/api/patches/132536/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20231011092805.693171-31-haijie1@huawei.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20231011092805.693171-31-haijie1@huawei.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20231011092805.693171-31-haijie1@huawei.com", "date": "2023-10-11T09:27:55", "name": "[v5,30/40] net/null: check RSS hash algorithms", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": true, "hash": "635bcb47e9635b5ddf768dfa12834a521977ebbc", "submitter": { "id": 2935, "url": "http://patches.dpdk.org/api/people/2935/?format=api", "name": "Jie Hai", "email": "haijie1@huawei.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20231011092805.693171-31-haijie1@huawei.com/mbox/", "series": [ { "id": 29816, "url": "http://patches.dpdk.org/api/series/29816/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=29816", "date": "2023-10-11T09:27:25", "name": "support setting and querying RSS algorithms", "version": 5, "mbox": "http://patches.dpdk.org/series/29816/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/132536/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/132536/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 066F14235E;\n\tWed, 11 Oct 2023 11:34:23 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 58AB042D2A;\n\tWed, 11 Oct 2023 11:32:07 +0200 (CEST)", "from szxga08-in.huawei.com (szxga08-in.huawei.com [45.249.212.255])\n by mails.dpdk.org (Postfix) with ESMTP id 71C3F40ED0\n for <dev@dpdk.org>; Wed, 11 Oct 2023 11:31:43 +0200 (CEST)", "from kwepemi500020.china.huawei.com (unknown [172.30.72.57])\n by szxga08-in.huawei.com (SkyGuard) with ESMTP id 4S56sc6JH6z1M98r\n for <dev@dpdk.org>; Wed, 11 Oct 2023 17:29:08 +0800 (CST)", "from localhost.localdomain (10.67.165.2) by\n kwepemi500020.china.huawei.com (7.221.188.8) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id\n 15.1.2507.31; Wed, 11 Oct 2023 17:31:42 +0800" ], "From": "Jie Hai <haijie1@huawei.com>", "To": "<dev@dpdk.org>, Tetsuya Mukawa <mtetsuyah@gmail.com>", "CC": "<lihuisong@huawei.com>, <fengchengwen@huawei.com>,\n <liudongdong3@huawei.com>", "Subject": "[PATCH v5 30/40] net/null: check RSS hash algorithms", "Date": "Wed, 11 Oct 2023 17:27:55 +0800", "Message-ID": "<20231011092805.693171-31-haijie1@huawei.com>", "X-Mailer": "git-send-email 2.30.0", "In-Reply-To": "<20231011092805.693171-1-haijie1@huawei.com>", "References": "<20230908080030.3837515-1-haijie1@huawei.com>\n <20231011092805.693171-1-haijie1@huawei.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Originating-IP": "[10.67.165.2]", "X-ClientProxiedBy": "dggems704-chm.china.huawei.com (10.3.19.181) To\n kwepemi500020.china.huawei.com (7.221.188.8)", "X-CFilter-Loop": "Reflected", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "A new field 'algorithm' has been added to rss_conf, check it\nin case of ignoring unsupported values.\n\nSigned-off-by: Jie Hai <haijie1@huawei.com>\n---\n drivers/net/null/rte_eth_null.c | 8 ++++++++\n 1 file changed, 8 insertions(+)", "diff": "diff --git a/drivers/net/null/rte_eth_null.c b/drivers/net/null/rte_eth_null.c\nindex 31081af79752..8427d7484178 100644\n--- a/drivers/net/null/rte_eth_null.c\n+++ b/drivers/net/null/rte_eth_null.c\n@@ -186,6 +186,11 @@ eth_null_copy_tx(void *q, struct rte_mbuf **bufs, uint16_t nb_bufs)\n static int\n eth_dev_configure(struct rte_eth_dev *dev __rte_unused)\n {\n+\tif ((dev->data->dev_conf.rxmode.mq_mode & RTE_ETH_MQ_RX_RSS_FLAG) &&\n+\t dev->data->dev_conf.rx_adv_conf.rss_conf.algorithm !=\n+\t RTE_ETH_HASH_FUNCTION_DEFAULT)\n+\t\treturn -EINVAL;\n+\n \treturn 0;\n }\n \n@@ -444,6 +449,9 @@ eth_rss_hash_update(struct rte_eth_dev *dev, struct rte_eth_rss_conf *rss_conf)\n \n \trte_spinlock_lock(&internal->rss_lock);\n \n+\tif (rss_conf->algorithm != RTE_ETH_HASH_FUNCTION_DEFAULT)\n+\t\treturn -EINVAL;\n+\n \tif ((rss_conf->rss_hf & internal->flow_type_rss_offloads) != 0)\n \t\tdev->data->dev_conf.rx_adv_conf.rss_conf.rss_hf =\n \t\t\t\trss_conf->rss_hf & internal->flow_type_rss_offloads;\n", "prefixes": [ "v5", "30/40" ] }