Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/132453/?format=api
{ "id": 132453, "url": "http://patches.dpdk.org/api/patches/132453/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20231010061727.205886-2-chaoyong.he@corigine.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20231010061727.205886-2-chaoyong.he@corigine.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20231010061727.205886-2-chaoyong.he@corigine.com", "date": "2023-10-10T06:17:26", "name": "[1/2] net/nfp: fix checking return value", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "c5247d94b5aff787e5f58e3e04933e612c54c968", "submitter": { "id": 2554, "url": "http://patches.dpdk.org/api/people/2554/?format=api", "name": "Chaoyong He", "email": "chaoyong.he@corigine.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20231010061727.205886-2-chaoyong.he@corigine.com/mbox/", "series": [ { "id": 29786, "url": "http://patches.dpdk.org/api/series/29786/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=29786", "date": "2023-10-10T06:17:25", "name": "Fix two converity issue of NFP PMD", "version": 1, "mbox": "http://patches.dpdk.org/series/29786/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/132453/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/132453/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 785F742348;\n\tTue, 10 Oct 2023 08:17:54 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 7BEA6402F1;\n\tTue, 10 Oct 2023 08:17:50 +0200 (CEST)", "from NAM11-BN8-obe.outbound.protection.outlook.com\n (mail-bn8nam11on2100.outbound.protection.outlook.com [40.107.236.100])\n by mails.dpdk.org (Postfix) with ESMTP id E384840278;\n Tue, 10 Oct 2023 08:17:48 +0200 (CEST)", "from SJ0PR13MB5545.namprd13.prod.outlook.com (2603:10b6:a03:424::5)\n by DM8PR13MB5192.namprd13.prod.outlook.com (2603:10b6:8:6::6) with\n Microsoft\n SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.20.6863.38; Tue, 10 Oct 2023 06:17:47 +0000", "from SJ0PR13MB5545.namprd13.prod.outlook.com\n ([fe80::2d5:f7d6:ecde:c93a]) by SJ0PR13MB5545.namprd13.prod.outlook.com\n ([fe80::2d5:f7d6:ecde:c93a%4]) with mapi id 15.20.6863.032; Tue, 10 Oct 2023\n 06:17:47 +0000" ], "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;\n b=PQMURM9D2ELB6h9a62qTYym1tjfrDOTc1XUJ6S6RalsvZPVLZO/edvnRFrhdaNwwF0OZ5R/Rq3iZhfVZ8sAreG3HpscyxWtrdf189Q4SDvZ4yqK9Xisssl7XqqZ9NuzHfhtvTaX05wpd6IoGDTSeNiEDdX15DLZE322/G3GGyF1LYGs7cBr77RVSbORTKca8XYkkyth3Wmu6Br51HjioiR/RiobdCc5rL8FhVESHeCDuqZ2oM+cr8galgKDE/8Q3lvglfxQk2JZtUQ6VTBN2th9IsIA2ZGgppSjaGRAhG+pWfWfpIeEMp7dKUeqcoHaA7oQFbZD7Fp5JPs9xGx3RYA==", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector9901;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=rI3D5c9g2+u36RFoOlyGgUVpbe0J2R9vlbQ/10H9P5A=;\n b=nwhplDytpnT/+KFnYDKqG4hzZXHBUc1iA+jLiQHSAqj0C2xlT3CohmjjcNkHs5tc5YOaBWIrJ58pvzab1zuYZxoCeA3d9CCk1dSuBuIw+iRYGMfxOQnaSmBvfpwG7AZYFockTw8NONrET+pP4IKV7VFnpuiXGmxg1tPO0GnJmkqMQDPpVjqZHwjFY9Ax7NVqeO4n0FpTjkB3RbnqSJDWnoLxXzzKgMhcUsKZyQbQF29ydAwX2jlCJickr1gcn9HqrNN9MG8U+5JMPSs/DQ7mgy9WBTnO3z+1ubM2HAIEIUkjM+YWYOfSm6grR+lamfOyMJ9j0GdedtssVNbf0Cr7yw==", "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass\n smtp.mailfrom=corigine.com; dmarc=pass action=none header.from=corigine.com;\n dkim=pass header.d=corigine.com; arc=none", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=corigine.onmicrosoft.com; s=selector2-corigine-onmicrosoft-com;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=rI3D5c9g2+u36RFoOlyGgUVpbe0J2R9vlbQ/10H9P5A=;\n b=voPBIK3/mbj8RD6t2l7A5R4nnPc06v/asYzvH9+G0yD0JLSqDfhcpw8g5qxCKwHVjM/UWno+RCpLqWDYcauwSO7EOhdfByMPS2vJ7xGjGrgBUm4wG6foI14SsXDEoszlGxDcnzStSlFS9IamH1caE9sFuKuREXKYkFMurDYd6Uo=", "Authentication-Results": "dkim=none (message not signed)\n header.d=none;dmarc=none action=none header.from=corigine.com;", "From": "Chaoyong He <chaoyong.he@corigine.com>", "To": "dev@dpdk.org", "Cc": "oss-drivers@corigine.com, Long Wu <long.wu@corigine.com>,\n chaoyong.he@corigine.com, stable@dpdk.org,\n Peng Zhang <peng.zhang@corigine.com>", "Subject": "[PATCH 1/2] net/nfp: fix checking return value", "Date": "Tue, 10 Oct 2023 14:17:26 +0800", "Message-Id": "<20231010061727.205886-2-chaoyong.he@corigine.com>", "X-Mailer": "git-send-email 2.39.1", "In-Reply-To": "<20231010061727.205886-1-chaoyong.he@corigine.com>", "References": "<20231010061727.205886-1-chaoyong.he@corigine.com>", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-ClientProxiedBy": "PH7PR17CA0023.namprd17.prod.outlook.com\n (2603:10b6:510:324::24) To SJ0PR13MB5545.namprd13.prod.outlook.com\n (2603:10b6:a03:424::5)", "MIME-Version": "1.0", "X-MS-PublicTrafficType": "Email", "X-MS-TrafficTypeDiagnostic": "SJ0PR13MB5545:EE_|DM8PR13MB5192:EE_", "X-MS-Office365-Filtering-Correlation-Id": "6a03e302-d6dc-4fb6-b83e-08dbc9589f7a", "X-MS-Exchange-SenderADCheck": "1", "X-MS-Exchange-AntiSpam-Relay": "0", "X-Microsoft-Antispam": "BCL:0;", "X-Microsoft-Antispam-Message-Info": "\n rvOAfz5QXi9v4Vpn8mzb4H9q4QPzfedAjqtlnpcrPfksUm4n3w/ZJiI2AZdO34f1wny2V7M0lL5ZlgP/lrGZ1bw/rRzJPiPy9yoIizZUD3NfILJ6+N5ngc0EvYeIAZYdrl0/XgvtPNgFcjJKFfdrZ59f1cyW2hhyaH6HOVAUsvZmDUvpfwSl5Ar/L8wgxKsjpEAqxXjonrW0Aq+XwSw8jdhSGPOX+IIjGeqrQiN9SvhJ2fOWTezB9GSiAogEmbfDf1wbWJAqsgCkrilNdaDMc5lHp83nR2q5ht7wUyflI+6nZDD8Dfx3zS8RSHrDFaAWP2nW+WmHYeAMJ+Gz58FqlXZWMi5oyMjJ+QrTtTGA9g9PyVqHaP/SoesWZnTL0gWg6Vm0TCsgX2MyMlPDmEuUnb5th2ASBYImJQbvV/F0XsESHNP8mIayLdirtJ7jrt1eri8mdUSWXbCVJuXeE89F0WJ32EBFCKZxIlHlooP37R05nVik+IgBu2oF0VFx44Ul6aBRwRrwJTDn1DYx9pfQdl/NHf2xqlghK1VU6DuV+90wpzH6RSFPTnp36fQNW7UKTr38ul+8g2VZfeqtSiKWm9q5tm9Cy9Y4UoPLnrx2iNPzI3CI0usj/ogtOHObh+QS5hGm9M3ZURRpRuk75a1TKAqqePKPvVfxjwLJQ26nw6Q=", "X-Forefront-Antispam-Report": "CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;\n IPV:NLI; SFV:NSPM; H:SJ0PR13MB5545.namprd13.prod.outlook.com; PTR:; CAT:NONE;\n SFS:(13230031)(396003)(39830400003)(136003)(376002)(346002)(366004)(230922051799003)(451199024)(64100799003)(186009)(1800799009)(5660300002)(450100002)(41300700001)(8936002)(8676002)(4326008)(44832011)(86362001)(2906002)(52116002)(6506007)(6512007)(6666004)(478600001)(107886003)(83380400001)(36756003)(1076003)(2616005)(26005)(316002)(6916009)(66946007)(66476007)(66556008)(38350700002)(38100700002)(54906003)(6486002);\n DIR:OUT; SFP:1102;", "X-MS-Exchange-AntiSpam-MessageData-ChunkCount": "1", "X-MS-Exchange-AntiSpam-MessageData-0": "\n SF+c2PX70t0soQvQUIdI+ZRf2wcHF2L0IpRrzUWHQ3+fZbd6+WwObRh2aPIdBn/QFgwJPyxHB/XYlImP/59r3EifauV7UQObWReXRQpyy8kbD7/iNibE7uQWDZ3ssz1EOYQvKmm0p8lTx0yU8MVuUejmRiG+/dDTuoxyDk0OXrcnsGbH3+hD3OFn/VembvGqqdnRIoLgVHsocCowenyHwbvsKNk6Epu9mUUNIEXITWYdAlbptjHzwIIkL1FaEJE4AO+E8MNu16/wSLk5tCUfP9rcMDWfO3mEa/mBiOTlgtcVu4Z2Y0UtNHSHpHk3YseCBMR4nH62H69wgmJTQksJ7eLnDZGOBZdXlEIYeT6jNQw/id9rsKHz59awzrwZ8Ttwhwj2cSNcbQU3F2qeGDOZohxB+ghQwudpsGyYC0vCam1Umcfjxh3W78vY/PgzaK1tWz4dyEbn4YjiB/QJGmq1pxKteeV1zoROVc+h4d2S2meGTe0Os5QIlPg23Lcwjk1t4u1fQBsGhBNSrDYGvqSFugzCelLphI/g5orgpn+UIkDBVfBscOo237LLRTjGSVVdcG5J0yJwj9WAZp2kptehQCDW2yVRWu8+LJtLHqfIzbQn4HGJuNM1O9E8laVw2JpisnU+sEKbb4amyyYc8JT1IYeZCHxiEwGrKKAkHrxVieqxx9HPTTY3x8t9UJbgzPyP7BYLtmcfBAUT6vgsmRGv3mqb0JbP0Dpwgbwlen4QjO+qfFbIO39SR+S2IZlhupubvI47rUdzl4DfF/Om00W6Yk/XbIe2/5fPSMs7wr1W2s0ZlOmoB/Kk8jiyTYDljB/UwsYgelP8+FUbfJ9hiGTB26Cwr6YF3mm82jDtpIRqpx2ua8kleRTO4P3thhbPyqDowEJDulj3JpEw0qmWTBLPEjzrqxV1MIvgFxtlZpuheFz8b5GPkPYrwKBBq2VQnIb2RaQ206wtLSTuZyqxYXj71ESC84JF9w5YTskncTlsSwa3nfDYH60IRcXV8j6rxQ9NGS4aufwMg28SPGYBzu6B5o9a35HVNfsuu0oc7I+Y/g60RzgMwGZK2lp5bEm2RJRFXl2gU+F5lhWY5QzfDzd9fP6EKzbDjSZipbX5YuE6VOgg52QPn3NaeGx2cExM+m2fzobdFBhmlORSDMg4LfLiLWH7Rpvf1ySi52WoXT6FnD0PIpFNtWc1XZLGvk6p7oQQUneWBqL/IXdt12/d6qEjO2Q+iaz6L6t1wWy6J8J13x5D5vMVpoRgx6Qk8L9+L/aRuScjVvrtmtQrp83iH/Oh/GmJLVFXWZXIKcyZ7dmEB+Q/ysjvnc08bq8AswJcRClrtUVztGX9C2DwF5Q9wutA1XO6WLuDVCyQ7nMNRYVCE8EaUWb26KEekqNhvlgzTd3Zq+75Q0RllqlKScakL1n0viX1qh8cSfKsSRckvuo0g5lEfeZwGVFHH2Dqv6M+Kj3FgMMwPIp1krcqNy1yDHVDkk+1BeXQVfIxWfgOtX6GFinB2B9jvCE5YsnNj4qEBClLJTWY5Fh6Bu6WEzsFvqnhH8W+APe0geTnbnrAFDbhE3bWeql9AoTGu7TGdxF03o4GzafTSVMdMMYzaK8KzcJnDw==", "X-OriginatorOrg": "corigine.com", "X-MS-Exchange-CrossTenant-Network-Message-Id": "\n 6a03e302-d6dc-4fb6-b83e-08dbc9589f7a", "X-MS-Exchange-CrossTenant-AuthSource": "SJ0PR13MB5545.namprd13.prod.outlook.com", "X-MS-Exchange-CrossTenant-AuthAs": "Internal", "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "10 Oct 2023 06:17:47.6075 (UTC)", "X-MS-Exchange-CrossTenant-FromEntityHeader": "Hosted", "X-MS-Exchange-CrossTenant-Id": "fe128f2c-073b-4c20-818e-7246a585940c", "X-MS-Exchange-CrossTenant-MailboxType": "HOSTED", "X-MS-Exchange-CrossTenant-UserPrincipalName": "\n yKP/F5oXn/HJ2b0fXRF2hdXruvPEl9H8xhIwQSIN6oZlykgfQssp11/nrzFKa5Wo0MM+jUq3uigyeh60tb2XfVTuTNpusnVee0qlSBoxg4s=", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "DM8PR13MB5192", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "From: Long Wu <long.wu@corigine.com>\n\nCI found that calling \"rte_pci_write_config\" without\nchecking return value.\n\nCoverity issue: 403100\nFixes: 1fbe51cd9c3a (\"net/nfp: extend usage of BAR from 8 to 24\")\nCc: chaoyong.he@corigine.com\nCc: stable@dpdk.org\n\nSigned-off-by: Long Wu <long.wu@corigine.com>\nReviewed-by: Chaoyong He <chaoyong.he@corigine.com>\nReviewed-by: Peng Zhang <peng.zhang@corigine.com>\n---\n drivers/net/nfp/nfpcore/nfp6000_pcie.c | 8 +++++---\n 1 file changed, 5 insertions(+), 3 deletions(-)", "diff": "diff --git a/drivers/net/nfp/nfpcore/nfp6000_pcie.c b/drivers/net/nfp/nfpcore/nfp6000_pcie.c\nindex 13cf523506..a6fd89b6c8 100644\n--- a/drivers/net/nfp/nfpcore/nfp6000_pcie.c\n+++ b/drivers/net/nfp/nfpcore/nfp6000_pcie.c\n@@ -214,8 +214,9 @@ nfp_bar_write(struct nfp_pcie_user *nfp,\n \t\trte_read32(nfp->csr + xbar);\n \t} else {\n \t\txbar += nfp->dev_info->pcie_cfg_expbar_offset;\n-\t\trte_pci_write_config(nfp->pci_dev, &newcfg, sizeof(uint32_t),\n-\t\t\t\txbar);\n+\t\tif (rte_pci_write_config(nfp->pci_dev, &newcfg, sizeof(uint32_t),\n+\t\t\t\txbar) < 0)\n+\t\t\treturn -EIO;\n \t}\n \n \tbar->barcfg = newcfg;\n@@ -379,7 +380,8 @@ nfp_enable_bars(struct nfp_pcie_user *nfp)\n \tbar = &nfp->bar[0];\n \tbar->lock = true;\n \n-\tnfp_bar_write(nfp, bar, barcfg_msix_general);\n+\tif (nfp_bar_write(nfp, bar, barcfg_msix_general) < 0)\n+\t\treturn -EIO;\n \n \t/* Sort bars by bit size - use the smallest possible first. */\n \tqsort(&nfp->bar[0], nfp->bars, sizeof(nfp->bar[0]), nfp_cmp_bars);\n", "prefixes": [ "1/2" ] }