Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/132373/?format=api
{ "id": 132373, "url": "http://patches.dpdk.org/api/patches/132373/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20231007023339.1546659-4-chaoyong.he@corigine.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20231007023339.1546659-4-chaoyong.he@corigine.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20231007023339.1546659-4-chaoyong.he@corigine.com", "date": "2023-10-07T02:33:31", "name": "[03/11] net/nfp: unify the type of integer variable", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "eaf9d4b4b10e56ffc6f3d9cdb1d924fceafdd58c", "submitter": { "id": 2554, "url": "http://patches.dpdk.org/api/people/2554/?format=api", "name": "Chaoyong He", "email": "chaoyong.he@corigine.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20231007023339.1546659-4-chaoyong.he@corigine.com/mbox/", "series": [ { "id": 29758, "url": "http://patches.dpdk.org/api/series/29758/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=29758", "date": "2023-10-07T02:33:28", "name": "Unify the PMD coding style", "version": 1, "mbox": "http://patches.dpdk.org/series/29758/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/132373/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/132373/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 8F301426D6;\n\tSat, 7 Oct 2023 04:34:30 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id BA93C40A7D;\n\tSat, 7 Oct 2023 04:34:08 +0200 (CEST)", "from NAM10-DM6-obe.outbound.protection.outlook.com\n (mail-dm6nam10on2108.outbound.protection.outlook.com [40.107.93.108])\n by mails.dpdk.org (Postfix) with ESMTP id 0AAA340A6C\n for <dev@dpdk.org>; Sat, 7 Oct 2023 04:34:06 +0200 (CEST)", "from SJ0PR13MB5545.namprd13.prod.outlook.com (2603:10b6:a03:424::5)\n by SA0PR13MB3936.namprd13.prod.outlook.com (2603:10b6:806:97::24)\n with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6838.38; Sat, 7 Oct\n 2023 02:34:04 +0000", "from SJ0PR13MB5545.namprd13.prod.outlook.com\n ([fe80::28c0:63e2:ecd1:9314]) by SJ0PR13MB5545.namprd13.prod.outlook.com\n ([fe80::28c0:63e2:ecd1:9314%4]) with mapi id 15.20.6813.027; Sat, 7 Oct 2023\n 02:34:04 +0000" ], "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;\n b=NlgZ1MZ2SAR46GmdegP82T7+FB13zYcDjt0rh3ue1RMO8cRYmQ3ktI62TxhGO9CTlb/uc6Jbk/NUEwGTOqh8M5Ddr6AX24eFPbtlJE5KmhPD2AVAZr5+6rAawjHz5ioNH5xlSupKTZ9vDVNRCKCb2k8q+hQC9XEML0nAnK5OqllYQj7NaLQ/9wYR/P8ZBQ6MmZJZvQFg78NSQnQgJlJMfFTNAfp/nRwwcDETKbeSQgW3OWafMVlAZdobZ4BpIcqhIt0buA2i/B4bqboJSqYEwaIltqX+vs9DbNr+rIGnnA0MIAl5hfJf280rZANuU5gmcm4cpqQAE4sGPL48LI/AJQ==", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector9901;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=gDCg0FTEyvmnctj4XSM0Ma8YfuByetGBc+HvHTIzZlg=;\n b=gaDp1cx6/GnYk6Zdn7wp66403pdHdd2/uogTLynTZAoU82kXwfO+SuNr9TWZLAWGGC9vhMSJfvb6aGH04h9XksbLfr3+pO9xiES24LLUg/hrT5kl9DB8UODe6ShdUWrnLlfpj1AX/ZwDvjI2g2Ia8QOxUUpPZzvAWvuF9VdgPw/U4uJn7U5f4f5gHcSVtCHJKhhcSen2MLcKWDUOOMxjnI4hSK1NdtfBogQxvDcYiQyX3Xa/NtdB0dkb5gW6jJooSoAwJMUeRG4ltAbOJWHTF3zhC2X/+cdFjrW/4NqAgQUB4BUznz/qH4R5PAe1k2n41Hmr/+vu3cKLKeenryWKbQ==", "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass\n smtp.mailfrom=corigine.com; dmarc=pass action=none header.from=corigine.com;\n dkim=pass header.d=corigine.com; arc=none", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=corigine.onmicrosoft.com; s=selector2-corigine-onmicrosoft-com;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=gDCg0FTEyvmnctj4XSM0Ma8YfuByetGBc+HvHTIzZlg=;\n b=P0COn/1E6pIcBYuXsDq3E4KOR3UHV94XYFYvR6DUz2CZRDJx98EnerNYw028ncKoJ+Fy9HlUS7faX9Ryl3SrBHsMKg4C6YSYWxZlx5bfdQTJ2+OQrrlqN0cAtOJgIUlsX0VlL9GsBJIi8y5oSR8GeYXFZXQPsmh/WyFBD/WK2q4=", "Authentication-Results": "dkim=none (message not signed)\n header.d=none;dmarc=none action=none header.from=corigine.com;", "From": "Chaoyong He <chaoyong.he@corigine.com>", "To": "dev@dpdk.org", "Cc": "oss-drivers@corigine.com, Chaoyong He <chaoyong.he@corigine.com>,\n Long Wu <long.wu@corigine.com>, Peng Zhang <peng.zhang@corigine.com>", "Subject": "[PATCH 03/11] net/nfp: unify the type of integer variable", "Date": "Sat, 7 Oct 2023 10:33:31 +0800", "Message-Id": "<20231007023339.1546659-4-chaoyong.he@corigine.com>", "X-Mailer": "git-send-email 2.39.1", "In-Reply-To": "<20231007023339.1546659-1-chaoyong.he@corigine.com>", "References": "<20231007023339.1546659-1-chaoyong.he@corigine.com>", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-ClientProxiedBy": "SJ0PR03CA0212.namprd03.prod.outlook.com\n (2603:10b6:a03:39f::7) To SJ0PR13MB5545.namprd13.prod.outlook.com\n (2603:10b6:a03:424::5)", "MIME-Version": "1.0", "X-MS-PublicTrafficType": "Email", "X-MS-TrafficTypeDiagnostic": "SJ0PR13MB5545:EE_|SA0PR13MB3936:EE_", "X-MS-Office365-Filtering-Correlation-Id": "5195df8b-0d1f-4731-c509-08dbc6dddf2f", "X-MS-Exchange-SenderADCheck": "1", "X-MS-Exchange-AntiSpam-Relay": "0", "X-Microsoft-Antispam": "BCL:0;", "X-Microsoft-Antispam-Message-Info": "\n EWK3cx0Q2HfuHk0HpDAMOV7yb47RHdqi1vXSKo/sOmcyZ2hMH+Qdk3i84n4O1plAe9uN5Gcj7Kt0AjgrOI3g7rD/zBFFTuml64FQeQcsd+JEl5NZPEQFTX9gu+olT9RmvM1PAL6P5zo5t8s3wLFBLTtZO7cCMqFniA2TPhgg3ABZ4iU27UWht+IFNUeX+u+dOC8DxVOi7vug2K9tM9IEWNQyCLxbSuOCR2uFV14xF8g08cRMbQCnaaNKaCKxbYEYtLT2leEU3Mps4DgEPGR2crGTqoM/kuTQQNrNeblvzibgXtFoFzMYFxSJuE6WW0B/bWB9jpfDejgLKpFM3cr374TvuU77qavxdE09gFMGBGP+jo/xw3HhLdFsYMe+RYY0Ts3lF0JDdaL6QI5WnqnQIV1hDGvG8EsMkUoD/JLv3KEkNTtJN5u+tTIEpAJdkE15gbXoOhgVsKJ/qdGHEKBx/CXtpPoGnxA4yPtBV/MZ89P1n79QmdKkkZDSeg1PiovqP19x8Q+ThXQfCAWqG3ewQ9QQf2U4DoJzkopFpYCjB+mH8FKHmpg+9KL/x3Dop8nJyTcShJcfXz47oI5jMsesnQQTlxScVXB6ExtqMz1vs5OxWZQ57DswugurigMP9yaU15CwM3tYmv+WLJuYB13RAIxPA6ACoET9ThgdEVUmY+o=", "X-Forefront-Antispam-Report": "CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;\n IPV:NLI; SFV:NSPM; H:SJ0PR13MB5545.namprd13.prod.outlook.com; PTR:; CAT:NONE;\n SFS:(13230031)(366004)(376002)(346002)(396003)(39830400003)(136003)(230922051799003)(186009)(1800799009)(64100799003)(451199024)(6666004)(6506007)(52116002)(6512007)(478600001)(6486002)(26005)(107886003)(1076003)(6916009)(316002)(30864003)(41300700001)(2906002)(44832011)(66476007)(8936002)(5660300002)(4326008)(54906003)(66556008)(66946007)(36756003)(8676002)(86362001)(38350700002)(38100700002)(2616005)(83380400001);\n DIR:OUT; SFP:1102;", "X-MS-Exchange-AntiSpam-MessageData-ChunkCount": "1", "X-MS-Exchange-AntiSpam-MessageData-0": "\n Xb5x8FrWVhVoXDfEbgMwjsu/w8qXFLMPo7yEZec9A4c2HWV2FpeT5To33ivMTb53Qjkq7fM+hTlL+EgjFnyGsvkw4zQXuRpkE9W9CDPYCSBF4Jrfvgg4Fm1+qL5QTZdGobzH4BNFuxsdW17/y1s7cSFzbg8zoKUh7anCpsAQzGlaBzVdW4cE69EZFQpp0IcjA8PlylQ52OTiDyuWTdBxW51rn6AqCp7N+Or7WHPZrf4+7/8fOx7q8Thr5Rxv+trYb4jEIzDPw45OwZluwmd6MvKHg3uQhKYZWB/V9ikJ6y6SPyu46hMtsbyTZIvZHr7cS7Azh3rK5H2W6axwZK7XqD5XyY7N0EL9dtry9x5oNuD34KfwdoYK+LZJsaaDZ++c46lVnsyrP01aJPpGzQpncSTHHBKNmLbuuaocZB/Bqv2mk/FQI4KUxy2l4y9GDW9BqJsd9R294Z8fBa9dS1ALi+8ZfashLumvfJqaWHWVTf4KsGSSkKGWoq1tSbxMiWmL0/e70M4rOT6aYBOVBEzwz8DjP2Ts1fx1sZ5Y6Mh4Dm0vgmL0CNF8obdBI8RVRyF1h+5SFPwJd9n1LMzVI96fzoQbpNuRtp1I1wYgikJ4IejnAuGaseBuQfSNjS+rMO8JJAEUBD5OSoE41fbPnjbFJ7rr0xMyvCCKF+jHP7Jd1JfJww7po9hCs7v3VPspgPnuvcrBYroyFlU9IxYtwEIUFyDyyFJO7Dlo6NonZjHiGXySPDa/6nCxOUXMPwq0AIXtB4bqVqt2WbgeTxESwC87b43hL0IHGRnxgY3gd70twK63FgHN2i6MuUkS8XU8EhCwsoqkQVkIJ/nZcRMDISm1cvr5rzgLlLf0wAzYd0chesZFhG/YGjJUVaxkcCmahJrth8zFn1/ZWguF+gQUofZewe7lmIJG4N2rHgDuG9n9MPFyUCwC3OPDGpPAZFv73sF51t55CfFIkd817t+LDUt93N+2slBcMHg5iEstqQMg9p2RcBf8WZO2rduPfZRX+kXnFBfzhpKID3lRp3d/ow4MWO3xv+3gzW6v7oETXu7Y+A4Jzr3CegLuWMn2m+ra4VuWnnCl2w39P48Y8hEaI77CQkNmD/GT6A/8fxNrGW3yRsiAUJgY+7IqHFEa4V7gNSFDVIhhsproiGXjRvyViaxNDWntxbj/HTIFNsnfL7DL4QjsnfBezkQ3FwISIQ3+cdEpBriomY6Zzef4Z7BV29ei8rX9VinWZ7lwCqwPXKH9pJR+nUoEVCB7WUQZRYMr0JvLZfsnUWCKMj1lqJuiTmYz/0TaVbMJ9DWWaQ4CzfA3W9BFCtbU64zkp6asAgGysBBws/eVo8sFi/GlKBdju0scKXZuvNUw2E6Ylln5IH4YDzHL1fHJKR0iJF4XmxLFsAjs6WpVIlleAN9rU80ZjJIl+C2ns0zhagsBl8CIoAudfkGLMVGFZwmDf9FAY7Z+ZQODBFu6Y5Ih41bFvlcMF+YTwJV2t9L8ofwGgkAGxGHJK7sIBLQa5POf++tmQallYLBr5qZS1pDjeu43xaPQp7mV32ZV87FKvfnXfcG/5TFn/Hvb6jAGDcjGS1eyrXClPsTsKa5QH88945OGhPCc+JDfdA==", "X-OriginatorOrg": "corigine.com", "X-MS-Exchange-CrossTenant-Network-Message-Id": "\n 5195df8b-0d1f-4731-c509-08dbc6dddf2f", "X-MS-Exchange-CrossTenant-AuthSource": "SJ0PR13MB5545.namprd13.prod.outlook.com", "X-MS-Exchange-CrossTenant-AuthAs": "Internal", "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "07 Oct 2023 02:34:04.0617 (UTC)", "X-MS-Exchange-CrossTenant-FromEntityHeader": "Hosted", "X-MS-Exchange-CrossTenant-Id": "fe128f2c-073b-4c20-818e-7246a585940c", "X-MS-Exchange-CrossTenant-MailboxType": "HOSTED", "X-MS-Exchange-CrossTenant-UserPrincipalName": "\n QkrFKAhrWyL8xc13KeXfRyC8q1WONN56w50ghV522lOMKLJqhdrAqyUjXO4LY/uZNPjBRsa27Ahw8j5i7qN4YA7cJQE0ViJyfDGPgAT8FyY=", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "SA0PR13MB3936", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Unify the type of integer variable to the DPDK prefer style.\n\nSigned-off-by: Chaoyong He <chaoyong.he@corigine.com>\nReviewed-by: Long Wu <long.wu@corigine.com>\nReviewed-by: Peng Zhang <peng.zhang@corigine.com>\n---\n drivers/net/nfp/flower/nfp_flower.c | 2 +-\n drivers/net/nfp/flower/nfp_flower_cmsg.c | 16 +++++-----\n drivers/net/nfp/nfd3/nfp_nfd3_dp.c | 6 ++--\n drivers/net/nfp/nfp_common.c | 37 +++++++++++++-----------\n drivers/net/nfp/nfp_common.h | 16 +++++-----\n drivers/net/nfp/nfp_ethdev.c | 24 +++++++--------\n drivers/net/nfp/nfp_ethdev_vf.c | 2 +-\n drivers/net/nfp/nfp_flow.c | 4 +--\n drivers/net/nfp/nfp_rxtx.c | 12 ++++----\n drivers/net/nfp/nfp_rxtx.h | 2 +-\n 10 files changed, 62 insertions(+), 59 deletions(-)", "diff": "diff --git a/drivers/net/nfp/flower/nfp_flower.c b/drivers/net/nfp/flower/nfp_flower.c\nindex 59717fa6b1..bd961043b2 100644\n--- a/drivers/net/nfp/flower/nfp_flower.c\n+++ b/drivers/net/nfp/flower/nfp_flower.c\n@@ -26,7 +26,7 @@ nfp_pf_repr_enable_queues(struct rte_eth_dev *dev)\n {\n \tstruct nfp_net_hw *hw;\n \tuint64_t enabled_queues = 0;\n-\tint i;\n+\tuint16_t i;\n \tstruct nfp_flower_representor *repr;\n \n \trepr = dev->data->dev_private;\ndiff --git a/drivers/net/nfp/flower/nfp_flower_cmsg.c b/drivers/net/nfp/flower/nfp_flower_cmsg.c\nindex 6b9532f5b6..5d6912b079 100644\n--- a/drivers/net/nfp/flower/nfp_flower_cmsg.c\n+++ b/drivers/net/nfp/flower/nfp_flower_cmsg.c\n@@ -64,10 +64,10 @@ nfp_flower_cmsg_mac_repr_init(struct rte_mbuf *mbuf,\n \n static void\n nfp_flower_cmsg_mac_repr_fill(struct rte_mbuf *m,\n-\t\tunsigned int idx,\n-\t\tunsigned int nbi,\n-\t\tunsigned int nbi_port,\n-\t\tunsigned int phys_port)\n+\t\tuint8_t idx,\n+\t\tuint32_t nbi,\n+\t\tuint32_t nbi_port,\n+\t\tuint32_t phys_port)\n {\n \tstruct nfp_flower_cmsg_mac_repr *msg;\n \n@@ -81,11 +81,11 @@ nfp_flower_cmsg_mac_repr_fill(struct rte_mbuf *m,\n int\n nfp_flower_cmsg_mac_repr(struct nfp_app_fw_flower *app_fw_flower)\n {\n-\tint i;\n+\tuint8_t i;\n \tuint16_t cnt;\n-\tunsigned int nbi;\n-\tunsigned int nbi_port;\n-\tunsigned int phys_port;\n+\tuint32_t nbi;\n+\tuint32_t nbi_port;\n+\tuint32_t phys_port;\n \tstruct rte_mbuf *mbuf;\n \tstruct nfp_eth_table *nfp_eth_table;\n \ndiff --git a/drivers/net/nfp/nfd3/nfp_nfd3_dp.c b/drivers/net/nfp/nfd3/nfp_nfd3_dp.c\nindex 64928254d8..5a84629ed7 100644\n--- a/drivers/net/nfp/nfd3/nfp_nfd3_dp.c\n+++ b/drivers/net/nfp/nfd3/nfp_nfd3_dp.c\n@@ -227,9 +227,9 @@ nfp_net_nfd3_xmit_pkts_common(void *tx_queue,\n \t\tuint16_t nb_pkts,\n \t\tbool repr_flag)\n {\n-\tint i;\n-\tint pkt_size;\n-\tint dma_size;\n+\tuint16_t i;\n+\tuint32_t pkt_size;\n+\tuint16_t dma_size;\n \tuint8_t offset;\n \tuint64_t dma_addr;\n \tuint16_t free_descs;\ndiff --git a/drivers/net/nfp/nfp_common.c b/drivers/net/nfp/nfp_common.c\nindex 9719a9212b..cb2c2afbd7 100644\n--- a/drivers/net/nfp/nfp_common.c\n+++ b/drivers/net/nfp/nfp_common.c\n@@ -199,7 +199,7 @@ static int\n __nfp_net_reconfig(struct nfp_net_hw *hw,\n \t\tuint32_t update)\n {\n-\tint cnt;\n+\tuint32_t cnt;\n \tuint32_t new;\n \tstruct timespec wait;\n \n@@ -229,7 +229,7 @@ __nfp_net_reconfig(struct nfp_net_hw *hw,\n \t\t}\n \t\tif (cnt >= NFP_NET_POLL_TIMEOUT) {\n \t\t\tPMD_INIT_LOG(ERR, \"Reconfig timeout for 0x%08x after\"\n-\t\t\t\t\t\" %dms\", update, cnt);\n+\t\t\t\t\t\" %ums\", update, cnt);\n \t\t\treturn -EIO;\n \t\t}\n \t\tnanosleep(&wait, 0); /* waiting for a 1ms */\n@@ -466,7 +466,7 @@ nfp_net_enable_queues(struct rte_eth_dev *dev)\n {\n \tstruct nfp_net_hw *hw;\n \tuint64_t enabled_queues = 0;\n-\tint i;\n+\tuint16_t i;\n \n \thw = NFP_NET_DEV_PRIVATE_TO_HW(dev->data->dev_private);\n \n@@ -575,7 +575,7 @@ nfp_configure_rx_interrupt(struct rte_eth_dev *dev,\n \t\tstruct rte_intr_handle *intr_handle)\n {\n \tstruct nfp_net_hw *hw;\n-\tint i;\n+\tuint16_t i;\n \n \tif (rte_intr_vec_list_alloc(intr_handle, \"intr_vec\",\n \t\t\t\tdev->data->nb_rx_queues) != 0) {\n@@ -832,7 +832,7 @@ int\n nfp_net_stats_get(struct rte_eth_dev *dev,\n \t\tstruct rte_eth_stats *stats)\n {\n-\tint i;\n+\tuint16_t i;\n \tstruct nfp_net_hw *hw;\n \tstruct rte_eth_stats nfp_dev_stats;\n \n@@ -923,7 +923,7 @@ nfp_net_stats_get(struct rte_eth_dev *dev,\n int\n nfp_net_stats_reset(struct rte_eth_dev *dev)\n {\n-\tint i;\n+\tuint16_t i;\n \tstruct nfp_net_hw *hw;\n \n \thw = NFP_NET_DEV_PRIVATE_TO_HW(dev->data->dev_private);\n@@ -1398,7 +1398,7 @@ nfp_rx_queue_intr_enable(struct rte_eth_dev *dev,\n {\n \tstruct rte_pci_device *pci_dev;\n \tstruct nfp_net_hw *hw;\n-\tint base = 0;\n+\tuint16_t base = 0;\n \n \thw = NFP_NET_DEV_PRIVATE_TO_HW(dev->data->dev_private);\n \tpci_dev = RTE_ETH_DEV_TO_PCI(dev);\n@@ -1419,7 +1419,7 @@ nfp_rx_queue_intr_disable(struct rte_eth_dev *dev,\n {\n \tstruct rte_pci_device *pci_dev;\n \tstruct nfp_net_hw *hw;\n-\tint base = 0;\n+\tuint16_t base = 0;\n \n \thw = NFP_NET_DEV_PRIVATE_TO_HW(dev->data->dev_private);\n \tpci_dev = RTE_ETH_DEV_TO_PCI(dev);\n@@ -1619,9 +1619,10 @@ nfp_net_rss_reta_write(struct rte_eth_dev *dev,\n \t\tstruct rte_eth_rss_reta_entry64 *reta_conf,\n \t\tuint16_t reta_size)\n {\n-\tuint32_t reta, mask;\n-\tint i, j;\n-\tint idx, shift;\n+\tuint8_t mask;\n+\tuint32_t reta;\n+\tuint16_t i, j;\n+\tuint16_t idx, shift;\n \tstruct nfp_net_hw *hw =\n \t\tNFP_NET_DEV_PRIVATE_TO_HW(dev->data->dev_private);\n \n@@ -1695,8 +1696,9 @@ nfp_net_reta_query(struct rte_eth_dev *dev,\n \t\tstruct rte_eth_rss_reta_entry64 *reta_conf,\n \t\tuint16_t reta_size)\n {\n-\tuint8_t i, j, mask;\n-\tint idx, shift;\n+\tuint16_t i, j;\n+\tuint8_t mask;\n+\tuint16_t idx, shift;\n \tuint32_t reta;\n \tstruct nfp_net_hw *hw;\n \n@@ -1720,7 +1722,7 @@ nfp_net_reta_query(struct rte_eth_dev *dev,\n \t\t/* Handling 4 RSS entries per loop */\n \t\tidx = i / RTE_ETH_RETA_GROUP_SIZE;\n \t\tshift = i % RTE_ETH_RETA_GROUP_SIZE;\n-\t\tmask = (uint8_t)((reta_conf[idx].mask >> shift) & 0xF);\n+\t\tmask = (reta_conf[idx].mask >> shift) & 0xF;\n \n \t\tif (mask == 0)\n \t\t\tcontinue;\n@@ -1744,7 +1746,7 @@ nfp_net_rss_hash_write(struct rte_eth_dev *dev,\n \tuint64_t rss_hf;\n \tuint32_t cfg_rss_ctrl = 0;\n \tuint8_t key;\n-\tint i;\n+\tuint8_t i;\n \n \thw = NFP_NET_DEV_PRIVATE_TO_HW(dev->data->dev_private);\n \n@@ -1835,7 +1837,7 @@ nfp_net_rss_hash_conf_get(struct rte_eth_dev *dev,\n \tuint64_t rss_hf;\n \tuint32_t cfg_rss_ctrl;\n \tuint8_t key;\n-\tint i;\n+\tuint8_t i;\n \tstruct nfp_net_hw *hw;\n \n \thw = NFP_NET_DEV_PRIVATE_TO_HW(dev->data->dev_private);\n@@ -1893,7 +1895,8 @@ nfp_net_rss_config_default(struct rte_eth_dev *dev)\n \tstruct rte_eth_rss_reta_entry64 nfp_reta_conf[2];\n \tuint16_t rx_queues = dev->data->nb_rx_queues;\n \tuint16_t queue;\n-\tint i, j, ret;\n+\tuint8_t i, j;\n+\tint ret;\n \n \tPMD_DRV_LOG(INFO, \"setting default RSS conf for %u queues\",\n \t\t\trx_queues);\ndiff --git a/drivers/net/nfp/nfp_common.h b/drivers/net/nfp/nfp_common.h\nindex e4fd394868..71153ea25b 100644\n--- a/drivers/net/nfp/nfp_common.h\n+++ b/drivers/net/nfp/nfp_common.h\n@@ -245,14 +245,14 @@ nn_writeq(uint64_t val,\n */\n static inline uint8_t\n nn_cfg_readb(struct nfp_net_hw *hw,\n-\t\tint off)\n+\t\tuint32_t off)\n {\n \treturn nn_readb(hw->ctrl_bar + off);\n }\n \n static inline void\n nn_cfg_writeb(struct nfp_net_hw *hw,\n-\t\tint off,\n+\t\tuint32_t off,\n \t\tuint8_t val)\n {\n \tnn_writeb(val, hw->ctrl_bar + off);\n@@ -260,14 +260,14 @@ nn_cfg_writeb(struct nfp_net_hw *hw,\n \n static inline uint16_t\n nn_cfg_readw(struct nfp_net_hw *hw,\n-\t\tint off)\n+\t\tuint32_t off)\n {\n \treturn rte_le_to_cpu_16(nn_readw(hw->ctrl_bar + off));\n }\n \n static inline void\n nn_cfg_writew(struct nfp_net_hw *hw,\n-\t\tint off,\n+\t\tuint32_t off,\n \t\tuint16_t val)\n {\n \tnn_writew(rte_cpu_to_le_16(val), hw->ctrl_bar + off);\n@@ -275,14 +275,14 @@ nn_cfg_writew(struct nfp_net_hw *hw,\n \n static inline uint32_t\n nn_cfg_readl(struct nfp_net_hw *hw,\n-\t\tint off)\n+\t\tuint32_t off)\n {\n \treturn rte_le_to_cpu_32(nn_readl(hw->ctrl_bar + off));\n }\n \n static inline void\n nn_cfg_writel(struct nfp_net_hw *hw,\n-\t\tint off,\n+\t\tuint32_t off,\n \t\tuint32_t val)\n {\n \tnn_writel(rte_cpu_to_le_32(val), hw->ctrl_bar + off);\n@@ -290,14 +290,14 @@ nn_cfg_writel(struct nfp_net_hw *hw,\n \n static inline uint64_t\n nn_cfg_readq(struct nfp_net_hw *hw,\n-\t\tint off)\n+\t\tuint32_t off)\n {\n \treturn rte_le_to_cpu_64(nn_readq(hw->ctrl_bar + off));\n }\n \n static inline void\n nn_cfg_writeq(struct nfp_net_hw *hw,\n-\t\tint off,\n+\t\tuint32_t off,\n \t\tuint64_t val)\n {\n \tnn_writeq(rte_cpu_to_le_64(val), hw->ctrl_bar + off);\ndiff --git a/drivers/net/nfp/nfp_ethdev.c b/drivers/net/nfp/nfp_ethdev.c\nindex 65473d87e8..140d20dcf7 100644\n--- a/drivers/net/nfp/nfp_ethdev.c\n+++ b/drivers/net/nfp/nfp_ethdev.c\n@@ -23,7 +23,7 @@\n \n static int\n nfp_net_pf_read_mac(struct nfp_app_fw_nic *app_fw_nic,\n-\t\tint port)\n+\t\tuint16_t port)\n {\n \tstruct nfp_eth_table *nfp_eth_table;\n \tstruct nfp_net_hw *hw = NULL;\n@@ -255,7 +255,7 @@ nfp_net_close(struct rte_eth_dev *dev)\n \tstruct rte_pci_device *pci_dev;\n \tstruct nfp_pf_dev *pf_dev;\n \tstruct nfp_app_fw_nic *app_fw_nic;\n-\tint i;\n+\tuint8_t i;\n \n \tif (rte_eal_process_type() != RTE_PROC_PRIMARY)\n \t\treturn 0;\n@@ -487,7 +487,7 @@ nfp_net_init(struct rte_eth_dev *eth_dev)\n \tstruct rte_ether_addr *tmp_ether_addr;\n \tuint64_t rx_base;\n \tuint64_t tx_base;\n-\tint port = 0;\n+\tuint16_t port = 0;\n \tint err;\n \n \tPMD_INIT_FUNC_TRACE();\n@@ -501,7 +501,7 @@ nfp_net_init(struct rte_eth_dev *eth_dev)\n \tapp_fw_nic = NFP_PRIV_TO_APP_FW_NIC(pf_dev->app_fw_priv);\n \n \tport = ((struct nfp_net_hw *)eth_dev->data->dev_private)->idx;\n-\tif (port < 0 || port > 7) {\n+\tif (port > 7) {\n \t\tPMD_DRV_LOG(ERR, \"Port value is wrong\");\n \t\treturn -ENODEV;\n \t}\n@@ -761,10 +761,10 @@ static int\n nfp_init_app_fw_nic(struct nfp_pf_dev *pf_dev,\n \t\tconst struct nfp_dev_info *dev_info)\n {\n-\tint i;\n+\tuint8_t i;\n \tint ret;\n \tint err = 0;\n-\tint total_vnics;\n+\tuint32_t total_vnics;\n \tstruct nfp_net_hw *hw;\n \tunsigned int numa_node;\n \tstruct rte_eth_dev *eth_dev;\n@@ -785,7 +785,7 @@ nfp_init_app_fw_nic(struct nfp_pf_dev *pf_dev,\n \n \t/* Read the number of vNIC's created for the PF */\n \ttotal_vnics = nfp_rtsym_read_le(pf_dev->sym_tbl, \"nfd_cfg_pf0_num_ports\", &err);\n-\tif (err != 0 || total_vnics <= 0 || total_vnics > 8) {\n+\tif (err != 0 || total_vnics == 0 || total_vnics > 8) {\n \t\tPMD_INIT_LOG(ERR, \"nfd_cfg_pf0_num_ports symbol with wrong value\");\n \t\tret = -ENODEV;\n \t\tgoto app_cleanup;\n@@ -795,7 +795,7 @@ nfp_init_app_fw_nic(struct nfp_pf_dev *pf_dev,\n \t * For coreNIC the number of vNICs exposed should be the same as the\n \t * number of physical ports\n \t */\n-\tif (total_vnics != (int)nfp_eth_table->count) {\n+\tif (total_vnics != nfp_eth_table->count) {\n \t\tPMD_INIT_LOG(ERR, \"Total physical ports do not match number of vNICs\");\n \t\tret = -ENODEV;\n \t\tgoto app_cleanup;\n@@ -1053,15 +1053,15 @@ nfp_secondary_init_app_fw_nic(struct rte_pci_device *pci_dev,\n \t\tstruct nfp_rtsym_table *sym_tbl,\n \t\tstruct nfp_cpp *cpp)\n {\n-\tint i;\n+\tuint32_t i;\n \tint err = 0;\n \tint ret = 0;\n-\tint total_vnics;\n+\tuint32_t total_vnics;\n \tstruct nfp_net_hw *hw;\n \n \t/* Read the number of vNIC's created for the PF */\n \ttotal_vnics = nfp_rtsym_read_le(sym_tbl, \"nfd_cfg_pf0_num_ports\", &err);\n-\tif (err != 0 || total_vnics <= 0 || total_vnics > 8) {\n+\tif (err != 0 || total_vnics == 0 || total_vnics > 8) {\n \t\tPMD_INIT_LOG(ERR, \"nfd_cfg_pf0_num_ports symbol with wrong value\");\n \t\treturn -ENODEV;\n \t}\n@@ -1069,7 +1069,7 @@ nfp_secondary_init_app_fw_nic(struct rte_pci_device *pci_dev,\n \tfor (i = 0; i < total_vnics; i++) {\n \t\tstruct rte_eth_dev *eth_dev;\n \t\tchar port_name[RTE_ETH_NAME_MAX_LEN];\n-\t\tsnprintf(port_name, sizeof(port_name), \"%s_port%d\",\n+\t\tsnprintf(port_name, sizeof(port_name), \"%s_port%u\",\n \t\t\t\tpci_dev->device.name, i);\n \n \t\tPMD_INIT_LOG(DEBUG, \"Secondary attaching to port %s\", port_name);\ndiff --git a/drivers/net/nfp/nfp_ethdev_vf.c b/drivers/net/nfp/nfp_ethdev_vf.c\nindex ac6a10685d..892300a909 100644\n--- a/drivers/net/nfp/nfp_ethdev_vf.c\n+++ b/drivers/net/nfp/nfp_ethdev_vf.c\n@@ -260,7 +260,7 @@ nfp_netvf_init(struct rte_eth_dev *eth_dev)\n \n \tuint64_t tx_bar_off = 0, rx_bar_off = 0;\n \tuint32_t start_q;\n-\tint port = 0;\n+\tuint16_t port = 0;\n \tint err;\n \tconst struct nfp_dev_info *dev_info;\n \ndiff --git a/drivers/net/nfp/nfp_flow.c b/drivers/net/nfp/nfp_flow.c\nindex 156b9599db..a254d839ff 100644\n--- a/drivers/net/nfp/nfp_flow.c\n+++ b/drivers/net/nfp/nfp_flow.c\n@@ -2001,7 +2001,7 @@ nfp_flow_compile_item_proc(struct nfp_flower_representor *repr,\n \t\tchar **mbuf_off_mask,\n \t\tbool is_outer_layer)\n {\n-\tint i;\n+\tuint32_t i;\n \tint ret = 0;\n \tbool continue_flag = true;\n \tconst struct rte_flow_item *item;\n@@ -2235,7 +2235,7 @@ nfp_flow_action_set_ipv6(char *act_data,\n \t\tconst struct rte_flow_action *action,\n \t\tbool ip_src_flag)\n {\n-\tint i;\n+\tuint32_t i;\n \trte_be32_t tmp;\n \tsize_t act_size;\n \tstruct nfp_fl_act_set_ipv6_addr *set_ip;\ndiff --git a/drivers/net/nfp/nfp_rxtx.c b/drivers/net/nfp/nfp_rxtx.c\nindex 7885166753..8cbb9b74a2 100644\n--- a/drivers/net/nfp/nfp_rxtx.c\n+++ b/drivers/net/nfp/nfp_rxtx.c\n@@ -190,7 +190,7 @@ nfp_net_rx_fill_freelist(struct nfp_net_rxq *rxq)\n {\n \tstruct nfp_net_dp_buf *rxe = rxq->rxbufs;\n \tuint64_t dma_addr;\n-\tunsigned int i;\n+\tuint16_t i;\n \n \tPMD_RX_LOG(DEBUG, \"Fill Rx Freelist for %u descriptors\",\n \t\t\trxq->rx_count);\n@@ -229,7 +229,7 @@ nfp_net_rx_fill_freelist(struct nfp_net_rxq *rxq)\n int\n nfp_net_rx_freelist_setup(struct rte_eth_dev *dev)\n {\n-\tint i;\n+\tuint16_t i;\n \n \tfor (i = 0; i < dev->data->nb_rx_queues; i++) {\n \t\tif (nfp_net_rx_fill_freelist(dev->data->rx_queues[i]) != 0)\n@@ -840,7 +840,7 @@ nfp_net_recv_pkts(void *rx_queue,\n static void\n nfp_net_rx_queue_release_mbufs(struct nfp_net_rxq *rxq)\n {\n-\tunsigned int i;\n+\tuint16_t i;\n \n \tif (rxq->rxbufs == NULL)\n \t\treturn;\n@@ -992,11 +992,11 @@ nfp_net_rx_queue_setup(struct rte_eth_dev *dev,\n * @txq: TX queue to work with\n * Returns number of descriptors freed\n */\n-int\n+uint32_t\n nfp_net_tx_free_bufs(struct nfp_net_txq *txq)\n {\n \tuint32_t qcp_rd_p;\n-\tint todo;\n+\tuint32_t todo;\n \n \tPMD_TX_LOG(DEBUG, \"queue %hu. Check for descriptor with a complete\"\n \t\t\t\" status\", txq->qidx);\n@@ -1032,7 +1032,7 @@ nfp_net_tx_free_bufs(struct nfp_net_txq *txq)\n static void\n nfp_net_tx_queue_release_mbufs(struct nfp_net_txq *txq)\n {\n-\tunsigned int i;\n+\tuint32_t i;\n \n \tif (txq->txbufs == NULL)\n \t\treturn;\ndiff --git a/drivers/net/nfp/nfp_rxtx.h b/drivers/net/nfp/nfp_rxtx.h\nindex 9a30ebd89e..98ef6c3d93 100644\n--- a/drivers/net/nfp/nfp_rxtx.h\n+++ b/drivers/net/nfp/nfp_rxtx.h\n@@ -253,7 +253,7 @@ int nfp_net_tx_queue_setup(struct rte_eth_dev *dev,\n \t\tuint16_t nb_desc,\n \t\tunsigned int socket_id,\n \t\tconst struct rte_eth_txconf *tx_conf);\n-int nfp_net_tx_free_bufs(struct nfp_net_txq *txq);\n+uint32_t nfp_net_tx_free_bufs(struct nfp_net_txq *txq);\n void nfp_net_set_meta_vlan(struct nfp_net_meta_raw *meta_data,\n \t\tstruct rte_mbuf *pkt,\n \t\tuint8_t layer);\n", "prefixes": [ "03/11" ] }