Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/132358/?format=api
{ "id": 132358, "url": "http://patches.dpdk.org/api/patches/132358/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20231006102932.164630-1-bruce.richardson@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20231006102932.164630-1-bruce.richardson@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20231006102932.164630-1-bruce.richardson@intel.com", "date": "2023-10-06T10:29:32", "name": "[v4] eventdev: ensure 16-byte alignment for events", "commit_ref": null, "pull_url": null, "state": "rejected", "archived": true, "hash": "9535bc1c7ea06a54c992be40dff735e40bbfebb2", "submitter": { "id": 20, "url": "http://patches.dpdk.org/api/people/20/?format=api", "name": "Bruce Richardson", "email": "bruce.richardson@intel.com" }, "delegate": null, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20231006102932.164630-1-bruce.richardson@intel.com/mbox/", "series": [ { "id": 29752, "url": "http://patches.dpdk.org/api/series/29752/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=29752", "date": "2023-10-06T10:29:32", "name": "[v4] eventdev: ensure 16-byte alignment for events", "version": 4, "mbox": "http://patches.dpdk.org/series/29752/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/132358/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/132358/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id CB61D426CF;\n\tFri, 6 Oct 2023 12:29:41 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id B4D1D4069F;\n\tFri, 6 Oct 2023 12:29:41 +0200 (CEST)", "from mgamail.intel.com (mgamail.intel.com [192.55.52.120])\n by mails.dpdk.org (Postfix) with ESMTP id DAD24402F2\n for <dev@dpdk.org>; Fri, 6 Oct 2023 12:29:39 +0200 (CEST)", "from fmsmga005.fm.intel.com ([10.253.24.32])\n by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 06 Oct 2023 03:29:38 -0700", "from silpixa00401385.ir.intel.com ([10.237.214.135])\n by fmsmga005.fm.intel.com with ESMTP; 06 Oct 2023 03:29:36 -0700" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1696588180; x=1728124180;\n h=from:to:cc:subject:date:message-id:in-reply-to:\n references:mime-version:content-transfer-encoding;\n bh=Ei7d9M+DuI02gFcMoP3zATXJlEYtUJNYaTkR4SoQOSM=;\n b=QaQxNIyoCvC5H0k1qgXpsQVyAJCL/KznXUK8nFlgOu80XHrEcdNVQbOF\n nGMec621Is1Fm+OYEBHI9EW9ZA3rsA8HAJWQ2mvin1JQtbYM3JdUlH7Ur\n jEUreXN6prCrZ5iBMSH0fGEoDxyfjw4EwY7ufRHZR4pT2SCDO2ouXUx92\n c1zmR8xHegXhcWMT5sXpH9BvimdD+dQ9YP/e8F26IitiJgU3U1P3KI1CD\n uPmmq4KS8ITzhnEbrtMJtd4INevcRWJOaL08wIwQtlerMAsUEjvRKF4FI\n /7LAnWPVFvPpivhY3+r0OUqeCKtdtVICqJP1ENQY2o671IjbtjixDogvQ w==;", "X-IronPort-AV": [ "E=McAfee;i=\"6600,9927,10854\"; a=\"382591444\"", "E=Sophos;i=\"6.03,203,1694761200\"; d=\"scan'208\";a=\"382591444\"", "E=McAfee;i=\"6600,9927,10854\"; a=\"1083407315\"", "E=Sophos;i=\"6.03,203,1694761200\"; d=\"scan'208\";a=\"1083407315\"" ], "X-ExtLoop1": "1", "From": "Bruce Richardson <bruce.richardson@intel.com>", "To": "dev@dpdk.org", "Cc": "Bruce Richardson <bruce.richardson@intel.com>, =?utf-8?q?Morten_Br=C3=B8?=\n\t=?utf-8?q?rup?= <mb@smartsharesystems.com>, Jerin Jacob <jerinj@marvell.com>", "Subject": "[PATCH v4] eventdev: ensure 16-byte alignment for events", "Date": "Fri, 6 Oct 2023 11:29:32 +0100", "Message-Id": "<20231006102932.164630-1-bruce.richardson@intel.com>", "X-Mailer": "git-send-email 2.39.2", "In-Reply-To": "<20231005115101.12276-1-bruce.richardson@intel.com>", "References": "<20231005115101.12276-1-bruce.richardson@intel.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "The event structure in DPDK is 16-bytes in size, and events are\nregularly passed as parameters directly rather than being passed as\npointers. To help compiler optimize correctly, we can explicitly request\n16-byte alignment for events, which means that we should be able\nto do aligned vector loads/stores (e.g. with SSE or Neon) when working\nwith those events.\n\nSigned-off-by: Bruce Richardson <bruce.richardson@intel.com>\nAcked-by: Morten Brørup <mb@smartsharesystems.com>\nAcked-by: Jerin Jacob <jerinj@marvell.com>\n\n---\nv4: change _Static_assert to static_assert for fwd compatibility\n moved size check on event structure to C file from header file\n\nv3: Fix spelling mistake in RN entry\n rebase on latest eventdev tree HEAD\n\nv2: added release note entry for ABI change\n added structure comment on 16-byte size and alignment\n added static assert for structure size\n---\n doc/guides/rel_notes/release_23_11.rst | 4 ++++\n lib/eventdev/rte_eventdev.c | 3 +++\n lib/eventdev/rte_eventdev.h | 4 +++-\n 3 files changed, 10 insertions(+), 1 deletion(-)", "diff": "diff --git a/doc/guides/rel_notes/release_23_11.rst b/doc/guides/rel_notes/release_23_11.rst\nindex 0903046b0c..33fed3e433 100644\n--- a/doc/guides/rel_notes/release_23_11.rst\n+++ b/doc/guides/rel_notes/release_23_11.rst\n@@ -209,6 +209,10 @@ ABI Changes\n fields, to move ``rxq`` and ``txq`` fields, to change the size of\n ``reserved1`` and ``reserved2`` fields.\n \n+* The ``rte_event`` structure, used by eventdev library and DPDK \"event\" class drivers,\n+ is now 16-byte aligned, as well as being 16-bytes in size.\n+ In previous releases, the structure only required 8-byte alignment.\n+\n \n Known Issues\n ------------\ndiff --git a/lib/eventdev/rte_eventdev.c b/lib/eventdev/rte_eventdev.c\nindex 95373bbaad..adc9751cef 100644\n--- a/lib/eventdev/rte_eventdev.c\n+++ b/lib/eventdev/rte_eventdev.c\n@@ -9,6 +9,7 @@\n #include <errno.h>\n #include <stdint.h>\n #include <inttypes.h>\n+#include <assert.h>\n \n #include <rte_string_fns.h>\n #include <rte_log.h>\n@@ -28,6 +29,8 @@\n #include \"eventdev_pmd.h\"\n #include \"eventdev_trace.h\"\n \n+static_assert(sizeof(struct rte_event) == 16, \"Event structure size is not 16-bytes in size\");\n+\n static struct rte_eventdev rte_event_devices[RTE_EVENT_MAX_DEVS];\n \n struct rte_eventdev *rte_eventdevs = rte_event_devices;\ndiff --git a/lib/eventdev/rte_eventdev.h b/lib/eventdev/rte_eventdev.h\nindex 2ea98302b8..758ee83a3f 100644\n--- a/lib/eventdev/rte_eventdev.h\n+++ b/lib/eventdev/rte_eventdev.h\n@@ -1284,6 +1284,8 @@ struct rte_event_vector {\n /**\n * The generic *rte_event* structure to hold the event attributes\n * for dequeue and enqueue operation\n+ *\n+ * This structure must be kept at 16-bytes in size, and has 16-byte alignment.\n */\n struct rte_event {\n \t/** WORD0 */\n@@ -1356,7 +1358,7 @@ struct rte_event {\n \t\tstruct rte_event_vector *vec;\n \t\t/**< Event vector pointer. */\n \t};\n-};\n+} __rte_aligned(16);\n \n /* Ethdev Rx adapter capability bitmap flags */\n #define RTE_EVENT_ETH_RX_ADAPTER_CAP_INTERNAL_PORT\t0x1\n", "prefixes": [ "v4" ] }