Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 132350,
    "url": "http://patches.dpdk.org/api/patches/132350/?format=api",
    "web_url": "http://patches.dpdk.org/project/dpdk/patch/20231005230648.68244-2-stephen@networkplumber.org/",
    "project": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<20231005230648.68244-2-stephen@networkplumber.org>",
    "list_archive_url": "https://inbox.dpdk.org/dev/20231005230648.68244-2-stephen@networkplumber.org",
    "date": "2023-10-05T23:06:45",
    "name": "[v2,1/4] pdump: fix setting rte_errno on mp error",
    "commit_ref": null,
    "pull_url": null,
    "state": "superseded",
    "archived": true,
    "hash": "6b5ea89e3b2b36626c0df7fc57296227a0afac6a",
    "submitter": {
        "id": 27,
        "url": "http://patches.dpdk.org/api/people/27/?format=api",
        "name": "Stephen Hemminger",
        "email": "stephen@networkplumber.org"
    },
    "delegate": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/users/1/?format=api",
        "username": "tmonjalo",
        "first_name": "Thomas",
        "last_name": "Monjalon",
        "email": "thomas@monjalon.net"
    },
    "mbox": "http://patches.dpdk.org/project/dpdk/patch/20231005230648.68244-2-stephen@networkplumber.org/mbox/",
    "series": [
        {
            "id": 29747,
            "url": "http://patches.dpdk.org/api/series/29747/?format=api",
            "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=29747",
            "date": "2023-10-05T23:06:44",
            "name": "dumpcap and pcapng fixes",
            "version": 2,
            "mbox": "http://patches.dpdk.org/series/29747/mbox/"
        }
    ],
    "comments": "http://patches.dpdk.org/api/patches/132350/comments/",
    "check": "success",
    "checks": "http://patches.dpdk.org/api/patches/132350/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@inbox.dpdk.org",
        "Delivered-To": "patchwork@inbox.dpdk.org",
        "Received": [
            "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id D6005426C7;\n\tFri,  6 Oct 2023 01:07:07 +0200 (CEST)",
            "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 1832F402DB;\n\tFri,  6 Oct 2023 01:07:02 +0200 (CEST)",
            "from mail-pf1-f179.google.com (mail-pf1-f179.google.com\n [209.85.210.179])\n by mails.dpdk.org (Postfix) with ESMTP id C19B4402A8\n for <dev@dpdk.org>; Fri,  6 Oct 2023 01:07:00 +0200 (CEST)",
            "by mail-pf1-f179.google.com with SMTP id\n d2e1a72fcca58-690bc3f82a7so1361384b3a.0\n for <dev@dpdk.org>; Thu, 05 Oct 2023 16:07:00 -0700 (PDT)",
            "from hermes.local (204-195-126-68.wavecable.com. [204.195.126.68])\n by smtp.gmail.com with ESMTPSA id\n d13-20020aa7814d000000b00690cd981652sm112665pfn.61.2023.10.05.16.06.58\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Thu, 05 Oct 2023 16:06:58 -0700 (PDT)"
        ],
        "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1696547220;\n x=1697152020; darn=dpdk.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=LsawYgUPNSz8KCXOkCvRdkh/dufEOeHsF/JSonH5eXU=;\n b=OSkEOhv6hvoRKPj8hJOTiqSo0VECbGFVae5xYwBZCXIR6CcmoRBNFX6H+P7NLnwQSw\n iL/3QGHaSPNShIXHo1RFhj+q89FjPHyV7/b+t64wG8XWiQ59THUfVz24CHlgF8eVd5mc\n 0B2NE+gSXy2mADYcmjnZCGnCHAb2ZTV1beYTZgYe94AXkqiTVd9m3iGakB07a6mZQe2y\n yF7wOP9lYMO4gwg3menZLU6ygJeo9GGjoYFd/89EWRbASvlx0319HDE1RdKWBANwtlXN\n neVZdEI4BqdZaVhVGzy6PlMAvdVJcEiR1Wn4YtzlvblJoj/Sptud7lOHG9+vPsvM4MRl\n 2tOw==",
        "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20230601; t=1696547220; x=1697152020;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n :subject:date:message-id:reply-to;\n bh=LsawYgUPNSz8KCXOkCvRdkh/dufEOeHsF/JSonH5eXU=;\n b=hi6QirIjdoHPm3n9FFreoi4OrhV0dKQUBZ98lM/O7qEFUTSV7LlRIwjPLypLLOUB1X\n SfWI/HeVMevik3+RXfozUJZAGn3DunbBAHymanmy+FOWNA00+8xSNFM9iXuC3+MlR6N/\n 8Hyg8J0w8fmGENSbL6j5ldadzGihxFVv+oOr2h3Yw8uVmmOuUYVm5rp2ERwziZ1j+AHv\n 4obGX3ahD8HakZWGARMFYA/0RkCInu8liN983ugRHsUvxwrx8cS7pwvMe/GZw6OhvP8c\n vKnPewP2uUjeXPgd+9kTfsraI3y6dJgLQDh1L0O6dhnFWksXhBMO7vEOV0nfrByB5c3P\n /eKw==",
        "X-Gm-Message-State": "AOJu0YwCNcSlDBGYiMvJZUrHKEtRWnVXqENARSzub0hnML938aR35CJW\n /R3N8ZCLkAb6DXM+YMQAmCiW+UlCVHKpG28FR2I=",
        "X-Google-Smtp-Source": "\n AGHT+IEgqUUMQnwjk1+BBa5+ifeF/8sgsiZoHRNcXIpbT+fibW05/P3DOQ4Iyvy6vICSMn95uhJvWQ==",
        "X-Received": "by 2002:a05:6a00:b84:b0:68f:ccea:8e14 with SMTP id\n g4-20020a056a000b8400b0068fccea8e14mr7647678pfj.32.1696547219609;\n Thu, 05 Oct 2023 16:06:59 -0700 (PDT)",
        "From": "Stephen Hemminger <stephen@networkplumber.org>",
        "To": "dev@dpdk.org",
        "Cc": "Stephen Hemminger <stephen@networkplumber.org>,\n Reshma Pattan <reshma.pattan@intel.com>,\n Jianfeng Tan <jianfeng.tan@intel.com>",
        "Subject": "[PATCH v2 1/4] pdump: fix setting rte_errno on mp error",
        "Date": "Thu,  5 Oct 2023 16:06:45 -0700",
        "Message-Id": "<20231005230648.68244-2-stephen@networkplumber.org>",
        "X-Mailer": "git-send-email 2.39.2",
        "In-Reply-To": "<20231005230648.68244-1-stephen@networkplumber.org>",
        "References": "<20230921042349.104150-1-stephen@networkplumber.org>\n <20231005230648.68244-1-stephen@networkplumber.org>",
        "MIME-Version": "1.0",
        "Content-Transfer-Encoding": "8bit",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.29",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org"
    },
    "content": "The response from MP server sets err_value to negative\non error. The convention for rte_errno is to use a positive\nvalue on error. This makes errors like duplicate registration\nshow up with the correct error value.\n\nFixes: 660098d61f57 (\"pdump: use generic multi-process channel\")\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\n---\n lib/pdump/rte_pdump.c | 5 +++--\n 1 file changed, 3 insertions(+), 2 deletions(-)",
    "diff": "diff --git a/lib/pdump/rte_pdump.c b/lib/pdump/rte_pdump.c\nindex 53cca1034d41..a70085bd0211 100644\n--- a/lib/pdump/rte_pdump.c\n+++ b/lib/pdump/rte_pdump.c\n@@ -564,9 +564,10 @@ pdump_prepare_client_request(const char *device, uint16_t queue,\n \tif (rte_mp_request_sync(&mp_req, &mp_reply, &ts) == 0) {\n \t\tmp_rep = &mp_reply.msgs[0];\n \t\tresp = (struct pdump_response *)mp_rep->param;\n-\t\trte_errno = resp->err_value;\n-\t\tif (!resp->err_value)\n+\t\tif (resp->err_value == 0)\n \t\t\tret = 0;\n+\t\telse\n+\t\t\trte_errno = -resp->err_value;\n \t\tfree(mp_reply.msgs);\n \t}\n \n",
    "prefixes": [
        "v2",
        "1/4"
    ]
}