Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/132249/?format=api
{ "id": 132249, "url": "http://patches.dpdk.org/api/patches/132249/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20230930010024.34377-1-rdna@apple.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20230930010024.34377-1-rdna@apple.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20230930010024.34377-1-rdna@apple.com", "date": "2023-09-30T01:00:24", "name": "net/vhost: report TX errors in port stats", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "ad9ddbd746708e716f6d9b368c480e663a5feee6", "submitter": { "id": 3203, "url": "http://patches.dpdk.org/api/people/3203/?format=api", "name": "Andrey Ignatov", "email": "rdna@apple.com" }, "delegate": { "id": 2642, "url": "http://patches.dpdk.org/api/users/2642/?format=api", "username": "mcoquelin", "first_name": "Maxime", "last_name": "Coquelin", "email": "maxime.coquelin@redhat.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20230930010024.34377-1-rdna@apple.com/mbox/", "series": [ { "id": 29707, "url": "http://patches.dpdk.org/api/series/29707/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=29707", "date": "2023-09-30T01:00:24", "name": "net/vhost: report TX errors in port stats", "version": 1, "mbox": "http://patches.dpdk.org/series/29707/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/132249/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/132249/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 5FF044267B;\n\tSat, 30 Sep 2023 03:01:25 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id D208B40268;\n\tSat, 30 Sep 2023 03:01:24 +0200 (CEST)", "from rn-mailsvcp-mx-lapp01.apple.com\n (rn-mailsvcp-mx-lapp01.apple.com [17.179.253.22])\n by mails.dpdk.org (Postfix) with ESMTP id CACF340156\n for <dev@dpdk.org>; Sat, 30 Sep 2023 03:01:23 +0200 (CEST)", "from rn-mailsvcp-mta-lapp01.rno.apple.com\n (rn-mailsvcp-mta-lapp01.rno.apple.com [10.225.203.149])\n by rn-mailsvcp-mx-lapp01.rno.apple.com\n (Oracle Communications Messaging Server 8.1.0.23.20230328 64bit (built Mar 28\n 2023)) with ESMTPS id <0S1R00DYPXIAQD40@rn-mailsvcp-mx-lapp01.rno.apple.com>\n for dev@dpdk.org; Fri, 29 Sep 2023 18:01:23 -0700 (PDT)", "from rn-mailsvcp-mmp-lapp01.rno.apple.com\n (rn-mailsvcp-mmp-lapp01.rno.apple.com [17.179.253.14])\n by rn-mailsvcp-mta-lapp01.rno.apple.com\n (Oracle Communications Messaging Server 8.1.0.23.20230328 64bit (built Mar 28\n 2023)) with ESMTPS id\n <0S1R00R83XIAEIN0@rn-mailsvcp-mta-lapp01.rno.apple.com>;\n Fri, 29 Sep 2023 18:01:22 -0700 (PDT)", "from process_milters-daemon.rn-mailsvcp-mmp-lapp01.rno.apple.com by\n rn-mailsvcp-mmp-lapp01.rno.apple.com\n (Oracle Communications Messaging Server 8.1.0.23.20230328 64bit (built Mar 28\n 2023)) id <0S1R00L00X15DY00@rn-mailsvcp-mmp-lapp01.rno.apple.com>; Fri,\n 29 Sep 2023 18:01:22 -0700 (PDT)", "from localhost (unknown [17.192.171.171])\n by rn-mailsvcp-mmp-lapp01.rno.apple.com\n (Oracle Communications Messaging Server 8.1.0.23.20230328 64bit (built Mar 28\n 2023))\n with ESMTPSA id <0S1R00CITXIAQC00@rn-mailsvcp-mmp-lapp01.rno.apple.com>; Fri,\n 29 Sep 2023 18:01:22 -0700 (PDT)" ], "X-Proofpoint-GUID": "l4n7corkdjr20yRgJFancclvoLr8WIdX", "X-Proofpoint-ORIG-GUID": "l4n7corkdjr20yRgJFancclvoLr8WIdX", "X-Proofpoint-Virus-Version": [ "vendor=fsecure engine=2.50.10434:6.0.619, 18.0.980\n definitions=2023-09-29_21:2023-09-28,\n 2023-09-29 signatures=0", "vendor=fsecure engine=2.50.10434:6.0.619, 18.0.980\n definitions=2023-09-29_21:2023-09-28,\n 2023-09-29 signatures=0" ], "X-Proofpoint-Spam-Details": "rule=interactive_user_notspam\n policy=interactive_user score=0 mlxscore=0 phishscore=0 adultscore=0\n malwarescore=0 mlxlogscore=819 bulkscore=0 spamscore=0 suspectscore=0\n classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2309180000\n definitions=main-2309300006", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=apple.com; h=from : to\n : cc : subject : date : message-id : mime-version :\n content-transfer-encoding;\n s=20180706; bh=iZhLpndfl7ZhpjAyO5zYZM9zxMoeQQK3f4qee5f2q50=;\n b=X3BsaqXZxY89INDRKVOak9vBSHv8oCbmzYcC2wx8jGrigbWCQ6y2/wfj5o496f0JBOMd\n 3nCV9oxfJpit1FkzNrYf+n649DCNMSsjymLueLBaXeC9MNG6lauQUdyBJo14nf/obnYI\n OXLkxCDFZ0tV0ImlUL4Kq9D4v6kL7zCftX3j4h1f8uw6EQbYxeYyZNQ/rdHsodxfdP/8\n YFr19JLzYJmstlhtqyPTYnt2/ENLiQFdiAMXecdk6ypzFVgqYznalsY3TA69sDhwbGYv\n fv4jekKZmMyz84s+ZJcBA4psxHI8sbSiZLVR25aY7Tac0r21+TvJb53iPljeAkRkqnlm sw==", "X-Va-A": "", "X-Va-T-CD": "890ecbe268e4da4a9b8ebf5646b77237", "X-Va-E-CD": "280b9b926dbacefa91ba9c877bba08ef", "X-Va-R-CD": "bec4b1bf10f980605dac9c6d17de9312", "X-Va-ID": "3a769997-baea-465e-b3b0-acda675daa5c", "X-Va-CD": "0", "X-V-A": "", "X-V-T-CD": "890ecbe268e4da4a9b8ebf5646b77237", "X-V-E-CD": "280b9b926dbacefa91ba9c877bba08ef", "X-V-R-CD": "bec4b1bf10f980605dac9c6d17de9312", "X-V-ID": "5af44de5-5c11-4d65-a318-708f5df763d1", "X-V-CD": "0", "From": "Andrey Ignatov <rdna@apple.com>", "To": "dev@dpdk.org", "Cc": "Maxime Coquelin <maxime.coquelin@redhat.com>,\n Chenbo Xia <chenbo.xia@intel.com>, Wei Shen <wshen0123@apple.com>,\n Andrey Ignatov <rdna@apple.com>", "Subject": "[PATCH] net/vhost: report TX errors in port stats", "Date": "Fri, 29 Sep 2023 18:00:24 -0700", "Message-id": "<20230930010024.34377-1-rdna@apple.com>", "X-Mailer": "git-send-email 2.39.3 (Apple Git-145)", "MIME-version": "1.0", "Content-transfer-encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "vhost device doesn't report TX errors what complicates debugging of\ndropped packets. Add oerrors to port stats.\n\n- before (testpmd `show port stats`):\n TX-packets: 18328512 TX-errors: 0 TX-bytes: 1173024768\n\n- after:\n TX-packets: 1737728 TX-errors: 131367616 TX-bytes: 111214592\n\nSigned-off-by: Andrey Ignatov <rdna@apple.com>\n---\n drivers/net/vhost/rte_eth_vhost.c | 4 ++++\n 1 file changed, 4 insertions(+)", "diff": "diff --git a/drivers/net/vhost/rte_eth_vhost.c b/drivers/net/vhost/rte_eth_vhost.c\nindex 8d37ec9775..48a9a79efe 100644\n--- a/drivers/net/vhost/rte_eth_vhost.c\n+++ b/drivers/net/vhost/rte_eth_vhost.c\n@@ -1299,6 +1299,7 @@ eth_stats_get(struct rte_eth_dev *dev, struct rte_eth_stats *stats)\n \tunsigned i;\n \tunsigned long rx_total = 0, tx_total = 0;\n \tunsigned long rx_total_bytes = 0, tx_total_bytes = 0;\n+\tunsigned long tx_total_errors = 0;\n \tstruct vhost_queue *vq;\n \n \tfor (i = 0; i < RTE_ETHDEV_QUEUE_STAT_CNTRS &&\n@@ -1323,12 +1324,15 @@ eth_stats_get(struct rte_eth_dev *dev, struct rte_eth_stats *stats)\n \n \t\tstats->q_obytes[i] = vq->stats.bytes;\n \t\ttx_total_bytes += stats->q_obytes[i];\n+\n+\t\ttx_total_errors += vq->stats.missed_pkts;\n \t}\n \n \tstats->ipackets = rx_total;\n \tstats->opackets = tx_total;\n \tstats->ibytes = rx_total_bytes;\n \tstats->obytes = tx_total_bytes;\n+\tstats->oerrors = tx_total_errors;\n \n \treturn 0;\n }\n", "prefixes": [] }