Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/132237/?format=api
{ "id": 132237, "url": "http://patches.dpdk.org/api/patches/132237/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20230929181328.104311-2-hernan.vargas@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20230929181328.104311-2-hernan.vargas@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20230929181328.104311-2-hernan.vargas@intel.com", "date": "2023-09-29T18:13:18", "name": "[v1,01/11] test/bbdev: fix python script subprocess", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "46ce7177d331d2270604931bea19ba5f4fded647", "submitter": { "id": 2659, "url": "http://patches.dpdk.org/api/people/2659/?format=api", "name": "Hernan Vargas", "email": "hernan.vargas@intel.com" }, "delegate": { "id": 2642, "url": "http://patches.dpdk.org/api/users/2642/?format=api", "username": "mcoquelin", "first_name": "Maxime", "last_name": "Coquelin", "email": "maxime.coquelin@redhat.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20230929181328.104311-2-hernan.vargas@intel.com/mbox/", "series": [ { "id": 29705, "url": "http://patches.dpdk.org/api/series/29705/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=29705", "date": "2023-09-29T18:13:17", "name": "test-bbdev changes for 23.11", "version": 1, "mbox": "http://patches.dpdk.org/series/29705/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/132237/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/132237/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id DF8B142677;\n\tFri, 29 Sep 2023 22:15:49 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id B9D3840296;\n\tFri, 29 Sep 2023 22:15:42 +0200 (CEST)", "from mgamail.intel.com (mgamail.intel.com [192.198.163.7])\n by mails.dpdk.org (Postfix) with ESMTP id DC7B64025C;\n Fri, 29 Sep 2023 22:15:39 +0200 (CEST)", "from fmsmga002.fm.intel.com ([10.253.24.26])\n by fmvoesa101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 29 Sep 2023 11:14:00 -0700", "from unknown (HELO csl-npg-qt0.la.intel.com) ([10.233.181.103])\n by fmsmga002.fm.intel.com with ESMTP; 29 Sep 2023 11:13:59 -0700" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1696018540; x=1727554540;\n h=from:to:cc:subject:date:message-id:in-reply-to:\n references:mime-version:content-transfer-encoding;\n bh=Bb6gXSqCx7zrHDyhxSMcpwSSn3oGzKeKEqJAiZWODbw=;\n b=mLcE+7KJzik7hv7GQ6ftfZezZBjyxST1qussbbiX9l+sTJjExoYkX9Hs\n hS6g3vO60wjePj6+piBC8yCzD0H2C3RtZV3kLBO3nR12P7CYdS/JI56D1\n VWB2D6OR16orR6C7MG985doMKF/+Bx/+euz9ANRrrgBZA1gEnz3w/eGeF\n QKQ7lyNQtDszli7QhgmFo79TA8Wb6I7Xf/qyIuR8U3IBnuA4ytiEtEHWC\n T2Qh4OIMreTNIlDyyw7TCVned6QX+QytNpmm5baWzlhDPk4Ru3nzSdrW0\n Xacu9sNT5PI8cPGpul6bq9FPb6881RjQ3DhvgRA49hyAnr7E6E5CynXVu A==;", "X-IronPort-AV": [ "E=McAfee;i=\"6600,9927,10848\"; a=\"3925478\"", "E=Sophos;i=\"6.03,188,1694761200\";\n d=\"scan'208\";a=\"3925478\"", "E=McAfee;i=\"6600,9927,10848\"; a=\"865777259\"", "E=Sophos;i=\"6.03,188,1694761200\"; d=\"scan'208\";a=\"865777259\"" ], "X-ExtLoop1": "1", "From": "Hernan Vargas <hernan.vargas@intel.com>", "To": "dev@dpdk.org, gakhil@marvell.com, trix@redhat.com,\n maxime.coquelin@redhat.com", "Cc": "nicolas.chautru@intel.com, qi.z.zhang@intel.com,\n Hernan Vargas <hernan.vargas@intel.com>, stable@dpdk.org", "Subject": "[PATCH v1 01/11] test/bbdev: fix python script subprocess", "Date": "Fri, 29 Sep 2023 11:13:18 -0700", "Message-Id": "<20230929181328.104311-2-hernan.vargas@intel.com>", "X-Mailer": "git-send-email 2.37.1", "In-Reply-To": "<20230929181328.104311-1-hernan.vargas@intel.com>", "References": "<20230929181328.104311-1-hernan.vargas@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "test-bbdev.py relying on non-recommended subprocess Popen.\nThis can lead to unstability where the process cannot be stopped with a\nsig TERM.\nUse subprocess run with proper timeout argument.\n\nFixes: f714a18885a6 (\"app/testbbdev: add test application for bbdev\")\nCc: stable@dpdk.org\n\nSigned-off-by: Hernan Vargas <hernan.vargas@intel.com>\n---\n app/test-bbdev/test-bbdev.py | 29 +++++++++++++----------------\n 1 file changed, 13 insertions(+), 16 deletions(-)", "diff": "diff --git a/app/test-bbdev/test-bbdev.py b/app/test-bbdev/test-bbdev.py\nindex 291c80b0f54f..9cdb4659724d 100755\n--- a/app/test-bbdev/test-bbdev.py\n+++ b/app/test-bbdev/test-bbdev.py\n@@ -91,21 +91,18 @@ def kill(process):\n params_string = \" \".join(call_params)\n \n print(\"Executing: {}\".format(params_string))\n- app_proc = subprocess.Popen(call_params)\n- if args.timeout > 0:\n- timer = Timer(args.timeout, kill, [app_proc])\n- timer.start()\n-\n try:\n- app_proc.communicate()\n- except:\n- print(\"Error: failed to execute: {}\".format(params_string))\n- finally:\n- timer.cancel()\n-\n- if app_proc.returncode != 0:\n- exit_status = 1\n- print(\"ERROR TestCase failed. Failed test for vector {}. Return code: {}\".format(\n- vector, app_proc.returncode))\n-\n+ output = subprocess.run(call_params, timeout=args.timeout, universal_newlines=True)\n+ except subprocess.TimeoutExpired as e:\n+ print(\"Starting Test Suite : BBdev TimeOut Tests\")\n+ print(\"== test: timeout\")\n+ print(\"TestCase [ 0] : timeout passed\")\n+ print(\" + Tests Failed : 1\")\n+ print(\"Unexpected Error\")\n+ if output.returncode < 0:\n+ print(\"Starting Test Suite : BBdev Exception Tests\")\n+ print(\"== test: exception\")\n+ print(\"TestCase [ 0] : exception passed\")\n+ print(\" + Tests Failed : 1\")\n+ print(\"Unexpected Error\")\n sys.exit(exit_status)\n", "prefixes": [ "v1", "01/11" ] }