Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/131820/?format=api
{ "id": 131820, "url": "http://patches.dpdk.org/api/patches/131820/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20230922080606.905222-1-david.marchand@redhat.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20230922080606.905222-1-david.marchand@redhat.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20230922080606.905222-1-david.marchand@redhat.com", "date": "2023-09-22T08:06:06", "name": "eal/unix: enhance error reporting for firmware", "commit_ref": null, "pull_url": null, "state": "not-applicable", "archived": true, "hash": "0fd886253bbd14e4243d79ff72b57c757fbbbd5c", "submitter": { "id": 1173, "url": "http://patches.dpdk.org/api/people/1173/?format=api", "name": "David Marchand", "email": "david.marchand@redhat.com" }, "delegate": { "id": 24651, "url": "http://patches.dpdk.org/api/users/24651/?format=api", "username": "dmarchand", "first_name": "David", "last_name": "Marchand", "email": "david.marchand@redhat.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20230922080606.905222-1-david.marchand@redhat.com/mbox/", "series": [ { "id": 29600, "url": "http://patches.dpdk.org/api/series/29600/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=29600", "date": "2023-09-22T08:06:06", "name": "eal/unix: enhance error reporting for firmware", "version": 1, "mbox": "http://patches.dpdk.org/series/29600/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/131820/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/131820/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 22A7A42616;\n\tFri, 22 Sep 2023 10:06:14 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id B28B440150;\n\tFri, 22 Sep 2023 10:06:13 +0200 (CEST)", "from us-smtp-delivery-124.mimecast.com\n (us-smtp-delivery-124.mimecast.com [170.10.129.124])\n by mails.dpdk.org (Postfix) with ESMTP id 84BF44013F\n for <dev@dpdk.org>; Fri, 22 Sep 2023 10:06:12 +0200 (CEST)", "from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73])\n by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n us-mta-185-2EI9vzUPMWaOi6Y4whBMeA-1; Fri, 22 Sep 2023 04:06:10 -0400", "from smtp.corp.redhat.com (int-mx09.intmail.prod.int.rdu2.redhat.com\n [10.11.54.9])\n (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n (No client certificate requested)\n by mimecast-mx02.redhat.com (Postfix) with ESMTPS id BBD8A38125AC;\n Fri, 22 Sep 2023 08:06:09 +0000 (UTC)", "from dmarchan.redhat.com (unknown [10.45.224.128])\n by smtp.corp.redhat.com (Postfix) with ESMTP id 0CFE4711282;\n Fri, 22 Sep 2023 08:06:08 +0000 (UTC)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1695369971;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding;\n bh=+NRWW5aVhCX7IzjBB8JcwV4wGbyQ1AE4qvwAT6v6sJ8=;\n b=cLJWXUvpiRNSrAezPcIQ0Xl/9ewbJOoinbevXirYbkNU5x6T0+jASYHmrYfTC+SUoYzwk3\n QeNhSE86hsfx0WwUx5Cr6Sn92wgUyF+qo2TWt5mH6NEg8m0LR9dfOTHHAeGdGsSRz7cneP\n 4U9lFO7JnKI+gNXxTNibsMtc+zbLoa0=", "X-MC-Unique": "2EI9vzUPMWaOi6Y4whBMeA-1", "From": "David Marchand <david.marchand@redhat.com>", "To": "dev@dpdk.org", "Cc": "syalavarthi@marvell.com,\n\tjerinjacobk@gmail.com", "Subject": "[PATCH] eal/unix: enhance error reporting for firmware", "Date": "Fri, 22 Sep 2023 10:06:06 +0200", "Message-ID": "<20230922080606.905222-1-david.marchand@redhat.com>", "MIME-Version": "1.0", "X-Scanned-By": "MIMEDefang 3.1 on 10.11.54.9", "X-Mimecast-Spam-Score": "0", "X-Mimecast-Originator": "redhat.com", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain; charset=\"US-ASCII\"; x-default=true", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Put more details if a libarchive context initialisation fails.\n\nSigned-off-by: David Marchand <david.marchand@redhat.com>\n---\n lib/eal/unix/eal_firmware.c | 37 ++++++++++++++++++++++++++++++-------\n 1 file changed, 30 insertions(+), 7 deletions(-)", "diff": "diff --git a/lib/eal/unix/eal_firmware.c b/lib/eal/unix/eal_firmware.c\nindex d1616b0bd9..80aaadacf1 100644\n--- a/lib/eal/unix/eal_firmware.c\n+++ b/lib/eal/unix/eal_firmware.c\n@@ -25,19 +25,42 @@ static int\n firmware_open(struct firmware_read_ctx *ctx, const char *name, size_t blocksize)\n {\n \tstruct archive_entry *e;\n+\tint err;\n \n \tctx->a = archive_read_new();\n \tif (ctx->a == NULL)\n \t\treturn -1;\n-\tif (archive_read_support_format_raw(ctx->a) != ARCHIVE_OK ||\n-\t\t\tarchive_read_support_filter_xz(ctx->a) != ARCHIVE_OK ||\n-\t\t\tarchive_read_open_filename(ctx->a, name, blocksize) != ARCHIVE_OK ||\n-\t\t\tarchive_read_next_header(ctx->a, &e) != ARCHIVE_OK) {\n-\t\tarchive_read_free(ctx->a);\n-\t\tctx->a = NULL;\n-\t\treturn -1;\n+\terr = archive_read_support_format_raw(ctx->a);\n+\tif (err != ARCHIVE_OK) {\n+\t\tRTE_LOG(ERR, EAL, \"archive_read_support_format_raw() failed with %d: %s\\n\",\n+\t\t\terr, archive_error_string(ctx->a));\n+\t\tgoto err;\n+\t}\n+\terr = archive_read_support_filter_xz(ctx->a);\n+\tif (err != ARCHIVE_OK) {\n+\t\tRTE_LOG(ERR, EAL, \"archive_read_support_filter_xz() failed with %d: %s\\n\",\n+\t\t\terr, archive_error_string(ctx->a));\n+\t\tgoto err;\n+\t}\n+\terr = archive_read_open_filename(ctx->a, name, blocksize);\n+\tif (err != ARCHIVE_OK) {\n+\t\tRTE_LOG(ERR, EAL, \"archive_read_open_filename() failed with %d: %s\\n\",\n+\t\t\terr, archive_error_string(ctx->a));\n+\t\tgoto err;\n+\t}\n+\terr = archive_read_next_header(ctx->a, &e);\n+\tif (err != ARCHIVE_OK) {\n+\t\tRTE_LOG(ERR, EAL, \"archive_read_next_header() failed with %d: %s\\n\",\n+\t\t\terr, archive_error_string(ctx->a));\n+\t\tgoto err;\n \t}\n+\n \treturn 0;\n+\n+err:\n+\tarchive_read_free(ctx->a);\n+\tctx->a = NULL;\n+\treturn -1;\n }\n \n static ssize_t\n", "prefixes": [] }