Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/131549/?format=api
http://patches.dpdk.org/api/patches/131549/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20230918024612.1600536-16-chaoyong.he@corigine.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20230918024612.1600536-16-chaoyong.he@corigine.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20230918024612.1600536-16-chaoyong.he@corigine.com", "date": "2023-09-18T02:46:01", "name": "[v4,15/26] net/nfp: refact the resource module", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": true, "hash": "126ab6150d5b912e0aa63bdbba4bed70af1bc163", "submitter": { "id": 2554, "url": "http://patches.dpdk.org/api/people/2554/?format=api", "name": "Chaoyong He", "email": "chaoyong.he@corigine.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20230918024612.1600536-16-chaoyong.he@corigine.com/mbox/", "series": [ { "id": 29531, "url": "http://patches.dpdk.org/api/series/29531/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=29531", "date": "2023-09-18T02:45:46", "name": "refact the nfpcore module", "version": 4, "mbox": "http://patches.dpdk.org/series/29531/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/131549/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/131549/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 7726A425C9;\n\tMon, 18 Sep 2023 04:49:17 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id AE9B441149;\n\tMon, 18 Sep 2023 04:47:44 +0200 (CEST)", "from NAM12-MW2-obe.outbound.protection.outlook.com\n (mail-mw2nam12on2113.outbound.protection.outlook.com [40.107.244.113])\n by mails.dpdk.org (Postfix) with ESMTP id 249B3410E6\n for <dev@dpdk.org>; Mon, 18 Sep 2023 04:47:39 +0200 (CEST)", "from SJ0PR13MB5545.namprd13.prod.outlook.com (2603:10b6:a03:424::5)\n by PH7PR13MB6435.namprd13.prod.outlook.com (2603:10b6:510:2ea::9)\n with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6792.26; Mon, 18 Sep\n 2023 02:47:37 +0000", "from SJ0PR13MB5545.namprd13.prod.outlook.com\n ([fe80::7a1c:2887:348a:84bd]) by SJ0PR13MB5545.namprd13.prod.outlook.com\n ([fe80::7a1c:2887:348a:84bd%6]) with mapi id 15.20.6792.026; Mon, 18 Sep 2023\n 02:47:37 +0000" ], "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;\n b=DfcOSXQThGG0N0Pxsm8t3rjU3pcmc9mHEd5lj2EbHsvWneHrSCoDh20ienX2iTUStojUGlCfDahFfB9DuCcNQ2Zz4dR/bcJANPH6TMmBaU5y2T3sMced0lA386XCsdUrq3TQbmV9YmBh3/gRNM8bfBW5lgu0s6jn3mnC5oN6+pUP6Rj3/3tLD3EEG7gTSHC/gcFUO4OkSTEozGZpyFhLTbBUWrKsP1olHAkpSn8869MVykt3aH5gsMimdA0G239rQx8RTafwUiRlXNNNbykolR2S70zP+qgaKlvSv63iPeLVPfRJMq/4fxZ45hbRoX8cCKbORYDaaPevpbAMBfFYRA==", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector9901;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=BJoNp6A839VbF5LvaSGqGRDg9h1LHD/biHMEefc8G00=;\n b=QGQEvnEyEe0q8alryka1sEpuIGp+YvH7gXi3Br9KCc/vYKidUUdAFEDwOhcEy19yKEodWS8/O3Mv2dHvdjTmCq9Ho8up9IvRxilLiDLxb9gz1Xlrm3BFYgwYJz3jhA2ykzhtnV7HQWlCW0qjLJ/FEvaMvyLUd68bDqnlM8U5X2lk6j57ZHzJhXbcKbwZ1+z4DEnF3oF1FVxGdWZ6HpiNHxaNOm9rfXYzjAWc5v7Yy5RFH0I99ROBcxRNMM7JhOJscOz8Xd7gknPJ0PbASjmTigYK3SYTejSS0Qofs87kmCqaCRTkprRrhb5zmnO+xDNQOOu5KNBVm8ky77uCnzV4Fw==", "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass\n smtp.mailfrom=corigine.com; dmarc=pass action=none header.from=corigine.com;\n dkim=pass header.d=corigine.com; arc=none", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=corigine.onmicrosoft.com; s=selector2-corigine-onmicrosoft-com;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=BJoNp6A839VbF5LvaSGqGRDg9h1LHD/biHMEefc8G00=;\n b=GCj3JDEB6bY6hv0JWBxzUisHKTvt9UHpUVtFhn1JWU0eBFBkOx8l8PqQubYhpsuF/06NZWKNNUs89jpELN57cqwnXbLzkuyiYPtajlgkqtov4+/6+G4mv2+fp38r6dWPedqj4eQOkIk9FAWhFKwosvHPyfkTz7C82Rs1HTwZXgo=", "Authentication-Results": "dkim=none (message not signed)\n header.d=none;dmarc=none action=none header.from=corigine.com;", "From": "Chaoyong He <chaoyong.he@corigine.com>", "To": "dev@dpdk.org", "Cc": "Chaoyong He <chaoyong.he@corigine.com>,\n =?utf-8?q?Niklas_S=C3=B6derlund?= <niklas.soderlund@corigine.com>", "Subject": "[PATCH v4 15/26] net/nfp: refact the resource module", "Date": "Mon, 18 Sep 2023 10:46:01 +0800", "Message-Id": "<20230918024612.1600536-16-chaoyong.he@corigine.com>", "X-Mailer": "git-send-email 2.39.1", "In-Reply-To": "<20230918024612.1600536-1-chaoyong.he@corigine.com>", "References": "<20230915091551.1459606-1-chaoyong.he@corigine.com>\n <20230918024612.1600536-1-chaoyong.he@corigine.com>", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "X-ClientProxiedBy": "SE2P216CA0016.KORP216.PROD.OUTLOOK.COM\n (2603:1096:101:114::20) To SJ0PR13MB5545.namprd13.prod.outlook.com\n (2603:10b6:a03:424::5)", "MIME-Version": "1.0", "X-MS-PublicTrafficType": "Email", "X-MS-TrafficTypeDiagnostic": "SJ0PR13MB5545:EE_|PH7PR13MB6435:EE_", "X-MS-Office365-Filtering-Correlation-Id": "c8fb4a00-86d4-4899-be38-08dbb7f19e65", "X-MS-Exchange-SenderADCheck": "1", "X-MS-Exchange-AntiSpam-Relay": "0", "X-Microsoft-Antispam": "BCL:0;", "X-Microsoft-Antispam-Message-Info": "\n aE6knkr5GB7e1oTdSouvHMv1POJ/TJqo2UzcY7hkb6gz1xG1xQqwRZvtVudUxWF+pa91XAf2lgyxJSR31wIDJbqa8L6XlOijVwqjXJK95U6hYWmjL9QVaECNIpUFQauvNn4ySGeH8GY8MGY21pYiLakMTNjG53/Mq0w/KCpFGWqPzqEgRxcJKgyNyvGjc9H2t/9jpJ3E+ZRPJOZWR62OYDqo8SO348WJJfEodHrn/TsvGGAGgW8ke2kvjvuaFeYYa5JQwWNPUEY/lEH9DFb4hQs2CE3wLWr/f0ycQGm0teamhPDp2c8l2DG2eREc8+e6g4RGN+ys2//rPcHWQFckJGVk20BN0s/RhZDkMHw3YA0RchBwnHhyEDE0uY4EDYvH9XleeZH4/Narfc4galt0CJ04U3Q50MQQxkqeUdPn3eNKtIBpgdMqCL2+QIiuIng/zIrUe+x7zW3vNvAK+ja5ZsGkoM9V5tM53aSo4Tl7oad4FFB4zXgORd3ej7MEaVHpNYloK0u6nlgJGD8EE1bB8MviUF2MOMOOX7wiMDmFiG4s8LavBwurCHJkrJXs8Gg0ZRpBy18Ds1sEyXf9TPBuAcj/HXhVkkjW6m11knPk0ANSIxENX/htoANmTKeXGxThhOSgAauFi3WZrNgJpn9WT++4uXJP15YaoJCpIsG5FY8=", "X-Forefront-Antispam-Report": "CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;\n IPV:NLI; SFV:NSPM; H:SJ0PR13MB5545.namprd13.prod.outlook.com; PTR:; CAT:NONE;\n SFS:(13230031)(39830400003)(136003)(346002)(366004)(376002)(396003)(1800799009)(451199024)(186009)(54906003)(66476007)(66946007)(41300700001)(6916009)(316002)(8676002)(4326008)(8936002)(52116002)(6506007)(6486002)(6512007)(478600001)(6666004)(83380400001)(26005)(1076003)(2616005)(107886003)(86362001)(2906002)(44832011)(38100700002)(38350700002)(5660300002)(36756003)(66556008);\n DIR:OUT; SFP:1102;", "X-MS-Exchange-AntiSpam-MessageData-ChunkCount": "1", "X-MS-Exchange-AntiSpam-MessageData-0": "=?utf-8?q?LxGq8evBzHtmvpNIu8sroUgr9nc1?=\n\t=?utf-8?q?q4ioPpwiHBpbeD0HvJ+7BYtSj2FeCQxiStUKDPX9+FNEXhnWwciSwTmP8rJUDtqua?=\n\t=?utf-8?q?m3GNF0Z6tHJnHsGsuwYUj8bpT8k2RhIIWicfNABWczuPT0PyMlzic4QuNeBeUOkBR?=\n\t=?utf-8?q?tiJjEulosTEUyxc4IxpBgNDADmLqO0oe5tVtxM9TBBt0GwgFNn8mMsLBGJOu4HpeV?=\n\t=?utf-8?q?eGHSm6Q5cRoQuPZ3qPeRHGmTui+m4ahl9R4fth/IZiC3/y+GzRbRHqtqUW4vQgs5q?=\n\t=?utf-8?q?kX2Obq95Zb0+dMpgydOK4wd+PSaAhDGX/9RZfRCHwz/ggXHQ/Ia2SwcMkvcS/xAF6?=\n\t=?utf-8?q?3894bzxYwnJOKQ4SGOPxWKSTBIPFHP1uj6V8cPrZSeNwFTjgdDtnZIgZ+dvi6U82e?=\n\t=?utf-8?q?A2zYwQmnspr28wnZmqaUhZupPNOMf3ZphTgrIUqIngfiZqWZnhJWPNprb2rw4f6yj?=\n\t=?utf-8?q?JqO/E9lyd/drAB1TBcxRFz8iTxGbv/9QfyLLZkNNvgrTZuViVR96MaXdIEJDmP04P?=\n\t=?utf-8?q?T5avWvqUZBFau0w7HgNGXUjwmSeyCM312O5yxa2TvRW2+QGsrV2IZfJwI2G2FFSB2?=\n\t=?utf-8?q?1A56bixUFTdzaAfOycaWd/zzZW5zzOM7AP4+B1POiKeNmK1AHPWYeM1kzAHUfeRHO?=\n\t=?utf-8?q?K/TxhLhwulzgilYbuPJo9DvAOwipWhjDgnIhkqTAOZKdY4PlRDnritpr0IZ32SOLw?=\n\t=?utf-8?q?TssGv8t9GYhWJpzfHYKaRFbvvEewwzVToVFFo5m3O1MnWznghQ6LIDX9UI1/fzHAy?=\n\t=?utf-8?q?n19hY4mmo8V/ptBaIJmG+uYn2crOG22m2MpX8Jh700aQTZiigHQyRtAoRtNU9HXWW?=\n\t=?utf-8?q?mxbViZexoAh9DkMkhjudj9VUJWArOYhGV388lm5MLeL2RrA1dbUFdC/YQ7Iw3gtp/?=\n\t=?utf-8?q?+bBypOEMc/Pb+nts/Lf2l7s6nIo697HGqHwAjjJoj154kgOcX64B/PfKe5WxWSmFl?=\n\t=?utf-8?q?NUgSFDKfBKvWa8iZ4CzrKOYsHsnKylYTdRMyj9PbSOhLC4OzSuV/FEO6Mvwkh2IKR?=\n\t=?utf-8?q?W7FtUBuchFev72lwPZ4NIif6WOG7Zz+rjAozE6fBGa0cKn+DpyBScl2rC6JNblWPd?=\n\t=?utf-8?q?iMcYVGRouHGwvs74AGntuZ9RR1udPFmSvrH6Yr5/mP03aBruUjWukl0TtFTueOasF?=\n\t=?utf-8?q?+693BcI3eFGp36tsN2kOxBISObB4IISF+/6xsOtnPk9sUV4fSHWTMgnIHX6odY5Zw?=\n\t=?utf-8?q?phufJ/2ywc6MgDSaiQR3W0w9ZqhsZMQCYyJO25ncgJHmZ4ZWtYBFu+Wvj/O+e3y7x?=\n\t=?utf-8?q?Inmi6DLLJ0B91QE5x9v7a6vKi0OCfzA/Y626bUTj12C4A97anCaGZ8tSwGKU0CYjN?=\n\t=?utf-8?q?N1iwYE61/MGp1l7zG/3L674kwU3KAMc6NKu8699ZjgZRk+bfMQoe7er1+uLGoaumm?=\n\t=?utf-8?q?gieUWTLAuhrYTVwp1gUEb87QNuo1IYQSGXO8uYUf+YC4OwnLLjxCK3NzlbnFJcFS9?=\n\t=?utf-8?q?aqzFiIKjnwOGk5gLwH4Ac5ElT1qAv8E7V1tUvJMSonQE1wJouRS1+HS1uSWFvF+7U?=\n\t=?utf-8?q?mfn/4plzbsZWIq4DCWJRih6MouW9IQEPyQ=3D=3D?=", "X-OriginatorOrg": "corigine.com", "X-MS-Exchange-CrossTenant-Network-Message-Id": "\n c8fb4a00-86d4-4899-be38-08dbb7f19e65", "X-MS-Exchange-CrossTenant-AuthSource": "SJ0PR13MB5545.namprd13.prod.outlook.com", "X-MS-Exchange-CrossTenant-AuthAs": "Internal", "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "18 Sep 2023 02:47:37.7225 (UTC)", "X-MS-Exchange-CrossTenant-FromEntityHeader": "Hosted", "X-MS-Exchange-CrossTenant-Id": "fe128f2c-073b-4c20-818e-7246a585940c", "X-MS-Exchange-CrossTenant-MailboxType": "HOSTED", "X-MS-Exchange-CrossTenant-UserPrincipalName": "\n PAtxh2CLpmT1wunl7iymSnmKKPkwzM7AFBln7iGI8Z240+htzGQZN3FT7e6taD4DSLlvBs75Ur802bP06iLnHT/vdVPOjPyJzdr96MpAYLo=", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "PH7PR13MB6435", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Sync the logic from kernel driver and remove the unneeded header\nfile include statements.\n\nSigned-off-by: Chaoyong He <chaoyong.he@corigine.com>\nReviewed-by: Niklas Söderlund <niklas.soderlund@corigine.com>\n---\n drivers/net/nfp/nfpcore/nfp_resource.c | 21 ++++++++-------------\n 1 file changed, 8 insertions(+), 13 deletions(-)", "diff": "diff --git a/drivers/net/nfp/nfpcore/nfp_resource.c b/drivers/net/nfp/nfpcore/nfp_resource.c\nindex 54bcc5f234..c0afdbfdd2 100644\n--- a/drivers/net/nfp/nfpcore/nfp_resource.c\n+++ b/drivers/net/nfp/nfpcore/nfp_resource.c\n@@ -3,15 +3,11 @@\n * All rights reserved.\n */\n \n-#include <stdio.h>\n-#include <time.h>\n-#include <endian.h>\n+#include \"nfp_resource.h\"\n \n-#include \"nfp_cpp.h\"\n+#include \"nfp_crc.h\"\n #include \"nfp_logs.h\"\n #include \"nfp6000/nfp6000.h\"\n-#include \"nfp_resource.h\"\n-#include \"nfp_crc.h\"\n \n #define NFP_RESOURCE_TBL_TARGET NFP_CPP_TARGET_MU\n #define NFP_RESOURCE_TBL_BASE 0x8100000000ULL\n@@ -43,7 +39,7 @@ struct nfp_resource_entry {\n };\n \n #define NFP_RESOURCE_TBL_SIZE 4096\n-#define NFP_RESOURCE_TBL_ENTRIES (int)(NFP_RESOURCE_TBL_SIZE / \\\n+#define NFP_RESOURCE_TBL_ENTRIES (NFP_RESOURCE_TBL_SIZE / \\\n \t\t\t\t\tsizeof(struct nfp_resource_entry))\n \n struct nfp_resource {\n@@ -175,8 +171,7 @@ nfp_resource_acquire(struct nfp_cpp *cpp,\n \t\t\tNFP_RESOURCE_TBL_BASE, NFP_RESOURCE_TBL_KEY);\n \tif (dev_mutex == NULL) {\n \t\tPMD_DRV_LOG(ERR, \"RESOURCE - CPP mutex alloc failed\");\n-\t\tfree(res);\n-\t\treturn NULL;\n+\t\tgoto err_free;\n \t}\n \n \twait.tv_sec = 0;\n@@ -188,13 +183,12 @@ nfp_resource_acquire(struct nfp_cpp *cpp,\n \t\t\tbreak;\n \t\tif (err != -EBUSY) {\n \t\t\tPMD_DRV_LOG(ERR, \"RESOURCE - try acquire failed\");\n-\t\t\tgoto err_free;\n+\t\t\tgoto mutex_free;\n \t\t}\n \n \t\tif (count++ > 1000) { /* 1ms * 1000 = 1s */\n \t\t\tPMD_DRV_LOG(ERR, \"Error: resource %s timed out\", name);\n-\t\t\terr = -EBUSY;\n-\t\t\tgoto err_free;\n+\t\t\tgoto mutex_free;\n \t\t}\n \n \t\tnanosleep(&wait, NULL);\n@@ -204,8 +198,9 @@ nfp_resource_acquire(struct nfp_cpp *cpp,\n \n \treturn res;\n \n-err_free:\n+mutex_free:\n \tnfp_cpp_mutex_free(dev_mutex);\n+err_free:\n \tfree(res);\n \treturn NULL;\n }\n", "prefixes": [ "v4", "15/26" ] }{ "id": 131549, "url": "