Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/131528/?format=api
{ "id": 131528, "url": "http://patches.dpdk.org/api/patches/131528/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20230918021130.192982-13-simei.su@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20230918021130.192982-13-simei.su@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20230918021130.192982-13-simei.su@intel.com", "date": "2023-09-18T02:11:24", "name": "[v4,12/18] common/idpf/base: refactor descriptor 'ret val' stripping", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "566848ae04c7d385175e88211d7468452564ee20", "submitter": { "id": 1298, "url": "http://patches.dpdk.org/api/people/1298/?format=api", "name": "Simei Su", "email": "simei.su@intel.com" }, "delegate": { "id": 1540, "url": "http://patches.dpdk.org/api/users/1540/?format=api", "username": "qzhan15", "first_name": "Qi", "last_name": "Zhang", "email": "qi.z.zhang@intel.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20230918021130.192982-13-simei.su@intel.com/mbox/", "series": [ { "id": 29530, "url": "http://patches.dpdk.org/api/series/29530/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=29530", "date": "2023-09-18T02:11:12", "name": "update idpf base code", "version": 4, "mbox": "http://patches.dpdk.org/series/29530/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/131528/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/131528/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 69F37425C9;\n\tMon, 18 Sep 2023 04:13:05 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 8EE2540A7A;\n\tMon, 18 Sep 2023 04:12:41 +0200 (CEST)", "from mgamail.intel.com (mgamail.intel.com [192.55.52.151])\n by mails.dpdk.org (Postfix) with ESMTP id 5EA38402E9\n for <dev@dpdk.org>; Mon, 18 Sep 2023 04:12:37 +0200 (CEST)", "from fmsmga004.fm.intel.com ([10.253.24.48])\n by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 17 Sep 2023 19:11:35 -0700", "from dpdk-simei-icelake.sh.intel.com ([10.67.110.167])\n by fmsmga004.fm.intel.com with ESMTP; 17 Sep 2023 19:11:33 -0700" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1695003157; x=1726539157;\n h=from:to:cc:subject:date:message-id:in-reply-to:\n references:mime-version:content-transfer-encoding;\n bh=0oUtMNRvodUI5RAPXgN2bbFUkEaXRfFVfUM/V9UID5Y=;\n b=oJ7CYZ8vkCxYvd7LsEALXZyScdugXLnB5h8+m/jNlZb9Whz4IY2U46CB\n rSrjZ3jVsE9QcNJyuSfbmFqk7Eer1MsZnF9vJgEeMv1kA1WdNkABiJBKD\n 6IRyQwA1Yz2u/zyXvW2cc5SChg9KuvFhy5hgP/ASWDNNY0vHUerjTTjmf\n 7lmldeayI1BcGCoZflBtHoMH15HnsEo97HpMb9fQp5WjJ0PfYaWXl0FLm\n xr8yNieEvPCfCkvViK9XrDbqWF9ixj4YEggwEvhRv2WmmQnau1BNDwVgm\n lIBpqFKihNSFIOC0L8IkFAaiutKSBmJmF0xVqAVLb3yHOWsuWssEi+Hpa Q==;", "X-IronPort-AV": [ "E=McAfee;i=\"6600,9927,10836\"; a=\"359801752\"", "E=Sophos;i=\"6.02,155,1688454000\"; d=\"scan'208\";a=\"359801752\"", "E=McAfee;i=\"6600,9927,10836\"; a=\"815846975\"", "E=Sophos;i=\"6.02,155,1688454000\"; d=\"scan'208\";a=\"815846975\"" ], "X-ExtLoop1": "1", "From": "Simei Su <simei.su@intel.com>", "To": "jingjing.wu@intel.com,\n\tbeilei.xing@intel.com,\n\tqi.z.zhang@intel.com", "Cc": "dev@dpdk.org, wenjun1.wu@intel.com, mingxia.liu@intel.com,\n wenjing.qiao@intel.com, Simei Su <simei.su@intel.com>,\n Pavan Kumar Linga <pavan.kumar.linga@intel.com>", "Subject": "[PATCH v4 12/18] common/idpf/base: refactor descriptor 'ret val'\n stripping", "Date": "Mon, 18 Sep 2023 10:11:24 +0800", "Message-Id": "<20230918021130.192982-13-simei.su@intel.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20230918021130.192982-1-simei.su@intel.com>", "References": "<20230915021730.2681882-1-simei.su@intel.com>\n <20230918021130.192982-1-simei.su@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Conditional check is not necessary to strip and get status bits\nfrom the descriptor.\n\nSigned-off-by: Pavan Kumar Linga <pavan.kumar.linga@intel.com>\nSigned-off-by: Simei Su <simei.su@intel.com>\nAcked-by: Beilei Xing <beilei.xing@intel.com>\n---\n drivers/common/idpf/base/idpf_controlq.c | 7 ++-----\n 1 file changed, 2 insertions(+), 5 deletions(-)", "diff": "diff --git a/drivers/common/idpf/base/idpf_controlq.c b/drivers/common/idpf/base/idpf_controlq.c\nindex 7b12dfab18..da5c930578 100644\n--- a/drivers/common/idpf/base/idpf_controlq.c\n+++ b/drivers/common/idpf/base/idpf_controlq.c\n@@ -426,11 +426,8 @@ static int __idpf_ctlq_clean_sq(struct idpf_ctlq_info *cq, u16 *clean_count,\n \t\tif (!force && !(LE16_TO_CPU(desc->flags) & IDPF_CTLQ_FLAG_DD))\n \t\t\tbreak;\n \n-\t\tdesc_err = LE16_TO_CPU(desc->ret_val);\n-\t\tif (desc_err) {\n-\t\t\t/* strip off FW internal code */\n-\t\t\tdesc_err &= 0xff;\n-\t\t}\n+\t\t/* strip off FW internal code */\n+\t\tdesc_err = LE16_TO_CPU(desc->ret_val) & 0xff;\n \n \t\tmsg_status[i] = cq->bi.tx_msg[ntc];\n \t\tif (!msg_status[i])\n", "prefixes": [ "v4", "12/18" ] }