Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/131527/?format=api
{ "id": 131527, "url": "http://patches.dpdk.org/api/patches/131527/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20230918021130.192982-12-simei.su@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20230918021130.192982-12-simei.su@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20230918021130.192982-12-simei.su@intel.com", "date": "2023-09-18T02:11:23", "name": "[v4,11/18] common/idpf/base: use 'void' return type", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "69c88142a4b824ea16de6d4ccab89f79476e1028", "submitter": { "id": 1298, "url": "http://patches.dpdk.org/api/people/1298/?format=api", "name": "Simei Su", "email": "simei.su@intel.com" }, "delegate": { "id": 1540, "url": "http://patches.dpdk.org/api/users/1540/?format=api", "username": "qzhan15", "first_name": "Qi", "last_name": "Zhang", "email": "qi.z.zhang@intel.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20230918021130.192982-12-simei.su@intel.com/mbox/", "series": [ { "id": 29530, "url": "http://patches.dpdk.org/api/series/29530/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=29530", "date": "2023-09-18T02:11:12", "name": "update idpf base code", "version": 4, "mbox": "http://patches.dpdk.org/series/29530/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/131527/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/131527/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id BA542425C9;\n\tMon, 18 Sep 2023 04:12:59 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 1D08D40A7D;\n\tMon, 18 Sep 2023 04:12:38 +0200 (CEST)", "from mgamail.intel.com (mgamail.intel.com [192.55.52.151])\n by mails.dpdk.org (Postfix) with ESMTP id 7B71C4067B\n for <dev@dpdk.org>; Mon, 18 Sep 2023 04:12:35 +0200 (CEST)", "from fmsmga004.fm.intel.com ([10.253.24.48])\n by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 17 Sep 2023 19:11:33 -0700", "from dpdk-simei-icelake.sh.intel.com ([10.67.110.167])\n by fmsmga004.fm.intel.com with ESMTP; 17 Sep 2023 19:11:30 -0700" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1695003155; x=1726539155;\n h=from:to:cc:subject:date:message-id:in-reply-to:\n references:mime-version:content-transfer-encoding;\n bh=fc5nS2v0GS0RKihbnhSicK16e0vNA0G1Qkbdy/MCQjA=;\n b=QQ/VHZ3FGEg4Aou9UPyKjOWk58+3OaS2KygZE6tkOBWhV/9eVhSBR7z6\n U3/bcOiSV6F2oUBYsG5oCfO0qj1lDfqCI0rHuagTd4sFTwSnZAxTQC3fj\n /NU7IDvUr0BQCqxOtkLnQxxxtmizEwwZ8RGLLJhfQ+/WF2Fl06yWdAZhF\n cZwCZB2zPdko5y69H6pgcoaqbniswCIzL5MUJyqxfBgW/9To/q6tvDb0V\n Mtd/H+tR6dx7ZJlHGuPZ/xTHhSFPMfoHnls7PZACRPIC0DoEzMUbppsnB\n yy5MRsg4bhfAlgPkwTGKTxi0SEWWFWL4qGgRXpTUfyOsRtgBvZx98PLLT A==;", "X-IronPort-AV": [ "E=McAfee;i=\"6600,9927,10836\"; a=\"359801734\"", "E=Sophos;i=\"6.02,155,1688454000\"; d=\"scan'208\";a=\"359801734\"", "E=McAfee;i=\"6600,9927,10836\"; a=\"815846955\"", "E=Sophos;i=\"6.02,155,1688454000\"; d=\"scan'208\";a=\"815846955\"" ], "X-ExtLoop1": "1", "From": "Simei Su <simei.su@intel.com>", "To": "jingjing.wu@intel.com,\n\tbeilei.xing@intel.com,\n\tqi.z.zhang@intel.com", "Cc": "dev@dpdk.org, wenjun1.wu@intel.com, mingxia.liu@intel.com,\n wenjing.qiao@intel.com, Simei Su <simei.su@intel.com>,\n Pavan Kumar Linga <pavan.kumar.linga@intel.com>", "Subject": "[PATCH v4 11/18] common/idpf/base: use 'void' return type", "Date": "Mon, 18 Sep 2023 10:11:23 +0800", "Message-Id": "<20230918021130.192982-12-simei.su@intel.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20230918021130.192982-1-simei.su@intel.com>", "References": "<20230915021730.2681882-1-simei.su@intel.com>\n <20230918021130.192982-1-simei.su@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "As idpf_ctlq_deinit always returns success, make it 'void' instead\nof returning only success. This also changes the return type for\nidpf_deinit_hw as 'void'.\n\nBased on the upstream comments, explicit __le16 typecasting is not\nnecessary as CPU_TO_LE16 is already being used.\n\nSigned-off-by: Pavan Kumar Linga <pavan.kumar.linga@intel.com>\nSigned-off-by: Simei Su <simei.su@intel.com>\nAcked-by: Beilei Xing <beilei.xing@intel.com>\n---\n drivers/common/idpf/base/idpf_common.c | 4 ++--\n drivers/common/idpf/base/idpf_controlq.c | 7 ++-----\n drivers/common/idpf/base/idpf_controlq_api.h | 2 +-\n drivers/common/idpf/base/idpf_prototype.h | 2 +-\n 4 files changed, 6 insertions(+), 9 deletions(-)", "diff": "diff --git a/drivers/common/idpf/base/idpf_common.c b/drivers/common/idpf/base/idpf_common.c\nindex 9610916aa9..7181a7f14c 100644\n--- a/drivers/common/idpf/base/idpf_common.c\n+++ b/drivers/common/idpf/base/idpf_common.c\n@@ -262,12 +262,12 @@ int idpf_clean_arq_element(struct idpf_hw *hw,\n * idpf_deinit_hw - shutdown routine\n * @hw: pointer to the hardware structure\n */\n-int idpf_deinit_hw(struct idpf_hw *hw)\n+void idpf_deinit_hw(struct idpf_hw *hw)\n {\n \thw->asq = NULL;\n \thw->arq = NULL;\n \n-\treturn idpf_ctlq_deinit(hw);\n+\tidpf_ctlq_deinit(hw);\n }\n \n /**\ndiff --git a/drivers/common/idpf/base/idpf_controlq.c b/drivers/common/idpf/base/idpf_controlq.c\nindex b84a1ea046..7b12dfab18 100644\n--- a/drivers/common/idpf/base/idpf_controlq.c\n+++ b/drivers/common/idpf/base/idpf_controlq.c\n@@ -75,7 +75,7 @@ static void idpf_ctlq_init_rxq_bufs(struct idpf_ctlq_info *cq)\n \t\tdesc->flags =\n \t\t\tCPU_TO_LE16(IDPF_CTLQ_FLAG_BUF | IDPF_CTLQ_FLAG_RD);\n \t\tdesc->opcode = 0;\n-\t\tdesc->datalen = (__le16)CPU_TO_LE16(bi->size);\n+\t\tdesc->datalen = CPU_TO_LE16(bi->size);\n \t\tdesc->ret_val = 0;\n \t\tdesc->cookie_high = 0;\n \t\tdesc->cookie_low = 0;\n@@ -264,16 +264,13 @@ int idpf_ctlq_init(struct idpf_hw *hw, u8 num_q,\n * idpf_ctlq_deinit - destroy all control queues\n * @hw: pointer to hw struct\n */\n-int idpf_ctlq_deinit(struct idpf_hw *hw)\n+void idpf_ctlq_deinit(struct idpf_hw *hw)\n {\n \tstruct idpf_ctlq_info *cq = NULL, *tmp = NULL;\n-\tint ret_code = 0;\n \n \tLIST_FOR_EACH_ENTRY_SAFE(cq, tmp, &hw->cq_list_head,\n \t\t\t\t idpf_ctlq_info, cq_list)\n \t\tidpf_ctlq_remove(hw, cq);\n-\n-\treturn ret_code;\n }\n \n /**\ndiff --git a/drivers/common/idpf/base/idpf_controlq_api.h b/drivers/common/idpf/base/idpf_controlq_api.h\nindex f4e7b53ac9..78a54f6b4c 100644\n--- a/drivers/common/idpf/base/idpf_controlq_api.h\n+++ b/drivers/common/idpf/base/idpf_controlq_api.h\n@@ -205,6 +205,6 @@ int idpf_ctlq_post_rx_buffs(struct idpf_hw *hw,\n \t\t\t struct idpf_dma_mem **buffs);\n \n /* Will destroy all q including the default mb */\n-int idpf_ctlq_deinit(struct idpf_hw *hw);\n+void idpf_ctlq_deinit(struct idpf_hw *hw);\n \n #endif /* _IDPF_CONTROLQ_API_H_ */\ndiff --git a/drivers/common/idpf/base/idpf_prototype.h b/drivers/common/idpf/base/idpf_prototype.h\nindex 988ff00506..e2f090a9e3 100644\n--- a/drivers/common/idpf/base/idpf_prototype.h\n+++ b/drivers/common/idpf/base/idpf_prototype.h\n@@ -20,7 +20,7 @@\n #define APF\n \n int idpf_init_hw(struct idpf_hw *hw, struct idpf_ctlq_size ctlq_size);\n-int idpf_deinit_hw(struct idpf_hw *hw);\n+void idpf_deinit_hw(struct idpf_hw *hw);\n \n int idpf_clean_arq_element(struct idpf_hw *hw,\n \t\t\t struct idpf_arq_event_info *e,\n", "prefixes": [ "v4", "11/18" ] }