Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/131388/?format=api
{ "id": 131388, "url": "http://patches.dpdk.org/api/patches/131388/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20230913114351.1940459-3-thomas@monjalon.net/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20230913114351.1940459-3-thomas@monjalon.net>", "list_archive_url": "https://inbox.dpdk.org/dev/20230913114351.1940459-3-thomas@monjalon.net", "date": "2023-09-13T11:28:15", "name": "[v3,02/11] eal: rename thread name length definition", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "519c85a4053097f651a20298bba1f6a54e24ad12", "submitter": { "id": 685, "url": "http://patches.dpdk.org/api/people/685/?format=api", "name": "Thomas Monjalon", "email": "thomas@monjalon.net" }, "delegate": { "id": 24651, "url": "http://patches.dpdk.org/api/users/24651/?format=api", "username": "dmarchand", "first_name": "David", "last_name": "Marchand", "email": "david.marchand@redhat.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20230913114351.1940459-3-thomas@monjalon.net/mbox/", "series": [ { "id": 29494, "url": "http://patches.dpdk.org/api/series/29494/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=29494", "date": "2023-09-13T11:28:13", "name": "rework thread management", "version": 3, "mbox": "http://patches.dpdk.org/series/29494/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/131388/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/131388/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 4AAD042588;\n\tWed, 13 Sep 2023 13:45:13 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 8CD6A40689;\n\tWed, 13 Sep 2023 13:45:11 +0200 (CEST)", "from wout5-smtp.messagingengine.com (wout5-smtp.messagingengine.com\n [64.147.123.21]) by mails.dpdk.org (Postfix) with ESMTP id 9985940293\n for <dev@dpdk.org>; Wed, 13 Sep 2023 13:45:09 +0200 (CEST)", "from compute1.internal (compute1.nyi.internal [10.202.2.41])\n by mailout.west.internal (Postfix) with ESMTP id E5DC73200957;\n Wed, 13 Sep 2023 07:45:07 -0400 (EDT)", "from mailfrontend1 ([10.202.2.162])\n by compute1.internal (MEProxy); Wed, 13 Sep 2023 07:45:08 -0400", "by mail.messagingengine.com (Postfix) with ESMTPA; Wed,\n 13 Sep 2023 07:45:05 -0400 (EDT)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=\n cc:cc:content-transfer-encoding:content-type:content-type:date\n :date:from:from:in-reply-to:in-reply-to:message-id:mime-version\n :references:reply-to:sender:subject:subject:to:to; s=fm2; t=\n 1694605507; x=1694691907; bh=Qu2x7Ja/yh9Qi3mISmOdF72ldQCkUZbKAQQ\n /xmlwgv0=; b=J9BEpIqhgcGOpkm5ILS8VIFz5kk+F6Q97VtGnIhJhwVgFSPkaNT\n N5fkQE/eQ2pRhaPgGqMvFOubCt98gLIxSbB4pjiYNGV9kjIcU5hRxpkFRsr22znA\n odrvqbaIl6CTpn0r99oYtB7a+QjXccB6N/43hHg/INLkwt36cqeSCdTSzQCQVBRP\n YfksEQ9tNqHIoAp6L/IWo+JHTwD6H3yhEI+2fd6CV6X4WInDLmBmVHTqy/4q1T9P\n FNh43o8v17NDmVpP/buNX4cbpCJbA7C9Y5IeWE4QTApl4iQAixdu5N2qkMgDu6mV\n 6C8qDGlrh9r/vj5PU2o7W1kLyH/2avFTTlw==", "v=1; a=rsa-sha256; c=relaxed/relaxed; d=\n messagingengine.com; h=cc:cc:content-transfer-encoding\n :content-type:content-type:date:date:feedback-id:feedback-id\n :from:from:in-reply-to:in-reply-to:message-id:mime-version\n :references:reply-to:sender:subject:subject:to:to:x-me-proxy\n :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=\n 1694605507; x=1694691907; bh=Qu2x7Ja/yh9Qi3mISmOdF72ldQCkUZbKAQQ\n /xmlwgv0=; b=pjogxeoVht/B8PTCtaxms5aDDBpNhW9Lge7FU2OQDvUhQVTGmAp\n cIQZCxI57FwJZh9aAbg6OmzZtAes5KULlz2Jz0yZ9k7fDfKYs6PqWaBkqK4HN0PP\n +SqniSZTVDEsZjYvv8o+iNJohfcephpEufD/1QXK7VbKJWCJi8tLJ7kk39lRuBgf\n 8yuz+S2QXEitoQWdCvhZ6pLeMTl9XrW4mh7jRff0/pPxa76e58CFYpbmHq+qfFrM\n juJ22fSzlLzt777h7W5ksMCxTWa14th5FXEYqj7V0rdZL28UAIfbacooxnAvhu6q\n CJljOeEPRx5M/zeg0cFceQ4D3ez5+j9phgw==" ], "X-ME-Sender": "<xms:w6ABZdF5W1yIocEXFj2U8-F2_Y21_xg2fa6wgNawb6wLY8rbZHLNmQ>\n <xme:w6ABZSXABlU1pMT1Z90zgHoOj7mCjr4oyZd5WkDY4cZj0uUAAaaP2DAWvk4y_zk2I\n jTDT_yCgrDe1-K9OA>", "X-ME-Received": "\n <xmr:w6ABZfJl_XMpMb3pWTFbqKbWOX4rDV70oUYuUBHDSlVvr00_Cc1fWTHNll2l6W1iFgIuzg>", "X-ME-Proxy-Cause": "\n gggruggvucftvghtrhhoucdtuddrgedviedrudeikedggeegucetufdoteggodetrfdotf\n fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen\n uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne\n cujfgurhephffvvefufffkofgjfhggtgfgsehtkeertdertdejnecuhfhrohhmpefvhhho\n mhgrshcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqne\n cuggftrfgrthhtvghrnheptdeiffffgeefteelhfekueetueduffejgfelvedtieejudek\n gfevheetheehgeejnecuvehluhhsthgvrhfuihiivgepvdenucfrrghrrghmpehmrghilh\n hfrhhomhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth", "X-ME-Proxy": "<xmx:w6ABZTFAdyiIEGRjtP5hkFWvKh-NjSnmELttzSFBzYKc7vyT02VpGg>\n <xmx:w6ABZTUf4kXsw6xkQfRvCqoeMvlEG4kyohIcVyUZGTQ8OoXjHEftng>\n <xmx:w6ABZeODEyVmhwplrEdGiknH3QVrOECJT_21X_f3BZKv6I2-FOnQmA>\n <xmx:w6ABZfqueZdA79NBu7yeV6pe7dZt6pfyPXp_kYVHm_OrmttLXjyiQg>", "Feedback-ID": "i47234305:Fastmail", "From": "Thomas Monjalon <thomas@monjalon.net>", "To": "dev@dpdk.org", "Cc": "Tyler Retzlaff <roretzla@linux.microsoft.com>,\n David Marchand <david.marchand@redhat.com>,\n Ferruh Yigit <ferruh.yigit@amd.com>,\n =?utf-8?q?Morten_Br=C3=B8rup?= <mb@smartsharesystems.com>,\n Bruce Richardson <bruce.richardson@intel.com>,\n Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>,\n Narcisa Ana Maria Vasile <navasile@linux.microsoft.com>,\n Dmitry Malloy <dmitrym@microsoft.com>,\n Pallavi Kadam <pallavi.kadam@intel.com>", "Subject": "[PATCH v3 02/11] eal: rename thread name length definition", "Date": "Wed, 13 Sep 2023 13:28:15 +0200", "Message-ID": "<20230913114351.1940459-3-thomas@monjalon.net>", "X-Mailer": "git-send-email 2.42.0", "In-Reply-To": "<20230913114351.1940459-1-thomas@monjalon.net>", "References": "<20230906162226.1618088-1-thomas@monjalon.net>\n <20230913114351.1940459-1-thomas@monjalon.net>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "RTE_MAX_THREAD_NAME_LEN is including the NUL character,\nso it should be named \"size\" instead of \"length\".\nA new constant RTE_THREAD_NAME_SIZE is introduced for naming accuracy.\nFor API compatibility, the old name is kept.\n\nAt the same time, the original definition is moved\nfrom rte_eal.h to rte_thread.h.\n\nSigned-off-by: Thomas Monjalon <thomas@monjalon.net>\nAcked-by: Morten Brørup <mb@smartsharesystems.com>\nAcked-by: Tyler Retzlaff <roretzla@linux.microsoft.com>\n---\n lib/eal/freebsd/eal.c | 2 +-\n lib/eal/freebsd/eal_thread.c | 2 +-\n lib/eal/include/rte_eal.h | 3 ---\n lib/eal/include/rte_thread.h | 9 +++++++--\n lib/eal/linux/eal.c | 2 +-\n lib/eal/linux/eal_thread.c | 2 +-\n lib/eal/windows/eal.c | 2 +-\n lib/eal/windows/rte_thread.c | 2 +-\n 8 files changed, 13 insertions(+), 11 deletions(-)", "diff": "diff --git a/lib/eal/freebsd/eal.c b/lib/eal/freebsd/eal.c\nindex 9e1e267955..39a2868523 100644\n--- a/lib/eal/freebsd/eal.c\n+++ b/lib/eal/freebsd/eal.c\n@@ -583,7 +583,7 @@ rte_eal_init(int argc, char **argv)\n \tstatic uint32_t run_once;\n \tuint32_t has_run = 0;\n \tchar cpuset[RTE_CPU_AFFINITY_STR_LEN];\n-\tchar thread_name[RTE_MAX_THREAD_NAME_LEN];\n+\tchar thread_name[RTE_THREAD_NAME_SIZE];\n \tconst struct rte_config *config = rte_eal_get_configuration();\n \tstruct internal_config *internal_conf =\n \t\teal_get_internal_configuration();\ndiff --git a/lib/eal/freebsd/eal_thread.c b/lib/eal/freebsd/eal_thread.c\nindex 3227d9b8a2..ba9b25c2c0 100644\n--- a/lib/eal/freebsd/eal_thread.c\n+++ b/lib/eal/freebsd/eal_thread.c\n@@ -34,7 +34,7 @@ int rte_sys_gettid(void)\n \n void rte_thread_set_name(rte_thread_t thread_id, const char *thread_name)\n {\n-\tchar truncated[RTE_MAX_THREAD_NAME_LEN];\n+\tchar truncated[RTE_THREAD_NAME_SIZE];\n \tconst size_t truncatedsz = sizeof(truncated);\n \n \tif (strlcpy(truncated, thread_name, truncatedsz) >= truncatedsz)\ndiff --git a/lib/eal/include/rte_eal.h b/lib/eal/include/rte_eal.h\nindex 53c4a5519e..cd318ee141 100644\n--- a/lib/eal/include/rte_eal.h\n+++ b/lib/eal/include/rte_eal.h\n@@ -27,9 +27,6 @@ extern \"C\" {\n \n #define RTE_MAGIC 19820526 /**< Magic number written by the main partition when ready. */\n \n-/* Maximum thread_name length. */\n-#define RTE_MAX_THREAD_NAME_LEN 16\n-\n /**\n * The type of process in a linux, multi-process setup\n */\ndiff --git a/lib/eal/include/rte_thread.h b/lib/eal/include/rte_thread.h\nindex 369e2375f6..6233142322 100644\n--- a/lib/eal/include/rte_thread.h\n+++ b/lib/eal/include/rte_thread.h\n@@ -23,6 +23,11 @@\n extern \"C\" {\n #endif\n \n+/** Maximum thread name length (including '\\0'). */\n+#define RTE_THREAD_NAME_SIZE 16\n+/* Old definition, aliased for compatibility. */\n+#define RTE_MAX_THREAD_NAME_LEN RTE_THREAD_NAME_SIZE\n+\n /**\n * Thread id descriptor.\n */\n@@ -110,7 +115,7 @@ int rte_thread_create(rte_thread_t *thread_id,\n * Filled with the thread id of the new created thread.\n * @param name\n * The name of the control thread\n- * (max RTE_MAX_THREAD_NAME_LEN characters including '\\0').\n+ * (max RTE_THREAD_NAME_SIZE characters including '\\0').\n * @param thread_attr\n * Attributes for the new thread.\n * @param thread_func\n@@ -188,7 +193,7 @@ rte_thread_t rte_thread_self(void);\n * The id of the thread to set name.\n *\n * @param thread_name\n- * The name to set. Truncated to RTE_MAX_THREAD_NAME_LEN,\n+ * The name to set. Truncated to RTE_THREAD_NAME_SIZE,\n * including terminating NUL if necessary.\n */\n __rte_experimental\ndiff --git a/lib/eal/linux/eal.c b/lib/eal/linux/eal.c\nindex a26822f667..5f4b2fb005 100644\n--- a/lib/eal/linux/eal.c\n+++ b/lib/eal/linux/eal.c\n@@ -970,7 +970,7 @@ rte_eal_init(int argc, char **argv)\n \tstatic uint32_t run_once;\n \tuint32_t has_run = 0;\n \tchar cpuset[RTE_CPU_AFFINITY_STR_LEN];\n-\tchar thread_name[RTE_MAX_THREAD_NAME_LEN];\n+\tchar thread_name[RTE_THREAD_NAME_SIZE];\n \tbool phys_addrs;\n \tconst struct rte_config *config = rte_eal_get_configuration();\n \tstruct internal_config *internal_conf =\ndiff --git a/lib/eal/linux/eal_thread.c b/lib/eal/linux/eal_thread.c\nindex c07ad9d8a4..b9a126f3a8 100644\n--- a/lib/eal/linux/eal_thread.c\n+++ b/lib/eal/linux/eal_thread.c\n@@ -24,7 +24,7 @@ void rte_thread_set_name(rte_thread_t thread_id, const char *thread_name)\n \tint ret = ENOSYS;\n #if defined(__GLIBC__) && defined(__GLIBC_PREREQ)\n #if __GLIBC_PREREQ(2, 12)\n-\tchar truncated[RTE_MAX_THREAD_NAME_LEN];\n+\tchar truncated[RTE_THREAD_NAME_SIZE];\n \tconst size_t truncatedsz = sizeof(truncated);\n \n \tif (strlcpy(truncated, thread_name, truncatedsz) >= truncatedsz)\ndiff --git a/lib/eal/windows/eal.c b/lib/eal/windows/eal.c\nindex 16c1ba1596..7ec2152211 100644\n--- a/lib/eal/windows/eal.c\n+++ b/lib/eal/windows/eal.c\n@@ -283,7 +283,7 @@ rte_eal_init(int argc, char **argv)\n \tenum rte_iova_mode iova_mode;\n \tint ret;\n \tchar cpuset[RTE_CPU_AFFINITY_STR_LEN];\n-\tchar thread_name[RTE_MAX_THREAD_NAME_LEN];\n+\tchar thread_name[RTE_THREAD_NAME_SIZE];\n \n \teal_log_init(NULL, 0);\n \ndiff --git a/lib/eal/windows/rte_thread.c b/lib/eal/windows/rte_thread.c\nindex e528ac9991..acf648456c 100644\n--- a/lib/eal/windows/rte_thread.c\n+++ b/lib/eal/windows/rte_thread.c\n@@ -324,7 +324,7 @@ void\n rte_thread_set_name(rte_thread_t thread_id, const char *thread_name)\n {\n \tint ret = 0;\n-\twchar_t wname[RTE_MAX_THREAD_NAME_LEN];\n+\twchar_t wname[RTE_THREAD_NAME_SIZE];\n \tmbstate_t state = {0};\n \tsize_t rv;\n \tHANDLE thread_handle;\n", "prefixes": [ "v3", "02/11" ] }