Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/131386/?format=api
{ "id": 131386, "url": "http://patches.dpdk.org/api/patches/131386/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20230913103600.1935292-12-thomas@monjalon.net/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20230913103600.1935292-12-thomas@monjalon.net>", "list_archive_url": "https://inbox.dpdk.org/dev/20230913103600.1935292-12-thomas@monjalon.net", "date": "2023-09-13T10:34:30", "name": "[v2,11/11] lib: remove pthread.h from includes", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "4462b4f3bd5677e9d3dbe0a19661a3103c09e91f", "submitter": { "id": 685, "url": "http://patches.dpdk.org/api/people/685/?format=api", "name": "Thomas Monjalon", "email": "thomas@monjalon.net" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20230913103600.1935292-12-thomas@monjalon.net/mbox/", "series": [ { "id": 29493, "url": "http://patches.dpdk.org/api/series/29493/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=29493", "date": "2023-09-13T10:34:19", "name": "rework thread management", "version": 2, "mbox": "http://patches.dpdk.org/series/29493/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/131386/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/131386/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 5E8E442588;\n\tWed, 13 Sep 2023 12:38:28 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 14B2E40A72;\n\tWed, 13 Sep 2023 12:38:17 +0200 (CEST)", "from wout5-smtp.messagingengine.com (wout5-smtp.messagingengine.com\n [64.147.123.21]) by mails.dpdk.org (Postfix) with ESMTP id 3C51A402E2\n for <dev@dpdk.org>; Wed, 13 Sep 2023 12:38:15 +0200 (CEST)", "from compute3.internal (compute3.nyi.internal [10.202.2.43])\n by mailout.west.internal (Postfix) with ESMTP id 2DAEE3200991;\n Wed, 13 Sep 2023 06:38:12 -0400 (EDT)", "from mailfrontend1 ([10.202.2.162])\n by compute3.internal (MEProxy); Wed, 13 Sep 2023 06:38:14 -0400", "by mail.messagingengine.com (Postfix) with ESMTPA; Wed,\n 13 Sep 2023 06:38:07 -0400 (EDT)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=\n cc:cc:content-transfer-encoding:content-type:content-type:date\n :date:from:from:in-reply-to:in-reply-to:message-id:mime-version\n :references:reply-to:sender:subject:subject:to:to; s=fm2; t=\n 1694601491; x=1694687891; bh=CmRpyHZnRwrd/WVgmOtZhSc3zNRrJ91JaeY\n 4VGVqLbM=; b=JOhOgplPAnzJX2AarUyD13RbGta+HZgVjWrIMkLnzTt37PKZROc\n AjYaBDPU/6cYnOq/caTaizZozTDlLxAuZTLkEeo8LB239OtrWDgDZYxhP95cP96T\n l2r6uv7mEzZvZAppin8xK59Y6rasuAy77NOWOAireHcJUZ9SzisJCoQL2ztdSs0z\n y/E1agdih+VkRJyN1zT1YkdzSWZN5R8FilYYNoDMnEf8iFLPwLkYqT/eUYvys53/\n y9Dw4HW+BBEyJYZhQN1Ly1+w6JNvcYbNk8oCXwclqi/A1RTmd6jDROVIr1Yfru1W\n 2li+feFF/XpExfhftUkJyKTzWxGrrYbYn9Q==", "v=1; a=rsa-sha256; c=relaxed/relaxed; d=\n messagingengine.com; h=cc:cc:content-transfer-encoding\n :content-type:content-type:date:date:feedback-id:feedback-id\n :from:from:in-reply-to:in-reply-to:message-id:mime-version\n :references:reply-to:sender:subject:subject:to:to:x-me-proxy\n :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=\n 1694601491; x=1694687891; bh=CmRpyHZnRwrd/WVgmOtZhSc3zNRrJ91JaeY\n 4VGVqLbM=; b=hsmkN22heEFOGLoKRpO70wxbe2Wv6d+I+doLhbEl3VWyAThf7PW\n 6xlMrJ3VIl87S5Fwxx7jWKdiNoksI4uLMRWzMrfXWUuZnTDqn1yGlfAh6+ny5RhU\n lSwkxOucfj9DY2tUKEOpqYx+mwyEgvjUjbw7SzpazTK43XghedmTzZuMlOTPX7XY\n UJuxxctqzOcFrIB8HAZqx+mOkvDAvKcyCJJpspZfZYeg3fXUv1Jskn3sBC6SiY3e\n KKp272jocYrP5wAS+qtOnCKOK1dE7su6uHSJ0I36386PCZBRL5Q53rSqUBj49WYn\n lJrz8A/YJ7VL+6LKVNSXWk0YKyMHsquaDuw==" ], "X-ME-Sender": "<xms:E5EBZdoCG9EK48X9tLgx7ebPHVWzqimZzr1WYCXVQ5UYbaB1bOxYOg>\n <xme:E5EBZfou_kHsR5TBpQx2kw8jvxw7j7q0f7o_Ajs_UtoYNW146D_6YOrtOe77RwdaK\n hUqJ9lbzFIEpZnQGQ>", "X-ME-Received": "\n <xmr:E5EBZaP0Rol633Ro5qRIL-q55_bicvNxkmWhzG9T1zABKnJeX9U8AIGe1VmcZhk1oAAFFQ>", "X-ME-Proxy-Cause": "\n gggruggvucftvghtrhhoucdtuddrgedviedrudeikedgfedtucetufdoteggodetrfdotf\n fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen\n uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne\n cujfgurhephffvvefufffkofgjfhggtgfgsehtkeertdertdejnecuhfhrohhmpefvhhho\n mhgrshcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqne\n cuggftrfgrthhtvghrnheptdeiffffgeefteelhfekueetueduffejgfelvedtieejudek\n gfevheetheehgeejnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilh\n hfrhhomhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth", "X-ME-Proxy": "<xmx:E5EBZY4HKFhgcSmbyi7U9yhj3226Rf3HzfjRDSv1J9K5YMRvvBgd8g>\n <xmx:E5EBZc6PANdwrECh4sy_K4XQOWwmBQXRLo8F5zFmBjaknL-K1qUF1Q>\n <xmx:E5EBZQjrPsPnD4Qhz0DOTWnA1qzXDNkIJnWmgju6i80zhu9peHr43Q>\n <xmx:E5EBZUrkqxioh_P3VO9aL5L4QI_VCZiRsc4d-aCN51bEd2-wVNPa5Q>", "Feedback-ID": "i47234305:Fastmail", "From": "Thomas Monjalon <thomas@monjalon.net>", "To": "dev@dpdk.org", "Cc": "Tyler Retzlaff <roretzla@linux.microsoft.com>,\n David Marchand <david.marchand@redhat.com>,\n Ferruh Yigit <ferruh.yigit@amd.com>,\n =?utf-8?q?Morten_Br=C3=B8rup?= <mb@smartsharesystems.com>,\n Ajit Khaparde <ajit.khaparde@broadcom.com>, Rosen Xu <rosen.xu@intel.com>,\n\tChas Williams <chas3@att.com>, \"Min Hu (Connor)\" <humin29@huawei.com>,\n\tMatan Azrad <matan@nvidia.com>,\n Viacheslav Ovsiienko <viacheslavo@nvidia.com>, Ori Kam <orika@nvidia.com>,\n\tSuanming Mou <suanmingm@nvidia.com>,\n Somnath Kotur <somnath.kotur@broadcom.com>,\n Devendra Singh Rawat <dsinghrawat@marvell.com>,\n Alok Prasad <palok@marvell.com>,\tTianfei Zhang <tianfei.zhang@intel.com>,\n Vijay Kumar Srivastava <vsrivast@xilinx.com>,\n Jerin Jacob <jerinj@marvell.com>,\tSunil Kumar Kori <skori@marvell.com>,\n Anatoly Burakov <anatoly.burakov@intel.com>,\n Bruce Richardson <bruce.richardson@intel.com>,\n Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>,\n Naga Harish K S V <s.v.naga.harish.k@intel.com>,\n Maxime Coquelin <maxime.coquelin@redhat.com>,\n Chenbo Xia <chenbo.xia@intel.com>", "Subject": "[PATCH v2 11/11] lib: remove pthread.h from includes", "Date": "Wed, 13 Sep 2023 12:34:30 +0200", "Message-ID": "<20230913103600.1935292-12-thomas@monjalon.net>", "X-Mailer": "git-send-email 2.42.0", "In-Reply-To": "<20230913103600.1935292-1-thomas@monjalon.net>", "References": "<20230906162226.1618088-1-thomas@monjalon.net>\n <20230913103600.1935292-1-thomas@monjalon.net>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "The header files should have the minimum embedded includes.\nThe file pthread.h can logically be removed from\nrte_per_lcore.h and rte_ethdev_core.h files.\n\nSigned-off-by: Thomas Monjalon <thomas@monjalon.net>\nAcked-by: Morten Brørup <mb@smartsharesystems.com>\nAcked-by: Tyler Retzlaff <roretzla@linux.microsoft.com>\nAcked-by: Ajit Khaparde <ajit.khaparde@broadcom.com>\nAcked-by: Rosen Xu <rosen.xu@intel.com>\n---\n app/test/test_link_bonding.c | 2 ++\n drivers/common/mlx5/mlx5_common.c | 1 +\n drivers/common/mlx5/windows/mlx5_win_ext.h | 2 ++\n drivers/net/bnxt/bnxt.h | 1 +\n drivers/net/qede/base/bcm_osal.h | 1 +\n drivers/raw/ifpga/base/opae_osdep.h | 1 +\n drivers/vdpa/sfc/sfc_vdpa.c | 1 +\n lib/eal/common/eal_common_options.c | 1 +\n lib/eal/common/eal_common_trace.c | 1 +\n lib/eal/common/malloc_mp.c | 1 +\n lib/eal/freebsd/eal_alarm.c | 1 +\n lib/eal/include/rte_per_lcore.h | 2 --\n lib/eal/linux/eal_alarm.c | 1 +\n lib/ethdev/ethdev_driver.c | 1 +\n lib/ethdev/ethdev_driver.h | 2 ++\n lib/ethdev/rte_ethdev_core.h | 2 --\n lib/ethdev/rte_flow.c | 1 +\n lib/eventdev/rte_event_eth_rx_adapter.c | 1 +\n lib/vhost/vhost.c | 1 +\n 19 files changed, 20 insertions(+), 4 deletions(-)", "diff": "diff --git a/app/test/test_link_bonding.c b/app/test/test_link_bonding.c\nindex 2f46e4c6ee..d6b6ebc2f2 100644\n--- a/app/test/test_link_bonding.c\n+++ b/app/test/test_link_bonding.c\n@@ -10,8 +10,10 @@\n #include <stdint.h>\n #include <inttypes.h>\n #include <errno.h>\n+#include <pthread.h>\n #include <sys/queue.h>\n #include <sys/time.h>\n+\n #include <rte_cycles.h>\n #include <rte_byteorder.h>\n #include <rte_common.h>\ndiff --git a/drivers/common/mlx5/mlx5_common.c b/drivers/common/mlx5/mlx5_common.c\nindex 0ad14a48c7..ca8543e36e 100644\n--- a/drivers/common/mlx5/mlx5_common.c\n+++ b/drivers/common/mlx5/mlx5_common.c\n@@ -5,6 +5,7 @@\n #include <unistd.h>\n #include <string.h>\n #include <stdio.h>\n+#include <pthread.h>\n \n #include <rte_errno.h>\n #include <rte_mempool.h>\ndiff --git a/drivers/common/mlx5/windows/mlx5_win_ext.h b/drivers/common/mlx5/windows/mlx5_win_ext.h\nindex 6f69329a6f..a71c69bff5 100644\n--- a/drivers/common/mlx5/windows/mlx5_win_ext.h\n+++ b/drivers/common/mlx5/windows/mlx5_win_ext.h\n@@ -5,6 +5,8 @@\n #ifndef __MLX5_WIN_ETX_H__\n #define __MLX5_WIN_ETX_H__\n \n+#include <pthread.h>\n+\n #include \"mlx5_prm.h\"\n #include \"mlx5devx.h\"\n \ndiff --git a/drivers/net/bnxt/bnxt.h b/drivers/net/bnxt/bnxt.h\nindex ed21ba7f29..0e01b1d4ba 100644\n--- a/drivers/net/bnxt/bnxt.h\n+++ b/drivers/net/bnxt/bnxt.h\n@@ -8,6 +8,7 @@\n \n #include <inttypes.h>\n #include <stdbool.h>\n+#include <pthread.h>\n #include <sys/queue.h>\n \n #include <rte_pci.h>\ndiff --git a/drivers/net/qede/base/bcm_osal.h b/drivers/net/qede/base/bcm_osal.h\nindex 97e261d306..11019b5623 100644\n--- a/drivers/net/qede/base/bcm_osal.h\n+++ b/drivers/net/qede/base/bcm_osal.h\n@@ -8,6 +8,7 @@\n #define __BCM_OSAL_H\n \n #include <stdbool.h>\n+#include <pthread.h>\n #include <time.h>\n #include <rte_bitops.h>\n #include <rte_byteorder.h>\ndiff --git a/drivers/raw/ifpga/base/opae_osdep.h b/drivers/raw/ifpga/base/opae_osdep.h\nindex 033b7e098c..e91205f536 100644\n--- a/drivers/raw/ifpga/base/opae_osdep.h\n+++ b/drivers/raw/ifpga/base/opae_osdep.h\n@@ -7,6 +7,7 @@\n \n #include <string.h>\n #include <stdbool.h>\n+#include <pthread.h>\n \n #ifdef RTE_LIB_EAL\n #include \"osdep_rte/osdep_generic.h\"\ndiff --git a/drivers/vdpa/sfc/sfc_vdpa.c b/drivers/vdpa/sfc/sfc_vdpa.c\nindex bd6ecde450..9db87fcb7d 100644\n--- a/drivers/vdpa/sfc/sfc_vdpa.c\n+++ b/drivers/vdpa/sfc/sfc_vdpa.c\n@@ -4,6 +4,7 @@\n \n #include <stdbool.h>\n #include <stdint.h>\n+#include <pthread.h>\n #include <sys/queue.h>\n \n #include <rte_common.h>\ndiff --git a/lib/eal/common/eal_common_options.c b/lib/eal/common/eal_common_options.c\nindex d74b581567..a6d21f1cba 100644\n--- a/lib/eal/common/eal_common_options.c\n+++ b/lib/eal/common/eal_common_options.c\n@@ -5,6 +5,7 @@\n \n #include <stdlib.h>\n #include <string.h>\n+#include <pthread.h>\n #ifndef RTE_EXEC_ENV_WINDOWS\n #include <syslog.h>\n #endif\ndiff --git a/lib/eal/common/eal_common_trace.c b/lib/eal/common/eal_common_trace.c\nindex cb980af06d..b21e61bf39 100644\n--- a/lib/eal/common/eal_common_trace.c\n+++ b/lib/eal/common/eal_common_trace.c\n@@ -4,6 +4,7 @@\n \n #include <stdlib.h>\n #include <fnmatch.h>\n+#include <pthread.h>\n #include <sys/queue.h>\n #include <regex.h>\n \ndiff --git a/lib/eal/common/malloc_mp.c b/lib/eal/common/malloc_mp.c\nindex 7270c2ec90..4d62397aba 100644\n--- a/lib/eal/common/malloc_mp.c\n+++ b/lib/eal/common/malloc_mp.c\n@@ -4,6 +4,7 @@\n \n #include <stdlib.h>\n #include <string.h>\n+#include <pthread.h>\n #include <sys/time.h>\n \n #include <rte_errno.h>\ndiff --git a/lib/eal/freebsd/eal_alarm.c b/lib/eal/freebsd/eal_alarm.c\nindex acdcf53804..e5b0909a45 100644\n--- a/lib/eal/freebsd/eal_alarm.c\n+++ b/lib/eal/freebsd/eal_alarm.c\n@@ -4,6 +4,7 @@\n \n #include <sys/types.h>\n #include <sys/stat.h>\n+#include <pthread.h>\n #include <fcntl.h>\n #include <stdio.h>\n #include <stdlib.h>\ndiff --git a/lib/eal/include/rte_per_lcore.h b/lib/eal/include/rte_per_lcore.h\nindex 2b846f9337..5a1497631a 100644\n--- a/lib/eal/include/rte_per_lcore.h\n+++ b/lib/eal/include/rte_per_lcore.h\n@@ -22,8 +22,6 @@\n extern \"C\" {\n #endif\n \n-#include <pthread.h>\n-\n #ifdef RTE_TOOLCHAIN_MSVC\n /**\n * Macro to define a per lcore variable \"var\" of type \"type\", don't\ndiff --git a/lib/eal/linux/eal_alarm.c b/lib/eal/linux/eal_alarm.c\nindex 397f25d7d5..766ba2c251 100644\n--- a/lib/eal/linux/eal_alarm.c\n+++ b/lib/eal/linux/eal_alarm.c\n@@ -5,6 +5,7 @@\n #include <stdint.h>\n #include <stdlib.h>\n #include <errno.h>\n+#include <pthread.h>\n #include <sys/queue.h>\n #include <sys/time.h>\n #include <sys/timerfd.h>\ndiff --git a/lib/ethdev/ethdev_driver.c b/lib/ethdev/ethdev_driver.c\nindex 0be1e8ca04..30db839a77 100644\n--- a/lib/ethdev/ethdev_driver.c\n+++ b/lib/ethdev/ethdev_driver.c\n@@ -3,6 +3,7 @@\n */\n \n #include <stdlib.h>\n+#include <pthread.h>\n \n #include <rte_kvargs.h>\n #include <rte_malloc.h>\ndiff --git a/lib/ethdev/ethdev_driver.h b/lib/ethdev/ethdev_driver.h\nindex 980f837ab6..3fa8b309c1 100644\n--- a/lib/ethdev/ethdev_driver.h\n+++ b/lib/ethdev/ethdev_driver.h\n@@ -18,6 +18,8 @@ extern \"C\" {\n * use them.\n */\n \n+#include <pthread.h>\n+\n #include <dev_driver.h>\n #include <rte_compat.h>\n #include <rte_ethdev.h>\ndiff --git a/lib/ethdev/rte_ethdev_core.h b/lib/ethdev/rte_ethdev_core.h\nindex 46e9721e07..8d260584b4 100644\n--- a/lib/ethdev/rte_ethdev_core.h\n+++ b/lib/ethdev/rte_ethdev_core.h\n@@ -5,8 +5,6 @@\n #ifndef _RTE_ETHDEV_CORE_H_\n #define _RTE_ETHDEV_CORE_H_\n \n-#include <pthread.h>\n-\n /**\n * @file\n *\ndiff --git a/lib/ethdev/rte_flow.c b/lib/ethdev/rte_flow.c\nindex 271d854f78..0c5aabea45 100644\n--- a/lib/ethdev/rte_flow.c\n+++ b/lib/ethdev/rte_flow.c\n@@ -6,6 +6,7 @@\n #include <errno.h>\n #include <stddef.h>\n #include <stdint.h>\n+#include <pthread.h>\n \n #include <rte_common.h>\n #include <rte_errno.h>\ndiff --git a/lib/eventdev/rte_event_eth_rx_adapter.c b/lib/eventdev/rte_event_eth_rx_adapter.c\nindex c166ef69a8..2145d803e4 100644\n--- a/lib/eventdev/rte_event_eth_rx_adapter.c\n+++ b/lib/eventdev/rte_event_eth_rx_adapter.c\n@@ -4,6 +4,7 @@\n */\n #include <ctype.h>\n #include <stdlib.h>\n+#include <pthread.h>\n #if defined(LINUX)\n #include <sys/epoll.h>\n #endif\ndiff --git a/lib/vhost/vhost.c b/lib/vhost/vhost.c\nindex eb6309b681..c03bb9c6eb 100644\n--- a/lib/vhost/vhost.c\n+++ b/lib/vhost/vhost.c\n@@ -6,6 +6,7 @@\n #include <linux/virtio_net.h>\n #include <stdint.h>\n #include <stdlib.h>\n+#include <pthread.h>\n #ifdef RTE_LIBRTE_VHOST_NUMA\n #include <numa.h>\n #include <numaif.h>\n", "prefixes": [ "v2", "11/11" ] }