Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/131383/?format=api
{ "id": 131383, "url": "http://patches.dpdk.org/api/patches/131383/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20230913103600.1935292-9-thomas@monjalon.net/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20230913103600.1935292-9-thomas@monjalon.net>", "list_archive_url": "https://inbox.dpdk.org/dev/20230913103600.1935292-9-thomas@monjalon.net", "date": "2023-09-13T10:34:27", "name": "[v2,08/11] examples: convert to normal control threads", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "2ea5fd5aee380731cd49f1c8b43ad482c4e9795d", "submitter": { "id": 685, "url": "http://patches.dpdk.org/api/people/685/?format=api", "name": "Thomas Monjalon", "email": "thomas@monjalon.net" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20230913103600.1935292-9-thomas@monjalon.net/mbox/", "series": [ { "id": 29493, "url": "http://patches.dpdk.org/api/series/29493/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=29493", "date": "2023-09-13T10:34:19", "name": "rework thread management", "version": 2, "mbox": "http://patches.dpdk.org/series/29493/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/131383/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/131383/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id C0C1A42588;\n\tWed, 13 Sep 2023 12:38:00 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id A1813406B7;\n\tWed, 13 Sep 2023 12:37:56 +0200 (CEST)", "from wout5-smtp.messagingengine.com (wout5-smtp.messagingengine.com\n [64.147.123.21]) by mails.dpdk.org (Postfix) with ESMTP id 9B6F5406BC\n for <dev@dpdk.org>; Wed, 13 Sep 2023 12:37:54 +0200 (CEST)", "from compute4.internal (compute4.nyi.internal [10.202.2.44])\n by mailout.west.internal (Postfix) with ESMTP id 339D2320085B;\n Wed, 13 Sep 2023 06:37:53 -0400 (EDT)", "from mailfrontend1 ([10.202.2.162])\n by compute4.internal (MEProxy); Wed, 13 Sep 2023 06:37:53 -0400", "by mail.messagingengine.com (Postfix) with ESMTPA; Wed,\n 13 Sep 2023 06:37:51 -0400 (EDT)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=\n cc:cc:content-transfer-encoding:content-type:content-type:date\n :date:from:from:in-reply-to:in-reply-to:message-id:mime-version\n :references:reply-to:sender:subject:subject:to:to; s=fm2; t=\n 1694601472; x=1694687872; bh=yAqhi5WcODEXLT25jJCPVZkr3LmIozel/Ly\n duQuyWpA=; b=B6PP5Xh91Yt58WKznL3yyrAooQNUfLk1Lo5du+sHnvW8vkne9A6\n aJ3LM9xmyuYhDVJbgZSxLgc7y+SFEazAo1rAEv6UeTIJBKWpPOjRMS2xVpeBlT8Y\n F/slUKCAgfwBlF/vDLv8ual4hb/Y4iZxx1Z7sBXdqiut/X8yXJdqwyBn6LDjGIzj\n lDNpXPlXzdyAB8PqTAnICSzNUfnnisCod7t31m1jT64GCxV5I6nVJQ2ZWmzcXqCa\n KPC6HYtpl2C0UlDVckPxsDZ7yPJDqtrOxKbcvc2EnMPmpzwAriEXtD/l2Mx3XMKL\n uYAuIn9UvZNB7EaEFpJHGmft6QZagKvCInw==", "v=1; a=rsa-sha256; c=relaxed/relaxed; d=\n messagingengine.com; h=cc:cc:content-transfer-encoding\n :content-type:content-type:date:date:feedback-id:feedback-id\n :from:from:in-reply-to:in-reply-to:message-id:mime-version\n :references:reply-to:sender:subject:subject:to:to:x-me-proxy\n :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=\n 1694601472; x=1694687872; bh=yAqhi5WcODEXLT25jJCPVZkr3LmIozel/Ly\n duQuyWpA=; b=TNx0NS+Ib9ZX57cXZWHvh/3vno8sKQippnYlUOyJFhxMxK11xjQ\n 8lfS3seeNY/OaJzHzd39J4lqySiRpts8KhM4Eznx0tHtZat9tpWCkTZ4Q8AkeION\n AePlYWdOMhafNd76Y2ICvp2wyUsKWJKXNp3HiHgpTop1iujJtjgQK1A3T3ONI7Q3\n LGLBlbXRRdwPix8/C+5xWV+0Tyw7Gr7zMVzR/iFzwiN6a1fbaH/jMhEXVRq6Osax\n 5/g9a3ptkVuVaX8/kCopJJP3Z06cfLLxPZYTWAC6rpf8dDrWM2nboVzfUKl+mlzX\n 9pDCvH2anRhKQS3i0EjkLvOsTnstPztx8ig==" ], "X-ME-Sender": "<xms:AJEBZes22IpIjSOknzyZ-RbdB2q0RXro58yL-dUPZcSTH803tFuqmA>\n <xme:AJEBZTegABKs_z15kI__Z2L06XuQrxwLzVAY1zEETc6_WOAzVC4luY1-oJCxZLjUW\n 97NMVNB19v0uQTUcA>", "X-ME-Received": "\n <xmr:AJEBZZz5SZaRAPJl4VgobQNyFFNKI6fQbzeJ3SR2Qp0BdOi5-DuBsPUW_EH6tDsq2nopyA>", "X-ME-Proxy-Cause": "\n gggruggvucftvghtrhhoucdtuddrgedviedrudeikedgfedtucetufdoteggodetrfdotf\n fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen\n uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne\n cujfgurhephffvvefufffkofgjfhggtgfgsehtkeertdertdejnecuhfhrohhmpefvhhho\n mhgrshcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqne\n cuggftrfgrthhtvghrnheptdeiffffgeefteelhfekueetueduffejgfelvedtieejudek\n gfevheetheehgeejnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilh\n hfrhhomhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth", "X-ME-Proxy": "<xmx:AJEBZZPbdByxDYfVFZluKG-kWniPiCnfHIXEXUKDIsMwiRdYW9CVDQ>\n <xmx:AJEBZe9Tzzz179y2T3tGGENchKy0MqDTiNbL6Zdh-gFiUcw0X4w-9Q>\n <xmx:AJEBZRUT6kyGyMoZPHmOTbpaSSYjj0wYSbIMdA5CE61O1nfrYNF0Ww>\n <xmx:AJEBZVnohI7BbXaNe2qE_O9Z751UwNSi5GUciwt1Dos3AJsi8lBFgA>", "Feedback-ID": "i47234305:Fastmail", "From": "Thomas Monjalon <thomas@monjalon.net>", "To": "dev@dpdk.org", "Cc": "Tyler Retzlaff <roretzla@linux.microsoft.com>,\n David Marchand <david.marchand@redhat.com>,\n Ferruh Yigit <ferruh.yigit@amd.com>,\n =?utf-8?q?Morten_Br=C3=B8rup?= <mb@smartsharesystems.com>,\n Maxime Coquelin <maxime.coquelin@redhat.com>,\n Chenbo Xia <chenbo.xia@intel.com>", "Subject": "[PATCH v2 08/11] examples: convert to normal control threads", "Date": "Wed, 13 Sep 2023 12:34:27 +0200", "Message-ID": "<20230913103600.1935292-9-thomas@monjalon.net>", "X-Mailer": "git-send-email 2.42.0", "In-Reply-To": "<20230913103600.1935292-1-thomas@monjalon.net>", "References": "<20230906162226.1618088-1-thomas@monjalon.net>\n <20230913103600.1935292-1-thomas@monjalon.net>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Calls to rte_ctrl_thread_create() are replaced with\nrte_thread_create_control().\n\nIn vhost_blk, the control thread is not forced\nto be scheduled on core 0 anymore.\n\nSigned-off-by: Thomas Monjalon <thomas@monjalon.net>\nAcked-by: Morten Brørup <mb@smartsharesystems.com>\nAcked-by: Tyler Retzlaff <roretzla@linux.microsoft.com>\n---\n examples/vhost/main.c | 9 +++++----\n examples/vhost_blk/vhost_blk.c | 21 ++++++---------------\n 2 files changed, 11 insertions(+), 19 deletions(-)", "diff": "diff --git a/examples/vhost/main.c b/examples/vhost/main.c\nindex 9ff2c1f31b..ce5c1efddf 100644\n--- a/examples/vhost/main.c\n+++ b/examples/vhost/main.c\n@@ -28,6 +28,7 @@\n #include <rte_pause.h>\n #include <rte_dmadev.h>\n #include <rte_vhost_async.h>\n+#include <rte_thread.h>\n \n #include \"main.h\"\n \n@@ -1807,7 +1808,7 @@ static const struct rte_vhost_device_ops virtio_net_device_ops =\n * This is a thread will wake up after a period to print stats if the user has\n * enabled them.\n */\n-static void *\n+static uint32_t\n print_stats(__rte_unused void *arg)\n {\n \tstruct vhost_dev *vdev;\n@@ -1852,7 +1853,7 @@ print_stats(__rte_unused void *arg)\n \t\tfflush(stdout);\n \t}\n \n-\treturn NULL;\n+\treturn 0;\n }\n \n static void\n@@ -1907,7 +1908,7 @@ main(int argc, char *argv[])\n \tunsigned nb_ports, valid_num_ports;\n \tint ret, i;\n \tuint16_t portid;\n-\tstatic pthread_t tid;\n+\trte_thread_t tid;\n \tuint64_t flags = RTE_VHOST_USER_NET_COMPLIANT_OL_FLAGS;\n \n \tsignal(SIGINT, sigint_handler);\n@@ -1986,7 +1987,7 @@ main(int argc, char *argv[])\n \n \t/* Enable stats if the user option is set. */\n \tif (enable_stats) {\n-\t\tret = rte_ctrl_thread_create(&tid, \"dpdk-vhost-stat\", NULL,\n+\t\tret = rte_thread_create_control(&tid, \"dpdk-vhost-stat\",\n \t\t\t\t\tprint_stats, NULL);\n \t\tif (ret < 0)\n \t\t\trte_exit(EXIT_FAILURE,\ndiff --git a/examples/vhost_blk/vhost_blk.c b/examples/vhost_blk/vhost_blk.c\nindex 45699eb0b3..376f7b89a7 100644\n--- a/examples/vhost_blk/vhost_blk.c\n+++ b/examples/vhost_blk/vhost_blk.c\n@@ -5,8 +5,6 @@\n #ifndef _GNU_SOURCE\n #define _GNU_SOURCE\n #endif\n-#include <pthread.h>\n-#include <sched.h>\n \n #include <stdint.h>\n #include <stdlib.h>\n@@ -529,12 +527,10 @@ process_vq(struct vhost_blk_queue *vq)\n \t}\n }\n \n-static void *\n+static uint32_t\n ctrlr_worker(void *arg)\n {\n \tstruct vhost_blk_ctrlr *ctrlr = (struct vhost_blk_ctrlr *)arg;\n-\tcpu_set_t cpuset;\n-\tpthread_t thread;\n \tint i;\n \n \tfprintf(stdout, \"Ctrlr Worker Thread start\\n\");\n@@ -546,11 +542,6 @@ ctrlr_worker(void *arg)\n \t\texit(0);\n \t}\n \n-\tthread = pthread_self();\n-\tCPU_ZERO(&cpuset);\n-\tCPU_SET(0, &cpuset);\n-\tpthread_setaffinity_np(thread, sizeof(cpu_set_t), &cpuset);\n-\n \tfor (i = 0; i < NUM_OF_BLK_QUEUES; i++)\n \t\tsubmit_inflight_vq(&ctrlr->queues[i]);\n \n@@ -560,7 +551,7 @@ ctrlr_worker(void *arg)\n \n \tfprintf(stdout, \"Ctrlr Worker Thread Exiting\\n\");\n \tsem_post(&exit_sem);\n-\treturn NULL;\n+\treturn 0;\n }\n \n static int\n@@ -605,7 +596,7 @@ new_device(int vid)\n \tstruct vhost_blk_queue *vq;\n \tchar path[PATH_MAX];\n \tuint64_t features, protocol_features;\n-\tpthread_t tid;\n+\trte_thread_t tid;\n \tint i, ret;\n \tbool packed_ring, inflight_shmfd;\n \n@@ -686,15 +677,15 @@ new_device(int vid)\n \t/* start polling vring */\n \tworker_thread_status = WORKER_STATE_START;\n \tfprintf(stdout, \"New Device %s, Device ID %d\\n\", path, vid);\n-\tif (rte_ctrl_thread_create(&tid, \"dpdk-vhost-blk\", NULL,\n-\t\t\t\t &ctrlr_worker, ctrlr) != 0) {\n+\tif (rte_thread_create_control(&tid, \"dpdk-vhost-blk\",\n+\t\t\t&ctrlr_worker, ctrlr) != 0) {\n \t\tfprintf(stderr, \"Worker Thread Started Failed\\n\");\n \t\treturn -1;\n \t}\n \n \t/* device has been started */\n \tctrlr->started = 1;\n-\tpthread_detach(tid);\n+\trte_thread_detach(tid);\n \treturn 0;\n }\n \n", "prefixes": [ "v2", "08/11" ] }