Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/131255/?format=api
{ "id": 131255, "url": "http://patches.dpdk.org/api/patches/131255/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20230908080030.3837515-3-haijie1@huawei.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20230908080030.3837515-3-haijie1@huawei.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20230908080030.3837515-3-haijie1@huawei.com", "date": "2023-09-08T08:00:24", "name": "[v4,2/7] ethdev: support setting and querying RSS algorithm", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "f01c5b7e4a718c254325377654e5f4d50c35687e", "submitter": { "id": 2935, "url": "http://patches.dpdk.org/api/people/2935/?format=api", "name": "Jie Hai", "email": "haijie1@huawei.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20230908080030.3837515-3-haijie1@huawei.com/mbox/", "series": [ { "id": 29457, "url": "http://patches.dpdk.org/api/series/29457/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=29457", "date": "2023-09-08T08:00:22", "name": "support setting and querying RSS algorithms", "version": 4, "mbox": "http://patches.dpdk.org/series/29457/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/131255/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/131255/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 87A4442544;\n\tFri, 8 Sep 2023 10:03:53 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 11E3C402EC;\n\tFri, 8 Sep 2023 10:03:45 +0200 (CEST)", "from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188])\n by mails.dpdk.org (Postfix) with ESMTP id 92B00402D9\n for <dev@dpdk.org>; Fri, 8 Sep 2023 10:03:41 +0200 (CEST)", "from kwepemi500020.china.huawei.com (unknown [172.30.72.53])\n by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4RhpT83yRjzVkDp;\n Fri, 8 Sep 2023 16:01:00 +0800 (CST)", "from localhost.localdomain (10.67.165.2) by\n kwepemi500020.china.huawei.com (7.221.188.8) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id\n 15.1.2507.31; Fri, 8 Sep 2023 16:03:39 +0800" ], "From": "Jie Hai <haijie1@huawei.com>", "To": "<dev@dpdk.org>, Thomas Monjalon <thomas@monjalon.net>, Ferruh Yigit\n <ferruh.yigit@amd.com>, Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>, Ori\n Kam <orika@nvidia.com>", "CC": "<haijie1@huawei.com>, <lihuisong@huawei.com>", "Subject": "[PATCH v4 2/7] ethdev: support setting and querying RSS algorithm", "Date": "Fri, 8 Sep 2023 16:00:24 +0800", "Message-ID": "<20230908080030.3837515-3-haijie1@huawei.com>", "X-Mailer": "git-send-email 2.30.0", "In-Reply-To": "<20230908080030.3837515-1-haijie1@huawei.com>", "References": "<20230904072851.7384-1-haijie1@huawei.com>\n <20230908080030.3837515-1-haijie1@huawei.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Originating-IP": "[10.67.165.2]", "X-ClientProxiedBy": "dggems704-chm.china.huawei.com (10.3.19.181) To\n kwepemi500020.china.huawei.com (7.221.188.8)", "X-CFilter-Loop": "Reflected", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Currently, rte_eth_rss_conf supports configuring and querying\nRSS hash functions, rss key and it's length, but not RSS hash\nalgorithm.\n\nThe structure ``rte_eth_rss_conf`` is extended by adding a new\nfield \"func\". This represents the RSS algorithms to apply. The\nfollowing API will be affected:\n\t- rte_eth_dev_configure\n\t- rte_eth_dev_rss_hash_update\n\t- rte_eth_dev_rss_hash_conf_get\n\nIf the value of \"func\" used for configuration is a gibberish\nvalue, report the error and return. Do the same for\nrte_eth_dev_rss_hash_update and rte_eth_dev_configure.\n\nTo check whether the drivers report the \"func\" field, it is set\nto default value before querying.\n\nSigned-off-by: Jie Hai <haijie1@huawei.com>\nSigned-off-by: Dongdong Liu <liudongdong3@huawei.com>\n---\n doc/guides/rel_notes/release_23_11.rst | 2 ++\n lib/ethdev/rte_ethdev.c | 17 +++++++++++++++++\n lib/ethdev/rte_ethdev.h | 21 +++++++++++++++++++++\n lib/ethdev/rte_flow.c | 1 -\n lib/ethdev/rte_flow.h | 22 ++--------------------\n 5 files changed, 42 insertions(+), 21 deletions(-)", "diff": "diff --git a/doc/guides/rel_notes/release_23_11.rst b/doc/guides/rel_notes/release_23_11.rst\nindex 333e1d95a283..deb019fbe4c1 100644\n--- a/doc/guides/rel_notes/release_23_11.rst\n+++ b/doc/guides/rel_notes/release_23_11.rst\n@@ -129,6 +129,8 @@ ABI Changes\n Also, make sure to start the actual text at the margin.\n =======================================================\n \n+* ethdev: Added \"func\" field to ``rte_eth_rss_conf`` structure for RSS hash\n+ algorithm.\n \n Known Issues\n ------------\ndiff --git a/lib/ethdev/rte_ethdev.c b/lib/ethdev/rte_ethdev.c\nindex 0840d2b5942a..4cbcdb344cac 100644\n--- a/lib/ethdev/rte_ethdev.c\n+++ b/lib/ethdev/rte_ethdev.c\n@@ -1445,6 +1445,14 @@ rte_eth_dev_configure(uint16_t port_id, uint16_t nb_rx_q, uint16_t nb_tx_q,\n \t\tgoto rollback;\n \t}\n \n+\tif (dev_conf->rx_adv_conf.rss_conf.func >= RTE_ETH_HASH_FUNCTION_MAX) {\n+\t\tRTE_ETHDEV_LOG(ERR,\n+\t\t\t\"Ethdev port_id=%u invalid rss hash function (%u)\\n\",\n+\t\t\tport_id, dev_conf->rx_adv_conf.rss_conf.func);\n+\t\tret = -EINVAL;\n+\t\tgoto rollback;\n+\t}\n+\n \t/* Check if Rx RSS distribution is disabled but RSS hash is enabled. */\n \tif (((dev_conf->rxmode.mq_mode & RTE_ETH_MQ_RX_RSS_FLAG) == 0) &&\n \t (dev_conf->rxmode.offloads & RTE_ETH_RX_OFFLOAD_RSS_HASH)) {\n@@ -4630,6 +4638,13 @@ rte_eth_dev_rss_hash_update(uint16_t port_id,\n \t\treturn -ENOTSUP;\n \t}\n \n+\tif (rss_conf->func >= RTE_ETH_HASH_FUNCTION_MAX) {\n+\t\tRTE_ETHDEV_LOG(ERR,\n+\t\t\t\"Ethdev port_id=%u invalid rss hash function (%u)\\n\",\n+\t\t\tport_id, rss_conf->func);\n+\t\treturn -EINVAL;\n+\t}\n+\n \tif (*dev->dev_ops->rss_hash_update == NULL)\n \t\treturn -ENOTSUP;\n \tret = eth_err(port_id, (*dev->dev_ops->rss_hash_update)(dev,\n@@ -4657,6 +4672,8 @@ rte_eth_dev_rss_hash_conf_get(uint16_t port_id,\n \t\treturn -EINVAL;\n \t}\n \n+\trss_conf->func = RTE_ETH_HASH_FUNCTION_DEFAULT;\n+\n \tif (*dev->dev_ops->rss_hash_conf_get == NULL)\n \t\treturn -ENOTSUP;\n \tret = eth_err(port_id, (*dev->dev_ops->rss_hash_conf_get)(dev,\ndiff --git a/lib/ethdev/rte_ethdev.h b/lib/ethdev/rte_ethdev.h\nindex 40cfbb7efddd..33cec3570f85 100644\n--- a/lib/ethdev/rte_ethdev.h\n+++ b/lib/ethdev/rte_ethdev.h\n@@ -445,6 +445,26 @@ struct rte_vlan_filter_conf {\n \tuint64_t ids[64];\n };\n \n+/**\n+ * Hash function types.\n+ */\n+enum rte_eth_hash_function {\n+\t/**\n+\t * DEFAULT means that conformance to a specific hash algorithm is\n+\t * uncared to the caller. The driver can pick the one it deems optimal.\n+\t */\n+\tRTE_ETH_HASH_FUNCTION_DEFAULT = 0,\n+\tRTE_ETH_HASH_FUNCTION_TOEPLITZ, /**< Toeplitz */\n+\tRTE_ETH_HASH_FUNCTION_SIMPLE_XOR, /**< Simple XOR */\n+\t/**\n+\t * Symmetric Toeplitz: src, dst will be replaced by\n+\t * xor(src, dst). For the case with src/dst only,\n+\t * src or dst address will xor with zero pair.\n+\t */\n+\tRTE_ETH_HASH_FUNCTION_SYMMETRIC_TOEPLITZ,\n+\tRTE_ETH_HASH_FUNCTION_MAX,\n+};\n+\n /**\n * A structure used to configure the Receive Side Scaling (RSS) feature\n * of an Ethernet port.\n@@ -464,6 +484,7 @@ struct rte_eth_rss_conf {\n \t * Supplying an *rss_hf* equal to zero disables the RSS feature.\n \t */\n \tuint64_t rss_hf;\n+\tenum rte_eth_hash_function func;\t/**< Hash algorithm. */\n };\n \n /*\ndiff --git a/lib/ethdev/rte_flow.c b/lib/ethdev/rte_flow.c\nindex 271d854f7807..d3f2d466d841 100644\n--- a/lib/ethdev/rte_flow.c\n+++ b/lib/ethdev/rte_flow.c\n@@ -12,7 +12,6 @@\n #include <rte_branch_prediction.h>\n #include <rte_string_fns.h>\n #include <rte_mbuf_dyn.h>\n-#include \"rte_ethdev.h\"\n #include \"rte_flow_driver.h\"\n #include \"rte_flow.h\"\n \ndiff --git a/lib/ethdev/rte_flow.h b/lib/ethdev/rte_flow.h\nindex 3bd0dc64fbe2..a7578b1d2eff 100644\n--- a/lib/ethdev/rte_flow.h\n+++ b/lib/ethdev/rte_flow.h\n@@ -40,6 +40,8 @@\n #include <rte_macsec.h>\n #include <rte_ib.h>\n \n+#include \"rte_ethdev.h\"\n+\n #ifdef __cplusplus\n extern \"C\" {\n #endif\n@@ -3183,26 +3185,6 @@ struct rte_flow_query_count {\n \tuint64_t bytes; /**< Number of bytes through this rule [out]. */\n };\n \n-/**\n- * Hash function types.\n- */\n-enum rte_eth_hash_function {\n-\t/**\n-\t * DEFAULT means that conformance to a specific hash algorithm is\n-\t * uncared to the caller. The driver can pick the one it deems optimal.\n-\t */\n-\tRTE_ETH_HASH_FUNCTION_DEFAULT = 0,\n-\tRTE_ETH_HASH_FUNCTION_TOEPLITZ, /**< Toeplitz */\n-\tRTE_ETH_HASH_FUNCTION_SIMPLE_XOR, /**< Simple XOR */\n-\t/**\n-\t * Symmetric Toeplitz: src, dst will be replaced by\n-\t * xor(src, dst). For the case with src/dst only,\n-\t * src or dst address will xor with zero pair.\n-\t */\n-\tRTE_ETH_HASH_FUNCTION_SYMMETRIC_TOEPLITZ,\n-\tRTE_ETH_HASH_FUNCTION_MAX,\n-};\n-\n /**\n * RTE_FLOW_ACTION_TYPE_RSS\n *\n", "prefixes": [ "v4", "2/7" ] }