Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/131220/?format=api
{ "id": 131220, "url": "http://patches.dpdk.org/api/patches/131220/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20230907151606.849612-11-beilei.xing@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20230907151606.849612-11-beilei.xing@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20230907151606.849612-11-beilei.xing@intel.com", "date": "2023-09-07T15:16:05", "name": "[v3,10/11] net/cpfl: update vport info before creating representor", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "072dc9648a5a93b033d71db0d9dccf9c37e758a4", "submitter": { "id": 410, "url": "http://patches.dpdk.org/api/people/410/?format=api", "name": "Xing, Beilei", "email": "beilei.xing@intel.com" }, "delegate": { "id": 1540, "url": "http://patches.dpdk.org/api/users/1540/?format=api", "username": "qzhan15", "first_name": "Qi", "last_name": "Zhang", "email": "qi.z.zhang@intel.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20230907151606.849612-11-beilei.xing@intel.com/mbox/", "series": [ { "id": 29441, "url": "http://patches.dpdk.org/api/series/29441/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=29441", "date": "2023-09-07T15:15:55", "name": "net/cpfl: support port representor", "version": 3, "mbox": "http://patches.dpdk.org/series/29441/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/131220/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/131220/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id BEA4D42532;\n\tThu, 7 Sep 2023 08:58:39 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 30E1340A6D;\n\tThu, 7 Sep 2023 08:57:42 +0200 (CEST)", "from mgamail.intel.com (mgamail.intel.com [192.55.52.136])\n by mails.dpdk.org (Postfix) with ESMTP id 517A640691\n for <dev@dpdk.org>; Thu, 7 Sep 2023 08:57:40 +0200 (CEST)", "from fmsmga001.fm.intel.com ([10.253.24.23])\n by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 06 Sep 2023 23:57:39 -0700", "from dpdk-beileix-icelake.sh.intel.com ([10.67.116.248])\n by fmsmga001.fm.intel.com with ESMTP; 06 Sep 2023 23:57:25 -0700" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1694069860; x=1725605860;\n h=from:to:cc:subject:date:message-id:in-reply-to:\n references:mime-version:content-transfer-encoding;\n bh=7LyPKUcHJKwR1tDYYgseBJp53O36g7NcBUBtjwsP9jk=;\n b=VNJcKIqfK3B0Ri/E8mtvdJgcJ6VecEzLQfVZ5uBHN0gy0rIF5eCPttyz\n wr5eFUEPjVP9QkFnjyi1eiXZpO9XNMhMsZ6ZIARmdhGBPAIwRZA/64c5G\n Pmjkp8Nb+owNzWC0xAs/jagXAfxAHzmUyOcvhQN3J2FHTnuY1psiaIKeb\n k4O4jnyGjCXEFdDfRnoU96GpmZq7zy4MbT6Jd2yrY/9lInu65VfsP/PHQ\n mFh68SLvkMFtITLHq3MnzFHmF863QXWJPb3CeBL6hGL7bQle+NBThwZUY\n ve+AVFIZJsjHu83jksdu2jMJtU7ZyH3QWMnq8he3R7I2bhhV2vjhcgwnB g==;", "X-IronPort-AV": [ "E=McAfee;i=\"6600,9927,10825\"; a=\"356758142\"", "E=Sophos;i=\"6.02,234,1688454000\"; d=\"scan'208\";a=\"356758142\"", "E=McAfee;i=\"6600,9927,10825\"; a=\"885035802\"", "E=Sophos;i=\"6.02,234,1688454000\"; d=\"scan'208\";a=\"885035802\"" ], "X-ExtLoop1": "1", "From": "beilei.xing@intel.com", "To": "jingjing.wu@intel.com", "Cc": "dev@dpdk.org, mingxia.liu@intel.com, Beilei Xing <beilei.xing@intel.com>", "Subject": "[PATCH v3 10/11] net/cpfl: update vport info before creating\n representor", "Date": "Thu, 7 Sep 2023 15:16:05 +0000", "Message-Id": "<20230907151606.849612-11-beilei.xing@intel.com>", "X-Mailer": "git-send-email 2.34.1", "In-Reply-To": "<20230907151606.849612-1-beilei.xing@intel.com>", "References": "<20230816150541.144532-1-beilei.xing@intel.com>\n <20230907151606.849612-1-beilei.xing@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "From: Beilei Xing <beilei.xing@intel.com>\n\nGet port representor's vport list and update vport_map_hash\nbefore creating the port representor.\n\nSigned-off-by: Beilei Xing <beilei.xing@intel.com>\n---\n drivers/net/cpfl/cpfl_ethdev.c | 2 +-\n drivers/net/cpfl/cpfl_ethdev.h | 3 +\n drivers/net/cpfl/cpfl_representor.c | 124 +++++++++++++++++++++++++++-\n 3 files changed, 124 insertions(+), 5 deletions(-)", "diff": "diff --git a/drivers/net/cpfl/cpfl_ethdev.c b/drivers/net/cpfl/cpfl_ethdev.c\nindex 6eb387ce96..330a865e3c 100644\n--- a/drivers/net/cpfl/cpfl_ethdev.c\n+++ b/drivers/net/cpfl/cpfl_ethdev.c\n@@ -1643,7 +1643,7 @@ cpfl_handle_vchnl_event_msg(struct cpfl_adapter_ext *adapter, uint8_t *msg, uint\n \t}\n }\n \n-static int\n+int\n cpfl_vport_info_create(struct cpfl_adapter_ext *adapter,\n \t\t struct cpfl_vport_id *vport_identity,\n \t\t struct cpchnl2_vport_info *vport_info)\ndiff --git a/drivers/net/cpfl/cpfl_ethdev.h b/drivers/net/cpfl/cpfl_ethdev.h\nindex 4c6653e113..8f5b07abc5 100644\n--- a/drivers/net/cpfl/cpfl_ethdev.h\n+++ b/drivers/net/cpfl/cpfl_ethdev.h\n@@ -198,6 +198,9 @@ struct cpfl_adapter_ext {\n \n TAILQ_HEAD(cpfl_adapter_list, cpfl_adapter_ext);\n \n+int cpfl_vport_info_create(struct cpfl_adapter_ext *adapter,\n+\t\t\t struct cpfl_vport_id *vport_identity,\n+\t\t\t struct cpchnl2_vport_info *vport_info);\n int cpfl_cc_vport_list_get(struct cpfl_adapter_ext *adapter,\n \t\t\t struct cpfl_vport_id *vi,\n \t\t\t struct cpchnl2_get_vport_list_response *response);\ndiff --git a/drivers/net/cpfl/cpfl_representor.c b/drivers/net/cpfl/cpfl_representor.c\nindex fd42063f2c..0cd92b1351 100644\n--- a/drivers/net/cpfl/cpfl_representor.c\n+++ b/drivers/net/cpfl/cpfl_representor.c\n@@ -390,6 +390,86 @@ cpfl_match_repr_with_vport(const struct cpfl_repr_id *repr_id,\n \treturn false;\n }\n \n+static int\n+cpfl_repr_vport_list_query(struct cpfl_adapter_ext *adapter,\n+\t\t\t const struct cpfl_repr_id *repr_id,\n+\t\t\t struct cpchnl2_get_vport_list_response *response)\n+{\n+\tstruct cpfl_vport_id vi;\n+\tint ret;\n+\n+\tif (repr_id->type == RTE_ETH_REPRESENTOR_PF) {\n+\t\t/* PF */\n+\t\tvi.func_type = CPCHNL2_FUNC_TYPE_PF;\n+\t\tvi.pf_id = cpfl_func_id_get(repr_id->host_id, repr_id->pf_id);\n+\t\tvi.vf_id = 0;\n+\t} else {\n+\t\t/* VF */\n+\t\tvi.func_type = CPCHNL2_FUNC_TYPE_SRIOV;\n+\t\tvi.pf_id = CPFL_HOST0_APF;\n+\t\tvi.vf_id = repr_id->vf_id;\n+\t}\n+\n+\tret = cpfl_cc_vport_list_get(adapter, &vi, response);\n+\n+\treturn ret;\n+}\n+\n+static int\n+cpfl_repr_vport_info_query(struct cpfl_adapter_ext *adapter,\n+\t\t\t const struct cpfl_repr_id *repr_id,\n+\t\t\t struct cpchnl2_vport_id *vport_id,\n+\t\t\t struct cpchnl2_get_vport_info_response *response)\n+{\n+\tstruct cpfl_vport_id vi;\n+\tint ret;\n+\n+\tif (repr_id->type == RTE_ETH_REPRESENTOR_PF) {\n+\t\t/* PF */\n+\t\tvi.func_type = CPCHNL2_FUNC_TYPE_PF;\n+\t\tvi.pf_id = cpfl_func_id_get(repr_id->host_id, repr_id->pf_id);\n+\t\tvi.vf_id = 0;\n+\t} else {\n+\t\t/* VF */\n+\t\tvi.func_type = CPCHNL2_FUNC_TYPE_SRIOV;\n+\t\tvi.pf_id = CPFL_HOST0_APF;\n+\t\tvi.vf_id = repr_id->vf_id;\n+\t}\n+\n+\tret = cpfl_cc_vport_info_get(adapter, vport_id, &vi, response);\n+\n+\treturn ret;\n+}\n+\n+static int\n+cpfl_repr_vport_map_update(struct cpfl_adapter_ext *adapter,\n+\t\t\t const struct cpfl_repr_id *repr_id, uint32_t vport_id,\n+\t\t\t struct cpchnl2_get_vport_info_response *response)\n+{\n+\tstruct cpfl_vport_id vi;\n+\tint ret;\n+\n+\tvi.vport_id = vport_id;\n+\tif (repr_id->type == RTE_ETH_REPRESENTOR_PF) {\n+\t\t/* PF */\n+\t\tvi.func_type = CPCHNL2_FUNC_TYPE_PF;\n+\t\tvi.pf_id = cpfl_func_id_get(repr_id->host_id, repr_id->pf_id);\n+\t} else {\n+\t\t/* VF */\n+\t\tvi.func_type = CPCHNL2_FUNC_TYPE_SRIOV;\n+\t\tvi.pf_id = CPFL_HOST0_APF;\n+\t\tvi.vf_id = repr_id->vf_id;\n+\t}\n+\n+\tret = cpfl_vport_info_create(adapter, &vi, &response->info);\n+\tif (ret != 0) {\n+\t\tPMD_INIT_LOG(ERR, \"Fail to update vport map hash for representor.\");\n+\t\treturn ret;\n+\t}\n+\n+\treturn 0;\n+}\n+\n int\n cpfl_repr_create(struct rte_pci_device *pci_dev, struct cpfl_adapter_ext *adapter)\n {\n@@ -397,8 +477,14 @@ cpfl_repr_create(struct rte_pci_device *pci_dev, struct cpfl_adapter_ext *adapte\n \tuint32_t iter = 0;\n \tconst struct cpfl_repr_id *repr_id;\n \tconst struct cpfl_vport_id *vp_id;\n+\tstruct cpchnl2_get_vport_list_response *vlist_resp;\n+\tstruct cpchnl2_get_vport_info_response vinfo_resp;\n \tint ret;\n \n+\tvlist_resp = rte_zmalloc(NULL, IDPF_DFLT_MBX_BUF_SIZE, 0);\n+\tif (vlist_resp == NULL)\n+\t\treturn -ENOMEM;\n+\n \trte_spinlock_lock(&adapter->repr_lock);\n \n \twhile (rte_hash_iterate(adapter->repr_allowlist_hash,\n@@ -407,6 +493,7 @@ cpfl_repr_create(struct rte_pci_device *pci_dev, struct cpfl_adapter_ext *adapte\n \t\tchar name[RTE_ETH_NAME_MAX_LEN];\n \t\tuint32_t iter_iter = 0;\n \t\tbool matched;\n+\t\tint i;\n \n \t\t/* skip representor already be created */\n \t\tif (dev != NULL)\n@@ -424,6 +511,35 @@ cpfl_repr_create(struct rte_pci_device *pci_dev, struct cpfl_adapter_ext *adapte\n \t\t\t\t repr_id->host_id,\n \t\t\t\t repr_id->pf_id);\n \n+\t\t/* get vport list for the port representor */\n+\t\tret = cpfl_repr_vport_list_query(adapter, repr_id, vlist_resp);\n+\t\tif (ret != 0) {\n+\t\t\tPMD_INIT_LOG(ERR, \"Failed to get host%d pf%d vf%d's vport list\",\n+\t\t\t\t repr_id->host_id, repr_id->pf_id, repr_id->vf_id);\n+\t\t\tgoto err;\n+\t\t}\n+\n+\t\t/* get all vport info for the port representor */\n+\t\tfor (i = 0; i < vlist_resp->nof_vports; i++) {\n+\t\t\tret = cpfl_repr_vport_info_query(adapter, repr_id,\n+\t\t\t\t\t\t\t &vlist_resp->vports[i], &vinfo_resp);\n+\t\t\tif (ret != 0) {\n+\t\t\t\tPMD_INIT_LOG(ERR, \"Failed to get host%d pf%d vf%d vport[%d]'s info\",\n+\t\t\t\t\t repr_id->host_id, repr_id->pf_id, repr_id->vf_id,\n+\t\t\t\t\t vlist_resp->vports[i].vport_id);\n+\t\t\t\tgoto err;\n+\t\t\t}\n+\n+\t\t\tret = cpfl_repr_vport_map_update(adapter, repr_id,\n+\t\t\t\t\t\t vlist_resp->vports[i].vport_id, &vinfo_resp);\n+\t\t\tif (ret != 0) {\n+\t\t\t\tPMD_INIT_LOG(ERR, \"Failed to update host%d pf%d vf%d vport[%d]'s info to vport_map_hash\",\n+\t\t\t\t\t repr_id->host_id, repr_id->pf_id, repr_id->vf_id,\n+\t\t\t\t\t vlist_resp->vports[i].vport_id);\n+\t\t\t\tgoto err;\n+\t\t\t}\n+\t\t}\n+\n \t\t/* find a matched vport */\n \t\trte_spinlock_lock(&adapter->vport_map_lock);\n \n@@ -449,8 +565,7 @@ cpfl_repr_create(struct rte_pci_device *pci_dev, struct cpfl_adapter_ext *adapte\n \t\t\tif (ret != 0) {\n \t\t\t\tPMD_INIT_LOG(ERR, \"Failed to create representor %s\", name);\n \t\t\t\trte_spinlock_unlock(&adapter->vport_map_lock);\n-\t\t\t\trte_spinlock_unlock(&adapter->repr_lock);\n-\t\t\t\treturn ret;\n+\t\t\t\tgoto err;\n \t\t\t}\n \t\t\tbreak;\n \t\t}\n@@ -464,7 +579,8 @@ cpfl_repr_create(struct rte_pci_device *pci_dev, struct cpfl_adapter_ext *adapte\n \t\trte_spinlock_unlock(&adapter->vport_map_lock);\n \t}\n \n+err:\n \trte_spinlock_unlock(&adapter->repr_lock);\n-\n-\treturn 0;\n+\trte_free(vlist_resp);\n+\treturn ret;\n }\n", "prefixes": [ "v3", "10/11" ] }