Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/131179/?format=api
{ "id": 131179, "url": "http://patches.dpdk.org/api/patches/131179/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20230905163908.19946-2-pbhagavatula@marvell.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20230905163908.19946-2-pbhagavatula@marvell.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20230905163908.19946-2-pbhagavatula@marvell.com", "date": "2023-09-05T16:39:07", "name": "[2/3] event/cnxk: remove checks from op release", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "eaf3e31af4f079d8617a1b52ff831bd09c28958c", "submitter": { "id": 1183, "url": "http://patches.dpdk.org/api/people/1183/?format=api", "name": "Pavan Nikhilesh Bhagavatula", "email": "pbhagavatula@marvell.com" }, "delegate": { "id": 310, "url": "http://patches.dpdk.org/api/users/310/?format=api", "username": "jerin", "first_name": "Jerin", "last_name": "Jacob", "email": "jerinj@marvell.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20230905163908.19946-2-pbhagavatula@marvell.com/mbox/", "series": [ { "id": 29429, "url": "http://patches.dpdk.org/api/series/29429/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=29429", "date": "2023-09-05T16:39:07", "name": "[1/3] cnxk/event: invalidate GWC on port reset", "version": 1, "mbox": "http://patches.dpdk.org/series/29429/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/131179/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/131179/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id C5A22424F4;\n\tTue, 5 Sep 2023 18:39:19 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id A38AF40E78;\n\tTue, 5 Sep 2023 18:39:19 +0200 (CEST)", "from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com\n [67.231.156.173])\n by mails.dpdk.org (Postfix) with ESMTP id 31C3E400D7\n for <dev@dpdk.org>; Tue, 5 Sep 2023 18:39:18 +0200 (CEST)", "from pps.filterd (m0045851.ppops.net [127.0.0.1])\n by mx0b-0016f401.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id\n 385C6w1p026839 for <dev@dpdk.org>; Tue, 5 Sep 2023 09:39:17 -0700", "from dc5-exch01.marvell.com ([199.233.59.181])\n by mx0b-0016f401.pphosted.com (PPS) with ESMTPS id 3sv4jkaje0-1\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT)\n for <dev@dpdk.org>; Tue, 05 Sep 2023 09:39:17 -0700", "from DC5-EXCH02.marvell.com (10.69.176.39) by DC5-EXCH01.marvell.com\n (10.69.176.38) with Microsoft SMTP Server (TLS) id 15.0.1497.48;\n Tue, 5 Sep 2023 09:39:15 -0700", "from maili.marvell.com (10.69.176.80) by DC5-EXCH02.marvell.com\n (10.69.176.39) with Microsoft SMTP Server id 15.0.1497.48 via Frontend\n Transport; Tue, 5 Sep 2023 09:39:15 -0700", "from MININT-80QBFE8.corp.innovium.com (MININT-80QBFE8.marvell.com\n [10.28.164.106])\n by maili.marvell.com (Postfix) with ESMTP id D76CF3F7065;\n Tue, 5 Sep 2023 09:39:13 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com;\n h=from : to : cc :\n subject : date : message-id : in-reply-to : references : mime-version :\n content-transfer-encoding : content-type; s=pfpt0220;\n bh=tacWIsZdxJk/qZxjYmreA+IhUzHy8CEnzscK8bF0HO8=;\n b=Q6vHEVZ1qGJEBDLt7UWQvDSPDIxJi59R4NifP6B8K0BmaGDpJgrxAycE3RrGyY1N5oEP\n GI9fWZW7kwqU95xtB20Z4OjrLUK4loakzfEXNNET9Nd8DNNQU+c/z+W5EFDPX+JO0Ydn\n e6VdwFBg+dc/ekMQZfBysvwWulc0sQWmoSPxooKkYkAs2aR/b9DmAu3x2cSoUd804UpX\n qiTWg6dAPX3ClBz3Lw/OJfZtEEL9zxiQ0pZZnZd+vRS+cRERtHug9FNNvUjzYwYzoO3D\n lVx8iZJlcpKIlakKMxucWSUS/NdjQGcG7T9c8z3zO9HO2vcz4aB9FCCBDIDp6S/k56v/ rA==", "From": "<pbhagavatula@marvell.com>", "To": "<jerinj@marvell.com>, Pavan Nikhilesh <pbhagavatula@marvell.com>, \"Shijith\n Thotton\" <sthotton@marvell.com>", "CC": "<dev@dpdk.org>", "Subject": "[PATCH 2/3] event/cnxk: remove checks from op release", "Date": "Tue, 5 Sep 2023 22:09:07 +0530", "Message-ID": "<20230905163908.19946-2-pbhagavatula@marvell.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20230905163908.19946-1-pbhagavatula@marvell.com>", "References": "<20230905163908.19946-1-pbhagavatula@marvell.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Proofpoint-GUID": "K63YARG8ZTyeVM4cD2oouyBYs7H0MUMA", "X-Proofpoint-ORIG-GUID": "K63YARG8ZTyeVM4cD2oouyBYs7H0MUMA", "X-Proofpoint-Virus-Version": "vendor=baseguard\n engine=ICAP:2.0.267,Aquarius:18.0.957,Hydra:6.0.601,FMLib:17.11.176.26\n definitions=2023-09-05_10,2023-09-05_01,2023-05-22_02", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "From: Pavan Nikhilesh <pbhagavatula@marvell.com>\n\nRemove expensive fastpath checks from op release, remove\nexplicit release in CN9K tx routine.\n\nSigned-off-by: Pavan Nikhilesh <pbhagavatula@marvell.com>\n---\n drivers/event/cnxk/cn9k_worker.h | 17 -----------------\n drivers/event/cnxk/cnxk_worker.h | 6 ------\n 2 files changed, 23 deletions(-)", "diff": "diff --git a/drivers/event/cnxk/cn9k_worker.h b/drivers/event/cnxk/cn9k_worker.h\nindex 9ddab095ac..ee659e80d6 100644\n--- a/drivers/event/cnxk/cn9k_worker.h\n+++ b/drivers/event/cnxk/cn9k_worker.h\n@@ -156,15 +156,6 @@ cn9k_sso_hws_dual_forward_event(struct cn9k_sso_hws_dual *dws, uint64_t base,\n \t}\n }\n \n-static __rte_always_inline void\n-cn9k_sso_tx_tag_flush(uint64_t base)\n-{\n-\tif (unlikely(CNXK_TT_FROM_TAG(plt_read64(base + SSOW_LF_GWS_TAG)) ==\n-\t\t SSO_TT_EMPTY))\n-\t\treturn;\n-\tplt_write64(0, base + SSOW_LF_GWS_OP_SWTAG_FLUSH);\n-}\n-\n static __rte_always_inline void\n cn9k_wqe_to_mbuf(uint64_t wqe, const uint64_t mbuf, uint8_t port_id,\n \t\t const uint32_t tag, const uint32_t flags,\n@@ -727,7 +718,6 @@ cn9k_sso_hws_event_tx(uint64_t base, struct rte_event *ev, uint64_t *cmd,\n \t\t uint64_t *txq_data, const uint32_t flags)\n {\n \tstruct rte_mbuf *m = ev->mbuf;\n-\tuint16_t ref_cnt = m->refcnt;\n \tstruct cn9k_eth_txq *txq;\n \n \t/* Perform header writes before barrier for TSO */\n@@ -800,13 +790,6 @@ cn9k_sso_hws_event_tx(uint64_t base, struct rte_event *ev, uint64_t *cmd,\n \t}\n \n done:\n-\tif (flags & NIX_TX_OFFLOAD_MBUF_NOFF_F) {\n-\t\tif (ref_cnt > 1)\n-\t\t\treturn 1;\n-\t}\n-\n-\tcn9k_sso_tx_tag_flush(base);\n-\n \treturn 1;\n }\n \ndiff --git a/drivers/event/cnxk/cnxk_worker.h b/drivers/event/cnxk/cnxk_worker.h\nindex 2bd41f8a5e..0e0d728ba4 100644\n--- a/drivers/event/cnxk/cnxk_worker.h\n+++ b/drivers/event/cnxk/cnxk_worker.h\n@@ -54,12 +54,6 @@ cnxk_sso_hws_swtag_untag(uintptr_t swtag_untag_op)\n static __rte_always_inline void\n cnxk_sso_hws_swtag_flush(uint64_t base)\n {\n-\t/* Ensure that there is no previous flush is pending. */\n-\twhile (plt_read64(base + SSOW_LF_GWS_PENDSTATE) & BIT_ULL(56))\n-\t\t;\n-\tif (CNXK_TT_FROM_TAG(plt_read64(base + SSOW_LF_GWS_TAG)) ==\n-\t SSO_TT_EMPTY)\n-\t\treturn;\n \tplt_write64(0, base + SSOW_LF_GWS_OP_SWTAG_FLUSH);\n }\n \n", "prefixes": [ "2/3" ] }