Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/130777/?format=api
{ "id": 130777, "url": "http://patches.dpdk.org/api/patches/130777/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20230826074607.16771-2-haijie1@huawei.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20230826074607.16771-2-haijie1@huawei.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20230826074607.16771-2-haijie1@huawei.com", "date": "2023-08-26T07:46:03", "name": "[v2,1/5] ethdev: support setting and querying RSS algorithm", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "d859224c52187fd4d6df8102f01af0828ffe21de", "submitter": { "id": 2935, "url": "http://patches.dpdk.org/api/people/2935/?format=api", "name": "Jie Hai", "email": "haijie1@huawei.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20230826074607.16771-2-haijie1@huawei.com/mbox/", "series": [ { "id": 29351, "url": "http://patches.dpdk.org/api/series/29351/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=29351", "date": "2023-08-26T07:46:03", "name": "support setting and querying RSS algorithms", "version": 2, "mbox": "http://patches.dpdk.org/series/29351/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/130777/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/130777/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id CC0D94310A;\n\tSat, 26 Aug 2023 09:50:29 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 4DEF8410DC;\n\tSat, 26 Aug 2023 09:50:29 +0200 (CEST)", "from szxga03-in.huawei.com (szxga03-in.huawei.com [45.249.212.189])\n by mails.dpdk.org (Postfix) with ESMTP id F1E0D40E6E\n for <dev@dpdk.org>; Sat, 26 Aug 2023 09:50:26 +0200 (CEST)", "from kwepemi500020.china.huawei.com (unknown [172.30.72.53])\n by szxga03-in.huawei.com (SkyGuard) with ESMTP id 4RXpn96VyxzJrrF;\n Sat, 26 Aug 2023 15:47:09 +0800 (CST)", "from localhost.localdomain (10.69.192.56) by\n kwepemi500020.china.huawei.com (7.221.188.8) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id\n 15.1.2507.31; Sat, 26 Aug 2023 15:50:17 +0800" ], "From": "Jie Hai <haijie1@huawei.com>", "To": "<dev@dpdk.org>, Thomas Monjalon <thomas@monjalon.net>, Ferruh Yigit\n <ferruh.yigit@amd.com>, Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>", "CC": "<liudongdong3@huawei.com>, <haijie1@huawei.com>", "Subject": "[PATCH v2 1/5] ethdev: support setting and querying RSS algorithm", "Date": "Sat, 26 Aug 2023 15:46:03 +0800", "Message-ID": "<20230826074607.16771-2-haijie1@huawei.com>", "X-Mailer": "git-send-email 2.33.0", "In-Reply-To": "<20230826074607.16771-1-haijie1@huawei.com>", "References": "<20230315110033.30143-1-liudongdong3@huawei.com>\n <20230826074607.16771-1-haijie1@huawei.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Originating-IP": "[10.69.192.56]", "X-ClientProxiedBy": "dggems703-chm.china.huawei.com (10.3.19.180) To\n kwepemi500020.china.huawei.com (7.221.188.8)", "X-CFilter-Loop": "Reflected", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Currently, rte_eth_rss_conf supports configuring and querying\nrss hash functions, rss key and it's length, but not rss hash\nalgorithm.\n\nThe structure ``rte_eth_rss_conf`` is extended by adding a new\nfield \"func\". This represents the RSS algorithms to apply. The\nfollowing API is affected:\n\t- rte_eth_dev_configure\n\t- rte_eth_dev_rss_hash_update\n\t- rte_eth_dev_rss_hash_conf_get\n\nIf the value of \"func\" used for configuration is a gibberish\nvalue, report the error and return. Do the same for\nrte_eth_dev_rss_hash_update and rte_eth_dev_configure.\n\nTo check whether the drivers report the \"func\" field, it is set\nto default value before querying.\n\nSigned-off-by: Jie Hai <haijie1@huawei.com>\nSigned-off-by: Dongdong Liu <liudongdong3@huawei.com>\n---\n doc/guides/rel_notes/release_23_11.rst | 2 ++\n lib/ethdev/rte_ethdev.c | 17 +++++++++++++++++\n lib/ethdev/rte_ethdev.h | 6 ++++++\n 3 files changed, 25 insertions(+)", "diff": "diff --git a/doc/guides/rel_notes/release_23_11.rst b/doc/guides/rel_notes/release_23_11.rst\nindex 4411bb32c195..3746436e8bc9 100644\n--- a/doc/guides/rel_notes/release_23_11.rst\n+++ b/doc/guides/rel_notes/release_23_11.rst\n@@ -123,6 +123,8 @@ ABI Changes\n Also, make sure to start the actual text at the margin.\n =======================================================\n \n+ * ethdev: Added \"func\" field to ``rte_eth_rss_conf`` structure for RSS hash\n+ algorithm.\n \n Known Issues\n ------------\ndiff --git a/lib/ethdev/rte_ethdev.c b/lib/ethdev/rte_ethdev.c\nindex 0840d2b5942a..4cbcdb344cac 100644\n--- a/lib/ethdev/rte_ethdev.c\n+++ b/lib/ethdev/rte_ethdev.c\n@@ -1445,6 +1445,14 @@ rte_eth_dev_configure(uint16_t port_id, uint16_t nb_rx_q, uint16_t nb_tx_q,\n \t\tgoto rollback;\n \t}\n \n+\tif (dev_conf->rx_adv_conf.rss_conf.func >= RTE_ETH_HASH_FUNCTION_MAX) {\n+\t\tRTE_ETHDEV_LOG(ERR,\n+\t\t\t\"Ethdev port_id=%u invalid rss hash function (%u)\\n\",\n+\t\t\tport_id, dev_conf->rx_adv_conf.rss_conf.func);\n+\t\tret = -EINVAL;\n+\t\tgoto rollback;\n+\t}\n+\n \t/* Check if Rx RSS distribution is disabled but RSS hash is enabled. */\n \tif (((dev_conf->rxmode.mq_mode & RTE_ETH_MQ_RX_RSS_FLAG) == 0) &&\n \t (dev_conf->rxmode.offloads & RTE_ETH_RX_OFFLOAD_RSS_HASH)) {\n@@ -4630,6 +4638,13 @@ rte_eth_dev_rss_hash_update(uint16_t port_id,\n \t\treturn -ENOTSUP;\n \t}\n \n+\tif (rss_conf->func >= RTE_ETH_HASH_FUNCTION_MAX) {\n+\t\tRTE_ETHDEV_LOG(ERR,\n+\t\t\t\"Ethdev port_id=%u invalid rss hash function (%u)\\n\",\n+\t\t\tport_id, rss_conf->func);\n+\t\treturn -EINVAL;\n+\t}\n+\n \tif (*dev->dev_ops->rss_hash_update == NULL)\n \t\treturn -ENOTSUP;\n \tret = eth_err(port_id, (*dev->dev_ops->rss_hash_update)(dev,\n@@ -4657,6 +4672,8 @@ rte_eth_dev_rss_hash_conf_get(uint16_t port_id,\n \t\treturn -EINVAL;\n \t}\n \n+\trss_conf->func = RTE_ETH_HASH_FUNCTION_DEFAULT;\n+\n \tif (*dev->dev_ops->rss_hash_conf_get == NULL)\n \t\treturn -ENOTSUP;\n \tret = eth_err(port_id, (*dev->dev_ops->rss_hash_conf_get)(dev,\ndiff --git a/lib/ethdev/rte_ethdev.h b/lib/ethdev/rte_ethdev.h\nindex 04a2564f222a..1bb5f23059ca 100644\n--- a/lib/ethdev/rte_ethdev.h\n+++ b/lib/ethdev/rte_ethdev.h\n@@ -174,6 +174,7 @@ extern \"C\" {\n \n #include \"rte_ethdev_trace_fp.h\"\n #include \"rte_dev_info.h\"\n+#include \"rte_flow.h\"\n \n extern int rte_eth_dev_logtype;\n \n@@ -461,11 +462,16 @@ struct rte_vlan_filter_conf {\n * The *rss_hf* field of the *rss_conf* structure indicates the different\n * types of IPv4/IPv6 packets to which the RSS hashing must be applied.\n * Supplying an *rss_hf* equal to zero disables the RSS feature.\n+ *\n+ * The *func* field of the *rss_conf* structure indicates the hash algorithm\n+ * applied by the RSS hashing. Passing RTE_ETH_HASH_FUNCTION_DEFAULT allows\n+ * the PMD to use its best-effort algorithm rather than a specific one.\n */\n struct rte_eth_rss_conf {\n \tuint8_t *rss_key; /**< If not NULL, 40-byte hash key. */\n \tuint8_t rss_key_len; /**< hash key length in bytes. */\n \tuint64_t rss_hf; /**< Hash functions to apply - see below. */\n+\tenum rte_eth_hash_function func;\t/**< Hash algorithm to apply. */\n };\n \n /*\n", "prefixes": [ "v2", "1/5" ] }