Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/130656/?format=api
{ "id": 130656, "url": "http://patches.dpdk.org/api/patches/130656/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1692738045-32363-5-git-send-email-roretzla@linux.microsoft.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1692738045-32363-5-git-send-email-roretzla@linux.microsoft.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1692738045-32363-5-git-send-email-roretzla@linux.microsoft.com", "date": "2023-08-22T21:00:43", "name": "[v6,4/6] distributor: adapt for EAL optional atomics API changes", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "9d1aedef91908ccdb495b4595105d1978e61546b", "submitter": { "id": 2077, "url": "http://patches.dpdk.org/api/people/2077/?format=api", "name": "Tyler Retzlaff", "email": "roretzla@linux.microsoft.com" }, "delegate": { "id": 24651, "url": "http://patches.dpdk.org/api/users/24651/?format=api", "username": "dmarchand", "first_name": "David", "last_name": "Marchand", "email": "david.marchand@redhat.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1692738045-32363-5-git-send-email-roretzla@linux.microsoft.com/mbox/", "series": [ { "id": 29318, "url": "http://patches.dpdk.org/api/series/29318/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=29318", "date": "2023-08-22T21:00:40", "name": "rte atomics API for optional stdatomic", "version": 6, "mbox": "http://patches.dpdk.org/series/29318/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/130656/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/130656/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id D412E430D4;\n\tTue, 22 Aug 2023 23:01:09 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 1652543254;\n\tTue, 22 Aug 2023 23:00:53 +0200 (CEST)", "from linux.microsoft.com (linux.microsoft.com [13.77.154.182])\n by mails.dpdk.org (Postfix) with ESMTP id AF4ED40EE3;\n Tue, 22 Aug 2023 23:00:47 +0200 (CEST)", "by linux.microsoft.com (Postfix, from userid 1086)\n id DAB702126CD9; Tue, 22 Aug 2023 14:00:46 -0700 (PDT)" ], "DKIM-Filter": "OpenDKIM Filter v2.11.0 linux.microsoft.com DAB702126CD9", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com;\n s=default; t=1692738046;\n bh=Qz/0UuhNTnLG6MGjbFjd7qUl9rc+2w8eH7yrJpvU1r8=;\n h=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n b=QWW5lwKwXjMtisKPxy00Bcwf/uWfC9PaybeLwYo5DLqrLOyjUfxFr6dWfbgaflkMr\n Ez0ZK4x/slJQYLGaDZLfySdJ3dVAa4+ZTfu9mgZZvdMzjCNv2H+X1lviRsvnHlXnBR\n TMMSFnVEDcqz/26Ryx0XE246BI0GUDkYOPPw7shw=", "From": "Tyler Retzlaff <roretzla@linux.microsoft.com>", "To": "dev@dpdk.org", "Cc": "techboard@dpdk.org, Bruce Richardson <bruce.richardson@intel.com>,\n Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>,\n Ruifeng Wang <ruifeng.wang@arm.com>, Jerin Jacob <jerinj@marvell.com>,\n Sunil Kumar Kori <skori@marvell.com>,\n =?utf-8?q?Mattias_R=C3=B6nnblom?= <mattias.ronnblom@ericsson.com>,\n Joyce Kong <joyce.kong@arm.com>, David Christensen <drc@linux.vnet.ibm.com>,\n Konstantin Ananyev <konstantin.v.ananyev@yandex.ru>,\n David Hunt <david.hunt@intel.com>, Thomas Monjalon <thomas@monjalon.net>,\n David Marchand <david.marchand@redhat.com>,\n Tyler Retzlaff <roretzla@linux.microsoft.com>", "Subject": "[PATCH v6 4/6] distributor: adapt for EAL optional atomics API\n changes", "Date": "Tue, 22 Aug 2023 14:00:43 -0700", "Message-Id": "<1692738045-32363-5-git-send-email-roretzla@linux.microsoft.com>", "X-Mailer": "git-send-email 1.8.3.1", "In-Reply-To": "<1692738045-32363-1-git-send-email-roretzla@linux.microsoft.com>", "References": "<1691717521-1025-1-git-send-email-roretzla@linux.microsoft.com>\n <1692738045-32363-1-git-send-email-roretzla@linux.microsoft.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Adapt distributor for EAL optional atomics API changes\n\nSigned-off-by: Tyler Retzlaff <roretzla@linux.microsoft.com>\nReviewed-by: Morten Brørup <mb@smartsharesystems.com>\nAcked-by: Konstantin Ananyev <konstantin.v.ananyev@yandex.ru>\n---\n lib/distributor/distributor_private.h | 2 +-\n lib/distributor/rte_distributor_single.c | 44 ++++++++++++++++----------------\n 2 files changed, 23 insertions(+), 23 deletions(-)", "diff": "diff --git a/lib/distributor/distributor_private.h b/lib/distributor/distributor_private.h\nindex 7101f63..2f29343 100644\n--- a/lib/distributor/distributor_private.h\n+++ b/lib/distributor/distributor_private.h\n@@ -52,7 +52,7 @@\n * Only 64-bits of the memory is actually used though.\n */\n union rte_distributor_buffer_single {\n-\tvolatile int64_t bufptr64;\n+\tvolatile RTE_ATOMIC(int64_t) bufptr64;\n \tchar pad[RTE_CACHE_LINE_SIZE*3];\n } __rte_cache_aligned;\n \ndiff --git a/lib/distributor/rte_distributor_single.c b/lib/distributor/rte_distributor_single.c\nindex 2c77ac4..ad43c13 100644\n--- a/lib/distributor/rte_distributor_single.c\n+++ b/lib/distributor/rte_distributor_single.c\n@@ -32,10 +32,10 @@\n \tint64_t req = (((int64_t)(uintptr_t)oldpkt) << RTE_DISTRIB_FLAG_BITS)\n \t\t\t| RTE_DISTRIB_GET_BUF;\n \tRTE_WAIT_UNTIL_MASKED(&buf->bufptr64, RTE_DISTRIB_FLAGS_MASK,\n-\t\t==, 0, __ATOMIC_RELAXED);\n+\t\t==, 0, rte_memory_order_relaxed);\n \n \t/* Sync with distributor on GET_BUF flag. */\n-\t__atomic_store_n(&(buf->bufptr64), req, __ATOMIC_RELEASE);\n+\trte_atomic_store_explicit(&buf->bufptr64, req, rte_memory_order_release);\n }\n \n struct rte_mbuf *\n@@ -44,7 +44,7 @@ struct rte_mbuf *\n {\n \tunion rte_distributor_buffer_single *buf = &d->bufs[worker_id];\n \t/* Sync with distributor. Acquire bufptr64. */\n-\tif (__atomic_load_n(&buf->bufptr64, __ATOMIC_ACQUIRE)\n+\tif (rte_atomic_load_explicit(&buf->bufptr64, rte_memory_order_acquire)\n \t\t& RTE_DISTRIB_GET_BUF)\n \t\treturn NULL;\n \n@@ -72,10 +72,10 @@ struct rte_mbuf *\n \tuint64_t req = (((int64_t)(uintptr_t)oldpkt) << RTE_DISTRIB_FLAG_BITS)\n \t\t\t| RTE_DISTRIB_RETURN_BUF;\n \tRTE_WAIT_UNTIL_MASKED(&buf->bufptr64, RTE_DISTRIB_FLAGS_MASK,\n-\t\t==, 0, __ATOMIC_RELAXED);\n+\t\t==, 0, rte_memory_order_relaxed);\n \n \t/* Sync with distributor on RETURN_BUF flag. */\n-\t__atomic_store_n(&(buf->bufptr64), req, __ATOMIC_RELEASE);\n+\trte_atomic_store_explicit(&buf->bufptr64, req, rte_memory_order_release);\n \treturn 0;\n }\n \n@@ -119,7 +119,7 @@ struct rte_mbuf *\n \td->in_flight_tags[wkr] = 0;\n \td->in_flight_bitmask &= ~(1UL << wkr);\n \t/* Sync with worker. Release bufptr64. */\n-\t__atomic_store_n(&(d->bufs[wkr].bufptr64), 0, __ATOMIC_RELEASE);\n+\trte_atomic_store_explicit(&d->bufs[wkr].bufptr64, 0, rte_memory_order_release);\n \tif (unlikely(d->backlog[wkr].count != 0)) {\n \t\t/* On return of a packet, we need to move the\n \t\t * queued packets for this core elsewhere.\n@@ -165,21 +165,21 @@ struct rte_mbuf *\n \tfor (wkr = 0; wkr < d->num_workers; wkr++) {\n \t\tuintptr_t oldbuf = 0;\n \t\t/* Sync with worker. Acquire bufptr64. */\n-\t\tconst int64_t data = __atomic_load_n(&(d->bufs[wkr].bufptr64),\n-\t\t\t\t\t\t\t__ATOMIC_ACQUIRE);\n+\t\tconst int64_t data = rte_atomic_load_explicit(&d->bufs[wkr].bufptr64,\n+\t\t\t\t\t\t\trte_memory_order_acquire);\n \n \t\tif (data & RTE_DISTRIB_GET_BUF) {\n \t\t\tflushed++;\n \t\t\tif (d->backlog[wkr].count)\n \t\t\t\t/* Sync with worker. Release bufptr64. */\n-\t\t\t\t__atomic_store_n(&(d->bufs[wkr].bufptr64),\n+\t\t\t\trte_atomic_store_explicit(&d->bufs[wkr].bufptr64,\n \t\t\t\t\tbacklog_pop(&d->backlog[wkr]),\n-\t\t\t\t\t__ATOMIC_RELEASE);\n+\t\t\t\t\trte_memory_order_release);\n \t\t\telse {\n \t\t\t\t/* Sync with worker on GET_BUF flag. */\n-\t\t\t\t__atomic_store_n(&(d->bufs[wkr].bufptr64),\n+\t\t\t\trte_atomic_store_explicit(&d->bufs[wkr].bufptr64,\n \t\t\t\t\tRTE_DISTRIB_GET_BUF,\n-\t\t\t\t\t__ATOMIC_RELEASE);\n+\t\t\t\t\trte_memory_order_release);\n \t\t\t\td->in_flight_tags[wkr] = 0;\n \t\t\t\td->in_flight_bitmask &= ~(1UL << wkr);\n \t\t\t}\n@@ -217,8 +217,8 @@ struct rte_mbuf *\n \twhile (next_idx < num_mbufs || next_mb != NULL) {\n \t\tuintptr_t oldbuf = 0;\n \t\t/* Sync with worker. Acquire bufptr64. */\n-\t\tint64_t data = __atomic_load_n(&(d->bufs[wkr].bufptr64),\n-\t\t\t\t\t\t__ATOMIC_ACQUIRE);\n+\t\tint64_t data = rte_atomic_load_explicit(&(d->bufs[wkr].bufptr64),\n+\t\t\t\t\t\trte_memory_order_acquire);\n \n \t\tif (!next_mb) {\n \t\t\tnext_mb = mbufs[next_idx++];\n@@ -264,15 +264,15 @@ struct rte_mbuf *\n \n \t\t\tif (d->backlog[wkr].count)\n \t\t\t\t/* Sync with worker. Release bufptr64. */\n-\t\t\t\t__atomic_store_n(&(d->bufs[wkr].bufptr64),\n+\t\t\t\trte_atomic_store_explicit(&d->bufs[wkr].bufptr64,\n \t\t\t\t\t\tbacklog_pop(&d->backlog[wkr]),\n-\t\t\t\t\t\t__ATOMIC_RELEASE);\n+\t\t\t\t\t\trte_memory_order_release);\n \n \t\t\telse {\n \t\t\t\t/* Sync with worker. Release bufptr64. */\n-\t\t\t\t__atomic_store_n(&(d->bufs[wkr].bufptr64),\n+\t\t\t\trte_atomic_store_explicit(&d->bufs[wkr].bufptr64,\n \t\t\t\t\t\tnext_value,\n-\t\t\t\t\t\t__ATOMIC_RELEASE);\n+\t\t\t\t\t\trte_memory_order_release);\n \t\t\t\td->in_flight_tags[wkr] = new_tag;\n \t\t\t\td->in_flight_bitmask |= (1UL << wkr);\n \t\t\t\tnext_mb = NULL;\n@@ -294,8 +294,8 @@ struct rte_mbuf *\n \tfor (wkr = 0; wkr < d->num_workers; wkr++)\n \t\tif (d->backlog[wkr].count &&\n \t\t\t\t/* Sync with worker. Acquire bufptr64. */\n-\t\t\t\t(__atomic_load_n(&(d->bufs[wkr].bufptr64),\n-\t\t\t\t__ATOMIC_ACQUIRE) & RTE_DISTRIB_GET_BUF)) {\n+\t\t\t\t(rte_atomic_load_explicit(&d->bufs[wkr].bufptr64,\n+\t\t\t\trte_memory_order_acquire) & RTE_DISTRIB_GET_BUF)) {\n \n \t\t\tint64_t oldbuf = d->bufs[wkr].bufptr64 >>\n \t\t\t\t\tRTE_DISTRIB_FLAG_BITS;\n@@ -303,9 +303,9 @@ struct rte_mbuf *\n \t\t\tstore_return(oldbuf, d, &ret_start, &ret_count);\n \n \t\t\t/* Sync with worker. Release bufptr64. */\n-\t\t\t__atomic_store_n(&(d->bufs[wkr].bufptr64),\n+\t\t\trte_atomic_store_explicit(&d->bufs[wkr].bufptr64,\n \t\t\t\tbacklog_pop(&d->backlog[wkr]),\n-\t\t\t\t__ATOMIC_RELEASE);\n+\t\t\t\trte_memory_order_release);\n \t\t}\n \n \td->returns.start = ret_start;\n", "prefixes": [ "v6", "4/6" ] }