Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/130606/?format=api
{ "id": 130606, "url": "http://patches.dpdk.org/api/patches/130606/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20230821160921.383832-17-stephen@networkplumber.org/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20230821160921.383832-17-stephen@networkplumber.org>", "list_archive_url": "https://inbox.dpdk.org/dev/20230821160921.383832-17-stephen@networkplumber.org", "date": "2023-08-21T16:09:16", "name": "[v13,16/21] hash: move rte_thash_gfni stubs out of header file", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": true, "hash": "6c6193e61ecfee5f4e1ebcb19bd9fe2d9e6a36da", "submitter": { "id": 27, "url": "http://patches.dpdk.org/api/people/27/?format=api", "name": "Stephen Hemminger", "email": "stephen@networkplumber.org" }, "delegate": { "id": 24651, "url": "http://patches.dpdk.org/api/users/24651/?format=api", "username": "dmarchand", "first_name": "David", "last_name": "Marchand", "email": "david.marchand@redhat.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20230821160921.383832-17-stephen@networkplumber.org/mbox/", "series": [ { "id": 29298, "url": "http://patches.dpdk.org/api/series/29298/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=29298", "date": "2023-08-21T16:09:00", "name": "Convert static log types in libraries to dynamic types", "version": 13, "mbox": "http://patches.dpdk.org/series/29298/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/130606/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/130606/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 24236430C3;\n\tMon, 21 Aug 2023 18:11:48 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 763CE4328D;\n\tMon, 21 Aug 2023 18:10:15 +0200 (CEST)", "from mail-pl1-f170.google.com (mail-pl1-f170.google.com\n [209.85.214.170])\n by mails.dpdk.org (Postfix) with ESMTP id 415ED432A2\n for <dev@dpdk.org>; Mon, 21 Aug 2023 18:10:10 +0200 (CEST)", "by mail-pl1-f170.google.com with SMTP id\n d9443c01a7336-1bdaeb0f29aso21102975ad.2\n for <dev@dpdk.org>; Mon, 21 Aug 2023 09:10:10 -0700 (PDT)", "from hermes.local (204-195-127-207.wavecable.com. [204.195.127.207])\n by smtp.gmail.com with ESMTPSA id\n i1-20020a17090332c100b001bf2dcfe352sm7208159plr.234.2023.08.21.09.10.08\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Mon, 21 Aug 2023 09:10:08 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=networkplumber-org.20221208.gappssmtp.com; s=20221208; t=1692634209;\n x=1693239009;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=dxfCJ8JCP4HHGFPNVjC7sgPW8L8L1EzHthHSsCbcwEw=;\n b=nQ0laaNd+e9g9UIBOB3zfW6cRULKzwZ6Capfs2gQPDUDdFTROCwigRnXXlDsiunh6P\n hAvvcbP9dFVODpMLOvs0U8KmjOPlvwhjvpmDhYctrzq4/84Uhn4ra7EYSyDmN6bORhOI\n Tl4GOnZwslLRSzIp6Watdxhu6bk1QUkTNA0QkxzcY5FVpTKko3aG9AfLEhD0a1Mp4YY7\n JkA9Van1BGDsbIiywFVjvl+QlSjyvot6F7Tjzr6G+/vyoi1MEFd+P7whc0YhhdeTEVOw\n EVIh64OdSGwLQOoMPVC25fh+PSrLu4Y5dR9iI1BjglIjglj8Nv8w0ZRfLE3kzEIfSsZ4\n zweQ==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20221208; t=1692634209; x=1693239009;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n :subject:date:message-id:reply-to;\n bh=dxfCJ8JCP4HHGFPNVjC7sgPW8L8L1EzHthHSsCbcwEw=;\n b=FSVu7nYvWhKygeQJVxoKLBgYR8QTvYJlVddtfSDrbbrTbnX2IRbkGY3u4IaxbxaoFm\n eG19NTVtvcEgyeL4BTEdPir33q3eNyyb82fDMiJ4oLcL3iy2V5O3cXUnf2HpSDndQa2J\n VCbyP9VIwzzH7ISSGgWdVQxYvvY5XtVLNPOIFvzL8hhDY2v9bH0uwA++Rvezbum/fVUk\n BX2RJZlR4yAjaQnXs9xURWvZmbddgiQnFQgyV15ZcEx79ZZVDOI/65QyDvOk5g6zZ/ct\n H2ADrnlLeu4gUzpX5Vidt4uJKEjbtMtIcd0eF1Eg7SNmqWVZFvJ+eAaTUH4aN7pTG6T6\n 06qw==", "X-Gm-Message-State": "AOJu0YzXUqmfn0GBtmbEYIKimP5a98t3tDUXbwC2pQw4gw1mllOgSnPO\n 56thntSvB+RDbEuIiNpv5jEhqErQO+ZkVc5qF4BJLk1E", "X-Google-Smtp-Source": "\n AGHT+IF2Pi7fRtC5apfOi0DhhXSigYmnpXda5Zx5lTt1LnRTNq638BdAg6uxo3yNkxG/xiV6vH+mng==", "X-Received": "by 2002:a17:902:e884:b0:1bb:dc48:644a with SMTP id\n w4-20020a170902e88400b001bbdc48644amr5917281plg.49.1692634209250;\n Mon, 21 Aug 2023 09:10:09 -0700 (PDT)", "From": "Stephen Hemminger <stephen@networkplumber.org>", "To": "dev@dpdk.org", "Cc": "Stephen Hemminger <stephen@networkplumber.org>,\n Yipeng Wang <yipeng1.wang@intel.com>,\n Sameh Gobriel <sameh.gobriel@intel.com>,\n Bruce Richardson <bruce.richardson@intel.com>,\n Vladimir Medvedkin <vladimir.medvedkin@intel.com>", "Subject": "[PATCH v13 16/21] hash: move rte_thash_gfni stubs out of header file", "Date": "Mon, 21 Aug 2023 09:09:16 -0700", "Message-Id": "<20230821160921.383832-17-stephen@networkplumber.org>", "X-Mailer": "git-send-email 2.39.2", "In-Reply-To": "<20230821160921.383832-1-stephen@networkplumber.org>", "References": "<20230329234049.11071-1-stephen@networkplumber.org>\n <20230821160921.383832-1-stephen@networkplumber.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Having stubs in header file makes it harder to update\nRTE_LOG(). Also modify to only print warning once.\n\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\n---\n lib/hash/meson.build | 8 ++++++-\n lib/hash/rte_thash_gfni.c | 47 +++++++++++++++++++++++++++++++++++++++\n lib/hash/rte_thash_gfni.h | 30 ++++++++-----------------\n lib/hash/version.map | 4 ++++\n 4 files changed, 67 insertions(+), 22 deletions(-)\n create mode 100644 lib/hash/rte_thash_gfni.c", "diff": "diff --git a/lib/hash/meson.build b/lib/hash/meson.build\nindex 2f757d45f9bc..e56ee8572564 100644\n--- a/lib/hash/meson.build\n+++ b/lib/hash/meson.build\n@@ -17,7 +17,13 @@ indirect_headers += files(\n 'rte_thash_x86_gfni.h',\n )\n \n-sources = files('rte_cuckoo_hash.c', 'rte_fbk_hash.c', 'rte_thash.c')\n+sources = files(\n+ 'rte_cuckoo_hash.c',\n+ 'rte_fbk_hash.c',\n+ 'rte_thash.c',\n+ 'rte_thash_gfni.c'\n+)\n+\n deps += ['net']\n deps += ['ring']\n deps += ['rcu']\ndiff --git a/lib/hash/rte_thash_gfni.c b/lib/hash/rte_thash_gfni.c\nnew file mode 100644\nindex 000000000000..eb334185725c\n--- /dev/null\n+++ b/lib/hash/rte_thash_gfni.c\n@@ -0,0 +1,47 @@\n+/* SPDX-License-Identifier: BSD-3-Clause\n+ * Copyright(c) 2021 Intel Corporation\n+ */\n+\n+#include <stdbool.h>\n+\n+#include <rte_compat.h>\n+#include <rte_log.h>\n+#include <rte_thash_gfni.h>\n+\n+#ifndef RTE_THASH_GFNI_DEFINED\n+\n+uint32_t\n+rte_thash_gfni(const uint64_t *mtrx __rte_unused,\n+\t const uint8_t *key __rte_unused, int len __rte_unused)\n+{\n+\tstatic bool warned;\n+\n+\tif (!warned) {\n+\t\twarned = true;\n+\t\tRTE_LOG(ERR, HASH,\n+\t\t\t\"%s is undefined under given arch\\n\", __func__);\n+\t}\n+\n+\treturn 0;\n+}\n+\n+void\n+rte_thash_gfni_bulk(const uint64_t *mtrx __rte_unused,\n+\t\t int len __rte_unused, uint8_t *tuple[] __rte_unused,\n+\t\t uint32_t val[], uint32_t num)\n+{\n+\tunsigned int i;\n+\n+\tstatic bool warned;\n+\n+\tif (!warned) {\n+\t\twarned = true;\n+\t\tRTE_LOG(ERR, HASH,\n+\t\t\t\"%s is undefined under given arch\\n\", __func__);\n+\t}\n+\n+\tfor (i = 0; i < num; i++)\n+\t\tval[i] = 0;\n+}\n+\n+#endif\ndiff --git a/lib/hash/rte_thash_gfni.h b/lib/hash/rte_thash_gfni.h\nindex ef90faa302d1..4fc92984077e 100644\n--- a/lib/hash/rte_thash_gfni.h\n+++ b/lib/hash/rte_thash_gfni.h\n@@ -9,13 +9,14 @@\n extern \"C\" {\n #endif\n \n+#include <stdint.h>\n+\n #include <rte_compat.h>\n-#include <rte_log.h>\n+#include <rte_common.h>\n+#include <rte_config.h>\n \n #ifdef RTE_ARCH_X86\n-\n #include <rte_thash_x86_gfni.h>\n-\n #endif\n \n #ifndef RTE_THASH_GFNI_DEFINED\n@@ -38,13 +39,8 @@ extern \"C\" {\n * Calculated Toeplitz hash value.\n */\n __rte_experimental\n-static inline uint32_t\n-rte_thash_gfni(const uint64_t *mtrx __rte_unused,\n-\tconst uint8_t *key __rte_unused, int len __rte_unused)\n-{\n-\tRTE_LOG(ERR, HASH, \"%s is undefined under given arch\\n\", __func__);\n-\treturn 0;\n-}\n+uint32_t\n+rte_thash_gfni(const uint64_t *mtrx, const uint8_t *key, int len);\n \n /**\n * Bulk implementation for Toeplitz hash.\n@@ -67,17 +63,9 @@ rte_thash_gfni(const uint64_t *mtrx __rte_unused,\n * Number of tuples to hash.\n */\n __rte_experimental\n-static inline void\n-rte_thash_gfni_bulk(const uint64_t *mtrx __rte_unused,\n-\tint len __rte_unused, uint8_t *tuple[] __rte_unused,\n-\tuint32_t val[], uint32_t num)\n-{\n-\tunsigned int i;\n-\n-\tRTE_LOG(ERR, HASH, \"%s is undefined under given arch\\n\", __func__);\n-\tfor (i = 0; i < num; i++)\n-\t\tval[i] = 0;\n-}\n+void\n+rte_thash_gfni_bulk(const uint64_t *mtrx, int len, uint8_t *tuple[],\n+\t\t uint32_t val[], uint32_t num);\n \n #endif /* RTE_THASH_GFNI_DEFINED */\n \ndiff --git a/lib/hash/version.map b/lib/hash/version.map\nindex daaa9a8901db..8288c6e7967e 100644\n--- a/lib/hash/version.map\n+++ b/lib/hash/version.map\n@@ -51,4 +51,8 @@ EXPERIMENTAL {\n \trte_thash_complete_matrix;\n \trte_thash_get_gfni_matrices;\n \trte_thash_gfni_supported;\n+\n+\t# added in 22.07\n+\trte_thash_gfni;\n+\trte_thash_gfni_bulk;\n };\n", "prefixes": [ "v13", "16/21" ] }