Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/130538/?format=api
{ "id": 130538, "url": "http://patches.dpdk.org/api/patches/130538/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20230818174537.290222-14-stephen@networkplumber.org/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20230818174537.290222-14-stephen@networkplumber.org>", "list_archive_url": "https://inbox.dpdk.org/dev/20230818174537.290222-14-stephen@networkplumber.org", "date": "2023-08-18T17:45:37", "name": "[v2,13/13] net/axgbe: replace word abort", "commit_ref": null, "pull_url": null, "state": "rejected", "archived": true, "hash": "a08d5cba105bd99da0c86979a5c034896447e011", "submitter": { "id": 27, "url": "http://patches.dpdk.org/api/people/27/?format=api", "name": "Stephen Hemminger", "email": "stephen@networkplumber.org" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20230818174537.290222-14-stephen@networkplumber.org/mbox/", "series": [ { "id": 29282, "url": "http://patches.dpdk.org/api/series/29282/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=29282", "date": "2023-08-18T17:45:24", "name": "Replace us of term abort", "version": 2, "mbox": "http://patches.dpdk.org/series/29282/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/130538/comments/", "check": "warning", "checks": "http://patches.dpdk.org/api/patches/130538/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 1E59E4309A;\n\tFri, 18 Aug 2023 19:48:28 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id E0BBD43293;\n\tFri, 18 Aug 2023 19:47:02 +0200 (CEST)", "from mail-pf1-f171.google.com (mail-pf1-f171.google.com\n [209.85.210.171])\n by mails.dpdk.org (Postfix) with ESMTP id BC3384325D\n for <dev@dpdk.org>; Fri, 18 Aug 2023 19:46:56 +0200 (CEST)", "by mail-pf1-f171.google.com with SMTP id\n d2e1a72fcca58-68872ca740bso980153b3a.2\n for <dev@dpdk.org>; Fri, 18 Aug 2023 10:46:56 -0700 (PDT)", "from hermes.local (204-195-127-207.wavecable.com. [204.195.127.207])\n by smtp.gmail.com with ESMTPSA id\n u20-20020aa78394000000b0066a2e8431a0sm1804610pfm.183.2023.08.18.10.46.55\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Fri, 18 Aug 2023 10:46:55 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=networkplumber-org.20221208.gappssmtp.com; s=20221208; t=1692380816;\n x=1692985616;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=FXfHoITIXKtskf4Yk2sBcoNEbqQ0+cp/jvCbRjceZnw=;\n b=0djCmw4B5XE9X34aAYHFJzto9rCIXO+X84pk5Q4yRmJ2EuP8WNqkVlYdEHC/7YRbYY\n qTJi1aWnyD/r35v9Ks/Kl9nGFmVURbjOhTg9SfCQ3nhDFc35A6cSuQRRT28LJKF9G+3d\n 0iXkUudYGnygcPfjxbGXcA1v7hh+3efGQPs52f8TepfU8Rf22R2IAo4tfA3y4JiPg8tW\n HSGLVKzCym82SrlK0MTyzrsTuppdNQQJN8CN3wg5j7ZpTxXVuTPkX1MiwY3FPVoQAGWg\n TfactEedllbG9dhdJ4U58aS6fMBNgFFV42/qez4oiuvlSGCwjJWbejb4WsJJtzM8fcp5\n Bxcw==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20221208; t=1692380816; x=1692985616;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n :subject:date:message-id:reply-to;\n bh=FXfHoITIXKtskf4Yk2sBcoNEbqQ0+cp/jvCbRjceZnw=;\n b=EG66UElUnbRSXwoE+YSnBAJP2ElXNpVsXIDHeX8CJyhgI36H92tbGAW+kuuNPev7uc\n BSCnP7EOar+N6zgE3/9zmNtr7G54E9wax7GZU07nuu/vh6PgjipSThr3LTYtB2MSiYdr\n O3QD6bEzMs84AqXvm/PIko2nS9aSaKJ4pn5KGvfcEe8Qzj9S9xwGpX5s3glpAiuyDvlO\n gGek9ggoUmok5GbRBVPyKAWDSWbP479o4JFWSQoxXqQkRFe8YmRtuq+3AMOhM9xLj+qp\n SvBTRQYhBI3exq5nscXYftlwd4n6YAOC3dHnXGTq9gCMIQ0Ony/QRCUQ/1QtsAJTYh5c\n C9zQ==", "X-Gm-Message-State": "AOJu0YxXxjvN6DmN/T+msCI01Ub4bs2WrdmGbT0mKrWFmlZ+vpWdZlXA\n RSM5GJUHNY7lssVxESWF+2EBhTufWg/or7vb8j1kpA==", "X-Google-Smtp-Source": "\n AGHT+IHYel7vYUa+yeDjAJV013KFI1BQB52KHZ+WnuIqTnK5om575Bg3OrD067uo/XdTkcZEqdpQjg==", "X-Received": "by 2002:a05:6a00:1593:b0:687:5c3f:d834 with SMTP id\n u19-20020a056a00159300b006875c3fd834mr4495741pfk.11.1692380815763;\n Fri, 18 Aug 2023 10:46:55 -0700 (PDT)", "From": "Stephen Hemminger <stephen@networkplumber.org>", "To": "dev@dpdk.org", "Cc": "Stephen Hemminger <stephen@networkplumber.org>,\n Chandubabu Namburu <chandu@amd.com>", "Subject": "[PATCH v2 13/13] net/axgbe: replace word abort", "Date": "Fri, 18 Aug 2023 10:45:37 -0700", "Message-Id": "<20230818174537.290222-14-stephen@networkplumber.org>", "X-Mailer": "git-send-email 2.39.2", "In-Reply-To": "<20230818174537.290222-1-stephen@networkplumber.org>", "References": "<20230818025249.33994-1-stephen@networkplumber.org>\n <20230818174537.290222-1-stephen@networkplumber.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Use cancel instead of abort.\n\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\n---\n drivers/net/axgbe/axgbe_common.h | 4 ++--\n drivers/net/axgbe/axgbe_ethdev.h | 2 +-\n drivers/net/axgbe/axgbe_i2c.c | 26 +++++++++++++-------------\n 3 files changed, 16 insertions(+), 16 deletions(-)", "diff": "diff --git a/drivers/net/axgbe/axgbe_common.h b/drivers/net/axgbe/axgbe_common.h\nindex a5d11c583210..9180848f525c 100644\n--- a/drivers/net/axgbe/axgbe_common.h\n+++ b/drivers/net/axgbe/axgbe_common.h\n@@ -1123,8 +1123,8 @@\n #define IC_DATA_CMD_CMD_WIDTH\t\t\t1\n #define IC_DATA_CMD_STOP_INDEX\t\t\t9\n #define IC_DATA_CMD_STOP_WIDTH\t\t\t1\n-#define IC_ENABLE_ABORT_INDEX\t\t\t1\n-#define IC_ENABLE_ABORT_WIDTH\t\t\t1\n+#define IC_ENABLE_CANCEL_INDEX\t\t\t1\n+#define IC_ENABLE_CANCEL_WIDTH\t\t\t1\n #define IC_ENABLE_EN_INDEX\t\t\t0\n #define IC_ENABLE_EN_WIDTH\t\t\t1\n #define IC_ENABLE_STATUS_EN_INDEX\t\t0\ndiff --git a/drivers/net/axgbe/axgbe_ethdev.h b/drivers/net/axgbe/axgbe_ethdev.h\nindex 7f19321d881b..513b083c3b8b 100644\n--- a/drivers/net/axgbe/axgbe_ethdev.h\n+++ b/drivers/net/axgbe/axgbe_ethdev.h\n@@ -271,7 +271,7 @@ struct axgbe_i2c_op_state {\n \tunsigned int rx_len;\n \tunsigned char *rx_buf;\n \n-\tunsigned int tx_abort_source;\n+\tunsigned int tx_cancel_source;\n \n \tint ret;\n };\ndiff --git a/drivers/net/axgbe/axgbe_i2c.c b/drivers/net/axgbe/axgbe_i2c.c\nindex a2798f484e72..917867f60b27 100644\n--- a/drivers/net/axgbe/axgbe_i2c.c\n+++ b/drivers/net/axgbe/axgbe_i2c.c\n@@ -6,7 +6,7 @@\n #include \"axgbe_ethdev.h\"\n #include \"axgbe_common.h\"\n \n-#define AXGBE_ABORT_COUNT\t500\n+#define AXGBE_CANCEL_COUNT\t500\n #define AXGBE_DISABLE_COUNT\t1000\n \n #define AXGBE_STD_SPEED\t\t1\n@@ -23,18 +23,18 @@\n #define AXGBE_I2C_READ\t\tBIT(8)\n #define AXGBE_I2C_STOP\t\tBIT(9)\n \n-static int axgbe_i2c_abort(struct axgbe_port *pdata)\n+static int axgbe_i2c_cancel(struct axgbe_port *pdata)\n {\n-\tunsigned int wait = AXGBE_ABORT_COUNT;\n+\tunsigned int wait = AXGBE_CANCEL_COUNT;\n \n-\t/* Must be enabled to recognize the abort request */\n+\t/* Must be enabled to recognize the cancel request */\n \tXI2C_IOWRITE_BITS(pdata, IC_ENABLE, EN, 1);\n \n-\t/* Issue the abort */\n-\tXI2C_IOWRITE_BITS(pdata, IC_ENABLE, ABORT, 1);\n+\t/* Issue the cancel */\n+\tXI2C_IOWRITE_BITS(pdata, IC_ENABLE, CANCEL, 1);\n \n \twhile (wait--) {\n-\t\tif (!XI2C_IOREAD_BITS(pdata, IC_ENABLE, ABORT))\n+\t\tif (!XI2C_IOREAD_BITS(pdata, IC_ENABLE, CANCEL))\n \t\t\treturn 0;\n \t\trte_delay_us(500);\n \t}\n@@ -64,8 +64,8 @@ static int axgbe_i2c_disable(struct axgbe_port *pdata)\n \n \tret = axgbe_i2c_set_enable(pdata, false);\n \tif (ret) {\n-\t\t/* Disable failed, try an abort */\n-\t\tret = axgbe_i2c_abort(pdata);\n+\t\t/* Disable failed, try an cancel */\n+\t\tret = axgbe_i2c_cancel(pdata);\n \t\tif (ret)\n \t\t\treturn ret;\n \n@@ -147,7 +147,7 @@ static void axgbe_i2c_clear_isr_interrupts(struct axgbe_port *pdata,\n \tstruct axgbe_i2c_op_state *state = &pdata->i2c.op_state;\n \n \tif (isr & AXGBE_INTR_TX_ABRT) {\n-\t\tstate->tx_abort_source = XI2C_IOREAD(pdata, IC_TX_ABRT_SOURCE);\n+\t\tstate->tx_cancel_source = XI2C_IOREAD(pdata, IC_TX_ABRT_SOURCE);\n \t\tXI2C_IOREAD(pdata, IC_CLR_TX_ABRT);\n \t}\n \n@@ -169,7 +169,7 @@ static int axgbe_i2c_isr(struct axgbe_port *pdata)\n \tif (isr & AXGBE_INTR_TX_ABRT) {\n \t\tPMD_DRV_LOG(DEBUG,\n \t\t\t \"I2C TX_ABRT received (%#010x) for target %#04x\\n\",\n-\t\t\t state->tx_abort_source, state->op->target);\n+\t\t\t state->tx_cancel_source, state->op->target);\n \n \t\taxgbe_i2c_disable_interrupts(pdata);\n \n@@ -277,9 +277,9 @@ static int axgbe_i2c_xfer(struct axgbe_port *pdata, struct axgbe_i2c_op *op)\n success:\n \tret = state->ret;\n \tif (ret) {\n-\t\tif (state->tx_abort_source & IC_TX_ABRT_7B_ADDR_NOACK)\n+\t\tif (state->tx_cancel_source & IC_TX_ABRT_7B_ADDR_NOACK)\n \t\t\tret = -ENOTCONN;\n-\t\telse if (state->tx_abort_source & IC_TX_ABRT_ARB_LOST)\n+\t\telse if (state->tx_cancel_source & IC_TX_ABRT_ARB_LOST)\n \t\t\tret = -EAGAIN;\n \t}\n \n", "prefixes": [ "v2", "13/13" ] }