Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/130145/?format=api
{ "id": 130145, "url": "http://patches.dpdk.org/api/patches/130145/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20230811085805.441256-31-ndabilpuram@marvell.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20230811085805.441256-31-ndabilpuram@marvell.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20230811085805.441256-31-ndabilpuram@marvell.com", "date": "2023-08-11T08:58:05", "name": "[31/31] net/cnxk: fixes for IPv6 header in reassembly", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "e0a02a6aa9c39612525e11705ebf5be7297324a2", "submitter": { "id": 1202, "url": "http://patches.dpdk.org/api/people/1202/?format=api", "name": "Nithin Dabilpuram", "email": "ndabilpuram@marvell.com" }, "delegate": { "id": 310, "url": "http://patches.dpdk.org/api/users/310/?format=api", "username": "jerin", "first_name": "Jerin", "last_name": "Jacob", "email": "jerinj@marvell.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20230811085805.441256-31-ndabilpuram@marvell.com/mbox/", "series": [ { "id": 29177, "url": "http://patches.dpdk.org/api/series/29177/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=29177", "date": "2023-08-11T08:57:35", "name": "[01/31] common/cnxk: add aura ref count mechanism", "version": 1, "mbox": "http://patches.dpdk.org/series/29177/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/130145/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/130145/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 2C7CB43032;\n\tFri, 11 Aug 2023 11:01:18 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 61117432B7;\n\tFri, 11 Aug 2023 10:59:48 +0200 (CEST)", "from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com\n [67.231.148.174])\n by mails.dpdk.org (Postfix) with ESMTP id 58675432C1\n for <dev@dpdk.org>; Fri, 11 Aug 2023 10:59:46 +0200 (CEST)", "from pps.filterd (m0045849.ppops.net [127.0.0.1])\n by mx0a-0016f401.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id\n 37AMjx5m001610 for <dev@dpdk.org>; Fri, 11 Aug 2023 01:59:45 -0700", "from dc5-exch02.marvell.com ([199.233.59.182])\n by mx0a-0016f401.pphosted.com (PPS) with ESMTPS id 3sd8yp9red-1\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT)\n for <dev@dpdk.org>; Fri, 11 Aug 2023 01:59:45 -0700", "from DC5-EXCH01.marvell.com (10.69.176.38) by DC5-EXCH02.marvell.com\n (10.69.176.39) with Microsoft SMTP Server (TLS) id 15.0.1497.48;\n Fri, 11 Aug 2023 01:59:43 -0700", "from maili.marvell.com (10.69.176.80) by DC5-EXCH01.marvell.com\n (10.69.176.38) with Microsoft SMTP Server id 15.0.1497.48 via Frontend\n Transport; Fri, 11 Aug 2023 01:59:43 -0700", "from hyd1588t430.caveonetworks.com (unknown [10.29.52.204])\n by maili.marvell.com (Postfix) with ESMTP id 522903F706B;\n Fri, 11 Aug 2023 01:59:41 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com;\n h=from : to : cc :\n subject : date : message-id : in-reply-to : references : mime-version :\n content-transfer-encoding : content-type; s=pfpt0220;\n bh=d86/S0LfLPzGWVOnHmErn2YHzyxWVkUsweLOfFW1CjA=;\n b=fu6DSfskCvMNA+C5APwyrmikz5DzuB9qzTNhX91tSse2cZs3+UNtDwpKH30LckpMttRO\n +x69A94XJxI+wdJU9p0ng5CjhIz58/uw+NJ2G9IiPJY19HErSvtdeLUvg/3m9Fan7m3Z\n FeXj2YFcPXqxKPAns3nbXh3AD1qbJ+5fEhUGXVWZywE3SiKHwXkrXxo1NDa9dJcVEVM7\n ginFNjSRatQvOePB4JGrRD5oiV1sKd9hkcdLH007Oj4KdUhch5a9jaRUebpKkQCElrKQ\n LvXUFpPAaerWSPw7B9/HaTmI3T6XCpp8AILyHcwxcsEQg/FqsFnRQ8czs4PkpQwoRjnH JQ==", "From": "Nithin Dabilpuram <ndabilpuram@marvell.com>", "To": "Nithin Dabilpuram <ndabilpuram@marvell.com>, Kiran Kumar K\n <kirankumark@marvell.com>, Sunil Kumar Kori <skori@marvell.com>, Satha Rao\n <skoteshwar@marvell.com>", "CC": "<jerinj@marvell.com>, <dev@dpdk.org>, Rahul Bhansali\n <rbhansali@marvell.com>", "Subject": "[PATCH 31/31] net/cnxk: fixes for IPv6 header in reassembly", "Date": "Fri, 11 Aug 2023 14:28:05 +0530", "Message-ID": "<20230811085805.441256-31-ndabilpuram@marvell.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20230811085805.441256-1-ndabilpuram@marvell.com>", "References": "<20230811085805.441256-1-ndabilpuram@marvell.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Proofpoint-ORIG-GUID": "Ojjcr1NNWNSfjjWoO3BJmsD6xA1TayDU", "X-Proofpoint-GUID": "Ojjcr1NNWNSfjjWoO3BJmsD6xA1TayDU", "X-Proofpoint-Virus-Version": "vendor=baseguard\n engine=ICAP:2.0.267,Aquarius:18.0.957,Hydra:6.0.591,FMLib:17.11.176.26\n definitions=2023-08-10_20,2023-08-10_01,2023-05-22_02", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "From: Rahul Bhansali <rbhansali@marvell.com>\n\nIn reassembly path, next header field in IPv6 header is not\nupdated correctly, hence reassembled packet is corrupted.\nThis fix will consider IPv6 fragment header presence at start/mid/end in\nextension list and update the next header field accordingly.\n\nFixes: ec28231ed260 (\"net/cnxk: support reassembly of multi-segment packets\")\n\nSigned-off-by: Rahul Bhansali <rbhansali@marvell.com>\n---\n drivers/net/cnxk/cn10k_rx.h | 12 +++++++++++-\n 1 file changed, 11 insertions(+), 1 deletion(-)", "diff": "diff --git a/drivers/net/cnxk/cn10k_rx.h b/drivers/net/cnxk/cn10k_rx.h\nindex 982fd26045..41d11349fd 100644\n--- a/drivers/net/cnxk/cn10k_rx.h\n+++ b/drivers/net/cnxk/cn10k_rx.h\n@@ -205,26 +205,36 @@ nix_sec_reass_first_frag_update(struct rte_mbuf *head, const uint8_t *m_ipptr,\n \t\tstruct rte_ipv6_hdr *hdr = (struct rte_ipv6_hdr *)ipptr;\n \t\tsize_t ext_len = sizeof(struct rte_ipv6_hdr);\n \t\tuint8_t *nxt_hdr = (uint8_t *)hdr;\n+\t\tuint8_t *nxt_proto = &hdr->proto;\n \t\tint nh = hdr->proto;\n \n \t\t*ihl = 0;\n+\t\ttot_len = 0;\n \t\twhile (nh != -EINVAL) {\n \t\t\tnxt_hdr += ext_len;\n \t\t\t*ihl += ext_len;\n+\t\t\tif (nh == IPPROTO_FRAGMENT) {\n+\t\t\t\t*nxt_proto = *nxt_hdr;\n+\t\t\t\ttot_len = *ihl;\n+\t\t\t}\n \t\t\tnh = rte_ipv6_get_next_ext(nxt_hdr, nh, &ext_len);\n+\t\t\tnxt_proto = nxt_hdr;\n \t\t}\n \n \t\t/* Remove the frag header by moving header 8 bytes forward */\n \t\thdr->payload_len = rte_cpu_to_be_16(fragx_sum + *ihl -\n \t\t\t\t\t8 - sizeof(struct rte_ipv6_hdr));\n \n+\t\t/* tot_len is sum of all IP header's length before fragment header */\n \t\trte_memcpy(rte_pktmbuf_mtod_offset(head, void *, 8),\n \t\t\t rte_pktmbuf_mtod(head, void *),\n-\t\t\t lcptr + sizeof(struct rte_ipv6_hdr));\n+\t\t\t lcptr + tot_len);\n \n \t\thead->data_len -= 8;\n \t\thead->data_off += 8;\n \t\thead->pkt_len = lcptr + *ihl - 8 + fragx_sum;\n+\t\t/* ihl l3hdr size value should be up to fragment header for next frags */\n+\t\t*ihl = tot_len + 8;\n \t}\n }\n \n", "prefixes": [ "31/31" ] }