Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/130140/?format=api
{ "id": 130140, "url": "http://patches.dpdk.org/api/patches/130140/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20230811085805.441256-24-ndabilpuram@marvell.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20230811085805.441256-24-ndabilpuram@marvell.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20230811085805.441256-24-ndabilpuram@marvell.com", "date": "2023-08-11T08:57:58", "name": "[24/31] net/cnxk: move MAC address set from init to configure", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "65e2d2e08ef3a5c5641bf87b7352a99ddb26cfbb", "submitter": { "id": 1202, "url": "http://patches.dpdk.org/api/people/1202/?format=api", "name": "Nithin Dabilpuram", "email": "ndabilpuram@marvell.com" }, "delegate": { "id": 310, "url": "http://patches.dpdk.org/api/users/310/?format=api", "username": "jerin", "first_name": "Jerin", "last_name": "Jacob", "email": "jerinj@marvell.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20230811085805.441256-24-ndabilpuram@marvell.com/mbox/", "series": [ { "id": 29177, "url": "http://patches.dpdk.org/api/series/29177/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=29177", "date": "2023-08-11T08:57:35", "name": "[01/31] common/cnxk: add aura ref count mechanism", "version": 1, "mbox": "http://patches.dpdk.org/series/29177/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/130140/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/130140/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 73FF543032;\n\tFri, 11 Aug 2023 11:00:48 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id B0CE043284;\n\tFri, 11 Aug 2023 10:59:40 +0200 (CEST)", "from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com\n [67.231.156.173])\n by mails.dpdk.org (Postfix) with ESMTP id F1E6743247\n for <dev@dpdk.org>; Fri, 11 Aug 2023 10:59:37 +0200 (CEST)", "from pps.filterd (m0045851.ppops.net [127.0.0.1])\n by mx0b-0016f401.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id\n 37AN2WV9011282 for <dev@dpdk.org>; Fri, 11 Aug 2023 01:59:37 -0700", "from dc5-exch01.marvell.com ([199.233.59.181])\n by mx0b-0016f401.pphosted.com (PPS) with ESMTPS id 3sd8ya1gcd-1\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT)\n for <dev@dpdk.org>; Fri, 11 Aug 2023 01:59:37 -0700", "from DC5-EXCH02.marvell.com (10.69.176.39) by DC5-EXCH01.marvell.com\n (10.69.176.38) with Microsoft SMTP Server (TLS) id 15.0.1497.48;\n Fri, 11 Aug 2023 01:59:21 -0700", "from maili.marvell.com (10.69.176.80) by DC5-EXCH02.marvell.com\n (10.69.176.39) with Microsoft SMTP Server id 15.0.1497.48 via Frontend\n Transport; Fri, 11 Aug 2023 01:59:21 -0700", "from hyd1588t430.caveonetworks.com (unknown [10.29.52.204])\n by maili.marvell.com (Postfix) with ESMTP id 40F3A3F706A;\n Fri, 11 Aug 2023 01:59:18 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com;\n h=from : to : cc :\n subject : date : message-id : in-reply-to : references : mime-version :\n content-transfer-encoding : content-type; s=pfpt0220;\n bh=Eky7WpAHJeLiR91Ny8NQy6sCDTuzQQJPjEyifHXf6Q8=;\n b=ecws5sQGke6muuXWON0/9kieTDfV3qkzqyDY1YERvcv0omVi0PCuQK1tTarEGQbC3LLK\n KU01ZMTBWsNAjXqZAwgTNCj3+UpPj2GOzZqUrpbT8XqY8eGs6F9NLUqn3xIVJDZHBcWE\n pOQPMq+9dakiPZNDBLhge9n2GuShfqgQO0KnWFVqrVN4cw9JmPT9uXlj5PEKT5D0BKJG\n HaS/PVs7VEAqRcdyEOWWZmqLMNuuAgflXwBMDCDHjTtMdX5NRb77S12yItaHs2mRYES0\n N2WS2oT08aAaaas8diNPvJsoRbUFTETcU3WCCcM8WRd0AmMyTiDlz383YtiBK31zx2Zu Yw==", "From": "Nithin Dabilpuram <ndabilpuram@marvell.com>", "To": "Nithin Dabilpuram <ndabilpuram@marvell.com>, Kiran Kumar K\n <kirankumark@marvell.com>, Sunil Kumar Kori <skori@marvell.com>, Satha Rao\n <skoteshwar@marvell.com>", "CC": "<jerinj@marvell.com>, <dev@dpdk.org>, Srujana Challa <schalla@marvell.com>", "Subject": "[PATCH 24/31] net/cnxk: move MAC address set from init to configure", "Date": "Fri, 11 Aug 2023 14:27:58 +0530", "Message-ID": "<20230811085805.441256-24-ndabilpuram@marvell.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20230811085805.441256-1-ndabilpuram@marvell.com>", "References": "<20230811085805.441256-1-ndabilpuram@marvell.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Proofpoint-ORIG-GUID": "ldTtkrEqlAoa08zVbuPgRazDLHkYjVfi", "X-Proofpoint-GUID": "ldTtkrEqlAoa08zVbuPgRazDLHkYjVfi", "X-Proofpoint-Virus-Version": "vendor=baseguard\n engine=ICAP:2.0.267,Aquarius:18.0.957,Hydra:6.0.591,FMLib:17.11.176.26\n definitions=2023-08-10_20,2023-08-10_01,2023-05-22_02", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "From: Srujana Challa <schalla@marvell.com>\n\nChannel(rx_chan_base) is not available in the kernel at\nthe time of nix probe. Hence, move the mac address set\ncall from nix_device_init() to nix_device_configure().\nThis fixes the issue on cn10kb, where traffic was not\ngetting received when promisc is disabled.\n\nSigned-off-by: Srujana Challa <schalla@marvell.com>\n---\n drivers/net/cnxk/cnxk_ethdev.c | 18 +++++++++---------\n 1 file changed, 9 insertions(+), 9 deletions(-)", "diff": "diff --git a/drivers/net/cnxk/cnxk_ethdev.c b/drivers/net/cnxk/cnxk_ethdev.c\nindex bd161ad375..3b2ad5ff7d 100644\n--- a/drivers/net/cnxk/cnxk_ethdev.c\n+++ b/drivers/net/cnxk/cnxk_ethdev.c\n@@ -1301,6 +1301,15 @@ cnxk_nix_configure(struct rte_eth_dev *eth_dev)\n \t\tgoto fail_configure;\n \t}\n \n+\tif (!roc_nix_is_vf_or_sdp(nix)) {\n+\t\t/* Sync same MAC address to CGX/RPM table */\n+\t\trc = roc_nix_mac_addr_set(nix, dev->mac_addr);\n+\t\tif (rc) {\n+\t\t\tplt_err(\"Failed to set mac addr, rc=%d\", rc);\n+\t\t\tgoto fail_configure;\n+\t\t}\n+\t}\n+\n \t/* Check if ptp is enable in PF owning this VF*/\n \tif (!roc_nix_is_pf(nix) && (!roc_nix_is_sdp(nix)))\n \t\tdev->ptp_en = roc_nix_ptp_is_enable(nix);\n@@ -1941,15 +1950,6 @@ cnxk_eth_dev_init(struct rte_eth_dev *eth_dev)\n \t/* Update the mac address */\n \tmemcpy(eth_dev->data->mac_addrs, dev->mac_addr, RTE_ETHER_ADDR_LEN);\n \n-\tif (!roc_nix_is_vf_or_sdp(nix)) {\n-\t\t/* Sync same MAC address to CGX/RPM table */\n-\t\trc = roc_nix_mac_addr_set(nix, dev->mac_addr);\n-\t\tif (rc) {\n-\t\t\tplt_err(\"Failed to set mac addr, rc=%d\", rc);\n-\t\t\tgoto free_mac_addrs;\n-\t\t}\n-\t}\n-\n \t/* Union of all capabilities supported by CNXK.\n \t * Platform specific capabilities will be\n \t * updated later.\n", "prefixes": [ "24/31" ] }