Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/130134/?format=api
{ "id": 130134, "url": "http://patches.dpdk.org/api/patches/130134/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20230811085805.441256-20-ndabilpuram@marvell.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20230811085805.441256-20-ndabilpuram@marvell.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20230811085805.441256-20-ndabilpuram@marvell.com", "date": "2023-08-11T08:57:54", "name": "[20/31] net/cnxk: fix CQ allocation", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "94b47bb681e8483d775c1824f276f365c51c1084", "submitter": { "id": 1202, "url": "http://patches.dpdk.org/api/people/1202/?format=api", "name": "Nithin Dabilpuram", "email": "ndabilpuram@marvell.com" }, "delegate": { "id": 310, "url": "http://patches.dpdk.org/api/users/310/?format=api", "username": "jerin", "first_name": "Jerin", "last_name": "Jacob", "email": "jerinj@marvell.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20230811085805.441256-20-ndabilpuram@marvell.com/mbox/", "series": [ { "id": 29177, "url": "http://patches.dpdk.org/api/series/29177/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=29177", "date": "2023-08-11T08:57:35", "name": "[01/31] common/cnxk: add aura ref count mechanism", "version": 1, "mbox": "http://patches.dpdk.org/series/29177/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/130134/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/130134/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 8E76843032;\n\tFri, 11 Aug 2023 11:00:11 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 5195643296;\n\tFri, 11 Aug 2023 10:59:13 +0200 (CEST)", "from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com\n [67.231.148.174])\n by mails.dpdk.org (Postfix) with ESMTP id 4C67943273\n for <dev@dpdk.org>; Fri, 11 Aug 2023 10:59:12 +0200 (CEST)", "from pps.filterd (m0045849.ppops.net [127.0.0.1])\n by mx0a-0016f401.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id\n 37AMjx5e001610 for <dev@dpdk.org>; Fri, 11 Aug 2023 01:59:11 -0700", "from dc5-exch02.marvell.com ([199.233.59.182])\n by mx0a-0016f401.pphosted.com (PPS) with ESMTPS id 3sd8yp9rab-1\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT)\n for <dev@dpdk.org>; Fri, 11 Aug 2023 01:59:11 -0700", "from DC5-EXCH01.marvell.com (10.69.176.38) by DC5-EXCH02.marvell.com\n (10.69.176.39) with Microsoft SMTP Server (TLS) id 15.0.1497.48;\n Fri, 11 Aug 2023 01:59:09 -0700", "from maili.marvell.com (10.69.176.80) by DC5-EXCH01.marvell.com\n (10.69.176.38) with Microsoft SMTP Server id 15.0.1497.48 via Frontend\n Transport; Fri, 11 Aug 2023 01:59:09 -0700", "from hyd1588t430.caveonetworks.com (unknown [10.29.52.204])\n by maili.marvell.com (Postfix) with ESMTP id 4752F3F706A;\n Fri, 11 Aug 2023 01:59:07 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com;\n h=from : to : cc :\n subject : date : message-id : in-reply-to : references : mime-version :\n content-transfer-encoding : content-type; s=pfpt0220;\n bh=OLgRfEdjQ6y7bRjd5iHVG4Wte1g7joYmyT9Y3UoQ3oM=;\n b=ct2DkV1qGibDD6wCWXMXQu9ud/lW9Q21LuSvZ72t63tRANBNA95ih8mdH1ERr+KS26xU\n 8niJ5xvsq6jAK1XzYMRO8Zg/QO1dW7JN/VsMumLkDNxtqjZYcEANI5tIZr6Bhlx52zOS\n +gm/Sd27g3DqjaKjzwfSRiB4NkHctmhox7JAe637mejC5P0A1Soj4szY6pYao7eBd8sD\n y9rh98swpKwXuUTus5Rl3NOtUxEg38P67oSqw8+iidgXMDh8/Gieu7L+HI9b3YkBCvNg\n rGZtzXOosxRA5Mw8tQ5Ih3mvrn13K/IjzZB7pK+ANfROE/cjtg6affnNoyMF+Ni9v0MC ZA==", "From": "Nithin Dabilpuram <ndabilpuram@marvell.com>", "To": "Nithin Dabilpuram <ndabilpuram@marvell.com>, Kiran Kumar K\n <kirankumark@marvell.com>, Sunil Kumar Kori <skori@marvell.com>, Satha Rao\n <skoteshwar@marvell.com>", "CC": "<jerinj@marvell.com>, <dev@dpdk.org>, <rkudurumalla@marvell.com>", "Subject": "[PATCH 20/31] net/cnxk: fix CQ allocation", "Date": "Fri, 11 Aug 2023 14:27:54 +0530", "Message-ID": "<20230811085805.441256-20-ndabilpuram@marvell.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20230811085805.441256-1-ndabilpuram@marvell.com>", "References": "<20230811085805.441256-1-ndabilpuram@marvell.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Proofpoint-ORIG-GUID": "KeyMc6zpXdIAgPanxAXr-n4C9tjEis0i", "X-Proofpoint-GUID": "KeyMc6zpXdIAgPanxAXr-n4C9tjEis0i", "X-Proofpoint-Virus-Version": "vendor=baseguard\n engine=ICAP:2.0.267,Aquarius:18.0.957,Hydra:6.0.591,FMLib:17.11.176.26\n definitions=2023-08-10_20,2023-08-10_01,2023-05-22_02", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "From: Satha Rao <skoteshwar@marvell.com>\n\nAllocate number of CQs sufficient to handle completions of both\nRQs and SQs.\n\nFixes: dd9446991212 (\"net/cnxk: add transmit completion handler\")\nCc: rkudurumalla@marvell.com\n\nSigned-off-by: Satha Rao <skoteshwar@marvell.com>\n---\n drivers/net/cnxk/cnxk_ethdev.c | 26 +++++++++++---------------\n 1 file changed, 11 insertions(+), 15 deletions(-)", "diff": "diff --git a/drivers/net/cnxk/cnxk_ethdev.c b/drivers/net/cnxk/cnxk_ethdev.c\nindex 4b98faa729..46450088eb 100644\n--- a/drivers/net/cnxk/cnxk_ethdev.c\n+++ b/drivers/net/cnxk/cnxk_ethdev.c\n@@ -1197,8 +1197,8 @@ cnxk_nix_configure(struct rte_eth_dev *eth_dev)\n \tchar ea_fmt[RTE_ETHER_ADDR_FMT_SIZE];\n \tstruct roc_nix_fc_cfg fc_cfg = {0};\n \tstruct roc_nix *nix = &dev->nix;\n+\tuint16_t nb_rxq, nb_txq, nb_cq;\n \tstruct rte_ether_addr *ea;\n-\tuint16_t nb_rxq, nb_txq;\n \tuint64_t rx_cfg;\n \tvoid *qs;\n \tint rc;\n@@ -1309,6 +1309,9 @@ cnxk_nix_configure(struct rte_eth_dev *eth_dev)\n \n \tnb_rxq = data->nb_rx_queues;\n \tnb_txq = data->nb_tx_queues;\n+\tnb_cq = nb_rxq;\n+\tif (nix->tx_compl_ena)\n+\t\tnb_cq += nb_txq;\n \trc = -ENOMEM;\n \tif (nb_rxq) {\n \t\t/* Allocate memory for roc rq's and cq's */\n@@ -1318,13 +1321,6 @@ cnxk_nix_configure(struct rte_eth_dev *eth_dev)\n \t\t\tgoto free_nix_lf;\n \t\t}\n \t\tdev->rqs = qs;\n-\n-\t\tqs = plt_zmalloc(sizeof(struct roc_nix_cq) * nb_rxq, 0);\n-\t\tif (!qs) {\n-\t\t\tplt_err(\"Failed to alloc cqs\");\n-\t\t\tgoto free_nix_lf;\n-\t\t}\n-\t\tdev->cqs = qs;\n \t}\n \n \tif (nb_txq) {\n@@ -1335,15 +1331,15 @@ cnxk_nix_configure(struct rte_eth_dev *eth_dev)\n \t\t\tgoto free_nix_lf;\n \t\t}\n \t\tdev->sqs = qs;\n+\t}\n \n-\t\tif (nix->tx_compl_ena) {\n-\t\t\tqs = plt_zmalloc(sizeof(struct roc_nix_cq) * nb_txq, 0);\n-\t\t\tif (!qs) {\n-\t\t\t\tplt_err(\"Failed to alloc cqs\");\n-\t\t\t\tgoto free_nix_lf;\n-\t\t\t}\n-\t\t\tdev->cqs = qs;\n+\tif (nb_cq) {\n+\t\tqs = plt_zmalloc(sizeof(struct roc_nix_cq) * nb_cq, 0);\n+\t\tif (!qs) {\n+\t\t\tplt_err(\"Failed to alloc cqs\");\n+\t\t\tgoto free_nix_lf;\n \t\t}\n+\t\tdev->cqs = qs;\n \t}\n \n \t/* Re-enable NIX LF error interrupts */\n", "prefixes": [ "20/31" ] }