Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/130129/?format=api
{ "id": 130129, "url": "http://patches.dpdk.org/api/patches/130129/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20230811085805.441256-15-ndabilpuram@marvell.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20230811085805.441256-15-ndabilpuram@marvell.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20230811085805.441256-15-ndabilpuram@marvell.com", "date": "2023-08-11T08:57:49", "name": "[15/31] common/cnxk: fix BP threshold calculation", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "fa3dce67ef831d09bdca7e05793f1c0ad9b4f7f6", "submitter": { "id": 1202, "url": "http://patches.dpdk.org/api/people/1202/?format=api", "name": "Nithin Dabilpuram", "email": "ndabilpuram@marvell.com" }, "delegate": { "id": 310, "url": "http://patches.dpdk.org/api/users/310/?format=api", "username": "jerin", "first_name": "Jerin", "last_name": "Jacob", "email": "jerinj@marvell.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20230811085805.441256-15-ndabilpuram@marvell.com/mbox/", "series": [ { "id": 29177, "url": "http://patches.dpdk.org/api/series/29177/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=29177", "date": "2023-08-11T08:57:35", "name": "[01/31] common/cnxk: add aura ref count mechanism", "version": 1, "mbox": "http://patches.dpdk.org/series/29177/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/130129/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/130129/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id D13D743032;\n\tFri, 11 Aug 2023 10:59:41 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 2B61843262;\n\tFri, 11 Aug 2023 10:58:58 +0200 (CEST)", "from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com\n [67.231.148.174])\n by mails.dpdk.org (Postfix) with ESMTP id CABB143262\n for <dev@dpdk.org>; Fri, 11 Aug 2023 10:58:56 +0200 (CEST)", "from pps.filterd (m0045849.ppops.net [127.0.0.1])\n by mx0a-0016f401.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id\n 37AMkJKc002877 for <dev@dpdk.org>; Fri, 11 Aug 2023 01:58:56 -0700", "from dc5-exch02.marvell.com ([199.233.59.182])\n by mx0a-0016f401.pphosted.com (PPS) with ESMTPS id 3sd8yp9r95-1\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT)\n for <dev@dpdk.org>; Fri, 11 Aug 2023 01:58:55 -0700", "from DC5-EXCH02.marvell.com (10.69.176.39) by DC5-EXCH02.marvell.com\n (10.69.176.39) with Microsoft SMTP Server (TLS) id 15.0.1497.48;\n Fri, 11 Aug 2023 01:58:54 -0700", "from maili.marvell.com (10.69.176.80) by DC5-EXCH02.marvell.com\n (10.69.176.39) with Microsoft SMTP Server id 15.0.1497.48 via Frontend\n Transport; Fri, 11 Aug 2023 01:58:54 -0700", "from hyd1588t430.caveonetworks.com (unknown [10.29.52.204])\n by maili.marvell.com (Postfix) with ESMTP id 1A53E3F706B;\n Fri, 11 Aug 2023 01:58:51 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com;\n h=from : to : cc :\n subject : date : message-id : in-reply-to : references : mime-version :\n content-transfer-encoding : content-type; s=pfpt0220;\n bh=gtgk2wzWhFaX7PqYEi7VD77kBnpJidsDn5+PDdiE8+I=;\n b=EyZrrVnua4CYAhontSAuNz5TDg25xNBkyB6RZV0dfW7LRzwcIOMvJgoY7/VQXYIWtyK9\n fgjrB4u+tY23H7JYanyuvsXK3TpnhVxmBBqn2kZFTSgbny0wGK+WKjJUOMOqcbvIxlQ7\n ZBKVuQP/F937yyGkBbJrkTQrbzODKnW7/wfRdTfqEfqyTrhKma8RGodnuYw2EvmQBFFv\n BCVw0l/RqNTkUwiogm5OxmwgPKwGHHfVDLJFXKFuhjGPpr1klPzKj5guaoASE/bVUc5S\n lFe+cIuqF7Mj0NJetFe+Y0thhycD3KPWaHGNyq1JRNcvhsfVPCm+mEfuxr2JUz3C1CLg xQ==", "From": "Nithin Dabilpuram <ndabilpuram@marvell.com>", "To": "Nithin Dabilpuram <ndabilpuram@marvell.com>, Kiran Kumar K\n <kirankumark@marvell.com>, Sunil Kumar Kori <skori@marvell.com>, Satha Rao\n <skoteshwar@marvell.com>", "CC": "<jerinj@marvell.com>, <dev@dpdk.org>", "Subject": "[PATCH 15/31] common/cnxk: fix BP threshold calculation", "Date": "Fri, 11 Aug 2023 14:27:49 +0530", "Message-ID": "<20230811085805.441256-15-ndabilpuram@marvell.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20230811085805.441256-1-ndabilpuram@marvell.com>", "References": "<20230811085805.441256-1-ndabilpuram@marvell.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Proofpoint-ORIG-GUID": "5yUG4ojwWWu2G0dDygj5oiBapaOtv4q2", "X-Proofpoint-GUID": "5yUG4ojwWWu2G0dDygj5oiBapaOtv4q2", "X-Proofpoint-Virus-Version": "vendor=baseguard\n engine=ICAP:2.0.267,Aquarius:18.0.957,Hydra:6.0.591,FMLib:17.11.176.26\n definitions=2023-08-10_20,2023-08-10_01,2023-05-22_02", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "From: Sunil Kumar Kori <skori@marvell.com>\n\nCurrent macro to calculate BP threshold were evaluating incorrect\nthreshold because aura_limit is first shifted by shift then percentage\nis calculated.\n\nWhile first percentage should be calculated and the resultant should be\nshifted by shift.\n\nSo formula is updated accordingly.\n\nFixes: cb4bfd6e7bdf (\"event/cnxk: support Rx adapter\")\n\nSigned-off-by: Sunil Kumar Kori <skori@marvell.com>\n---\n drivers/common/cnxk/roc_nix_fc.c | 2 +-\n drivers/common/cnxk/roc_nix_priv.h | 2 +-\n 2 files changed, 2 insertions(+), 2 deletions(-)", "diff": "diff --git a/drivers/common/cnxk/roc_nix_fc.c b/drivers/common/cnxk/roc_nix_fc.c\nindex d58b35268e..0f9b5cbbc0 100644\n--- a/drivers/common/cnxk/roc_nix_fc.c\n+++ b/drivers/common/cnxk/roc_nix_fc.c\n@@ -496,7 +496,7 @@ roc_nix_fc_npa_bp_cfg(struct roc_nix *roc_nix, uint64_t pool_id, uint8_t ena, ui\n \taura_attr = &lf->aura_attr[aura_id];\n \n \tbp_intf = 1 << nix->is_nix1;\n-\tbp_thresh = NIX_RQ_AURA_THRESH(drop_percent, aura_attr->limit >> aura_attr->shift);\n+\tbp_thresh = NIX_RQ_AURA_BP_THRESH(drop_percent, aura_attr->limit, aura_attr->shift);\n \n \tbpid = (aura_attr->bp_ena & 0x1) ? aura_attr->nix0_bpid : aura_attr->nix1_bpid;\n \t/* BP is already enabled. */\ndiff --git a/drivers/common/cnxk/roc_nix_priv.h b/drivers/common/cnxk/roc_nix_priv.h\nindex f82e411b70..a582b9df33 100644\n--- a/drivers/common/cnxk/roc_nix_priv.h\n+++ b/drivers/common/cnxk/roc_nix_priv.h\n@@ -20,7 +20,7 @@\n /* Apply LBP at 75% of actual BP */\n #define NIX_CQ_LPB_THRESH_FRAC\t(75 * 16 / 100)\n #define NIX_CQ_FULL_ERRATA_SKID (1024ull * 256)\n-#define NIX_RQ_AURA_THRESH(percent, val) (((val) * (percent)) / 100)\n+#define NIX_RQ_AURA_BP_THRESH(percent, limit, shift) ((((limit) * (percent)) / 100) >> (shift))\n \n /* IRQ triggered when NIX_LF_CINTX_CNT[QCOUNT] crosses this value */\n #define CQ_CQE_THRESH_DEFAULT\t0x1ULL\n", "prefixes": [ "15/31" ] }