Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 130123,
    "url": "http://patches.dpdk.org/api/patches/130123/?format=api",
    "web_url": "http://patches.dpdk.org/project/dpdk/patch/20230811085805.441256-9-ndabilpuram@marvell.com/",
    "project": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<20230811085805.441256-9-ndabilpuram@marvell.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/20230811085805.441256-9-ndabilpuram@marvell.com",
    "date": "2023-08-11T08:57:43",
    "name": "[09/31] common/cnxk: fix leak in error path",
    "commit_ref": null,
    "pull_url": null,
    "state": "accepted",
    "archived": true,
    "hash": "29d76b50acf987d8b0781d9ab1f937840faa7e98",
    "submitter": {
        "id": 1202,
        "url": "http://patches.dpdk.org/api/people/1202/?format=api",
        "name": "Nithin Dabilpuram",
        "email": "ndabilpuram@marvell.com"
    },
    "delegate": {
        "id": 310,
        "url": "http://patches.dpdk.org/api/users/310/?format=api",
        "username": "jerin",
        "first_name": "Jerin",
        "last_name": "Jacob",
        "email": "jerinj@marvell.com"
    },
    "mbox": "http://patches.dpdk.org/project/dpdk/patch/20230811085805.441256-9-ndabilpuram@marvell.com/mbox/",
    "series": [
        {
            "id": 29177,
            "url": "http://patches.dpdk.org/api/series/29177/?format=api",
            "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=29177",
            "date": "2023-08-11T08:57:35",
            "name": "[01/31] common/cnxk: add aura ref count mechanism",
            "version": 1,
            "mbox": "http://patches.dpdk.org/series/29177/mbox/"
        }
    ],
    "comments": "http://patches.dpdk.org/api/patches/130123/comments/",
    "check": "success",
    "checks": "http://patches.dpdk.org/api/patches/130123/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@inbox.dpdk.org",
        "Delivered-To": "patchwork@inbox.dpdk.org",
        "Received": [
            "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id A3EB843032;\n\tFri, 11 Aug 2023 10:59:04 +0200 (CEST)",
            "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 443184327B;\n\tFri, 11 Aug 2023 10:58:40 +0200 (CEST)",
            "from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com\n [67.231.156.173])\n by mails.dpdk.org (Postfix) with ESMTP id 013B840E03\n for <dev@dpdk.org>; Fri, 11 Aug 2023 10:58:37 +0200 (CEST)",
            "from pps.filterd (m0045851.ppops.net [127.0.0.1])\n by mx0b-0016f401.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id\n 37AMj86q014471 for <dev@dpdk.org>; Fri, 11 Aug 2023 01:58:37 -0700",
            "from dc5-exch01.marvell.com ([199.233.59.181])\n by mx0b-0016f401.pphosted.com (PPS) with ESMTPS id 3sd8ya1g8h-1\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT)\n for <dev@dpdk.org>; Fri, 11 Aug 2023 01:58:37 -0700",
            "from DC5-EXCH02.marvell.com (10.69.176.39) by DC5-EXCH01.marvell.com\n (10.69.176.38) with Microsoft SMTP Server (TLS) id 15.0.1497.48;\n Fri, 11 Aug 2023 01:58:35 -0700",
            "from maili.marvell.com (10.69.176.80) by DC5-EXCH02.marvell.com\n (10.69.176.39) with Microsoft SMTP Server id 15.0.1497.48 via Frontend\n Transport; Fri, 11 Aug 2023 01:58:35 -0700",
            "from hyd1588t430.caveonetworks.com (unknown [10.29.52.204])\n by maili.marvell.com (Postfix) with ESMTP id C45523F706D;\n Fri, 11 Aug 2023 01:58:32 -0700 (PDT)"
        ],
        "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com;\n h=from : to : cc :\n subject : date : message-id : in-reply-to : references : mime-version :\n content-transfer-encoding : content-type; s=pfpt0220;\n bh=oXmOCeLD2zAZBXG7ac1k2xO2G9xDyMVFsIqqmJonwTs=;\n b=V4VPalwzEhiLAaLzqIOXprzWMR69gSYc2/g9FSGicwJcLHqARGUwBJp1nUjk88L51rnO\n MgUb7pSXpmr9L02cFkRnVzmzHy8OXCxzpNj0eAGNU/Ry8iQqWTKN//PlDETtnvbAARqs\n 3XHHI0L24Jw9ROnn8EVCrSOxtNnVIGWrw52XdZeNc4tTBLptdnVCede69Q4d3E4GnvtN\n njgAdiEMXPeZyOLMt9kuBwg3TlKYsQ/ScBAd7JixzZaZRKMMi4LkoU14A+DC/3Lii1dC\n YU8CGCAW4OtG+mYVZoJYqXxCplOMuwpe2oyz2+SHcBY+Ti89Rgs7OeswgJqjIgV9byWn 7A==",
        "From": "Nithin Dabilpuram <ndabilpuram@marvell.com>",
        "To": "Nithin Dabilpuram <ndabilpuram@marvell.com>, Kiran Kumar K\n <kirankumark@marvell.com>, Sunil Kumar Kori <skori@marvell.com>, Satha Rao\n <skoteshwar@marvell.com>",
        "CC": "<jerinj@marvell.com>, <dev@dpdk.org>, Akhil Goyal <gakhil@marvell.com>",
        "Subject": "[PATCH 09/31] common/cnxk: fix leak in error path",
        "Date": "Fri, 11 Aug 2023 14:27:43 +0530",
        "Message-ID": "<20230811085805.441256-9-ndabilpuram@marvell.com>",
        "X-Mailer": "git-send-email 2.25.1",
        "In-Reply-To": "<20230811085805.441256-1-ndabilpuram@marvell.com>",
        "References": "<20230811085805.441256-1-ndabilpuram@marvell.com>",
        "MIME-Version": "1.0",
        "Content-Transfer-Encoding": "8bit",
        "Content-Type": "text/plain",
        "X-Proofpoint-ORIG-GUID": "NPxWJefJOc6Ozjne4G_Pj7IzYxrvxBLh",
        "X-Proofpoint-GUID": "NPxWJefJOc6Ozjne4G_Pj7IzYxrvxBLh",
        "X-Proofpoint-Virus-Version": "vendor=baseguard\n engine=ICAP:2.0.267,Aquarius:18.0.957,Hydra:6.0.591,FMLib:17.11.176.26\n definitions=2023-08-10_20,2023-08-10_01,2023-05-22_02",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.29",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org"
    },
    "content": "From: Akhil Goyal <gakhil@marvell.com>\n\nFixed resource leak when pthread create fails in dev_init().\n\nFixes: 1c7a4d37e73d (\"common/cnxk: fix mailbox timeout due to deadlock\")\n\nSigned-off-by: Akhil Goyal <gakhil@marvell.com>\n---\n drivers/common/cnxk/roc_dev.c | 7 ++++---\n 1 file changed, 4 insertions(+), 3 deletions(-)",
    "diff": "diff --git a/drivers/common/cnxk/roc_dev.c b/drivers/common/cnxk/roc_dev.c\nindex 128b9751e4..18d7981825 100644\n--- a/drivers/common/cnxk/roc_dev.c\n+++ b/drivers/common/cnxk/roc_dev.c\n@@ -1472,7 +1472,7 @@ dev_init(struct dev *dev, struct plt_pci_device *pci_dev)\n \t\t\t\t\t    pf_vf_mbox_thread_main, dev);\n \t\tif (rc != 0) {\n \t\t\tplt_err(\"Failed to create thread for VF mbox handling\\n\");\n-\t\t\tgoto iounmap;\n+\t\t\tgoto thread_fail;\n \t\t}\n \t}\n \n@@ -1500,9 +1500,10 @@ dev_init(struct dev *dev, struct plt_pci_device *pci_dev)\n \t\tdev->sync.start_thread = false;\n \t\tpthread_cond_signal(&dev->sync.pfvf_msg_cond);\n \t\tpthread_join(dev->sync.pfvf_msg_thread, NULL);\n-\t\tpthread_mutex_destroy(&dev->sync.mutex);\n-\t\tpthread_cond_destroy(&dev->sync.pfvf_msg_cond);\n \t}\n+thread_fail:\n+\tpthread_mutex_destroy(&dev->sync.mutex);\n+\tpthread_cond_destroy(&dev->sync.pfvf_msg_cond);\n iounmap:\n \tdev_vf_mbase_put(pci_dev, vf_mbase);\n mbox_unregister:\n",
    "prefixes": [
        "09/31"
    ]
}